- 30 Apr, 2018 35 commits
-
-
Elad Alon authored
This would prevent a sub-class adding data members after the WeakPtrFactory. Bug: 826206 Change-Id: Idb81d4e677915391a248fc148f1d7ccfbeb852c3 Reviewed-on: https://chromium-review.googlesource.com/1032614Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#554715}
-
Greg Thompson authored
This allows it to be in force during session restore. This CL also gently reduces heap usage during blacklist preparation and moves regular blacklist prep to a non-blocking background thread. BUG=827173 Change-Id: Ibabae7111b6e005ea0433567a8dff840ce2cd156 Reviewed-on: https://chromium-review.googlesource.com/1032744Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#554714}
-
Mikhail Pozdnyakov authored
DevTools currently supports setting mock sensor data that is exposed to the web through a 'deviceorientation' event. Mock data sent this way should also be exposed by the Generic Sensors-based sensor objects. This CL is re-using the existing DevTools infra and UI and thus it brings a dependency from the 'deviceorientation' module to the 'sensor' module in Blink. In the future there should be Generic Sensor-specific extension to the browser protocol and a more sophisticated UI. Note: Unlike 'deviceorientation' events, page reload is required, to bring the overriden device orientation data into action for the `OrientationSensor`-based classes. A dedicated console message is shown to notify the user. Bug: 816478 Change-Id: If6f7371ab20790e30a41cee52636cd0a92715065 Reviewed-on: https://chromium-review.googlesource.com/1024172 Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#554713}
-
Christos Froussios authored
This reverts commit 1f675b46. Reason for revert: Breaks builder WebKit Linux Trusty ASAN Original change's description: > OOR-CORS: store more information to CORSErrorStatus on preflight errors > > Current implementation does not store rejected method or header > information to CORSErrorStatus on CORS-preflight checks, and > results in missing hint parameter on CreateErrorString() in Blink. > This patch provides required information to generate right error > messages, and fixes some crashed layout tests. > > Bug: 803766, 836741 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: If4de6b916a77d204812a7b010e39080bf059bc9e > Tbr: kinuko@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/1030670 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554642} TBR=kinuko@chromium.org,toyoshim@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 803766, 836741, 838057 Change-Id: Ia8eb9bf63b1b0c6edda93eb7d45c1bb20d26a7b7 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1034532Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#554712}
-
Kevin Marshall authored
All executables are run within packages now, so there is no more need to support both packaged and non-packaged execution modes. The transitional codepaths to handle both cases are no longer needed. This CL removes the bootfs mode from the local SDK builder script. Bug: 805057 Change-Id: I01bf0223a70f440de675d4ec2434248f973f3eb6 Reviewed-on: https://chromium-review.googlesource.com/1033475Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#554711}
-
Christos Froussios authored
This reverts commit 209edd56. Reason for revert: The test SplitViewWindowSelectorTest.DragToClose is flaky (mostly failing) on builder Linux Chromium OS ASan LSan Tests e.g. https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27234 Original change's description: > overview: Initial patch for overview swipe to close. > > Adds ability to drag the overview item up or fling the item up to close > the window. A later cl will add the fling animation. The feature is > hidden behind a newly added flag. > > Test: added test coverage > Bug: 828646 > Change-Id: I8e66fb3ed2a642deb6a833f30e9b7674d56b0fee > Reviewed-on: https://chromium-review.googlesource.com/1014490 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554651} TBR=oshima@chromium.org,xdai@chromium.org,sammiequon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 828646, 838061 Change-Id: I3eaedf6f764120131b4da729c7425056ef2bd018 Reviewed-on: https://chromium-review.googlesource.com/1033673 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e9f80dac..63b7a5b2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Idfe8c6d7b3b020ea6b19cfd3ca4e76a35329aa82 Reviewed-on: https://chromium-review.googlesource.com/1034227Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#554709}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I8eb05dcd44cf238f53192d36ca3b493be8505d1b Reviewed-on: https://chromium-review.googlesource.com/1034457Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554708}
-
Robin Raymond authored
The original patchset has a minor flaw in building for UWP unrelated to the changes made in the original CL itself. $target_cpu is used in "host" toolset instead of $host_cpu and when building an arm target it causes issues as it can't build host tools. Fixes an error introduced in crrev.com/c/923161 R=brucedawson@chromium.org, dpranke@chromium.org, phoglund@chromium.org Bug: 812814 Change-Id: Ia6e7f1dc2b5494e212d67b99a119e023a1308c25 Reviewed-on: https://chromium-review.googlesource.com/1022493Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#554707}
-
Luciano Pacheco authored
Re-enable the tests listed below. These tests require legacy event dispatch so that fake keyboard events the test sends are processed by the Blink default event handler. If we do not do this, the fake Tab keyboard events are not processed and thus can't move the focus. TabindexOpenDialog/FileManagerBrowserTest.Test* TabindexSaveFileDialog/FileManagerBrowserTest.Test* These tests aren't supported by Mash: disable on Mash. Bug: 836254,480491,482121 Change-Id: I91ecbfbf2944a702f473ffcb097942a61c260726 Reviewed-on: https://chromium-review.googlesource.com/1034425 Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#554706}
-
Lutz Justen authored
Renames ComponentPolicyBuilder to ComponentCloudPolicyBuilder and adds StringPolicyBuilder == ComponentActiveDirectoryPolicyBuilder, which has a string payload instead of a protobuf payload. Active Directory managed Chrome OS devices are going to use that for tests. BUG=chromium:735100 TEST=Tryjobs Change-Id: Id1f0591559d70d7e596e756d8ca5a8a588499a72 Reviewed-on: https://chromium-review.googlesource.com/1032559 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=warx@google.com Change-Id: I5434e01ecb2a7a0a6951265424727935c815c9e1 Reviewed-on: https://chromium-review.googlesource.com/1034434 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#554704}
-
Giovanni Ortuño Urquidi authored
Previously, NotifyPreferencesChanged was ignoring OOPIFs whose RenderViewHost was not associated it its RenderWidgetHost. Based on alexmos' suggestion in https://crbug.com/829688#c6 Bug: 837461 Change-Id: I427c9427125b2cc061e91f68f4d2edd7885dbb01 Reviewed-on: https://chromium-review.googlesource.com/1031791Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#554703}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I7ce49dfc6b769ad98311b883def83aaa05d9c6ee Reviewed-on: https://chromium-review.googlesource.com/1034456 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Zhongyi Shi authored
Bug: 794688 Change-Id: I051882193473490ecf1ea2cc61dbb1459a3f00ea Reviewed-on: https://chromium-review.googlesource.com/981305Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#554701}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f578e9249f18..64133ee653fb $ git log f578e9249..64133ee65 --date=short --no-merges --format='%ad %ae %s' 2018-04-29 manojgupta Revert "SimpleChrome: Attempt to fix SimpleChromeWorkflow." Created with: roll-dep src/third_party/chromite BUG=chromium:837794 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie329a31141115eba0a1fd11c85395da0e15af347 Reviewed-on: https://chromium-review.googlesource.com/1034452 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554700}
-
Alan Cutter authored
This CL provides guarantees that the close button is in the top right of each window frame. This change fixes a couple of bugs where transitionary layouts didn't meet this assertion. Bug: 832338 Change-Id: I44cc946b80fac8244f4f9b66f2738df837be552d Reviewed-on: https://chromium-review.googlesource.com/1025493 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO 4/30 - 5/9) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#554699}
-
Timothy Loh authored
Use views::DISTANCE_RELATED_CONTROL_VERTICAL for the space between the message text and the progress bar, and fix re-layout to happen after updating the message instead of before. Change-Id: Iba4a1d9585dc4135ae13a5122cbec67d89736cf2 Reviewed-on: https://chromium-review.googlesource.com/1034431Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#554698}
-
Christopher Lam authored
Bug: 834205 TBR=sky@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8b23ae84f287f688b1f0cebd2f278f3580588c8a Reviewed-on: https://chromium-review.googlesource.com/1016223Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#554697}
-
Alan Cutter authored
This change disables the menu item for creating page/PWA shortcuts while in incognito mode. This makes desktop consistent with Android's behaviour. The test added by this CL uncovered a feature list DCHECK hit when calling GetPwaForSecureActiveTab(). This CL cleans up that minor bug as well. Bug: 829716 Change-Id: I5818a280724e65c8af5e0a0c6a1d24a0809c77bb Reviewed-on: https://chromium-review.googlesource.com/1032273Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#554696}
-
Pavel Feldman authored
Change-Id: I9495216a14e15d35fd55894b48a19f616a649213 Reviewed-on: https://chromium-review.googlesource.com/1034196 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#554695}
-
Michael Giuffrida authored
TabMetricsLogger logs the TabMetrics UKM event for a background tab. This event includes the state of the tab, as well as some slightly tricky or nullable fields. Add a new TabFeatures struct that contains all this information, and generate the struct in a separate function. The UKM logging function now simply forwards info from the TabFeatures struct to the UKM event. Later we will use the same TabFeatures to calculate tab scores with an ML model. Encapsulating the logic for these features in a single function ensures that we use the same logic for logging as we will for inference. Bug: 784639, 783989 Change-Id: I11e64119ce30465f98409f54f7e97af0251ce4b3 Reviewed-on: https://chromium-review.googlesource.com/1028562 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#554694}
-
Patti authored
gfx::VectorIcons currently support being created via CreateVectorIcon() without any size. In this case, a default size is retrieved from the icon's file (provided via a CANVAS_DIMENSIONS directive). However, icons may not always specify a CANVAS_DIMENSIONS, so if the code is provided no size *and* there is no CANVAS_DIMENSIONS, it will fall back to a size of 48. This isn't ideal as it may result in some icons being drawn for a canvas that is too small or too large, so add a DCHECK to prevent this. Bug: 836116 Change-Id: I176d4b5ed7f07fe679a2b70addcce02a09a6b5a3 Reviewed-on: https://chromium-review.googlesource.com/1029556 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#554693}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=warx@google.com Change-Id: Iae9f4b4da15cba41d6dc3605d011b4ec25ec8469 Reviewed-on: https://chromium-review.googlesource.com/1034091 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I614044e46da6ef7351f9d4a4237a7c63412e4651 Reviewed-on: https://chromium-review.googlesource.com/1034089Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#554691}
-
Patti authored
Ink drop colors in touch / newer refresh mode have different alphas to the default, according to the spec. Update them in this patch. Screenshots - https://drive.google.com/file/d/1h4PUbTkNnWvRY5ZRpPRX5Kqp89ll1cOv/view?usp=sharing Bug: 829986 Change-Id: I7b42d09c07f953d1198bdad0f522f52633d2fb57 Reviewed-on: https://chromium-review.googlesource.com/1031630 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#554690}
-
Jinsuk Kim authored
AppWebMessagePort is the only implementation of the interface MessagePort. Replaced the direct reference to the class with the interface and added a public helper method |MessagePort.createPair()|. That makes AppWebMessagePort an implementation detail, and exposes only the public interface to embedders. Updated DEPS rules to remove the exception. Bug: 617324 Change-Id: I3f35c2db2436bc3c82a00c07cfede1062d447d29 Reviewed-on: https://chromium-review.googlesource.com/1031690 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#554689}
-
Noel Gordon authored
Persistent flake cause affecting all FileManager browser tests is fixed by issue 831074 issue 804413 issue 829310. Intermittent flake cause affecting Providers and other FileManger tests is fixed by crrev.com/554647. Run the Providers test all bots to help confirm issue 668680 is gone. Bug: 668680,836254 Change-Id: Ib2eb38cddd454ae0671929da201c70a157f29308 Reviewed-on: https://chromium-review.googlesource.com/1034418 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#554688}
-
Alexey Baskakov authored
In low disk space scenarios, Cryptohome performs a lot of disk space operations to erase data. This is a number of milliseconds taken to perform a cleanup. Reported only if longer than 5 ms. BUG=835114 Change-Id: I7af2fe673dd01581fa0442a1e26bf08dc2a7f315 Reviewed-on: https://chromium-review.googlesource.com/1032210Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#554687}
-
Euisang Lim authored
1. Remove the links of deleted files - docs/common_build_tasks.md - docs/shift_based_development.md deleted in https://chromium-review.googlesource.com/679054 - docs/subtle_threading_bugs.md deleted in https://chromium-review.googlesource.com/897782 2. Remove Old Chrome OS build instructions and add Chrome OS build instructions in Checking Out and Building - docs/old_chromeos_build_instructions.md renamed in https://chromium-review.googlesource.com/861043 3. Remove the link of an unidentified file - docs/testing/test_browser_ui.md can't find the history of the file. Bug: N/A Change-Id: I4c6d3e6fbe442ad79905c94b94627ad8baf251dd Reviewed-on: https://chromium-review.googlesource.com/1029396 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#554686}
-
Noel Gordon authored
MapStringToTargetVolume is only used by AddEntriesMessage: move it to AddEntriesMessage as a static helper. Bug: 833834 Change-Id: Iafcc7f5d2a464987145f8102c2e476ad89484243 Reviewed-on: https://chromium-review.googlesource.com/1034416Reviewed-by:
-
tzik authored
If a ScriptPromiseResolver is requested to resolve in a ScriptForbiddenScope, it delays the resolution. However, as no one retains a reference to the SPR instance, the GC may collect it before the promise is fully resolved. Bug: 831118 Change-Id: Ic8b506d808a7d7cf851e25fe2fb6e7d3aa7464c0 Reviewed-on: https://chromium-review.googlesource.com/1034046Reviewed-by:
-
Noel Gordon authored
Comment only change. No-Try: true Bug: 833834 Change-Id: I17bfb7a9ba9c9146a1c5496001b368f00a627f55 Reviewed-on: https://chromium-review.googlesource.com/1034414Reviewed-by:
-
kylechar authored
This reverts commit 6f5d66e1. Reason for revert: Test is failing on Windows 7 GPU bots. Original change's description: > Add viz_screenshot_sync_tests. > > Add a new GPU test target that runs screenshot_sync a second time with > --enable-features=VizDisplayCompositor. This test will verify that GPU > compositing is working for OOP-D. The test only runs on Windows and > Linux bots. > > Bug: 812385 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I56de0d01922d1c08521f3fd5aed4f64c148374e3 > Reviewed-on: https://chromium-review.googlesource.com/1028613 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554529} TBR=kbr@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 812385 Change-Id: Icf9c2d398312bebfd7ca5b7d47e2b0876716dd70 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1034392Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#554682}
-
Mohamed Amir Yosef authored
This is required for bookmarks to identify permanent folders such as bookmarks bar. Bug: 516866 Change-Id: If8d763479045c8bb9b9a8368382201bfff1dbe36 Reviewed-on: https://chromium-review.googlesource.com/1032788 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#554681}
-
- 29 Apr, 2018 5 commits
-
-
Noel Gordon authored
Tbr: slangley, yamaguchi Bug: 833834 Change-Id: I0b1e1ad58e66e5822449e1d03b8ff7bdd9502df9 Reviewed-on: https://chromium-review.googlesource.com/1034413Reviewed-by:
-
Noel Gordon authored
Move JSON conversion helper definitions into their class so we declare and define them once only (less to read). Document class members. Bug: 833834 Change-Id: Ic60e833271bce822795f63e34956992a51ad7f74 Reviewed-on: https://chromium-review.googlesource.com/1034412Reviewed-by:
-
Rune Lillesveen authored
With [1], user-modify is updated as part of style recalc for the inner editor element, and the inner editor element recalc is triggered from LayoutTextControl::StyleDidChange(). This removes the last mutable style access from LayoutTextControl. [1] https://crrev.com/4ef836ad2e67ce25e263514bcda94f808bfb02d6 Bug: 813068 Change-Id: I923e0081b2bb2a796b512e23a027550c35b045e4 Reviewed-on: https://chromium-review.googlesource.com/1034052Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#554678}
-
Darren Shen authored
In a previous patch, we created a dedicated function for reloading the VK without recreating the KeyboardController. This patch replaces all the remaining calls of CreateKeyboard that reload the VK to ReloadKeyboard. Note that some calls to CreateKeyboard are to enable the keyboard, so they will be replaced with a different function later. Bug: 731537 Change-Id: I2cf964d825433fb3fbeb19231e5c5757213a604f Reviewed-on: https://chromium-review.googlesource.com/1031970Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#554677}
-
Noel Gordon authored
Bug: 833834 Change-Id: I261665a70256ba03d838dddfe546dedcfd397865 Reviewed-on: https://chromium-review.googlesource.com/1034044Reviewed-by:
-
