- 02 Feb, 2018 40 commits
-
-
Nicolas Pena authored
This CL WPT-fies some tests and removes duplicates. For the removed: buffer_size_restriction.html: tested in several others. cross_origin_resource_request.html: added checks in resource_TAO_zero.htm. on_shrink_buffer_size.html: tested in others. timing_allow_cross_origin_resource_request.html: added checks in resource_TAO_origin.htm. The two failing tests were slightly changed because according to the spec setResourceTimingBufferSize should not fire onresourcetimingbufferfull. Bug: 498037 Change-Id: Ia2ab18a2239483f4faba8afc04b012574f64310a Reviewed-on: https://chromium-review.googlesource.com/894623 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#534111}
-
Adam Langley authored
AttestationConveyancePreference allows an RP to declare whether or not they are interested in attestation information. If not (which is the default), it is replaced with a “none” attestation. The option for ”indirect” attestation is currently implemented in the same way as “direct” since we are not currently planning on standing up a Privacy CA for this. The AAGUID is not zeroed out because, for U2F devices, the AAGUID is created by Chrome and is always zero. When we support CTAP2 devices this will have to be addressed. (The URLs in the comments here might not actually work yet. They are written assuming that https://github.com/w3c/webauthn/pull/741 lands, which should happen within a week or two.) Bug: 803829 Change-Id: Id701349ea2ec999b40a592cc94b1535818c25e78 Reviewed-on: https://chromium-review.googlesource.com/895387Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#534110}
-
kylechar authored
TakeHandle() was resetting |memory_| without unmapping the shared memory. This leaks resources because it's no longer possible to unmap after that point. Bug: 804399 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I42397ec8dc768ec6d9b2affcaee829f6c8a8ea00 Reviewed-on: https://chromium-review.googlesource.com/897969 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#534109}
-
Thomas Anderson authored
This reverts commit 9d1ddd57. Reason for revert: Causing http/tests/devtools/sources/debugger/async-callstack-fetch.js to fail on WebKit Linux Trusty ASAN: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/8904 Original change's description: > Refactor away TaskQueueManager::DoWork in favor of the Sequence interface > > This patch changes the Sequence interface slightly by introducing > DelayTillNextTask which helps work around problems scheduling delayed > tasks when TakeTask doesn't have a task to return (due to cancellation). > > Change-Id: I5935e41ad5bc725b6109a187b329c82ce5a70689 > Bug: 783309 > Reviewed-on: https://chromium-review.googlesource.com/883346 > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534070} TBR=skyostil@chromium.org,alexclarke@chromium.org,altimin@chromium.org Change-Id: I8eab7e997f2ca6d397b6233f7a4f3ae8664437a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783309 Reviewed-on: https://chromium-review.googlesource.com/899902Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#534108}
-
Evan Stade authored
Bug: 578868 Change-Id: I557cc7c90b9632beae9e7b56ca477515abcd67ab Reviewed-on: https://chromium-review.googlesource.com/896705Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#534107}
-
Navid Zolghadr authored
Previously we had splitted WebTouchEvents into bunch of WebPointerEvents and then sent it to WebWidgets. Apparently PepperWidget is not capable of handling it and it is causing some crashes. For now disable that for PepperWidget only and continue sending WebTouchEvent as is to PepperWidgets. Bug: 806396 Change-Id: I3ff4e327bf1e275c763776998a8937e97d89dd7f Reviewed-on: https://chromium-review.googlesource.com/890825Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#534106}
-
Jesse Doherty authored
Change-Id: I06c2c3fd1c1371821e3f07f6bc8c123dbbc624fb Reviewed-on: https://chromium-review.googlesource.com/895855Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#534105}
-
David Bokan authored
We don't support setting an OOPIF as the root scroller today so avoid promoting it since some of the operations assume we're in a local frame. Bug: 805427 Change-Id: I196e402e5e47ac86d364b705eab614758d0239b1 Reviewed-on: https://chromium-review.googlesource.com/895871 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#534104}
-
Devlin Cronin authored
CrazyExtensionTest.Crazy tests the result of calling into the app API of a removed context. Conceptually, this is very similar to other extension bindings API tests, and would benefit from constant tree coverage with both JS and native bindings. Move the test to the ExtensionBindingsApiTest suite, and have it run with both JS and native bindings. Additionally, the behavior for native and JS bindings is slightly different when accessing invalidated contexts' APIs: Native bindings throw an error, whereas JS bindings do not. Adjust the test expectations accordingly. Also rename the test to something slightly more descriptive (s/Crazy/UseAppAPIAfterFrameRemoval). Bug: 653596 Test: browser_tests --gtest_filter=*UseAppAPIAfterFrameRemoval* Change-Id: Ic9c1615eda03320262d04c9760bc7879b2af78c5 Reviewed-on: https://chromium-review.googlesource.com/898397Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534103}
-
Khushal authored
The SharedGpuContext is re-created on a context lost, which means any user of the context's cache must ensure that its usage does not extend the validity of the context. Ensure this by resetting the ImageProvider on a context loss. R=chrishtr@chromium.org, junov@chromium.org Bug: 806629 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I33891c0a45f59de1741470d408dfa81184dc153a Reviewed-on: https://chromium-review.googlesource.com/891982Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#534102}
-
Raymes Khoury authored
This reverts commit c8b47bac. Reason for revert: This caused a regression: https://bugs.chromium.org/p/chromium/issues/detail?id=807898 Original change's description: > Remove DSE text from Page Info in incognito > > Currently we still display the text "Location - Blocked for current search > engine" in Page Info when in incognito mode. However, in reality, DSE > settings don't impact incognito mode so we should just display the same > thing in Page Info as we do for a regular website. > > Change-Id: I0dc820f888945adb4288c1aec65f2c3d726f252f > Reviewed-on: https://chromium-review.googlesource.com/885382 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Ben Wells <benwells@chromium.org> > Commit-Queue: Raymes Khoury <raymes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532292} TBR=raymes@chromium.org,benwells@chromium.org,tedchoc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ibf27584954e10f3173e2424aa52411269daf1784 Reviewed-on: https://chromium-review.googlesource.com/899685Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#534101}
-
Mohamad Ahmadi authored
Bug: 808069 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If7333449fade8345516b71ef0c51ccefa1abf1f8 Reviewed-on: https://chromium-review.googlesource.com/896711 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#534100}
-
Lutz Justen authored
Adds the DeviceUserPolicyLoopbackProcessingMode Chrome OS device policy. For Active Directory managed Chromebooks, which receive their policy via Active Directory group policy objects (GPOs), the policy controls whether user policy in device GPOs is taken into account and how it interacts with the usual user policy in user GPOs. This is called loopback processing. The policy is the Chrome OS equivalent of the UserPolicyMode policy on Windows. It is consumed in the AuthPolicy daemon in Chrome OS. Chrome doesn't touch it. BUG=chromium:807999 TEST=Tryjobs Copied proto file over manually to Chrome OS and made sure it works Change-Id: I909267c9a4d8b354f01e7f9ad4853068512ed58f Reviewed-on: https://chromium-review.googlesource.com/899144Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#534099}
-
Aaron Gable authored
This reverts commit 00dd1b27. This commit introduced non-public dependencies to chromium/src.git. These dependencies are protected behind the checkout_google_internal flag. However, the pipeline which processes src.git for codesearch does not understand or respect gclient conditionals. This caused the pipeline to attempt to crawl these internal repos, and to fire alerts when it consistently failed to do so. This change is a temporary revert of the introduction of these internal dependencies. When the codesearch deps-to-submodules pipeline has been updated to respect gclient conditionals, we can reland the change. Original commit message: > Migrate some internal-only ios and android entries to public DEPS. > > This is an expanded version of the ios_internal change in > https://crrev.com/c/880903, which should be more acceptable to the > Chrome release scripts. > > BUG=803846,807318 > > Change-Id: Ic9ea736a754a6ade1f29bf044cde9b4687000dbd > Reviewed-on: https://chromium-review.googlesource.com/895247 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Michael Moss <mmoss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533861} TBR=dpranke@chromium.org, mmoss@chromium.org Bug: 803846, 807318, 808487 Change-Id: Ie3dd2be59a106bd979fa15de16090e261d1f877e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/899672Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#534098}
-
Reilly Grant authored
This adds a missing case to ConvertTransferResult which maps the low-level error code EOVERFLOW to UsbTransferStatus::BABBLE, indicating that the device sent more data than was expected. Bug: 808181 Change-Id: I697171615153e6de53d751f216fc3a2c6287efd5 Reviewed-on: https://chromium-review.googlesource.com/898323Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#534097}
-
Raymond Toy authored
Bug: 745778 Change-Id: I6b81cec9fd69b028b4368e02a5de8bd1dad8bd53 Reviewed-on: https://chromium-review.googlesource.com/896629Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#534096}
-
Aga Wronska authored
Message center label on lock screen provides user with the information that device needs to be unlocked for access to notifications. This information needs to be announced by ChromeVox. Announcement for the label is not needed in unlocked state. Message center should be dismissed by pressing Esc on the keyboard. * Make notification label focusable on lock screen so it gets announcement. * Move accessibility node information to MessageCenterButtonBar, because otherwise they are not available when needed. * Move button bar title to MessageCenterButtonBar to avoid the round trip to fetch it. * Remove MessageScrollView because it is no longer needed. Bug: 793330 Change-Id: Ida23d2557973cbcd182d7ea4d2ee3ebec5a100bc Reviewed-on: https://chromium-review.googlesource.com/894990Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#534095}
-
Reza.Zakerinasab authored
This is a follow up CL for chromium-review.googlesource.com/c/chromium/src/+/895056. This change: - removes hard coded reference pixels from video source layout test. - adds debug info for each tile to the console output. Bug: 806994 Change-Id: I85d17fe1eb329282231b7843fbff94d31372cfb6 TBR: junov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/899662Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#534094}
-
Raphael Kubo da Costa authored
Add some more information so that it is easier to understand when the code is querying Gerrit and when it is looking at existing Chromium commits, and say git errors are not fatal. R=robertma Change-Id: I3f8de589186d0d2facafb6a92fcccd129d1899be Reviewed-on: https://chromium-review.googlesource.com/899242 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#534093}
-
Koji Ishii authored
Following bot results are included. 3509 3510 3513 3514 3518 Defalke was skipped due to recent unstability of the ng-bots. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If04751f76f0560bdd7a411fc384d0694da69cada Reviewed-on: https://chromium-review.googlesource.com/898143 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#534092}
-
Stephen McGruer authored
In http://crrev.com/41658d0 we added support for the composite member of KeyframeEffectOptions, but the CL accidentally introduced a backwards-compatibility bug. Prior to that CL we would not throw for composite == 'add' or composite == 'accumulate', whereas after it we would. Bug: 806139 Change-Id: I82271c4f5b7d7756cbaac101825a22eb12367f8d Reviewed-on: https://chromium-review.googlesource.com/895049Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#534091}
-
Patrick Noland authored
This DCHECK, as Jan explains in the bug, is too restrictive. It's valid for the state to flip to CATEGORY_EXPLICITLY_DISABLED before the timeout triggers. Bug: 803028 Change-Id: Ifd206a583b9dbef5650d1ff04f2da65e9a0459e2 Reviewed-on: https://chromium-review.googlesource.com/898068Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Patrick Noland <pnoland@google.com> Cr-Commit-Position: refs/heads/master@{#534090}
-
Steven Valdez authored
Change-Id: I0ee24a362baa94a2d64c1e5609185fb2c6f0b917 Reviewed-on: https://chromium-review.googlesource.com/899582Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#534089}
-
https://chromium.googlesource.com/angle/angle.git/+log/95ed19473fb6..c7295f4d363d $ git log 95ed19473..c7295f4d3 --date=short --no-merges --format='%ad %ae %s' 2018-02-01 geofflang Vulkan: Add dEQP ES2 expectations. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ia711148af60d66753f0f72b1cec1add824b0c687 Reviewed-on: https://chromium-review.googlesource.com/899542Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534088}
-
Misha Efimov authored
- Make it available for native tests. - Fix lint warnings. Bug: 786559 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib8d704d63e7eaebdc92134fc595f3f3c7a1cb79e Reviewed-on: https://chromium-review.googlesource.com/899522Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#534087}
-
Robert Kaplow authored
Refactored the pref-setting logic out of metrics_reporting_state_browsertest in a way it could be reused in UKM. Setup a parametrized UKM test which tests the enabled/disabled group policy state based on prefs and verified service is enabled/disabled. Bug: 805983 Change-Id: Ic303e4116826990e7780125f186b0028a8fd6a5e Reviewed-on: https://chromium-review.googlesource.com/895390 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#534086}
-
Leonard Grey authored
Change-Id: I5d7424aca855f68b3bdf30532f4a841e9fdf7444 Reviewed-on: https://chromium-review.googlesource.com/887603Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#534085}
-
Daniel Bratell authored
This is a preparatory patch for jumbo compilations where several cc files are compiled in the same translation unit. Then you get compilation errors if they all define their own kNumRetries and kBackoffPolicy, kApiPath and so on. This patch gives the 5 different kNumRetries variables and 3 different kBackoffPolicy variables in chrome/browser their own name. It also renames kApiPath, kApiUrl and kApiScope. It also deduplicates a kAuthorizationHeaderFormat string that had 4 different instances. Bug: 746957 Change-Id: Ib14ccaa372d3b28cd505b2e7cec519a5635e3173 Reviewed-on: https://chromium-review.googlesource.com/868335Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#534084}
-
https://webrtc.googlesource.com/src.git/+log/c22d6a8f9b3e..debbc7801fbd $ git log c22d6a8f9..debbc7801 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iffd78d0538f4f022154dbbdda7809d4c2f71bb92 Reviewed-on: https://chromium-review.googlesource.com/899562Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534083}
-
Alex Newcomer authored
Add ContextMenuMetrics (User Journey Time, Show Source, and Command Executed) to shelf and desktop. Modified histograms.xml to include "Desktop" and "Shelf" components. TEST=manual Bug: 807035 Change-Id: If54d53ef71b3f4dfe12c144333980ac2a5281bf5 Reviewed-on: https://chromium-review.googlesource.com/896628Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#534082}
-
Ricardo Quesada authored
Use WriteHTML for "Copy to clipboard" button, in addition to WriteImage. This is needed by ARC, which for the moment, only support HTML and plain clips from the Clipboard. It cannot see SkBitmap clips. This CL restores the code that was before this one: https://chromium-review.googlesource.com/c/chromium/src/+/781342 while also preserving its functionality. (and adds: #include <utility> required by std::move) TEST=copy-to-clipboard works Ok with Hangouts extension and in ARC++. BUG=808210 Change-Id: I1018d503dfd69d4677c1726c3abb4c0202697fcd Reviewed-on: https://chromium-review.googlesource.com/898424Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Ricardo Quesada <ricardoq@chromium.org> Cr-Commit-Position: refs/heads/master@{#534081}
-
Juan Antonio Navarro Perez authored
Test failing on tablet testers. TBR: ntfschr@chromium.org Bug: 808444 Change-Id: I0f18bded5aa2e5204be8f745b5ec1ae16fcc100a Reviewed-on: https://chromium-review.googlesource.com/899245Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#534080}
-
Koji Ishii authored
This patch fixes the logic whether to generate box fragments for an inline box or not consistent across wrapped lines. Not all inline boxes need to have corresponding box fragments. NGInlineLayoutAlgorithm determines this and avoid creating them when not necessary. NGInlineLayoutAlgorithm used to determine it for each wrapped line, but this made traversing fragments harder. With this change, if traversal finds a box fragment for a LayoutInline, it knows that it can find all other fragments too. wpt/css/CSS2/normal-flow/block-in-inline-empty-00[14] no longer pass with this change. These tests don't pass in Blink/WebKit, and that the fix priority is not high at this moment. Bug: 636993 Change-Id: I58b0f3c5fd95ee743a5ab404c8e8a4b284909616 Reviewed-on: https://chromium-review.googlesource.com/895231 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534079}
-
Benoit Lize authored
"extra_chrome_shared_library_configs" is used to enable code ordering, but is only added for 32 bit webview. Add this config. A downstream change will enable ordering for ARM64, saving: - ~6.9MB of PSS for Chrome ARM64 (not widely released) - ~5MB of PSS in Android Search App on Android N - ~2.5MB of PSS in Android Search App on Android O Similar gains are expected for other webview apps, see attached bug. Bug: 803866 Change-Id: If15d319bf7fbc58c3ac76898a5d7893ba0ade32c Reviewed-on: https://chromium-review.googlesource.com/899362Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#534078}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d1f7fd6d. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11526 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hta@chromium.org: external/wpt/webrtc TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I0ff9b8b1459a28d2328c133db2ac11dfd1ddd55f Reviewed-on: https://chromium-review.googlesource.com/899102 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#534077}
-
Yutaka Hirano authored
This reverts commit e6395d1c. Reason for revert: performance regressions Original change's description: > Update RendererSideResourceScheduler testing config (Enabled_3_1024) > > This is a reland of > https://chromium.googlesource.com/chromium/src/+/47b8f2451e900fe2c5fc4d94046925f40fea2fc7 > with modester parameters. > > Bug: 785770, 794073 > Change-Id: Icab191e655118ff17aa91759bfe8ce9e1e45f6fb > Reviewed-on: https://chromium-review.googlesource.com/867824 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#529644} TBR=isherman@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 785770, 794073 Change-Id: Ibac8672cc5fb780f6c4b94cbde955fd7686a4041 Reviewed-on: https://chromium-review.googlesource.com/899403 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#534076}
-
Justin Cohen authored
Bug: 799345 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6c077be0ac58af923209234c27511b4433b0685d Reviewed-on: https://chromium-review.googlesource.com/896812Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#534075}
-
Justin Cohen authored
BUG=799345 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I760f36dcf8cb9f47322ecf8d5134f73957e2bf8f Reviewed-on: https://chromium-review.googlesource.com/897185Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#534074}
-
Vasilii Sukhanov authored
It was introduced in r488421 to handle the credentials without trailing '/' in signon_realm and origin. Now however, the signon_realm is created correctly by GmsCore. The origin has no '/'. As a result - r488421 is useless with a lot of complexity. - r488421 is harmful because it prevent the credential from being deleted via passwords.google.com. See b/69245513 R=battre@chromium.org Bug: 739101,801918 Change-Id: I20e64481b8dd972e3b43f18a00b0b3078f58c4fe Reviewed-on: https://chromium-review.googlesource.com/897610Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#534073}
-
Sebastien Marchand authored
Bug: 806265 Change-Id: I4820b88096de01aa134715ebbe6cb1556d91b4ec Reviewed-on: https://chromium-review.googlesource.com/888094Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#534072}
-