GitLab

Recent cleanup and performance changes caused a regression in the fullscreen
transition animation, leading to this revert.

This reverts commit 9ec18e41.
This reverts commit b62daf58.
This reverts commit 014fd0a1.

TBR=erikchen@chromium.org
BUG=470180,464754,454502
TEST=None

Review URL: https://codereview.chromium.org/1042633003

Cr-Commit-Position: refs/heads/master@{#322728}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a8e2d5b..7da1901

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/1039933002

Cr-Commit-Position: refs/heads/master@{#322727}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4cf3205..03f6b2d

TBR=

Review URL: https://codereview.chromium.org/1044723002

Cr-Commit-Position: refs/heads/master@{#322726}

This adds a number of new files and directories which should be covered
in the existing WATCHLIST entry.

R=johnme@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1045433003

Cr-Commit-Position: refs/heads/master@{#322725}

Just like the gfx::Display member |bounds_| is not stored in pixels, we need to
convert |work_area_| from pixels.

Both are used in MenuController::UpdateInitialLocation (|work_area_| is
preferred over |bounds_|), which gets events with already converted
coordinates.

BUG=469373,143619

Review URL: https://codereview.chromium.org/1036263003

Cr-Commit-Position: refs/heads/master@{#322724}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/06d3d68..a8e2d5b

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/1043773002

Cr-Commit-Position: refs/heads/master@{#322723}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f7c8626..4cf3205

TBR=

Review URL: https://codereview.chromium.org/1041013002

Cr-Commit-Position: refs/heads/master@{#322722}

This is creating a content/public/browser/permission_manager.h interface
that is hooked on the BrowserContext. It has an implementation in chrome/
android_webview/, content/shell/ and one for layout tests.

BUG=437770, 430238

Review URL: https://codereview.chromium.org/1011953003

Cr-Commit-Position: refs/heads/master@{#322721}

Cr-Commit-Position: refs/heads/master@{#322720}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/96eb006..f7c8626

TBR=

Review URL: https://codereview.chromium.org/1046633002

Cr-Commit-Position: refs/heads/master@{#322719}

This changes the behaviour of AdapterInputConnection to pass a
InputType.TYPE_TEXT_FLAG_CAP_* based on the
WebTextInputFlags.Autocapitalize* instead of doing it purely based on the
element's type.

This CL requires the following Blink CL:
https://codereview.chromium.org/995363002

Also the following build fix CL:
https://codereview.chromium.org/1040643003

BUG=466930

Committed: https://crrev.com/d1421a5faf9dc2d3b3cad10640576b24a092d9ba
Cr-Commit-Position: refs/heads/master@{#322414}

Review URL: https://codereview.chromium.org/1003143002

Cr-Commit-Position: refs/heads/master@{#322718}

As a result, if a generated .java class had to be added to a .jar file, the
java class would be rebuilt but the jar file would not be updated.

This has caused landmines in the past:
https://codereview.chromium.org/899403002

It is fixing the underlying issue blocking this:
https://codereview.chromium.org/1003143002

BUG=457038

Review URL: https://codereview.chromium.org/1040643003

Cr-Commit-Position: refs/heads/master@{#322717}

Add comment for QuicFramer::AppendPacketHeader. Correct/improve DLOG output. Clean up problems found by clang_tidy.

Merge internal change: 89724433
https://codereview.chromium.org/1047493003/

Fixed header ordering, missing override/explicit keywords. Nothing to see here.

Merge internal change: 89622231
https://codereview.chromium.org/1047493002/

Always build a QuicSecureConfigUpdater at startup.

Merge internal change: 89604435
https://codereview.chromium.org/1047483002/

Remove the using_pacing argument from QuicSentPacketManager::SetFromConfig because it's always true.

Merge internal change: 89599305
https://codereview.chromium.org/1048493002/

Pass QuicCryptoServerConfig by pointer instead of reference.

QuicCryptoServerStream was storing const reference to the config, which
makes the interface bug-prone because it's not clear for the caller
that the config must outlive the stream.

Merge internal change: 89542072
https://codereview.chromium.org/1048483002/

Cache the value of GetMaxPlaintextSize in QuicPacketCreator.  No functional change.

Saves 0.68% in GFE QUIC loadtests.

Merge internal change: 89532959
https://codereview.chromium.org/1046523002/

Remove thread race conditions in two tests.  No change to production code.

Merge internal change: 89510581
https://codereview.chromium.org/1047453003/

Remove QuicFramer::encrypter, because it's a test-only method.

Merge internal change: 89499341
https://codereview.chromium.org/1046513002/

Review URL: https://codereview.chromium.org/1037403004

Cr-Commit-Position: refs/heads/master@{#322716}

BUG=
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1042123002

Cr-Commit-Position: refs/heads/master@{#322715}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d8b34c2..06d3d68

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/1042113002

Cr-Commit-Position: refs/heads/master@{#322714}

BUG=340944
TBR=bauerb@chromium.org

Review URL: https://codereview.chromium.org/1045543002

Cr-Commit-Position: refs/heads/master@{#322713}

On systems with an older local install, appending the third_party path to
jinja2 will result in the local install being used.
Switching to prepending to avoid this.

BUG=470543
TEST=local
R=ncbray@chromium.org,jamesr@chromium.org

Review URL: https://codereview.chromium.org/813483005

Cr-Commit-Position: refs/heads/master@{#322712}

There are two reasons why this is going to be important:
  (1) With a database in the display path, there are failure cases.
  (2) After the SWR.showNotification() promise resolves, the developer
      should be able to assume it's included in SWR.getNotifications().

The browser process confirming display of the notification enables these
cases to be implemented reliably.

BUG=447628

Review URL: https://codereview.chromium.org/1021293002

Cr-Commit-Position: refs/heads/master@{#322711}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/722dd6c1..4879ca1a

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1048553002

Cr-Commit-Position: refs/heads/master@{#322710}

When corruption occurs in the notification database, destroy the
entire database, which means that the database will be re-created
during the next invocation. If the corruption occurs while opening
the database, try re-opening it immediately so that the operation
can continue.

Design document:
  http://goo.gl/TciXVp

BUG=447628

Review URL: https://codereview.chromium.org/1024463006

Cr-Commit-Position: refs/heads/master@{#322709}

https://codereview.chromium.org/1011953003 introduces a
content::PermissionManager interface which doesn't work well with the
current one.

BUG=437770, 430238

Review URL: https://codereview.chromium.org/1035223003

Cr-Commit-Position: refs/heads/master@{#322708}

Tested on Linux with the following command line:

$ gn gen out-gn --args='enable_nacl=true'
$ gn check out-gn //components/nacl/*

This should help fix some link errors as well.

BUG=367595,376000
TEST=see above
R=bradnelson@google.com,brettw@chromium.org
TBR=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/1042453002

Cr-Commit-Position: refs/heads/master@{#322707}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/539ab17..96eb006

TBR=

Review URL: https://codereview.chromium.org/1040723004

Cr-Commit-Position: refs/heads/master@{#322706}

This caused an issue where HiDPI devices would request 212x142pixels no matter what.

This changes the code to get the proper scaled dimension for the device (in case of HiDPI, this would be 424x284 if user is on a 2x device, or more accordingly).

BUG=470875
TEST=ContentBased*, SimpleThumb* unit_tests
TBR=jbauman

Review URL: https://codereview.chromium.org/1028393003

Cr-Commit-Position: refs/heads/master@{#322705}

the packet loss rate is bad for multiple connections in a row.

+ max_number_of_lossy_connections: specifies the maximum number of
  connections with high packet loss in a row after which QUIC will be
  disabled.

+ packet_loss_threshold:  specifies packet loss rate in franction after
  which a connection is closed and is considered as a lossy connection.

QUIC changes to support this were checked in the following CL:
  https://codereview.chromium.org/1025573002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/1041953003

Cr-Commit-Position: refs/heads/master@{#322704}

Cr-Commit-Position: refs/heads/master@{#322703}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c93fade..539ab17

TBR=

Review URL: https://codereview.chromium.org/1044603002

Cr-Commit-Position: refs/heads/master@{#322702}

Cr-Commit-Position: refs/heads/master@{#322701}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7a91f7f..c93fade

TBR=pkasting@chromium.org,yutak@chromium.org

Review URL: https://codereview.chromium.org/1047473004

Cr-Commit-Position: refs/heads/master@{#322700}

BUG=469296

Review URL: https://codereview.chromium.org/1046493003

Cr-Commit-Position: refs/heads/master@{#322699}

Cr-Commit-Position: refs/heads/master@{#322698}

Some classes still using it directly are:
- cloud_print_proxy_process_browsertest.cc (it's not a browser test so it doesn't
call ChromeMainDelegate::PreSandboxStartup(), which sets up the PathService
to know about the user-data-dir

- in_process_browser_test.cc, which needs to set up the user-data-dir directory
before PreSandboxStartup() is called

- diagnostics_model and diagnostics_controller, which are used in
BasicStartupComplete(), which is called before PreSandboxStartup() where the
PathService is set up

- shell_integration_win.cc which has a function that's used in unit tests, which
don't call PreSandboxStartup()

- chrome/browser/shell_integration.cc is used differently on linux than on other
platforms, and on the former a desktop app shortcut uses a different command line
that that of Chrome's

- cloud_print/service/*, since it seems to be its own thing, and have a separate
user_data_dir

BUG=464616

Review URL: https://codereview.chromium.org/1010923002

Cr-Commit-Position: refs/heads/master@{#322697}

This prevents Bluetooth (and other external) keyboards from shutting
down the Desktop activity when activated or powered off.

BUG=471435

Review URL: https://codereview.chromium.org/1046503002

Cr-Commit-Position: refs/heads/master@{#322696}

Remove the refcounted internal state object (nested class 'Context').
This refactor makes it more obvious what happens on what thread,
and avoids the need to pass refptrs around.

TBR=bradnelson@chromium.org
BUG=469248

Review URL: https://codereview.chromium.org/1022703007

Cr-Commit-Position: refs/heads/master@{#322695}

BUG=

Review URL: https://codereview.chromium.org/1039853002

Cr-Commit-Position: refs/heads/master@{#322694}

Old one was broken by a "git push --force".
The new mirror's path makes it clear that it is a github mirror.

BUG=470159

Review URL: https://codereview.chromium.org/1046473002

Cr-Commit-Position: refs/heads/master@{#322693}

When a Service Worker registration gets dropped, all notifications
associated with that notification should be removed as well.

Two cases which will be addressed in follow-up patches are when the
Service Worker database gets wiped, and granting the notification context
the ability to close deleted notifications by itself.

Design document:
  http://goo.gl/TciXVp

BUG=447628

Review URL: https://codereview.chromium.org/1014703007

Cr-Commit-Position: refs/heads/master@{#322692}

I'm trying to use Python's tokenize library, but it has a bug with this case. (Verified in Python 2.7.9.) Soooo just eliminate all instances.

Also adjust some long comments. The style guide rule is, "within comments, put long URLs on their own line if necessary."

BUG=449308
TEST=None.

Review URL: https://codereview.chromium.org/1020853015

Cr-Commit-Position: refs/heads/master@{#322691}

Revert of FFmpeg roll for M43. (patchset #2 id:20001 of https://codereview.chromium.org/1032543004/)

Reason for revert:
Failed to compile:

http://build.chromium.org/p/chromium.gpu/builders/GPU%20Mac%20Builder/builds/30642

Original issue's description:
> FFmpeg roll for M43.
>
> Update FFmpegDemuxer::OnFindStreamInfoDone with the new
> AVFormatContext layout.
>
> BUG=465940
>
> Committed: https://crrev.com/02c707cdd098e97dd78c3ff2858576dcbcaa9082
> Cr-Commit-Position: refs/heads/master@{#322688}

TBR=dalecurtis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=465940

Review URL: https://codereview.chromium.org/1046493002

Cr-Commit-Position: refs/heads/master@{#322690}

Update DEPS for trace-viewer to include the 3 tracing modes selector.

BUG=396081
TEST=

Review URL: https://codereview.chromium.org/1033223008

Cr-Commit-Position: refs/heads/master@{#322689}