GitLab

It turns out layer_tree_host_ can be nullptr in tests which
passes unexpectedly on bots other than UBSan bots. This CL
fixes this behavior.

Bug: 989936
Test: compositor_unittests on the UBsan gn flags
Change-Id: I6e8ff606709b07f19e6309e3b5a96ca240f0de99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731954Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683419}

See:
https://docs.google.com/document/d/1E1uyto12NGe9kZFpqH8T8pRyhaOdzcKwHW51RETw-0Q/edit

Bug: 979119
Change-Id: I21c84f254c90d17884b3038ab3ec23121994d6ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730580
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683418}

Added AppBrowserController::HasTabstrip to allow
System Web Apps to turn on browser FEATURE_TABSTRIP.

The tabstrip is required for CrOS chrome://terminal.

Bug: 846546
Change-Id: I3f1a6ebafd7b32be51bde17d7ad31526b8cd1ef3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714121Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683417}

The blink::ParsedContentType::Mode type had an alias blink::Mode
which made that type name unavailable or caused shadowing warnings
for other code in the blink namespace. It makes sense that code
has to write ParsedContentType::Mode instead of Mode since that
will be clearer.

Change-Id: Ie20089fdde14fe0aea4b2beb6f8ab82aa955fdc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732089Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Auto-Submit: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#683416}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5833269d4277..cba141f276a8


Created with:
  gclient setdep -r src-internal@cba141f276a8

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None
Change-Id: Ibac8a9edf77be251af8d3ab5aa26dee744324855
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731021Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683415}

I extended the following four metrics because they showed an unexpected
jump in M73 that I couldn't immediately explain:
SBClientDownload.SignedBinaryDownload
SBClientDownload.ExtractSignatureFeaturesTime
SBClientDownload.DownloadRequestTimeoutDuration
SBClientDownload.DownloadRequestTimeoutStats

If the changes in M73 turn out to be expected, I'll remove these metrics
as well, since we don't have any immediate plans for them.

I removed the following SBClientDownload metrics because we don't have
any immediate plans to use them:
SBClientDownload.ZipTooBigToUnpack
SBClientDownload.DownloadFileWithoutDiskImageExtensionHasKolySignature
SBClientDownload.DmgFileHasExecutableByType
SBClientDownload.DmgFileHasNoExecutableByType
SBClientDownload.DmgFileFailureByType
SBClientDownload.DmgFileArchivedBinariesCount
SBClientDownload.DmgTooBigToUnpack

Bug: 975430, 969936, 984257, 988872
Change-Id: I722cd40948513a42f53c64e4d8e4ba9bf05123de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725321Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683414}

On each user action, the client now can receive the custom data map.
This CL adds the custom data to impression proto. We will plumb this
data to the client and add this data to impression tracker in a
following CL.

Bug: 977255
Change-Id: I4b9552bf30c620a66d466cf6eeabc0f2549666fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717703
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683413}

The following tests are flaky. Disabling them for now.
MediaSourceTest.Playback_VideoAudio_WebM
WebRtcDataBrowserTest.CallWithSctpDataAndMedia
WebRtcDataBrowserTest.CallWithDataAndMedia

Bug: 990116
Change-Id: I6164f487483ea1a5cb74490553146ca0c1dfb59b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730784
Commit-Queue: Eric Karl <ericrk@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Eric Karl <ericrk@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683412}

Change-Id: I076892df0b6e105c8a0af8fb4ef98a8f2464bd75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731955Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683411}

https://pdfium.googlesource.com/pdfium.git/+log/077eb792907f..25661d1e1dc6

git log 077eb792907f..25661d1e1dc6 --date=short --no-merges --format='%ad %ae %s'
2019-08-01 thestig@chromium.org Add experimental JavaScript retrieval APIs.
2019-08-01 tsepez@chromium.org Move CPWL_AppStream to CPDFSDK_AppStream.
2019-08-01 tsepez@chromium.org Remove dependence from cjs_field.cpp to fpdfapi/font

Created with:
  gclient setdep -r src/third_party/pdfium@25661d1e1dc6

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=pdfium-deps-rolls@chromium.org

Bug: None
Change-Id: I910532d42ae3394f7cdac763b1c67a1a1384c8c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732061Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683410}

Previously, it always called it from the LayoutView, regardless of what
layout changed.

This will be more efficient in typical cases of non-root layouts. It
may be more inefficient in the following cases
a. Two layout roots are present, of which one is an ancestor of the other
(in this case, the new code will update the overlapping layout tree
portions twice).
b. Cases when LocalFrameview::UpdateLayout recurses, due to NeedsLayout
being true after the first one.

If we consider these cases sufficiently rare, then this CL is ok as-is.
Handling (a) and (b) is possible but is harder to implement.

Bug: 462719,970224
Change-Id: Ie65dc73a70bb9362dfa20ff9ad4070e3945d3c56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728717Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683409}

BUG=985192

Change-Id: I15da8fd02164d3c2089c4dddc24b48171577cde8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728171Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Julian Watson <juwa@google.com>
Cr-Commit-Position: refs/heads/master@{#683408}

crrev.com/c/1717885 was a workaround to fix use-after-free of
URLLoaderRequestController. This CL reverts the workaround.

This CL makes ServiceWorkerNavigationLoader reset
fallback callback when the controller is destructed. This
way we won't touch a stale controller.

Bug: 989404
Change-Id: Icf24e22b6fe5a3a6f29ccca95b21eb4233dab3b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730409
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683407}

When running run_py_tests.py, chmod on temp dirs can fail occasionally.
Wrapped the command with try/except to suppress the error and
allow tests process to complete.

Change-Id: I896f10021348f45a065a66787a4bad5dcb01b70f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732150
Commit-Queue: Tricia Crichton <triciac@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683406}

No change to logic, only adds metrics.

Following up on an issue where apps failed to specify MIME types, we
realized it would've been very helpful to understand how frequently we
expect this to happen in the wild. This CL adds metrics to track cases
where we expect apps to explicitly tell us with the MIME type for
content.

Bug: 989346
Test: None
Change-Id: Idfb1e7b68cb79622f1e6795b050ed72c090b4163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730729
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683405}

Bug: 990051
Change-Id: I3db913053bcd038514cde1cf26f6a72de4102a90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730775
Commit-Queue: Jenna Himawan <jhimawan@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683404}

This change runs most of the existing OpenVR/WMR tests with
OpenXR by adding OpenXR to the WEBXR_VR_ALL_RUNTIMES* macros.

Remaining tests to add are addressed in:
crbug.com/986637 (input)
crbug.com/986621 (drawing pixels)

Bug: 976434
Change-Id: I6b0a48d37d1380ba50b97b2d97d5b7accb9c495b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714304
Commit-Queue: Patrick To <patrto@microsoft.com>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683403}

Prework to removing uyvy output format references in
gpu_memory_buffer_video_frame_pool. UYVY is no longer used, in favor of yuv420.

Bug: 988538
Change-Id: Ice37e5f2f3975cd9c784d4a5470906e23a13345a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713668Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683402}

Document the high-level goal of IPC review.

Change-Id: Ie367c0026fe9d009196d2c58ec5619db4a4b72bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730498
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683401}

TBR=siggi@chromium.org

Bug: 990148
Change-Id: Ibeda7b1d6628105d59d66d8788e5fb99d04a9221
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731699Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683400}

Show the focus outline on a selected bg tile when navigating with the
keyboard.

http://go/scrcast/NTA2NTc0NTg1MzU3OTI2NHw1NGE3MmRmYS02Ng

Bug: 937570
Change-Id: I96c1449ddff90a5c32a2348607506ab5ae728743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728045Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683399}

This has thread safety issues, reverting to reland a fixed version.

This reverts commit 0f70801a.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [Cros SR] Reflect user history deletion actions in the model.
> 
> We have an on-device model ranking commonly used URLs in the CrOS
> launcher, which stores these URLs in the model itself. This CL
> observes the history service and deletes URLs from the model that
> are removed by the user.
> 
> Bug: 931149
> Change-Id: If9e9654a00ae804807319a3dc5dc91b599698c7c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725032
> Commit-Queue: Tony Yeoman <tby@chromium.org>
> Reviewed-by: Jia Meng <jiameng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#683049}

TBR=jiameng@chromium.org,tby@chromium.org

Change-Id: Iadd8433895f16fb3c9e3a4d5f9b2a53869612ab3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 931149
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731990Reviewed-by: Tony Yeoman <tby@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683398}

Gesture navigation on rendered pages opened via 'open in a new tab'
was not working due to a bug in the logic determining the activation
of its UI. This CL fixes the bug by having it use the same logic
used by native pages.

Bug: 989729

Change-Id: Ifdf6df5fa4ec5a7ce592167d16c5c63434c27b94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728535Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683397}

CollectedCookiesViews::CreateAndShowForWebContents may be called
while an existing dialog (widget) is in the process of closing. In
this case, exit gracefully instead of crashing.

The only way I can think of that might be possible to repro this
IRL (i.e. aside from clusterfuzz) would be to:
a) open page info bubble
b) click "cookies"
c) open page info bubble again
d) click "cookies", then focus cookies dialog, press escape,
   all in rapid succession
e) cookies dialog starts closing
f) click on "cookies" is a posted task, and is handled after
   cookies dialog starts closing, but before finishing closing

This is probably exceedingly rare, enough so that it's not worth
being concerned with re-opening the cookies dialog. (And arguably,
it shouldn't re-open anyway, since the last command the user issued
was "escape" (close).)

Bug: 989888
Change-Id: Ic4e3274128f5530b621d9dfe4e99dd6d24bddc21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731914Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683396}

Bug: 978109
Change-Id: Ie59d4d378da2476d9e78fc20f5a6a8e5929e55f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731763
Commit-Queue: Charlene Yan <cyan@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683395}

Context: These features hard-code in Chrome that Elo and JCB cards are
unsupported for upload save to Google Payments. In M75, the
AutofillDoNotUploadSaveUnsupportedCards study (Project Passport Control)
does the same thing but dynamically via a Payments RPC and for more card
types. Thus, these features can finally go away (M69-M74).

Note that this CL is essentially a reversal of the original one:
https://chromium-review.googlesource.com/c/chromium/src/+/1153301

Bug: 868552, 902366
Change-Id: I820a110afb83002151e726ae539097104e6ae45f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717490Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#683394}

`delivery_value` can be None.

Generated files will be updated after some more changes, not now.

Bug: 906850
Change-Id: Ia40b1cb4a75d14384092fb1fb84c51df8411ef15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723012
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683393}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/447b45d42307..24146be8336f

git log 447b45d42307..24146be8336f --date=short --no-merges --format='%ad %ae %s'
2019-08-01 ehmaldonado@chromium.org depot_tools: Simplify CheckCallAndFilter[AndHeader]

Created with:
  gclient setdep -r src/third_party/depot_tools@24146be8336f

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Bug: chromium:984182
Change-Id: If6530ac3c6647eb6e452bc719e787eb6bc7cf246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731760Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683392}

This CL moves the inline script CSP check from
PendingScript::ExecuteScriptBlock() (#execute-the-script-block)
to ScriptLoader::PrepareScript() (#prepare-a-script)
as spec'ed.

This CL removes Script::InlineSourceTextForCSP()
which is no longer used.

Behavior changes (the new behavior is spec-conformant and thus
this CL adds WPT tests):

- Previously <script>'s error events were fired
  when inline script CSP check fails,
  while after this CL the events are no longer fired.
  Test: scripthash-basic-blocked-error-event.html
  (Moved from layout test with expectation changes)

  This CL makes Chromium's behavior align with Firefox and Safari.

- If the nonce attribute is changed or the CSP list is updated
  after prepare-a-script before evaluation,
  previously the new nonce/CSP were used for CSP,
  while after this CL the old nonce/CSP
  (at the time of prepare-a-script) is used.
  Test: scriptnonce-changed-*.html

  This CL makes Chromium's behavior align with Firefox.
  (Safari's behavior is different from any other browsers)

This CL also adds scripthash-changed-*.html (just for symmetry
with scriptnonce-changed.html), which pass only on Chromium.

Bug: 964537
Change-Id: I8673956101d9d13708c452db23258f125cb3d256
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618262
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683391}

This removes ChildProcessLauncher's nominal dependency on BrowserThread
initialization by capturing the client's current SequencedTaskRunner
rather than the current thread's BrowserThread::ID, which may not be
initialized yet.

Bug: 989769
Change-Id: Ia4b9cb0781540f6737be761c201b6440f7713ac6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731473Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#683390}

Bug: 984550
Change-Id: I8d94c4267bb1730765e247d4841cad3ac7622a2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728268
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683389}

It's WebAPK-specific logic, so it seems like it belongs there.

I also made a utility getWebApkInfo() function. IMHO, it makes
conceptual sense that WebApkActivity only deals with WebApkInfo (it
mostly shouldn't need to know that WebappInfo even exists).

Change-Id: Ia2ed8583e4c1810327582481651dd44aa1678bf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730092
Commit-Queue: Glenn Hartmann <hartmanng@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683388}

In single-view, pages are horizontally centered within the document.
This centering is being done in PDFiumEngine, making it difficult to
test.

This CL moves the centering logic for single-view to
draw_utils::CenterRectHorizontally(). This allows us to test the logic.

Bug: 51472
Change-Id: Idd67cde3c57d4155c9e02ca82a36ad19a6205f08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730524
Commit-Queue: Jeremy Chinsen <chinsenj@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683387}

It is safe not to if ~RunLoop happens-after Quit() (or if the loop never
ran). Off-thread destruction happens sometimes in RefCountedThreadSafe
objects after the loop was quit (see failures on patch set 1).

Bug: 715235
Change-Id: If3d6e3661d9bc00547ac5606075b3fe066ff3e7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671868
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683386}

https://android.googlesource.com/platform/external/perfetto.git/+log/bf0e385cd6fb..f50c2ff2f70c

git log bf0e385cd6fb..f50c2ff2f70c --date=short --no-merges --format='%ad %ae %s'
2019-08-01 treehugger-gerrit@google.com Merge "client api: Ignore multiple registrations of the same data source"

Created with:
  gclient setdep -r src/third_party/perfetto@f50c2ff2f70c

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I7e05c82a7434f63450e9e2e09d72d4ccb3e4a46c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730497
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683385}

ActivationDelegate is the primary interface from cellular_setup.mojom to
be implemented in JavaScript. This class deals with sending and
receiving status update messages to the service.

This CL implements this delegate and deals with routing between the
first page (SIM detect) and either the second page (provisioning) or the
third page (final) depending on the response received.

Note that the second page (provisioning) still isn't implemented as part
of this CL; this functionality is part of a follow-up CL.

Bug: 968858
Change-Id: I67d86647237dc47a1c4660bf7160e5e993f45f13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721042
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683384}

As BrowserActionsContainer disappears with the introduction of
ExtensionsToolbarContainer this CL adds CHECKs to make sure that that
experiment is not enabled whenever GetBrowserActionsContainer gets
called.

This change adds |GetToolbarActionViewForId| and
|GetDefaultExtensionDialogAnchorView| to the ToolbarButtonProvider
interface so requests for those do not need to go through
BrowserActionsContainer.

As a a side effect ExtensionUninstallDialogView can now anchor to
pinned extensions when this experiment is enabled (as they are visible),
but like the extension-installed dialog they cannot pop out the
extension to display the dialog anchor yet.

Bug: chromium:985834
Change-Id: I0bbc8da1d501846e72fc06987343dd758e83f922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731301Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683383}

The main changes are making these run on the UI thread instead of IO.
Also removes some references to net:: objects that aren't needed
anymore.

Bug: 824856
Change-Id: I99262c4dd1d364c7b5a03627121023bea5d671ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731298
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683382}

We start them as shown if the WebContents is shown, then immediately
send a Hide() unconditionally - in different places for child and main
frames. Instead just always start them hidden and remove all the
plumbing.

This is toward https://chromium-review.googlesource.com/c/chromium/src/+/1693812
wherein I'd like to DCHECK we don't call OnHidden IPC for a provisional
RenderWidget, which we currently do. Right now we DCHECK that we don't
call it for a frozen widget, which includes provisional main frame
widgets, but not the first one. And it's the first one we create shown
and then hide.

Renderer-created widgets (eg window.open()) go through
WebContentsImpl::CreateNewWidget() and should Show() immediately if the
renderer has initialized the page as shown, since there may be no navigation
afterward to show the widget in that case.

R=avi@chromium.org

Bug: 419087, 745091
Change-Id: Id7cc1981ae9fbf6a71c51a4b54fc488ba47f1753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717702Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683381}

This requires notifying layout_helper_ when a tab is being destroyed,
and TabStripLayoutHelper to step carefully around closing tabs in a few
places, but saves more complexity by not duplicating state between
TabStrip and TabStripLayoutHelper.

Bug: 958173
Change-Id: Iaeafc2391ecac0397947ccc34ddaecf853feb787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725271
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683380}