GitLab

Patch [3/N] modified blink windows's binding to call CheckCoopAccess()
whenever a "CrossOrigin" attribute/methods was accessed.

So far, so good. Nevertheless, some attributes are missing, because they
have a custom implementation. CheckCoopAccess needs to be added manually
for them. This patch fixes the accesses when setting "opener".

COOP access reporting:
[ 1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294
[ 2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185
[ 3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472
[ 4/N] https://chromium-review.googlesource.com/c/chromium/src/+/2273120
[ 5/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309433
[ 6/N] https://chromium-review.googlesource.com/c/chromium/src/+/2308715
[ 7/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309697
[ 8/N] https://chromium-review.googlesource.com/c/chromium/src/+/2275889
[ 9/N] https://chromium-review.googlesource.com/c/chromium/src/+/2310530
[10/N] this patch.

Bug: 1090273
Change-Id: I4a5357d123db9e04ac4ac4fcf119ac3cacd93688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315024Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791883}

Add Troy card which card number have prefix 2205 or 9792
for autofill

Bug: 1026289
Skip-Translation-Screenshots-Check: True
Change-Id: I72b7b363c2ec63cb5ba1192b996773bcdf2d2e67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952628Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#791882}

This is part of a larger cleanup effort of Chrome's use of cookies. The
eventual goal is to make the constructor private and to have other parts
of Chrome use CreateSanitizedCookie().

Bug: 1102874
Change-Id: Id27150b987d2303fc670aac8cdf83300d2238877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303300
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791881}

The chrome://history page is a native page, and currently
TabListMediator and TabListFaviconProvider return the default round
favicon for all native pages. To fix this issue, both classes will only
check if it is a NTP, and treat other native pages the same as regular
URLs, and load real favicon for them.

Bug: 1104811
Change-Id: Ia93cfb77e41f2fdd2da9eb06c12fd797c4b34a82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310151
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791880}

Test: VirtualBrowsingContextGroupTest.HistoryNavigation
android-bot: https://ci.chromium.org/p/chromium/builders/ci/android-bfcache-rel
linux-bot: https://ci.chromium.org/p/chromium/builders/ci/linux-bfcache-rel

Bug: 1109648
Change-Id: If153c4143b1ad9c6e0fc2f684ef46d41882e624c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320126Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791879}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Ia9a830eb7acec89ff253da36f7d64be47e0b17b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320197Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791878}

Bug: 1104976
Change-Id: Id5f7228b00ace088c8943461554b9957208e7dde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296921
Auto-Submit: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791877}

If an Autofill session is triggered on the UrlBar before
setTextForAutofillServices has been called for the first time, the
member mTextForAutofillServices, which is null, is passed to the
constructor of SpannableStringBuilder. This results in a crash.

This is fixed by always intializing mTextForAutofillServices.

R=tedchoc@chromium.org

Bug: 1109186
Change-Id: I2d2e2b73521a6261c23c1cc3dd36ba83dc19f110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317209Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791876}

Add closure compilation for:
- duplex_settings_test.js
- dpi_settings_test.js
- destination_store_test.js

Bug: 1000989
Change-Id: I799f0006f738c8f6650d5af2a8e87a6efe25adb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314666
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791875}

This CL introduces the following changes as per UI feedback :-
1) Illustration is too low when there is no button on OOBE screen.
Moved it 40px higher as per feedback.
2) Space between text lines in the footer section is too tight.
Added line-height 20px as per feedback.
3) Updated margin-top for progress message as per OOBE spec.

Bug: 1106768
Change-Id: If1fcbbc5af9af86ec1336428c6035a388d5a869c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302639Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Saurabh Nijhara <snijhara@google.com>
Cr-Commit-Position: refs/heads/master@{#791874}

The tests were skipped because they were out-dated and blocked shipping
WebAssembly BigInts and MultiReturn. The tests got updated by now.

R=mlippautz@chromium.org

Bug: chromium:1097765
Change-Id: I1a82d11ba7df237fac755e72b6ed2d88de8da05a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320279Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791873}

This CL migrates fast/replaced/available-height-for-content.html to
external/wpt/css/css-sizing/available-height-for-replaced-content.html.

Change-Id: Ife10bdaf02857ff5b4e4142e6354c7d002671c3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320270
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#791872}

This cl fixes an issue where the offset calculation for css grid
line name labels do not account for the first offset as expected
by the inspector overlay (see the line number calculations for
example).

This causes the label to be incorrectly spaced if the grid wrapper
has a padding applied.

Before: https://imgur.com/3o6RrIA

After: https://imgur.com/XaHtACA

Bug: 1108528
Change-Id: I976a781e73a076de8092931bc4c3f393a44bafbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314699Reviewed-by: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#791871}

From an V8 Binding, minus the degenerate scenario where V8 Pointer Compression
currently disables externalization for small strings (even though there is a
likely significant performance benefit) an AtomicString is always created
when projecting a V8 String into a DOM string.

Thus, for the DOM Element APIs called by the bindings code, there is no
benefit to StringView in the common case. Later on, if temporary strings
for things like lowercasing are required, taking a StringView can be
beneficial in internal APIs to avoid an AtomicStringTable entry creation
but the public API does best just taking an AtomicString.

Furthermore, because the current ToBlinkStingView() creates a local
AtomicString reference to the externalied String, this causes a local
refcount thrash. When StringImpl's refcount is made threadsafe, this
thrash can account for 10-15% degredation on blink_perf benchmarks
such as get-element-by-id.html. ToBlinkStingView() can theoretically
be fixed, but as there is little benefit to using a StringView,
removing is easier.

This reverts commit 88bd95fa and
part of 41f55e37.

Bug: 1083392
Change-Id: I0b11e8e43f18dfc7711aadeefb8f000fee689741
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319544
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791870}

This logic was being duplicated on Mac because of an earlier change.

Bug: chromium:914976
Change-Id: I724c3447f9ed50c54e0e448e994a74f693f05168
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316150Reviewed-by: Kramer Ge <fangzhoug@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#791869}

This test aborts if the OSK doesn't seem to work, which can be the case
when a hardware keyboard is present. I found no better way to determine
if the soft keyboard is disabled or force it to be enabled. The CQ bots
appear to run with a soft keyboard and no hard keyboard, so they should
run the test to completion.

The presence of the OSK is verified by checking the size of the content
when not in fullscreen, behavior that has always worked. This is because
the behavior under test is respecting the OSK size when the content *is*
in fullscreen, so aborting based on fs behavior would not have caught
this bug (the bug would have made it seem as if there were no OSK).

This is split off from the fix in case the test turns out to be flaky.

Bug: 1107651
Change-Id: I803a67a4adef0bc4ee19b70a4d2ebd3126cd632f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315425Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791868}

Removes test asserts verifying ChromeSigninController state where it is
redundant - both SigninFragmentTest and SigninSignoutIntegrationTest
verify ChromeSigninController.isSignedIn after checking
IdentityManager.hasPrimaryAccount, which is now the source of truth for
the sign-in state.

Bug: 1046412
Change-Id: I4ca41bc2c838a37e31a957390efc75cedac4202d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317212
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Alice Wang <aliceywang@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791867}

This CL changes the method
AccountPickerCoordniator.Listener#goIncognito to default as it is not
needed for all implementations of the listener. The non necessary
empty implementations are also removed.

Bug: 1093795
Change-Id: I5882d9c35294d2b9de9a59d1e76e5673df7250ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317799
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791866}

This reverts commit f844efb2.

Reason for revert: Removed additional tests from commit

Original change's description:
> Revert "Explicitly name webgl/2 conformance tests on Windows"
>
> This reverts commit 539778cf.
>
> Reason for revert: not enough HW capacity for more tests
>
> Original change's description:
> > Explicitly name webgl/2 conformance tests on Windows
> >
> > These tests should be explicit about using ANGLE's d3d11 backend.
> >
> > Bug: chromium:850252
> > Change-Id: I0f3d348edf38f845efeb5ba9d2a70f38b662efbf
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302413
> > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
> > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
> > Cr-Commit-Position: refs/heads/master@{#790942}

Bug: chromium:850252
Change-Id: I281612c7770ae8e33dce0d739e501455b8fd3dfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315183
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791865}

Interface to be implemented using leveldb-proto.
See go/nearby-chrome-cert-manage

Bug: b/154865267
Change-Id: Ibeb17fa2962c95bdf152d633d79cd78753457baa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261218
Commit-Queue: Curt Clemens <cclem@google.com>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791864}

Hover cards are currently rolling out to stable on Mac and hover card
images are as well so we want to keep these metrics to monitor that.

Bug: 1097849, 1097848
Change-Id: I0e56e9a26ec4723c751b74db020afdf988440ffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315809Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791863}

Add FamilyLinkNoticeScreen after gaia sign-in to tell user supervision can be added via Family Link afterward. It should display when user selects sign in for a child and the child is older than 13 years old.

Bug: 1101318
Change-Id: If7c9c491f2967da038b70cc3ebb7d1318ea86b51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294861
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791862}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/450afef18d5b..f81afad16767

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC adithyas@google.com,rsorokin@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1033067,chromium:1098562,chromium:1105907
Tbr: adithyas@google.com,rsorokin@google.com
Change-Id: I5e7038e94b75dd2c936d4900d003043e54ab5835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320192Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791861}

Roll Chrome Mac PGO profile from chrome-mac-master-1595829164-c22b50893110427f86ce6cde1b20f409df22cb84.profdata to chrome-mac-master-1595851043-c48b6bdf39deda41f847276998118df921bfd4ef.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: Ie81710b23f5279a5d712e72978df40d14ac81be8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320189Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791860}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cec3e4fd4e86..0bf389ba6cb5

2020-07-27 janscheffler@chromium.org Migrate `front_end/har_importer` to `devtools_entrypoint`

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1101738
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ifd2583163fff8e93d7ed29dc5296fb423f9c40d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320190Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791859}

R=msisov@igalia.com
BUG=1109134

Change-Id: I076bf37cee8aae58782385463a5873ec98c12722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318548
Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com>
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com>
Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#791858}

If a list item contains a block box, the layout tree is initially like:

  LayoutListItem {LI}
    LayoutBlockFlow (anonymous)
      LayoutListMarker {::marker}
    LayoutBlockFlow {P}
      LayoutText #text

However, an outside ::marker should appear in the same line as the first
non-marker text of the list item. Therefore, it's changed into:

  LayoutListItem {LI}
    LayoutBlockFlow (anonymous)
    LayoutBlockFlow {P}
      LayoutListMarker {::marker}
      LayoutText {#text}

But this was not happening when dynamically toggling list-style-type
between 'none' and some other value. The reason was that there was a
'NormalChildNeedsLayout()' condition, which would hold the 1st time, but
in following layouts it would be false.

This patch just removes that condition.

Bug: 1107783

TEST=external/wpt/css/css-lists/change-list-style-type-002.html

Change-Id: Ic82f1a474b0a0ddf2f2aab8a60afac299aa6e2d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310359Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#791857}

Sets touch device list from cmd line only for non-ozone/X11 for now and
also doesn't set x11 error handlers if Ozone is used.

-----

PS: Please note that this is a temp solution that will help to choose
between ozone and non-ozone X11 build. The switch that will be used
to choose the path is --enable-features=UseOzonePlatform. Once
non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how
th finch trial goes), the wrapper will be removed.

Please also note that it's impossible to build use_x11 && use_ozone
without some hacks in PlatformCursor code. The changes to that are
on their way to upstream.

----

Bug: 1085700
Change-Id: Id0520d4c5b66ad7a6b628b09f887c4a65e03d470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315887
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791856}

https://dawn.googlesource.com/tint.git/+log/433670b576c5..429aa812a02d

$ git log 433670b57..429aa812a --date=short --no-merges --format='%ad %ae %s'
2020-07-23 dsinclair Add simple test runner.
2020-07-22 rharrison Fix BUILD.gn builds
2020-07-22 dsinclair [msl-writer] Only emit in/out structs if function call requires.

Created with:
  roll-dep src/third_party/tint/src

BUG=tint:123

Change-Id: Id73c77add1190c5d7705dbf5903d70fda2d0ade2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315489
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791855}

Change-Id: Ib01298649740501540236e185717879179a5dff6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317825
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791854}

The IO thread bits originally set up a URLRequestContext and friends,
but that has been removed as of
https://chromium-review.googlesource.com/c/1355136.

Bug: 908955
Change-Id: I5d2cd6f53352d142d64b7fa1e9fef7ba9f1939a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314831Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791853}

The HashTraits for KeyValuePair were updated to allow concurrent
marking, but HashMapValueTraits did not inherit that.
kCanTraceConcurrently is moved from HashTraits<KeyValuePair> to
KeyValuePairHashTraits so that it is inherited by HashMapValueTraits.

Bug: 986235
Change-Id: Id33b6054db3b8bf044cab6ebfd0e1d677118fab4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320169
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791852}

A CL (https://crrev.com/c/2302972) seems to regress a performance test.
This CL fixes the regression.

ImageResource seems to be more frequently accessed, and creating
base::optional<> in the hot spot would regress the performance.
This CL reverted to use a reference of String in ParseType(), and
to check ImageResource.type availability outside of the function.


Bug: 1108870
Change-Id: Ie5de9aff7b9ca479452637a22c90a82c829147ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318494Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Auto-Submit: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791851}

This CL adds an image button to restart the check passwords once the
previous one has been completed successfully or if there has been an
error in the previous check. It also adds the tests to verify the
correct visibility of the button.

IDS_ACCESSIBILITY_PASSWORD_CHECK_RESTART_BUTTON.png.sha1 image:
https://storage.cloud.google.com/chromium-translation-screenshots/ead1b2a3b13694352574ef214e5945cb5aace20e

Bug: 1109691, 1092444
Change-Id: I079d08820a3c98cefb4be2d7f3139a34dcfcc390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315339Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Eleonora Rocchi <erocchi@google.com>
Cr-Commit-Position: refs/heads/master@{#791850}

This reverts commit 9a66d347.

Reason for revert: android-pie-arm64-rel is not a bottleneck for the CQ health

Original change's description:
> Temporarily disable chrome_public_test_apk on android-pie-arm64-rel.
> 
> Bug: 1108071
> Change-Id: I2b8053233567b2478d3efd9eb3976000a6422bef
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311369
> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
> Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#790588}

TBR=martiniss@chromium.org,gbeaty@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1108071
Change-Id: I514d589541a79989c8e34cce26837a615887428f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318786Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791849}

This test suite has been failing consistently for 11 days.

One test crashes consistently:
  EGLFeatureControlTest.InvalidDisplay/ES2_OpenGL_NoFixture
The other tests are all identified to not even run on this configuration.

I'm adding an exception for this bot to not run the suite until the root cause
can be addressed.

TBR=ynovikov@chromium.org

Bug: 1094629
Change-Id: If8eadabb03de0e54d11956bce50761cf71aadcf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320408Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791848}

TBR=sdefresne@chromium.org

Bug: 1109740
Change-Id: I7f0d80fabe01f264629311374a968da52f10e0db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320275Reviewed-by: David Jean <djean@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791847}

it was only limited to non-Ozone/X11. It's time to enable that
for OS_LINUX instead as it can be either USE_X11 or USE_OZONE or
both.

Bug: 789065, 578890
Change-Id: I549f48b731cd9b4ae5d076be02c092939a6e3350
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315888
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791846}

This change creates a connection with the cros_healthd service factory
when the service connection is created. This will eventually allow
Chrome services (NetworkHealth and NetworkDiagnostics) to be passed to
cros_healthd when Chrome starts.

Bug: chromium:1057739
Change-Id: I0b2142d40adeac4d1991b22642b4555acbf31b97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303362
Commit-Queue: Trent Begin <tbegin@chromium.org>
Reviewed-by: Paul Moy <pmoy@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791845}

This will allow to override the URL used by BinaryUploadService::Request
on Chromium builds for development purposes.

Bug: 1108856
Change-Id: I8a4645b3fdb73c6268e0dbb790c539b1a2eb5824
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314688
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791844}