- 26 Aug, 2016 40 commits
-
-
lethalantidote authored
This change provides the client-side classes needed to receive and send geolocation messages. GeolocationFeature sends messages from the client that either contain a geolocation coordinate or error message. The GeolocationFeature class handles incoming GeoloationSetInterestLevelMessages and RequestRefreshMessages. Other items included: * Changes device/geolocation/mock_location_provider to use fake_location_provider name * Moves blimp/client/feature/mock_location_provider into device/geolocation. BUG=614486 Review-Url: https://codereview.chromium.org/2161223003 Cr-Commit-Position: refs/heads/master@{#414797}
-
bokan authored
Work on making RootScrollerController work across iframes revealed that there's two responsibilities that need management. All frames need a RootScrollerController to manage the Element currently set as root scroller and determine which Element should eventually become the effective root scroller. In addition, we need the RootScrollerController to manage the ViewportApplyScroll and set it on the appropriate element. Since only one Element on the whole page needs this callback set, it makes sense that only the top document should have this responsibility. Experience with classes like FrameView and EventHandler shows that this may be better served by subclassing the top level object rather than having isMainFrame() checks intermingled with the other code. BUG=505516 Review-Url: https://codereview.chromium.org/2280453002 Cr-Commit-Position: refs/heads/master@{#414796}
-
flackr authored
This change detects when we can paint the background onto the scrolling contents layer. This will unblock promoting scrollers with supported backgrounds on low DPI devices as we can now maintain subpixel antialiased text. BUG=381840,568847 TEST=compositing/overflow/overflow-scroll-with-local-image-background.html, LayoutBoxTest.BackgroundRect, CompositedLayerMappingTest.ShouldPaintBackgroundOntoScrollingContentsLayer CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2068723002 Cr-Commit-Position: refs/heads/master@{#414795}
-
rbpotter authored
BUG=568415 Review-Url: https://codereview.chromium.org/2272053002 Cr-Commit-Position: refs/heads/master@{#414794}
-
a.obzhirov authored
BUG= Review-Url: https://codereview.chromium.org/2275113003 Cr-Commit-Position: refs/heads/master@{#414793}
-
thestig authored
Use base::Bind and content::BrowserThread::PostTaskAndReplyWithResults() instead of custom function pointer based callbacks. Review-Url: https://codereview.chromium.org/2283823003 Cr-Commit-Position: refs/heads/master@{#414792}
-
spqchan authored
Menu should use the new browser tools error icon. BUG=630354 Review-Url: https://codereview.chromium.org/2280033003 Cr-Commit-Position: refs/heads/master@{#414791}
-
fgorski authored
* Successfully removed requests where returned in result as duplicates * above was fixed with tests updated BUG=641380 R=dewittj@chromium.org Review-Url: https://codereview.chromium.org/2283813003 Cr-Commit-Position: refs/heads/master@{#414790}
-
sievers authored
When the activity stops (or rather the context goes away and resident textures incl. UI resources are evicted), don't evict the thumbnails for the tab that was visible *if* the bitmap is still available and wasn't uploaded to a texture yet. Also, don't force the UIResource to be created proactively when the ETC1 compression completes *if* there are no running activities, since it's racy with uploading it into the old context that's going away, while throwing away the bitmap. When there's critical memory pressure, free all thumbnails. BUG=636630 Review-Url: https://codereview.chromium.org/2244783005 Cr-Commit-Position: refs/heads/master@{#414789}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/393e77578d5b..470a9e84e35b $ git log 393e77578..470a9e84e --date=short --no-merges --format='%ad %ae %s' 2016-08-26 alexandermont Fix confusion of read vs. write bandwidth in bus_parser.html. 2016-08-26 alexandermont Change FormatBytes in strip_memory_infra_trace to use binary prefixes. TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2284803002 Cr-Commit-Position: refs/heads/master@{#414788}
-
csharrison authored
This patch adds a histogram to count the microseconds used to preload scan the first chunk of CSS for the @import scanning experiment. BUG=596676 Review-Url: https://codereview.chromium.org/2283803002 Cr-Commit-Position: refs/heads/master@{#414787}
-
shaktisahu authored
This CL instantiates ImeFeature and NavigationFeature inside BlimpClientContext. BlimpClientContext owns these features and passes raw pointers to BlimpContents during construction. BUG=611111 Review-Url: https://codereview.chromium.org/2258563003 Cr-Commit-Position: refs/heads/master@{#414786}
-
sievers authored
This can happen if you create a new UI resource (through LTH) which queues a request while there are any evicted resources (as tracked by LTHImpl). RecreateUIResources() will then iterate over all existing client ids and queue another CREATE request. Simply check for duplicates before queuing more requests. The double-upload behavior didn't play well with Android's Thumbnail class which drops the bitmap after every UIResourceClient::GetBitmap() call. BUG=636630 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2247573002 Cr-Commit-Position: refs/heads/master@{#414785}
-
msramek authored
When clearing is in progress, we disable the buttons. We should also disable the checkboxes. Leaving them enabled not only gives the false impression that the datatype selection is modifiable during clearing, it can also have an undesired effect: When the clearing finishes, we show the message about other forms of history based on whether the history checkbox was checked - and thus we shouldn't allow (un)checking in. https://screenshot.googleplex.com/0VXxxLtXHZU.png BUG=595580 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2283853002 Cr-Commit-Position: refs/heads/master@{#414784}
-
fdoray authored
Contrary to what had been assumed, CheckCountAndPostQuitTask doesn't run on the main thread. Because of that, it cannot quit the RunLoop running on the main thread by calling its QuitWhenIdle function; it needs to post a QuitWhenIdleClosure to it. BUG=641142 Review-Url: https://codereview.chromium.org/2284693003 Cr-Commit-Position: refs/heads/master@{#414783}
-
warx authored
Status bubble height may be smaller than kMinimumOnScreenArea, which is 25. The current logic in AdjustBoundsToEnsureWindowVisibility fails in this case. For example, bounds->y() > visible_area.bottom() - min_height is satisfied when status bubble (height 22) touches the bottom of work area. If we adjust bounds using bounds->set_y(visible_area.bottom() - min_height), it will cause unwanted white space. BUG=624806 TEST=Device test, fixing the reporter's bug. The bug in comment 8 is a different bug and will be dealt with later by filing another bug with it. add unittest coverage Review-Url: https://codereview.chromium.org/2175833002 Cr-Commit-Position: refs/heads/master@{#414782}
-
thestig authored
Also don't bother compiling it on ChromeOS at all. Review-Url: https://codereview.chromium.org/2285843002 Cr-Commit-Position: refs/heads/master@{#414781}
-
agable authored
R=iannucci@chromium.org BUG=640251 Review-Url: https://codereview.chromium.org/2282933002 Cr-Commit-Position: refs/heads/master@{#414780}
-
afakhry authored
Unless the user manually tabs in the message center bubble, we shouldn't request the focus by default to prevent the ugly blue border from showing automatically [See screenshot: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LelZhbUN2aWtMSzg/view?usp=sharing] BUG=620801 Review-Url: https://codereview.chromium.org/2281983002 Cr-Commit-Position: refs/heads/master@{#414779}
-
sievers authored
Need to alloc bitmap before creating canvas or it will create an empty bitmap instead of one in WHITE. BUG=636630 Review-Url: https://codereview.chromium.org/2238173003 Cr-Commit-Position: refs/heads/master@{#414778}
-
gayane authored
BUG=622445 Review-Url: https://codereview.chromium.org/2275513003 Cr-Commit-Position: refs/heads/master@{#414777}
-
fs authored
We can no longer listen after events on something that is an instance in a <use>. Move the executeTest() call to the <use> element instead. Since the mentioned file is almost a stub, the actual change is in svg/animations/script-tests/use-animate-width-and-height.js. BUG=641398 Review-Url: https://codereview.chromium.org/2283893002 Cr-Commit-Position: refs/heads/master@{#414776}
-
sammc authored
Interface control messages were added before union support was ready so the structs used for messages manually imitate unions. Now that union support is ready, this workaround is no longer necessary and the structs used for interface control messages can contain unions of the possible message types. Review-Url: https://codereview.chromium.org/2277853003 Cr-Commit-Position: refs/heads/master@{#414775}
-
pasko authored
BUG=none Review-Url: https://codereview.chromium.org/2272043002 Cr-Commit-Position: refs/heads/master@{#414774}
-
mustaq authored
The context menu code for gesture long-press used to fire mousedown & contextmenu events with wrong button/buttons attributes (w.r.t. both the spec & other browsers). This CL fixes those attribute values. Moreover, the existing code achieved the desired outcome of a long-press (setting focus before context menu) through calling the raw PlatformMouseEvent entrypoint. This CL cherry-picks the needed steps, thus provides a cleaner alternative to double-pointer-event firing (minimally fixed through part of crrev.com/2141993003). We don't expect any change in behavior for this part of the CL. BUG=579564,629876 Review-Url: https://codereview.chromium.org/2249663002 Cr-Commit-Position: refs/heads/master@{#414773}
-
yuweih authored
As the old bitmap DesktopView is removed, there is no need to allow the DesktopView to directly access the render data. This CL moves mRenderData into TouchInputHandler to simplify the logic of the DesktopView a little bit. BUG=641123 Review-Url: https://codereview.chromium.org/2272253004 Cr-Commit-Position: refs/heads/master@{#414772}
-
pwnall authored
BUG=639416 Review-Url: https://codereview.chromium.org/2260933002 Cr-Commit-Position: refs/heads/master@{#414771}
-
gayane authored
affects MAC OSX for channels other than canary and Linux for all the channels. Other platforms don't go through the same first run flow. BUG=600391 Review-Url: https://codereview.chromium.org/2285483002 Cr-Commit-Position: refs/heads/master@{#414770}
-
rockot authored
ProcessManifest can return null in a few failure modes. This result gets passed into Reader::OnReadManifest which was doing no null checking. This fixes that. BUG=632916 TBR=ben@chromium.org Review-Url: https://codereview.chromium.org/2284843002 Cr-Commit-Position: refs/heads/master@{#414769}
-
pfeldman authored
DevTools: remove DevToolsTargetDescriptor and its implementations, we are now based on devtools agent hosts. BUG=627517 TBR=this is a mechanical change Review-Url: https://codereview.chromium.org/2273063002 Cr-Commit-Position: refs/heads/master@{#414768}
-
abakalov authored
This change results in chunks from the input getting removed if they contain repetitive strings or mostly spaces. BUG= Review-Url: https://codereview.chromium.org/2283683002 Cr-Commit-Position: refs/heads/master@{#414767}
-
fmeawad authored
This CL allows collecting v8 runtime call stats data as part of deep reports. R=oysteine@chromium.org BUG=641402 Review-Url: https://codereview.chromium.org/2282013003 Cr-Commit-Position: refs/heads/master@{#414766}
-
enne authored
https://codereview.chromium.org/1821863002 changed the display scheduler on Android to use the CompositorImpl ExternalBeginFrameSource directly instead of a synthetic BeginFrameSource that had its vsync parameters set from WindowAndroidCompositor::OnVSync. The frame time given to the display scheduler is always in the past, which made the past logic always give an immediate deadline, causing the display scheduler to run immediately. Fix this by providing a correct deadline in the future. This fixes bad jank where the display scheduler would never give any other compositors time to give frames. So, if the browser compositor was producing frames (such as a loading spinner) then the renderer frames would be extremely janky as they would often miss the immediate (incorrect) deadline. BUG=613193 R=sievers@chromium.org Review-Url: https://codereview.chromium.org/2275253003 Cr-Commit-Position: refs/heads/master@{#414765}
-
justincohen authored
BUG= Review-Url: https://codereview.chromium.org/2277103003 Cr-Commit-Position: refs/heads/master@{#414764}
-
eugenebut authored
SSL status needs to be reset if navigation fails with error. But back-forward navigation calls navigation failure callback with "cancelled" error. In this case SSL status should not be changed. The other case where navigation failure callback is called with cancelled error is load cancellation which should not reset SSL status as well. BUG=637832 Review-Url: https://codereview.chromium.org/2286803002 Cr-Commit-Position: refs/heads/master@{#414763}
-
pkalinnikov authored
This CL fixes the bug where UnindexedRulesetWriter doesn't trim the CodedOutputStream on Finish, resulting in the output having some extra uninitialized bytes at the end. BUG=609747 Review-Url: https://codereview.chromium.org/2279803002 Cr-Commit-Position: refs/heads/master@{#414762}
-
ellyjones authored
BUG= Review-Url: https://codereview.chromium.org/2282793002 Cr-Commit-Position: refs/heads/master@{#414761}
-
qinmin authored
When download snackbar shows up, clicking the open button will open download home for offline page. This CL corrects that behavior so that the corresponding offline page will be opened. BUG=641262 Review-Url: https://codereview.chromium.org/2274573008 Cr-Commit-Position: refs/heads/master@{#414760}
-
dcastagna authored
When a fullscreen quad is promoted to overlay, it should be removed from quad_list to be GL composited. This CL fixes a bug where OverlayStrategyFullscreen assumed that the first quad would always be the one to remove. BUG=b/29430506 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2280823002 Cr-Commit-Position: refs/heads/master@{#414759}
-
ortuno authored
BluetoothChooserController, which is in chrome/, was including BluetoothMetrics which is in content/. To avoid this we create a new histogram specifically for interactions with the chooser. BUG=641105 Review-Url: https://codereview.chromium.org/2278003003 Cr-Commit-Position: refs/heads/master@{#414758}
-