- 17 Mar, 2016 40 commits
-
-
dcheng authored
BUG=554298 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/1810893003 Cr-Commit-Position: refs/heads/master@{#381793}
-
sebsg authored
Some text state fields have a maxlength of two. This can cause problem for some states. For example New York is filled as NE (Nebraska) instead of NY. BUG=595104 TEST=AutofillFieldTest Review URL: https://codereview.chromium.org/1811543002 Cr-Commit-Position: refs/heads/master@{#381792}
-
rch authored
Committed: https://crrev.com/dced4c771d25317d26a0f6e258c7b7f64d4e8eea Cr-Commit-Position: refs/heads/master@{#379652} Committed: https://crrev.com/740688bec5c66af00debe117b6d375ecd212e570 Cr-Commit-Position: refs/heads/master@{#381134} Review URL: https://codereview.chromium.org/1699653002 Cr-Commit-Position: refs/heads/master@{#381791}
-
mek authored
This changes the basic SingleLinkHeaderTest to not verify implementation details of how LinkHeader deals with invalid headers. If a header is invalid it doesn't matter what it's url, rel and other attributes are set to. Also adds a missing EXPECT to compare the expected "as" attribute with the returned "as" attribute. Review URL: https://codereview.chromium.org/1778413005 Cr-Commit-Position: refs/heads/master@{#381790}
-
caseq authored
... for ease of re-used outside of front-end codebase. Review URL: https://codereview.chromium.org/1808063002 Cr-Commit-Position: refs/heads/master@{#381789}
-
alexmos authored
When we changed RenderFrameProxyHost::OnOpenURL to use the transfer logic in r377832, we lost FilterURL validation provided by RenderFrameHostImpl::OpenURL. This CL adds that validation to navigations initiated via proxies. BUG=595339 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1812723002 Cr-Commit-Position: refs/heads/master@{#381788}
-
philipj authored
https://github.com/whatwg/html/issues/869#issuecomment-196189743 R=mlamouri@chromium.org,isherman@chromium.org Review URL: https://codereview.chromium.org/1809023003 Cr-Commit-Position: refs/heads/master@{#381787}
-
marpan authored
https://chromium.googlesource.com/webm/libvpx.git/+log/9aa083d164e0..afd869308ef4 $ git log 9aa083d16..afd869308 --date=short --no-merges --format='%ad %ae %s' 2016-03-15 paulwilkins Revert "Fix bug in stats output for HBD." 2016-03-15 marpan vp9: Fix to scene cut/content change detection. 2016-03-15 huisu Fix typos in unit tests 2016-03-14 marpan vp9: Scene cut/content change detection: Adjust gf update. 2016-03-14 marpan vp9: Scene cut/slide change detection: Increse min_thresh. 2016-03-11 marpan vp9: Switch to model=1 for skin detection. 2016-03-11 marpan vp9: Fix issue in scene/content change detection. 2016-02-24 marpan vp9 non-rd pickmode. Some adjustments for vbr mode. 2016-03-10 marpan vp9: Update to skin detection. 2016-03-08 marpan vp9-svc: Fix to frame dropping in svc mode. 2016-03-08 marpan vp9-svc: Change default spatial bitrate allocation. 2016-03-08 jzern vp9_svc_layercontext(): fix proto mismatch 2016-03-08 marpan vp9-svc unitests: Add more tests for key frame periods. 2016-03-08 slavarnway VPX: loopfilter_mmx.asm using x86inc 2 2016-03-07 marpan vp9-resize tests: Update to real-time resize unittests. 2016-03-07 marpan vp9-svc: Fix to resetting pattern/flags on key frame. 2016-03-07 slavarnway define GET_GOT_DEFINED if not previously defined 2016-03-07 marpan vp9-svc: Non-rd pickmode, fix condition for testing zeromv for spatial ref. R=johannkoenig@google.com Review URL: https://codereview.chromium.org/1811993003 Cr-Commit-Position: refs/heads/master@{#381786}
-
amistry authored
BUG=582468 Review URL: https://codereview.chromium.org/1804353002 Cr-Commit-Position: refs/heads/master@{#381785}
-
gmanikpure authored
BUG= Review URL: https://codereview.chromium.org/1813813003 Cr-Commit-Position: refs/heads/master@{#381784}
-
zhenw authored
a parameter This CL updates Tracing.Start to accept trace config as a parameter when starting tracing. It is backward compatible with the old way. Design doc: https://goo.gl/GxQ23k BUG=579358 Review URL: https://codereview.chromium.org/1765153002 Cr-Commit-Position: refs/heads/master@{#381783}
-
dschuyler authored
Alan felt that just the word 'Search' made the side nav look like it was an option to search inside settings. He asked that the section name be changed to 'Search engine'. BUG=589630 Review URL: https://codereview.chromium.org/1812523004 Cr-Commit-Position: refs/heads/master@{#381782}
-
oshima authored
BUG=595794 R=georgesak@chromium.org Review URL: https://codereview.chromium.org/1807303003 Cr-Commit-Position: refs/heads/master@{#381781}
-
csharrison authored
This patch adds a method on NetworkMetricsProvider that logs aggregate ABORT metrics on the NetworkMetricsProvider::ProvideGeneralMetrics callback. This gives finer grained abort statistics. BUG=557430 Review URL: https://codereview.chromium.org/1796983002 Cr-Commit-Position: refs/heads/master@{#381780}
-
enne authored
Also, add back throttling tests to check changing the source. Depends on https://codereview.chromium.org/1765723002 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1774323003 Cr-Commit-Position: refs/heads/master@{#381779}
-
anthonyvd authored
https://codereview.chromium.org/1781433002 changed some of the constrained_window code and updated some callers, but not the tab-modal signin flow. The modal was being created but not shown. BUG=593091,217034 Review URL: https://codereview.chromium.org/1815433002 Cr-Commit-Position: refs/heads/master@{#381778}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b364ca30..873938e2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1811973002 Cr-Commit-Position: refs/heads/master@{#381777}
-
wkorman authored
The bot now uses 'git config' to explicitly set the intended author/committer user name and email before running the script, rather than routing through the rebaseline script itself. BUG=594817,589140 Review URL: https://codereview.chromium.org/1809723002 Cr-Commit-Position: refs/heads/master@{#381776}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/d427266a58af..852f15da7ceb $ git log d427266a5..852f15da7 --date=short --no-merges --format='%ad %ae %s' 2016-03-17 mtklein free -> reset 2016-03-17 reed update callsites for Make image factories 2016-03-17 djsollen Fix gdb debugging for the latest NDK release. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1806343003 2016-03-17 msarett Disable bad gif decode on CG 2016-03-17 bungeman Revert of Remove uses of SkImageDecoder from gms (patchset #2 id:20001 of https://codereview.chromium.org/1791583002/ ) 2016-03-17 bungeman Use sktarray.begin() instead of &sktarray[0]. 2016-03-17 mtklein try to flush stdio in the crash handler 2016-03-17 bungeman Revert of free -> reset (patchset #3 id:40001 of https://codereview.chromium.org/1811723002/ ) 2016-03-17 borenet Fix Linux Swarming bots 2016-03-17 borenet Some fixes for Swarming bots 2016-03-17 robertphillips Allow SkGpuDevice::drawSprite to handle subset SkBitmaps 2016-03-17 reed Allow const& for SkImages and SkPictures in draw methods. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=bungeman@google.com Review URL: https://codereview.chromium.org/1811063002 Cr-Commit-Position: refs/heads/master@{#381775}
-
bcwhite authored
Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d Cr-Commit-Position: refs/heads/master@{#380474} Committed: https://crrev.com/29601c49ec14ecb8cdfac577288b814e4c425bfa Cr-Commit-Position: refs/heads/master@{#380889} Review URL: https://codereview.chromium.org/1719363002 Cr-Commit-Position: refs/heads/master@{#381774}
-
pkasting authored
This replaces the unconditional update done in (or right after) construction in the subclasses. I need to add a ViewHierarchyChanged() override anyway, so I can set up a widget observer later, but I'm separating this bit out first to try to tease out what's causing trybot failures. BUG=none TEST=none Review URL: https://codereview.chromium.org/1785643002 Cr-Commit-Position: refs/heads/master@{#381773}
-
dschuyler authored
This CL moves the common iron-icon coloring and sizing to the settings shared style-module. The variations and one-offs are now in more specific files (such as the side nav icons). BUG=589630 Review URL: https://codereview.chromium.org/1813643002 Cr-Commit-Position: refs/heads/master@{#381772}
-
dalecurtis authored
This breaks hardware decoded video since ownership of video frames is tied to the hardware decoder. BUG=595716 TEST=none Review URL: https://codereview.chromium.org/1813883002 Cr-Commit-Position: refs/heads/master@{#381771}
-
scottmg authored
This one is a bit subtle. The two removed "helper" AppLaunchParams constructors were using HostDesktopType as an unrelated boolean to choose one or the other of the two constructors (unrelated to the actual value of HostDesktopType). I pulled those two out and had them use the now-single constructor, and tried to give the two names that made some sense according to their comments. R=benwells@chromium.org, sky@chromium.org BUG=558054, 587387, 586862 Review URL: https://codereview.chromium.org/1807743003 Cr-Commit-Position: refs/heads/master@{#381770}
-
danakj authored
Instead of writing it ourselves. Note that StaticAtomicSequenceNumber does not work here since it can only be used in global scope. R=piman@chromium.org BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Review URL: https://codereview.chromium.org/1809753003 Cr-Commit-Position: refs/heads/master@{#381769}
-
afakhry authored
Those reports needed to be queued nicely and each report should be sent with its correct respective system information not the one of the previous report. BUG=593452 Test=manually Review URL: https://codereview.chromium.org/1794513002 Cr-Commit-Position: refs/heads/master@{#381768}
-
rockot authored
This adds a flags argument to watch callbacks and exposes a flag to indicate that the callback was invoked as a result of some external process event (i.e. an incoming EDK IPC message). The public C++ Watcher implementation is updated to take advantage of this, effectively allowing us to dispatch to Mojo bindings synchronously when they live on the IO thread and are servicing messages from out-of-process. BUG=590495 Review URL: https://codereview.chromium.org/1811433002 Cr-Commit-Position: refs/heads/master@{#381767}
-
rdevlin.cronin authored
The preferencesPrivate, location, and principalsPrivate APIs have been reduced/removed. Update the histogram values in one CL with nothing else since presubmit complains about modifying values. BUG=595168 BUG=593166 BUG=586560 NOTRY=true (NOTRY because editing existing histogram entries in valid ways) Review URL: https://codereview.chromium.org/1810583003 Cr-Commit-Position: refs/heads/master@{#381766}
-
danakj authored
If the provider is not null, it will have a context that is not null. The provider is a WebGraphicsContext3DProviderImpl, which is given a ContextProviderWebContext. The ContextProviderWebContext is a ContextProviderCommandBuffer, the factory for which returns a null provider if the underlying context is null. Further, the provider comes from RenderThreadImpl's SharedMainThreadContextProvider(), which will return null if the provider is null, or if the provider fails to initialize its GL context. R=junov@chromium.org, kbr@chromium.org BUG=584497 Review URL: https://codereview.chromium.org/1813603003 Cr-Commit-Position: refs/heads/master@{#381765}
-
stevenjb authored
Revert of Re-land: Enable XFA-Forms for the PDFium plugin. (patchset #1 id:1 of https://codereview.chromium.org/1811743002/ ) Reason for revert: Causing "Target image has run out of space" errors on Chrome OS builders: http://crbug.com/595763 Original issue's description: > Re-land: Enable XFA-Forms for the PDFium plugin. > > This reverts commit 13fe4645. > See https://codereview.chromium.org/1761673002/ > > TBR=thakis@chromium.org > > Committed: https://crrev.com/ed07b3773e3aad4a44a79a48c17162ef57ca82ee > Cr-Commit-Position: refs/heads/master@{#381573} TBR=thakis@chromium.org,ochang@chromium.org,jschuh@chromium.org,rpop@chromium.org,dsinclair@chromium.org,tsepez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1814843003 Cr-Commit-Position: refs/heads/master@{#381764}
-
chcunningham authored
Clusterfuzz identified a race between the media thread calling SetVolume and the audio device thread calling ProvideInput. Add a lock to synchronize access to |volume_| between threads. Also adds some thread_checkers to just firm up the contract that the majority of these methods are called only by the media thread. BUG=588992 Committed: https://crrev.com/57c6958a99f2c62a4408d2a9d262a22129309106 Cr-Commit-Position: refs/heads/master@{#379349} Review URL: https://codereview.chromium.org/1748183006 Cr-Commit-Position: refs/heads/master@{#381763}
-
skyostil authored
Review URL: https://codereview.chromium.org/1811023002 Cr-Commit-Position: refs/heads/master@{#381762}
-
leon.han authored
Although the root cause of crash is not clear now, maybe we'd better add guard firstly to avoid crash. BUG=594644 Review URL: https://codereview.chromium.org/1813673002 Cr-Commit-Position: refs/heads/master@{#381761}
-
yzshen authored
This fixed the issue that enum generated code didn't work when variant is specified. This is a quick fix, we need more fundermental improvement for variant handling code. BUG=595791 Review URL: https://codereview.chromium.org/1811853004 Cr-Commit-Position: refs/heads/master@{#381760}
-
eugenebut authored
1.) Added |suppressDialogs| property to CRWWebController, which should be used instead of |setPageDialogOpenPolicy|. 2.) Suppress all dialogs in native code instead of JavaScript (except navigation dialogs which can not be suppressed w/o JS override). 3.) Suppress HTTP Auth dialog if |suppressDialogs| is YES. BUG=595463 TEST=window.open, window.prompt, window.confirm, window.alert, geolocation and http auth dialogs should be blocked for preload pages. All these dialogs should work normally for regular pages. Review URL: https://codereview.chromium.org/1806043004 Cr-Commit-Position: refs/heads/master@{#381759}
-
oshima authored
BUG=595490 TBR=zhaoqin@chromium.org Review URL: https://codereview.chromium.org/1812963003 Cr-Commit-Position: refs/heads/master@{#381758}
-
dschuyler authored
This CL updates the section names (shown on the side nav and above each section). They use sentence case. The & symbol is replaced with 'and'. The Reset and Languages names have been shortened. BUG=593989 Review URL: https://codereview.chromium.org/1803363003 Cr-Commit-Position: refs/heads/master@{#381757}
-
atanasova authored
When the whitelist is created we save the path to the locally stored icon. During the suggestions creation save that information and when trying to get the large icon for the NTP, first check if we have a locally stored one first. This does not yet handle the case when whitelist entry point becomes part of most visited. For more information on whitelists - go/chrome-whitelists Screenshot - https://screenshot.googleplex.com/3eTZ3wghRvH.png BUG=586097 Review URL: https://codereview.chromium.org/1772363002 Cr-Commit-Position: refs/heads/master@{#381756}
-
fgorski authored
BUG=595772 NOTRY=true Review URL: https://codereview.chromium.org/1814903002 Cr-Commit-Position: refs/heads/master@{#381755}
-
dschuyler authored
BUG=589630 Review URL: https://codereview.chromium.org/1798133002 Cr-Commit-Position: refs/heads/master@{#381754}
-