- 09 Sep, 2019 40 commits
-
-
Stefan Zager authored
Need to change the invocation after this: https://chromium-review.googlesource.com/c/android_ndk/+/1783234 BUG=891999 R=jbudorick@chromium.org,cbiesinger@chromium.org Change-Id: I3d21c01e5bce740c839e9d9f2375f32da33072d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786876Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#694915}
-
Luum Habtemariam authored
Since adding this flag we've found out that the kPluginVm flag exists. Now we'll start the CupsProxyService based on that and rip out the old flag. Bug: chromium:945409, chromium:999873 Test: manually confirmed service startup with new flag Change-Id: I4b3815d05bcca104725104250ab3b043b58f2411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790272 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#694914}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I771f441d9dd9d90c9b19d4025e397404e6c03d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793383 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#694913}
-
Peter Kasting authored
Bug: 1000055 Change-Id: I2ad15b7167db4e90ca80761c42de1d00ef08b41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792789 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#694912}
-
Mike Wittman authored
Implements the ThreadDelegate abstraction for Android, providing the stack base address and registers that may require rewriting to update them from pointing to the original stack to the copied stack. Removes code from the TracingSamplerProfiler that was attempting to use the StackSamplingProfiler with the built-in Android StackSampler. This had no effect previously and crashes with the current skeleton implementation. Tracing will be able to use the built-in sampler when it's in a more mature state. Bug: 988579 Change-Id: I4c44bbec33f2e1457c03de37d8c852a85eb9d65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764288Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#694911}
-
Avi Drissman authored
BUG=958419, 844455 Change-Id: I0549227aba40f6fd85b9e7b39e719798cd33e0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730774Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#694910}
-
Fredrik Söderquist authored
To be able to separate the resolution of intervals from the update of the "position" information (percent, repeat) we need to keep the "full" previous interval. Extend the existing |previous_interval_begin_| to a full interval, add a new GetActiveInterval(...) helper and use that in CalculateAnimation{Repeat,Percent}. Then move the calls to the latter two functions in Progress() after the interval check/resolution. Bug: 998526 Change-Id: Ia7154e6612252d21b04ab6302c8ef75bc7664b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790449Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#694909}
-
Tom Anderson authored
This is a reland of 0173c183 Original change's description: > Reland "Use shared memory to send images to X server" > > This is a reland of a752710d > > Original change's description: > > Use shared memory to send images to X server > > > > When playing back a 1440p 60fps video without hardware acceleration, ~15% of > > frames would be dropped. With this change, I'm not getting any dropped frames. > > > > Background: > > The bottleneck is in SoftwareOutputDeviceX11::EndPaint, which (for 4K video) was > > taking ~0.06s per frame, which was limiting the output to ~15fps. It was taking > > so long because we were sending each frame to the X server over the wire. With > > the shared memory approach from the above CL, SoftwareOutputDeviceX11::EndPaint > > takes only ~0.00002s. > > > > Summary of changes: > > * Switch usage of XPutImage() to XShmPutImage() when possible. > > * Shm segment is recycled across frames. > > * Segment has a 1.5x growth policy to give windows room to resize without > > having to reallocate for each frame. > > * Segment has space for 2 frames. It was experimentally found that bumping > > this up to 3 didn't give significant gains. > > * X server sends a completion event when XShmPutImage() is finished, so we > > cannot recycle the memory until getting this event. > > * Event processing happens on the GPU main thread, but processing needs to > > happen on the compositor thread, so forwarding the event is necessary. This > > is implemented in XShmImagePool. > > > > BUG=991633 > > > > Change-Id: Ia7782cb9e21d0a93d3250c118e4ba76025354e40 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693737 > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: kylechar <kylechar@chromium.org> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#691321} > > R=jorgelo > TBR=rjkroege,kbr,kylechar > > Bug: 991633 > Change-Id: Id0533ea8ba4de45ca2242ee979197798a818826d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775500 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693202} R=rjkroege TBR=jorgelo,kbr,kylechar CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel Bug: 991633 Change-Id: I9b678d7bbb928e3fc0214f2336cd780846a4bbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789444Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#694908}
-
Zhongyi Shi authored
Bug: 999285 Change-Id: Iafd038d43229d927105b3013e42c2ae333839ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776703 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#694907}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d4e6d75c. With Chromium commits locally applied on WPT: d8d7248d "Move forced colors tests to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I0cba28e543c03b67c543e364774c57e18039a94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792855Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694906}
-
Daniel Rubery authored
This has been launched since M76, so we can safely remove the feature flag at this point. Bug: 917190 Change-Id: I1bc9c9727d4d3ae0d0c60b99b7747c3d19b5429c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792230 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#694905}
-
Julie Jeongeun Kim authored
This CL converts NetworkContextPtr from unittests in chrome/browser, fuchsia/, google_apis/, and services/network to new Mojo types. Bug: 955171, 978694 Change-Id: Id29649d97d793a9fe2ea24295a19800d31cb7316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786369Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#694904}
-
Randy Rossi authored
The ChromeVox extension was changed recently to call commandLinePrivate to detect some experimental switches. This API is not available on ChromeCast and was causing the extension to fail on init. Stubbing this API out so the extension doesn't fail. Bug: None Test: Manual, display assistant Change-Id: I86322b85778ca7d96d66ca90a119eae9347b84f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786581Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#694903}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/523d565f1729..022776627054 Created with: gclient setdep -r src-internal@022776627054 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:790676,chromium:790463,chromium:790452,chromium:790443,chromium:790442,chromium:790439,chromium:790419,chromium:790403 Change-Id: I3d26a884625a8e26b70b798eec9d3dca3af459c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793224Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694902}
-
Peter Kasting authored
Bug: 1000055 Change-Id: I68b4037c827698f701c46ac7ef552c9c08d5cd70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793251 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#694901}
-
jonross authored
We added a CHECK to RenderWidgetHostImpl::SynchronizeVisualProperties. This was in order to help track down the route cause of a rare crash on Mac. Adding a CHECK in the browser process in order to crash earlier than in the renderer. The original bug has long since been fixed, but we kept this around in case we detected crashes in the wild. However aside from ClusterFuzz, and one project embedding Chromium, none arose. We do not feel it is valid to keep this CHECK around anymore. Our worry about this affecting end users is gone. Bug: 993274 Change-Id: I6de4c737f575d5d0fb183d93f1a5d3a092fd87a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792459Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#694900}
-
rbpotter authored
Autogenerating Polymer 3 version of CrContainerShadowBehavior test, since the behavior is now autogenerated (see https://crrev.com/c/1779435) Bug: 965770 Change-Id: Ieb01a2e8c7fa31f5b56028e61c428ab0d012dd41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789749Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#694899}
-
Ben Pastene authored
This reverts commit bd916257. Reason for revert: mac_chromium_compile_dbg_ng is purple: https://ci.chromium.org/p/chromium/builders/try/mac_chromium_compile_dbg_ng?limit=200 Original change's description: > Switch mac_chromium_compile_db_ng to builderless > > Bug: 999206 > Change-Id: I91c01200552c4170ac6d18badd5bdd113396526d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792461 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Auto-Submit: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694874} TBR=martiniss@chromium.org,jbudorick@chromium.org Change-Id: I4a3f86fdb97b98adc7752082e3330f0c2870d6e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 999206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793263Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#694898}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ac68e9c3dd09..afc6ed3cdbc7 git log ac68e9c3dd09..afc6ed3cdbc7 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 treehugger-gerrit@google.com Merge "Refactor record controllers and fix extension" Created with: gclient setdep -r src/third_party/perfetto@afc6ed3cdbc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I6e1f8c53c4bfca415fd1bd8c6dfb49710047b724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793262Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694897}
-
Daniel Clark authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1772228. The initial commit was reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1789295. It was reverted because the tests it changed were failing in Win7; it turns out that there is a UIA platform difference where the Win7 platform doesn't query for the LocalizedLandmarkType, causing the tests to fail as they now expect that value to be dumped. This reland is is identical to the initial change with the addition of separate test expectation files for Win7 where the LocalizedLandmarkType is omitted. Original change description follows: Change the LocalizedLandmarkType and LocalizedControlType for the contentinfo aria role from "content info" to "content information" per https://www.w3.org/TR/core-aam-1.1/#role-map-contentinfo. Also update the LocalizedLandmarkType for <footer> when scoped to the body element to "content information", since it inherits this from the contentinfo role per https://w3c.github.io/html-aam/#el-footer. Note that this doesn't affect <footer>'s LocalizedControlType, which should be "footer" (but is currently still "content info"). That is handled in the separate change at https://chromium-review.googlesource.com/c/chromium/src/+/1763243. TBRing reviewers: aleventhal@: Please review content/browser/accessibility/browser_accessibility.cc rockot@: Please review changes to content/app/strings/content_strings.grd TBR=aleventhal@chromium.org,rockot@google.com Bug: 997897 Change-Id: I30af47d7a3cc2f41653177b365cde003cb56caaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793283Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#694896}
-
Joshua Pawlicki authored
Bug: 1001973 Change-Id: Ib123d0f68d0557a07de10eb57a29604db8c8d38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793405Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#694895}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ec283489193a..884c81e1703f git log ec283489193a..884c81e1703f --date=short --no-merges --format='%ad %ae %s' 2019-09-09 perezju@chromium.org [Telemetry] Remove support for ShouldAddValue Created with: gclient setdep -r src/third_party/catapult@884c81e1703f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:921000 Change-Id: Id888836ed76d5dac6e9a673bc769c13c79b34f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793403Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694894}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/3f05f651ae36..3a4503986247 git log 3f05f651ae36..3a4503986247 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 absl-team@google.com Googletest export 2019-09-09 absl-team@google.com Googletest export 2019-09-09 absl-team@google.com Googletest export Created with: gclient setdep -r src/third_party/googletest/src@3a4503986247 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/googletest-chromium-autoroll Please CC isamsonov@google.com,staphany@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official TBR=isamsonov@google.com,staphany@google.com Bug: None Change-Id: Iecc2c85bc541dfee25b0ca837dece5e37ae6339f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792141Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694893}
-
Brian Sheedy authored
Switches media_perftests to use PerfResultReporter instead of PrintResult and whitelists the tests for conversion to histograms before uploading to the perf dashboard. Bug: 923564 Change-Id: Id007f0f777f47cf676b32feb7b9b0455ec5df628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790413 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#694892}
-
Tina Wang authored
Previously: when sharing by right clicking a non-avtive tab, the active tab will be sent. After fixing: send the tab that the user right clicked on. Bug: 995614 Change-Id: If9a52d36eed400c3f096b2cbf58069aa85169446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790375 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#694891}
-
Miyoung Shin authored
This CL converts AdapterPtr, AdapterClientPtr DiscoverySessionPtr in chrome and device to the new Mojo type, and uses pending_remote<AdapterClient> and pending_remote<DiscoverySession> in adapter.mojom and pending_remote<bluetooth.mojom.Adapter> in bluetooth_internals.mojom Bug: 955171 Change-Id: I013e11c6b5b1ce16275f22e99678f22564ebd13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787669 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#694890}
-
Khushal authored
Since we do uniform scaling horizontally and vertically when rastering content and choose the higher scale between the 2, this can lead to excessive memory use if the ratio between the 2 scales and layer bounds is extremely high. Cap this ratio to some limit (arbitrarily chosen). Change-Id: If90b101d5a096c03dfb22fb633f3b33e2600eb74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790958Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#694889}
-
Koji Ishii authored
This patch changes line breaking behavior after out-of-flow objects to match to ICU, assuming the out-of-flow object is an object replacement character. The behavior is not well-defined, and not all cases are interoperable across existing implementations. Legacy/WebKit resets the prior context so that text after out-of-flow objects behave as if it is at the top of the line. Gecko and Edge seem to allow break in most cases, even when NBSP follows, but not when the line overflows. The behavior implemented in this patch is interoperable for all tests that pass on existing 4 implementations, but not exactly same as legacy when implementations do not agree. Bug: 1001438 Change-Id: I4c7077d2c287a6e897175b29a73ce1c308f29f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792467Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#694888}
-
Brian Osman authored
The cache size is now configurable by the client. This CL re-implements the change made here: https://skia.googlesource.com/skia/+/450ba0a2b25de433470d5bfa2f21a0db833786fc Bug: chromium:974219 Bug: chromium:988964 Change-Id: Ibef0f842c30154d7295909284c5dc6922c3fa40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790501 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#694887}
-
Bo Liu authored
Use the ContentView as the WebContents container view Also emulate focus changes like content shell. Change-Id: I6edf3e7be920bcc2a385d0698b1bf949a496c91e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790150 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#694886}
-
Samuel Huang authored
This CL sets the default value for |dfmify_dev_ui_dfm| to true, to put the DevUI DFM on track for launch: Canary -> Dev -> Beta -> Stable. Depending on approval status, we can easily disable this. For Canary, Play Store is also expected to gracefully handle disappearance / reappearance of the DevUI DFM, if we ever need to disable / re-enable it. Currently only chrome://bluetooth-internals is in the DevUI DFM, but more will be moved in the upcoming weeks. Also, only native resources split is supported (native code split is future work). Bug: 927131 Change-Id: Ie5c8b821ca067a19f4c69dbd7af863816a89c460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793233 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#694885}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/views. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. Edit: Restore full TaskEnvironment in ViewsTestBase. R=weili@chromium.org Bug: 891670 Change-Id: Id7d806ac0dcacb9bdeeb3e7117c659ffbb46c217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786953Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#694884}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/browsing_data. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=dullweber@chromium.org Bug: 891670 Change-Id: I31e0a16f1dc0e605fad78e6252ec7d7a833efb9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786839 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#694883}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/eb590e0e22e9..1d3ff52a37c7 git log eb590e0e22e9..1d3ff52a37c7 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 thestig@chromium.org Fix out of bound read in PDF_DecodeText(). 2019-09-09 bebeaudr@microsoft.com PDF a11y: new API for font-weight 2019-09-07 thestig@chromium.org Simplify CPDF_CMap ctor. Created with: gclient setdep -r src/third_party/pdfium@1d3ff52a37c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:1001159,chromium:985604 Change-Id: Ib6fc0b8abd36d50385d4509937a90eb1c28f455f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793234Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694882}
-
David Tseng authored
Issue: Whenever a node does not have focus, the textSelStart and textSelEnd attributes are not populated properly. For example, Node role=textField textSelStart=2 textSelEnd=3 value="asdf" regardless of where the actual selection is in the text field. Change-Id: I542e58384268b069d6d015e981a2ad3fc7c20ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790268Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#694881}
-
Stephen Chenney authored
TBR=eae@chromium.org Bug: None Change-Id: I39bb28ca7e94aea076f0df2973c5ddc156a876bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793382Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#694880}
-
Sergey Ulanov authored
ExternalVkImageBacking was calling Initialize() for the command buffer returned from VulkanCommandPool::CreatePrimaryCommandBuffer(), but CreatePrimaryCommandBuffer() already calls Initialize(), i.e. Initialize() was called twice, which means VkCommandBuffer was created twice, while only second handle was freed in VulkanCommandBuffer::Destroy(), the other one was leaked. This change fixes the issue in ExternalVkImageBacking to avoid the second Initialize() call. Also added a DCHECK() to avoid this problem in the future. Bug: 1001296 Change-Id: I043ddd53952a0650db5cd44835f8d4c244a6e722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792853 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#694879}
-
Ramya Nagarajan authored
The SyncSendTabToSelf feature has been enabled by default across all platforms since M75. This cleans up any dependencies on the feature. Bug: 949612 Change-Id: I4a59c151d2cf6349d277e52a81fe88399f2ab665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790642 Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#694878}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /gpu/command_buffer. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=vmiura@chromium.org Bug: 891670 Change-Id: Idb77d543a4954904ed6f6fd8e8f9d753ef170964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786782 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#694877}
-
Xinghui Lu authored
Before allowlist is available from GmsCore, we plan to have it hardcoded in our code. This call is synchronous for now, since it gets result directly instead of a IPC call. I will have a follow up CL for Async implementation. Bug: 999344 Change-Id: Ide3b7de83f0e32c5be8ac657369ce9f95a848f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776601 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#694876}
-