- 24 Aug, 2019 39 commits
-
-
Yue Zhang authored
Bug: 997192 Change-Id: I5ddfea43dad58d17007eb6f4f50966d4ac7a29ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769799 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690164}
-
Benjamin Beaudry authored
The text direction attribute is now properly set for text runs in PDF. It is inferred by the position of the first and the last characters of a text run. This change includes a pdf-template file (text-direction.in) with RTL text representation used to generate our unit test PDF file. Bug: 985604 Change-Id: If5d82296463331e95c4ded4e5244d65be3fbadfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737019 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#690163}
-
Fred Mello authored
This avoids IS_BUNDLE being optimized out by the JVM. Added comments to clarify which config target should be used by other java targets. Note: The changes in this CL were originally uploaded @ 1765654 and patched (fixed srcjar_deps for tests) in this CL. Bug: 996821 Binary-Size: Related to a faulty CL(1762699) that decreased it (same amount). Change-Id: Ide295c69c61b98d7039f5f74fe72d97a88b28cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769516 Commit-Queue: Fred Mello <fredmello@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#690162}
-
Dan Beam authored
Also, start using assert() in NTP code. This is helpful for compile time typechecking and runtime enforcement. Based on https://crrev.com/c/1763345 by Evan Stade <estade@chromium.org> R=gayane@chromium.org BUG=996209 Change-Id: I6ab3f92e93ae52249bafd722733aa4bb63289930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764794 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#690161}
-
Jeremy Roman authored
Do it in the former (which runs earlier) and merely DCHECK in the latter. Change-Id: I53c0a8a64ec4f2b909de6dd710167d3f8e8aefac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769522Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#690160}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/195bf9a75021..079ace40c74f Created with: gclient setdep -r src-internal@079ace40c74f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9c37962d220f0321998fafc7f095eb8c5f68e672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769751Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690159}
-
Ken Rockot authored
Adds two new methods to SequenceBound: PostTaskWithThisObject(), and ResetWithCallbackAfterDestruction() PostTaskWithThisObject() allows for safe execution of arbitrary logic on the underlying sequence-bound object within its bound sequence. This is especially useful when performing batch operations on an object without having to modify the object's public API just to accommodate SequenceBounds's single-method-invocation Post() API. ResetWithCallbackAfterDestruction() allows a continuation to be run on the bound sequence after destruction of the underlying object is complete. This is at least useful in e.g. tests which may need to synchronize against the destruction of the object. Bug: None Change-Id: I600410b5579e0a0f9307ee6ead0845d549b9c4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768663 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#690158}
-
Matt Reynolds authored
The Gamepad object stores button and axis data in fixed-length arrays. It has buttons_length and axes_length members that indicate which items in these arrays contain valid data. NintendoController uses a Gamepad object to hold the most recent button and axis state, but does not initialize or check the buttons_length or axes_length members. This CL modifies NintendoController to avoid reading from these arrays unless they have the expected length. If the length does not match the expected length, the arrays are assumed to be uninitialized. BUG=997072 Change-Id: I376fa2518afbb6c00b055bec3d5ddbbc08d80a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769629Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#690157}
-
Dan Beam authored
R=ehmaldonado@chromium.org,iannucci@chromium.org BUG=997396 Change-Id: Ibf79cffe7c9fcb95be328551dcf00e7f13d1e97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769805 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#690156}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/90e930e2da74..7f75c0e92e6a git log 90e930e2da74..7f75c0e92e6a --date=short --no-merges --format='%ad %ae %s' 2019-08-23 jbudorick@chromium.org owners: fix inline comment support in included files. 2019-08-23 ehmaldonado@chromium.org depot_tools: Fix bug when running both python2 and python3 tests. Created with: gclient setdep -r src/third_party/depot_tools@7f75c0e92e6a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:995474,chromium:984182 Change-Id: I501430b1941b6cc107c012086be729aeac751ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769744Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690155}
-
Matt Mueller authored
CertPathBuilder::cert_path_iter_ is constructed with a pointer to out_result_, so out_result_ must be earlier in the member list to ensure it is constructed before cert_path_iter_ tries to access it. Bug: 997340,991247 Change-Id: I93137a16e0022db00d71b91b6636e42d6f39f2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769701Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#690154}
-
Ian Prest authored
The current heuristics always creates a new paragraph whenever the font-size changes, which is undesirable. Simply removing the size check causes many of the existing tests to fail because the size-change is often the only reason that we have multiple paragraphs at all. The problem is our PDF file has too few lines on each page to compute reasonable line & paragraph size thresholds. So this change required changing the heuristics. The new heuristic is as follows: 1. We keep track of the top & bottom of the current line, as weighted averages of the (recent) text boxes on the line. 2. When we encounter a new text box, if it significantly overlaps the top-to-bottom range, it's considered part of the same line. 3. If we are starting a new line, we also check the paragraph threshold to see if we should also start a new paragraph. If the paragraph threshold couldn't be computed (because there weren't enough lines on the page), we compare against the line size. We also introduce the `PDFExtensionAccessibilityTextExtractionTest` test suite. These tests are like the tree-dump tests, but they dump raw text content, split into lines and paragraphs. (Compared to tree-dump tests, this approach allows us to test the kNextOnLine and kPreviousOnLine attributes are correct.) Bug: 985604 Change-Id: Idfce6edfef42580e7fac4d8a7753c82495c15bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743032 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by:
-
Malay Keshav authored
In an effort to reduce disk usage by animations, this patch replaces an expensive APNG animation file usage with a lottie animation file in OOBE. Bug: 976057 Test: Manually tests this and dependent changes by navigating to OOBE Change-Id: I5965688a4d1c17dd6e32c59ee1b347f0496cfa66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764632 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#690152}
-
Joel Klinghed authored
On Android, PrintManager has a virtual method PdfWritingDone which is implemented by PrintViewManagerBasic which extends PrintViewManagerBase. PdfWritingDone() is called whenever a print job has finished, including if it is cancelled or fails. If the print view manager has an ongoing job and is destroyed then PrintViewManagerBase calls DisconnectFromCurrentPrintJob() from its destructor which can end up calling the now pure virtual function PdfWritingDone() (as we are in destructor of PrintViewManagerBase and PrintViewManagerBasic is already destroyed). Avoid this by calling DisconnectFromCurrentPrintJob() from PrintViewManagerBasic destructor so that any current print job is terminated while PrintViewManagerBasic is still available. Added PrintViewManagerBasicTest that triggers this problem on Android. Bug: 993255 Change-Id: If2b9f177fa9e106751e4d3d16f4ea171c6191131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751244 Commit-Queue: Joel Klinghed <the_jk@opera.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5d51a2e48472..34a2b06a63d3 git log 5d51a2e48472..34a2b06a63d3 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 vapier@chromium.org cros lint: upgrade pylint to 1.6 2019-08-23 mmortensen@google.com Update gen/chromite/api/binhost_pb2.py for PrepareDevInstallBinhostUploads. Created with: gclient setdep -r src/third_party/chromite@34a2b06a63d3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I855e7f06ae08baaddbb7d219898268ea4877241e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769742Reviewed-by:
-
Sharon Yang authored
As part of a previous change, build dependencies were required but not added, these are added now. Bug: 974072 Change-Id: I62093ba01ed10aa850788ed35b86a7d642831450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769916Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#690149}
-
Ryan Sturm authored
UKM (the links in the top urls list). Rather than prefetching the link with the highest navigation score overall, NavigationPredictor should only consider the link with the highest navigation score _of the links sent to the UKM_. This essentially restricts the links that can be prefetched to the links with the top 10 highest area ranks. Bug: 995547 Change-Id: I27cc7d5316993132c5835fa83858d9f0fa85a53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761526 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#690148}
-
Dan Beam authored
BUG=997396 Change-Id: Ia27be3ca7ad06a88ee98b093da988a7a944ba5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769800 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
Johannes Henkel authored
Bug: 991325 Change-Id: I8a39a28a8f5151100808d23ddbfbd1578f65e95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764929 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#690146}
-
Raymond Toy authored
WebAudio legacy code often does something like: DCHECK(foo); if (!foo) return; The style guide says the if/return should be removed; DCHECK failures should not be handled. Part 5 of 5: Update a few more files and for the most obvious cases where we can remove the if/return. We are basically done; there may be some left, but they're more complicated. Bug: 957654 Change-Id: I60b472fa3641bb7fd7e927c1f0839adf1ecaaad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769163Reviewed-by:Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#690145}
-
Andrew Xu authored
Add the gradient zone to the scrollable shelf. The zone's location is based on the layout strategy according to the new spec. Bug: 973481 Change-Id: I2949ca70bea6219dd2df3a7cf377050f5cb8b3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764765 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#690144}
-
Jamie Walch authored
This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/1707953. This change requires that users re-authorize Chrome Remote Desktop for accessibility permission. It's not important enough for that downside. Bug: 997387 Change-Id: I21047315ab0f53d5b09f09ee1666d6745c9c1c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769714 Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#690143}
-
Yusuke Sato authored
Now ARCVM's throttling is handled solely by Concierge. This CL depends on chromium:1748118. BUG=b:139095697 TEST=Start ARCVM, verify /sys/fs/cgroup/cpu/vms/arc/tasks is not empty, launch Play Store, verify /sys/fs/cgroup/cpu/vms/arc/cpu.shares is 1024, switch to Chrome, verify cpu.shares is 64. Change-Id: Ic9746bb29363ed71ef5b43ef3659f78c23b07be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758588 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#690142}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3f21e11e240a..25cc723823e3 git log 3f21e11e240a..25cc723823e3 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 rafael.cintron@microsoft.com Fix mFenceEvent HANDLE leak Created with: gclient setdep -r src/third_party/dawn@25cc723823e3 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ic6d6ff056de954fa5dd5a40d3823a62a9486ec97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769654Reviewed-by:
-
Andrew Xu authored
The bounds of the hotseat are not adapted to RTL. This CL fixes the issue. Bug: 997356 Change-Id: Ib73aec5af90958ebff2ec82d326dfbb704efaf1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769550Reviewed-by:
-
Bailey Berro authored
- Corrects the About page to calling the correct method on the AboutPageBrowserProxy. - Adds a test Bug: 997155 Change-Id: If39b45274f6d3836b52039c22086b300b5d3f5b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769625Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#690139}
-
Marijn Kruisselbrink authored
In particular some tests that test saving to files, as well as making sure that the usage indicator is shown when the site has write access. Bug: 993597 Change-Id: I2ee793921b6ea612731e278e8fbd5f4c5cfd093a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761249 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#690138}
-
Avery Musbach authored
The present CL implements a more reliable way to determine in which display a window is being dragged. For mouse dragging, it shall use CursorManager::GetDisplay. For touch dragging, it shall simply use the display where the drag started. Bug: 995413 Change-Id: I3ed8f5ef236d01d8bbbc397cfa7372be530be8af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761523 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#690137}
-
Antonio Gomes authored
... now that it is Oilpan GC-ed. This is a follow up of [1]. [1] https://crrev.com/c/1765493 BUG=704136 R=jbroman@chromium.org Change-Id: I9f2204ac9e1cbbae885acb67ab12874c2a95f96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768788 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#690136}
-
David Black authored
During the login sequence, browser context will settle before Assistant has bound its delegate. This means when the delegate is set, we won't register the fact that there may already be a set of relevant proactive suggestions until the browser context changes. To address this, we notify the delegate of any cached proactive suggestions when it is being bound. Bug: b:139199715 Change-Id: Ia2b91eb59368909bda4a54af28048cebe62cdbac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767485 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#690135}
-
Etienne Pierre-Doray authored
This reverts commit 63fbbb92. Reason for revert: Flaky on ios: https://ci.chromium.org/p/chromium/builders/try/ios-simulator/351893 Original change's description: > [ThreadPool]: Implement Job Delegate's ShouldYield and concurrency increase. > > This CL partially implement job's delegate, as well as concurrency > usage assertion: > - ShouldYield must be called in worker task. > - max concurrency is expected to decrease unless > NotifyConcurrencyIncrease() is called. > > To implement ShouldYield, PooledTaskRunnerDelegate is used > to communicate with ThreadPool and a racy priority is added to > task source. > > Bug: 839091 > Change-Id: I3504f00ec48ab600f79b64e44151bc9dded408a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713146 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690127} TBR=gab@chromium.org,fdoray@chromium.org,etiennep@chromium.org Change-Id: Id5b9838a38baa9ac00acda22284b35270344480c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769085Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#690134}
-
Mei Liang authored
This CL updates the system navigation bar and top status bar in GTS for incognito. Change-Id: I169c8706eeaa7bb7b4994b02f2bcfffb53fb2b9f Bug: 997345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769632Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#690133}
-
Eric Roman authored
Bug: 997359 Change-Id: I6d6dbe7d9ee75b82506530529318044873a28f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769703 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#690132}
-
Steven Bennetts authored
This CL: * Extracts internet_subpage_tests to a separate test suite. * Eliminates click-to-navigate logic from tests to fix flakiness. * Removes the tests from cr_settings_browsertest (they are redundant). * Re-enables the tests in os_settings_browsertest. Bug: 92116 Change-Id: Ibb005e607ada112f33d3b6df3695893c8b537aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768909 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#690131}
-
Jinsuk Kim authored
The reported crash shows that BottomSheetController might not be ready at the beginning when Tab starts getting first overscroll events. This CL adds nul checks in the interface implementation of NavigationSheet against the controller to not perform the action until the controller is ready for use. Bug: 996184 Change-Id: I6624282caaf79c8d2bd24ce8128aa24f16848cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765055Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#690130}
-
Brian Sheedy authored
Suppresses Pixel_WebGL_PremultipliedAlpha_False on Win10/Intel HD 630 configurations. TBR=kbr@chromium.org Bug: 997313 Change-Id: I9451e3f71d4e435cc0e0b6009e4d9ea41fb23657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769551Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#690129}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/83c24aa8a1cd..2f4a751866bc git log 83c24aa8a1cd..2f4a751866bc --date=short --no-merges --format='%ad %ae %s' 2019-08-23 bsheedy@chromium.org Refactor perf tests to fix metric/story swapping 2019-08-23 geofflang@chromium.org Don't reset the texture size to zero in TextureGL::releaseTexImage on Mac. 2019-08-23 geofflang@chromium.org GL: Unset the bound PBO when initiailizing texture data. 2019-08-23 jonahr@google.com Suppress failure in MultisampleCompatibilityTest Created with: gclient setdep -r src/third_party/angle@2f4a751866bc The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org,jonahr@google.com Bug: chromium:923564,chromium:924618 Change-Id: I73ecb3a8d22328dc7ecea0bc0bc52f9cd8fd405c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769648Reviewed-by:
-
Etienne Pierre-doray authored
This CL partially implement job's delegate, as well as concurrency usage assertion: - ShouldYield must be called in worker task. - max concurrency is expected to decrease unless NotifyConcurrencyIncrease() is called. To implement ShouldYield, PooledTaskRunnerDelegate is used to communicate with ThreadPool and a racy priority is added to task source. Bug: 839091 Change-Id: I3504f00ec48ab600f79b64e44151bc9dded408a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713146 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#690127}
-
Tricia Crichton authored
Reduce number of Web Servers created to 3. Initialize all servers in single base class, and set class derivation to that class. Remove GlobalStartUp and GlobalTearDown defs and calls where no longer needed. Bug: chromedriver:2279 Change-Id: I1a6b9cf89a80a04eef4d7579bc69ae14125af762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767062Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#690126}
-
- 23 Aug, 2019 1 commit
-
-
Johannes Henkel authored
In my rework, I think there could be some race conditions in the order of the output. I'll do the dry-run for now and see whether anything manifests. Perhaps it's worth doing some sorting of the logs, e.g. we could make the test insensitive to the order of some of the events in the golden file, by keeping two or three separate logging streams for each section. Bug: 991325 Change-Id: Ib9b8fb0732f5efbf9ad619ff12d5a36bccb02a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762823 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
