- 22 Aug, 2019 40 commits
-
-
Steven Bennetts authored
This CL: * Adds SetProperties to CrosNetworkConfig with a test * Implements AutoConnect and Priority in the internet detail page using CrosNetworkConfig.SetProperties. Bug: 853953 Change-Id: I7e0f4be921e8ba8aebb4413a449c4ff54e2a0bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756852Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#689297}
-
Andrew Lee authored
The goal is to enable and create the performance tool for ui_devtools. The performance panel will record and show metrics such as FPS, CPU time utilization for Aura/Views UI. This CL is for the backend only. The TracingAgent is very similar to the TracingHandler from https://cs.chromium.org/chromium/src/content/browser/devtools/protocol/tracing_handler.cc. Bug: 989052 Change-Id: Ic696e09f700e93bcd0842fdbda575ef1f54af63a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726651 Commit-Queue: MyungJae Lee <myungjaelee@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#689296}
-
Kenichi Ishibashi authored
Otherwise MSan complains we use uninitialized memory. Bug: N/A Tbr: afakhry@chromium.org Change-Id: I5ee9e0e5e9ae8e5c010701b403d22f0058b3abad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763513Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689295}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a1b7d649aa4c..679dc3716bdb git log a1b7d649aa4c..679dc3716bdb --date=short --no-merges --format='%ad %ae %s' 2019-08-21 simonhatch@chromium.org Pinpoint - Wait to issue iron-ajax calls until route is queue-stats 2019-08-21 bsheedy@chromium.org Support minidump symbolization on ChromeOS Created with: gclient setdep -r src/third_party/catapult@679dc3716bdb The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@google.com Bug: chromium:996319,chromium:978952 Change-Id: Ibe7bf12f521a6eaa871c067b1287ea38a531f3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764347Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689294}
-
Becca Hughes authored
Adds two histograms for the lock screen media controls. The first is records whether the controls were shown and if they will never be shown the reason why. The second records the reason if they were shown the reason why they were hidden. BUG=995373 Change-Id: Ic1448098912a79ebf6a2dad9e346c8fe3771eb01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761069 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689293}
-
Sanket Joshi authored
This CL adds to the implementation of the new color picker to provide functionality that allows the user to select colors visually. There are a few different components being added to the VisualColorPicker. They have been described in the ColorPicker.js file, but their description are also being shared herewith for convenience. EyeDropper: Allows color selection from content outside the color picker. (This is currently just a placeholder for a future implementation.) ColorViewer: Provides a view of the selected color. ColorSelectionArea: Base class for ColorWell and HueSlider that encapsulates a ColorPalette and a ColorSelectionRing. ColorPalette: Displays a range of colors. ColorSelectionRing: Provides movement and color selection functionality to pick colors from a given ColorPalette. ColorWell: Allows selection from a range of colors, between black and white, that have the same hue value. HueSlider: Allows selection from a range of colors with distinct hue values. This change includes connecting the existing manual color picker with the newly implemented visual color picker. If the user manually enters a new color value, it will be reflected visually, and similarly if the user visually selects a new color, the manual values will also get updated. Bug: 983311 Change-Id: I3017a9217a539f1b32e4c91ef2e93ca13ce093a8 TBR'ing original reviewers. Not changing the original CL beyond merge conflict resolution. The following change modified the expected behavior of the color picker set type test: https://chromium-review.googlesource.com/c/chromium/src/+/1759226. As a result, this change no longer needs to touch that test or its expected files. That test was the only MSAN failure in the original CL, so attempting to reland this change without further modifications. Pre- submission runs on the MSAN try bots pass. TBR: tkent@chromium.org,masonfreed@chromium.org Change-Id: I3017a9217a539f1b32e4c91ef2e93ca13ce093a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762572Reviewed-by:Kent Tamura <tkent@chromium.org> Commit-Queue: Sanket Joshi <sajos@microsoft.com> Cr-Commit-Position: refs/heads/master@{#689292}
-
Fergus Dall authored
This method is supposed to check if a notification is still running before closing it, but is incorrect due to a new running state that was added. This doesn't cause bugs in practice because CrostiniPackageService makes in independent check, but it does hit a NOTREACHED. Make this method somewhat more resilient by switching to a blacklist rather then a whitelist, on the theory that new finished states are rarer then new running states. Bug: 996217 Change-Id: I7b2efbd4ea9d2f8cce51495cbba37cdf04b650e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763550 Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#689291}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ffe7b037..18e21a5b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic393a72733f6d351e778d72fe0859c3c0b346fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763875Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689290}
-
Michael Thiessen authored
ActivityTabProvider#setTabModelSelector looks at the total tab count when willCloseTab is called, and checks to see if there's one tab remaining, in which case it reports no Activity tab. This is probably because didSelectTab is never passed a null tab (maybe we should do that instead?). The problem is, for SingleTabModel, there's only ever a single tab (or should we report 2 while a tab is closing?), so once we started calling WillCloseTab, we broke ActivityTabProvider. This change moves the select tab call after the willCloseTab call so that we restore the correct state to ActivityTabProvider after closing the tab. Bug: 995966 Change-Id: I9d478b774a9f0c88ed646653d3aa5d12b195a870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764331Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#689289}
-
Austin Eng authored
Bug: dawn:208 Change-Id: I1cea34b19ac99f9bda6e916148075103cc7dcc60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764527Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#689288}
-
Gavin Williams authored
Originally the Printers mock specified to display a plus icon for adding automatic printers. This was updated to instead display a button with "Save". Bug: 993817 Change-Id: Id3ec447661f97eed3bea53a299642a1ca9a1632d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758935 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#689287}
-
Rune Lillesveen authored
Use constexpr constant for maximum number of siblings to invalidate for sibling invalidation sets. Change-Id: I1bbff732293a25d1ad63ae755ecf9608456d5d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763690 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#689286}
-
Paul Dyson authored
Bug: 991433 Change-Id: Id22992f7b2e5b783ebde1d1da82fd98d5453ddea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743607Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#689285}
-
Mugdha Lakhani authored
No unit test has been added since there's no functional change. Change-Id: Idf34146edfcba4549fdead44ccf9558691c9776f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762235 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#689284}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/255b36d8ae06..bfcde3c5b880 git log 255b36d8ae06..bfcde3c5b880 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 ehmaldonado@chromium.org gclient_eval: Make compatible with Python 3. Created with: gclient setdep -r src/third_party/depot_tools@bfcde3c5b880 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:984182 Change-Id: I6653ade22f217239a2dac6ba06e8023711291ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764641Reviewed-by:
-
sczs authored
Bug: 979201 Change-Id: Ibb7d99c0a70497215024954008006e227db9cf29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757164Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#689282}
-
Ilia Samsonov authored
Unit test delegate and content test delegate result processing are very similar. The purpose of this CL is to combine the common result processing and move it to TestLauncher. This would be the last major refactor for this bug. Bug: 936248 Change-Id: If8131bef01ee02bc92626c6c431dc557b06dc05e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761653Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#689281}
-
Hiroshige Hayashizaki authored
- The tests are probably just slow. - fallback-disallowed.sub.tentative.html is no longer flakily failing. Bug: 959372, 936279, 992615 Change-Id: I0fd8c49514156f3bb60bfad3431affc38318384d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762260Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#689280}
-
Sergei Datsenko authored
Bug: 995508 Change-Id: Iec4a4042b66ee29a88930db5768678f8628c6538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762263 Auto-Submit: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#689279}
-
Gyuyoung Kim authored
This CL converts old Mojo types to the new types in MockWakeLock. - Replace mojo::Binding with mojo::Receiver - Replace mojo::BindingSet with mojo::ReceiverSet Bug: 983396 Change-Id: I0b096867f836fedcc189a399cc9eeef41cc8bb8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761961Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Matt Mueller authored
Records a bitfield of the various types of trust settings that were seen. Bug: 991247 Change-Id: I50d4070a309088a99c5317dc13a4a3c59acae47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754276 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#689277}
-
Gyuyoung Kim authored
This CL converts old Mojo types to the new types in DeviceSensorEntry. - Replace mojo::Binding with mojo::Receiver - Apply mojo::Remote into SensorPtr Bug: 983396 Change-Id: I5a6153c4046a6cef5b98d73dd723d7e1fcb955a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757422Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7719c19e556f..b06831a5ae4a Created with: gclient setdep -r src-internal@b06831a5ae4a The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie5d5aecad1b00334a16379b474f2f1ae8ea1171c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764636Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689275}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9e081d164c81..fe65f6d2c3d1 git log 9e081d164c81..fe65f6d2c3d1 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-21 fmalita@chromium.org [svgcanvas] Add flag to suppress newlines and tabs in XML Created with: gclient setdep -r src/third_party/skia@fe65f6d2c3d1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: I00ce5ca23bac57509f60b52821b7a1f0809f24fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764446Reviewed-by:
-
David Bertoni authored
Bug: 397197, 482733 Change-Id: I0238994306c26a6abb85cef2800ad86d0802cbd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764418Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#689273}
-
Zhenyao Mo authored
BUG=867155 TEST=none R=kbr@chromium.org NOTRY=true Change-Id: Ife839b1eac2643b7150e5c6172112f33cd36b283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717526 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Joel Hockey authored
Ignore any query or fragment in path when reading files Bug: 846546 Change-Id: If86dcf4ea1a12378c29553475945abe56714c729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763270 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#689271}
-
Fred Mello authored
Notable Changes: - Moved the MainDex annotation to the ModuleInstaller interface - Removed Stub Class and Template - Removed need for setInstanceForTesting to be static To add more context: - A change was also made to clank/BUILD.gn - Tested all modules locally - Reviewed MainDex changes with Sam M. - All tests passing locally as well as in the CQ Downstream change: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1685369 Bug: 995940 Change-Id: Id9771513ccaa7f33510a3cee49884dd405e33db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762699Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#689270}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/722aa0bc8abe..4de25e8087ab git log 722aa0bc8abe..4de25e8087ab --date=short --no-merges --format='%ad %ae %s' 2019-08-21 saklein@chromium.org Reland "AndroidService: Refactor uprev and unpin endpoints." 2019-08-21 pmoy@chromium.org usergroup_baseline: expect cros_healthd in the disk group. 2019-08-21 bpastene@chromium.org deploy_chrome: Only set the security context if 'restorecon' is available on the DUT. 2019-08-21 mikenichols@chromium.org httplib2: Update httplib2 to resolve SSL issue Created with: gclient setdep -r src/third_party/chromite@4de25e8087ab The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I65e79f9c08083b1b0bc1e49bf8ec46883c08c3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764445Reviewed-by:
-
Luciano Pacheco authored
Remove UI code and file_manager_browsertest_base that supports MyFilesVolume disabled. Change ARC++ tests to run with MyFilesVolume flag enabled since the issue with them has been fixed on CL:1757960. After this CL all Files app tests (UI, unit and integration) run with MyFilesVolume flag enabled, which allows the removal of the rest of the code using this flag. Bug: 880132,880130 Change-Id: If10b5af427db20be587afb6c142a108acc8c4f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755566Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#689268}
-
Ted Meyer authored
to reset, which caused duplicate IDs. Bug: 794255 Change-Id: I801c588529804a418b83dd66e7aa15806fae717c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764261Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#689267}
-
Reid Kleckner authored
He no longer works on Chrome and requested to be removed. TBR=yunlian@chromium.org Change-Id: Id03fcd144bd5c9e542a15e80a520571675c16550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764474Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#689266}
-
Jazz Xu authored
This CL add a SurfaceView in PictureInPictureActivity and a compositor in OverlayWindowAndroid to display video surface. Bug: 964388 Change-Id: I94f96bed25f8ed6904bce4d2d369f8bf4763d72c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757428Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689265}
-
Shawn Gallea authored
Add ExternalBeginFrameClient parameters to pass an ExternalBeginFrameClient object through CastWindowTreeHost to eventually allow custom framerates in cast. Bug: b/139299756 Test: Compile and run cast_shell Change-Id: If44428e639df047c69daa172ba4bc91d21089d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762578Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#689264}
-
Robert Sesek authored
Requests for private data on macOS are increasingly protected by the TCC (Transparency, Consent, and Control) subsystem, which mediates the access with dialog prompts. When an application launches a child process, the system maintains a concept of the "responsible" process, and the parent is responsible for the child (in terms of appearing as the requesting process in the dialog prompt). When launching processes that by design execute third-party code, such as PPAPI plugins and native components of extensions, the browser app should not appear to be the responsible process. The third-party code is the one making the request and should be displayed as such in the system prompt. In order to do this, an undocumented posix_spawnattr_t bit can be set to disclaim responsibility for the new child process. This establishes a new chain of responsibility starting with the launched process. Bug: 945969 Change-Id: Ib931d3345da1b19bce7c8c5197ef675cf776cdfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759149 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689263}
-
Natalie Chouinard authored
Change-Id: Ib09eca453afa833eb124d3e8c04e407c3e7b6466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762498Reviewed-by:
-
Erik Jensen authored
Xvfb-randr was a custom build of Xvfb we created due to missing RandR support in the stock Xvfb. However, stock Xvfb has supported RandR since version 1.18.1, making Xvfb-randr obsolete. This patchset drops the optional dependency on xvfb-randr from the Debian package and updates the session script to always use stock Xvfb. It also switches to using a large frame-buffer size on stock Xvfb. This will make resize-to-fit more useful out of the box for the vast majority of users now using a RandR- supporting version of Xvfb, but the handful of users running old Xvfb versions may find themselves with a much larger desktop than desired. Such users can revert to the old behavior by adding export CHROME_REMOTE_DESKTOP_DEFAULT_DESKTOP_SIZES=1600x1200 to their ~/.profile or similar. Bug: 955203 Change-Id: Ibad903104a719e7e86c1fe375d18388030668e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764675Reviewed-by:Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#689261}
-
Ovidio Henriquez authored
This change updates the descriptor tests in wpt/ to be standalone window tests. This change allows tests to be formatted with clang-format. Bug: 994756 Change-Id: Ifcedeadd35d0775793269572fec478eaa5dbe06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757889Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL is a part of converting Mojo types to new Mojo types. It cleans up ShareServiceRequest and uses PendingReceiver<mojom::blink::ShareService>. Bug: 978694 Change-Id: I79ee3ac57cb60cda4390c01d44c3d54bd43dcb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760845Reviewed-by:
-
Joel Hockey authored
These don't need to be crashes in prod Bug: 996263 Change-Id: I266c7986cba170f638d7d382f1ca5bfb71c3f883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763554 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
-
