- 12 Feb, 2020 40 commits
-
-
Md. Hasanur Rashid authored
This CL update the function FileSystemContext::CreateCrackedFileSystemURL to use url::Origin instead of GURL. Bug: 598424 Change-Id: Ida06511b8659a393602f4e55e9ae1a2ef4bede46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046944 Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#740623}
-
Roman Aleksandrov authored
Bug: 992967 Change-Id: Ic6a6aa46b4c5f33004a8e2ecb8bbe9d571698588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050693Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#740622}
-
Koji Ishii authored
This patch moves |CurrentText*()| functions and bidi functions to |NGInlineCursorPosition|. This patch has no behavior changes. Bug: 982194 Change-Id: Ibd1ea3a8ff805cd4f5bcf87a6b71f3b9559fc461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050219Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#740621}
-
Maxim Kolosovskiy authored
This reverts commit 9126b2a1. Reason for revert: Suspect this CL cause a failure of SignedExchangePrefetchBrowserTest/SignedExchangePrefetchBrowserTest.PrefetchMainResourceSXG_SignatureExpire/0 as this CL affects resources. https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/50946?blamelist=1#blamelist-tab Original change's description: > Clean up unused PageStatus constants in PeopleHandler > > PageStatus.TIMEOUT isn't used, so remove it and the associated HTML > content and string. > > PageStatus.SPINNER is used as the default state for the page, but isn't > sent from C++, so eliminate the C++ constant. > > Bug: none > Change-Id: I93b2dadb9bb6cf762faed3a825f0b2eda2ad4308 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050033 > Commit-Queue: Marc Treib <treib@chromium.org> > Auto-Submit: James Cook <jamescook@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740598} TBR=jamescook@chromium.org,treib@chromium.org Change-Id: If5728aefbdb0e1292210c9add4cef142dc6da499 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050379Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#740620}
-
Morten Stenshorne authored
This was missing when hit-testing a NG fragment (rather than the LayoutObject). I don't know how to write a WPT for this, but this fixes at least the following tests with LayoutNGFragmentTraversal enabled: fast/events/scrollbar-double-click.html fast/events/touch/gesture/gesture-scrollbar-touchscreen-fling.html fast/events/touch/gesture/gesture-scrollbar.html Bug: 1043787 Change-Id: I8669a16fe0d8762f29ba7a7600bcf7fa161e594f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048084 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#740619}
-
Miyoung Shin authored
This is a follow-up CL of https://crrev.com/c/1993076 and this CL is a part of the effort to use the mojo type in Blink without converting between Blink and Non-Blink. This CL removes scroll_into_view_params_type_converters.{cc, h} and uses mojom::blink::ScrollAlignment mojo type instead of ScrollAlignment class in Blink, and we keep ScrollAlignment class as a helper class. Bug: 1039285 Change-Id: I8cc47a8188b15a5e73f2d27783ef382a015f9720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024638 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#740618}
-
Oriol Brufau authored
Dynamic changes to 'list-style-position' in legacy layout are so broken, especially with nested list items. In lots of cases, some markers end up nested inside the wrong list item, or appear in the wrong position, or an empty line is inserted somewhere. This patch doesn't fix all the cases, which would require a big refactorization. It only fixes the case that I need for bug 457718. The case is: - Initially, <div><div style="list-style-position: inside"><div></div></div></div> - After being laid out, the middle <div> is set to 'outside': <div><div><div></div></div></div> - After reflowing, the inner <div> is set to 'inside': <div><div><div style="list-style-position: inside"></div></div></div> This used to place the 2 outside markers in a 1st line and the inside one in a 2nd line, creating an empty line between them. This patch fixes it. BUG=1051114 TEST=web_tests/external/wpt/css/css-lists/change-list-style-position-002.html The patch also fixes some typos in change-list-style-position-001.html Change-Id: Ib42433ec43eca1925d0a47f4caaabbce7951360c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049854Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#740617}
-
Fergal Daly authored
I added a helper GetParentRenderFrameHost because the previous code would crash if current_render_frame_host() was nullptr. This ensures that we still crash if that ever happens. Change-Id: I0f9d3ef2f5cb1a86a247f5fe5db8b6d9fe47d31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041153Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#740616}
-
arthursonzogni authored
This patch mojoify CSPViolationParams and SourceLocation. It also make the IPC ReportContentSecurityPolicyViolation to cross fewer layers. This removes ~220 lines of code (232 insertions, 451 deletions) This correspond to step 1.N of the Unify CSP document: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao ________________________________________________________________________ The struct CSPViolationParams was "triplicated": - content::CSPViolationParams - blink::mojom::CSPViolationParams - WebContentSecurityPolicyViolation All of them are removed and merged a unique - network::mojom::CSPViolation. ________________________________________________________________________ The struct SourceLocation was "duplicated": - blink::mojom::SourceLocation. - content::SourceLocation. All of them are removed and merged into a unique - network::mojom::SourceLocation. ________________________________________________________________________ "ReportContentSecurityPolicyViolation" was crossing these layers: content/browser -> content/renderer -> blink public -> blink internal Now, it's going straight: content/browser -> blink internal ________________________________________________________________________ Bug: 1021462 Change-Id: Icf3f72700102e9831e68861f87efa167b3a86879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035971Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#740615}
-
Maxim Kolosovskiy authored
This reverts commit c08274e9. Reason for revert: this CL made DumpAccessibilityTreeTest.DisplayLockingViewportActivation flaky on https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29?limit=200 Failures: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/60763 https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/60759 Original change's description: > DL: Don't include skip-viewport-activation subtrees in the AX tree > > Now both render-subtree: skip-viewport-activation and skip-activation > subtrees are not in the AX subtree at all, as discussed in > https://github.com/WICG/display-locking/issues/102#issuecomment-564205445 > > Now only render-subtree:invisible subtrees are in the AX tree, and they > are automatically marked as offscreen because the nodes are activated > when they are on screen. > > Bug: 1001930 > Change-Id: I1de511672f60078a02b3ddf3d989f2da1c44ae9d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028883 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740531} TBR=vmpstr@chromium.org,aboxhall@chromium.org,chrishtr@chromium.org,rakina@chromium.org Change-Id: If1d7041ed1fa81a2693480480eaf8163f2606aa8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051106Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#740614}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f510ec743553..ead1d6709ef6 Created with: gclient setdep -r src-internal@ead1d6709ef6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I93a28b05cd714d1033289bd21cf626d8dbda7ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051808Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740613}
-
Shik Chen authored
Make it easier to read. Bug: b:141518806 Test: Manually Change-Id: Icbcfcb38563f7bf92dd96423c4de23899cb14e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051475 Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#740612}
-
Yutaka Hirano authored
I removed the restriction on beacon with a blob with a non-CORS safelisted content type at https://crrev.com/c/2011786 but forgot to set the request mode. Fix that. Bug: 1051368 Change-Id: Ibb843c2232af09390ca1155bd8a807c453c61683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050410Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#740611}
-
Hajime Hoshi authored
In BackForwardCacheMetrics::DidCommitNavigation, |last_committed_main_frame_navigation_id_| can be not -1 not only on history navigation but also on reloading. This CL changes the conditions to record UKM only on history navigation. We plan to add other UKMs for back-forward cache, and they should not be recorded when reloading. For example, we are trying to record the reasons why the page was not in the cache, but recording them when reloading does not make sense. Then, we need more strict conditions. Bug: 1033410 Change-Id: I933e7093805f643e60f9059c753a1f5ec2cacd9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988093Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#740610}
-
Morten Stenshorne authored
Presumably because of fragment item fixes. TBR=kojii@chromium.org Change-Id: I5e1ce3be09d4e9af06da90575a3e370eb41e36d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050589Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#740609}
-
Huanzhong Huang authored
(The change is a bug fix. Please refer to bug for details.) The cookie controls tooltip icon in the Incognito NTP is made to respond to mouse clicks so that a setting can easily be found. To improve accessibility, this change makes the icon respond to Enter key. Bug: 1048121 Change-Id: I5bb2c5367c6661404131677af3eb3b88cd62b1ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040410 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#740608}
-
Yuki Shiino authored
Some of Blink implementations are missing header includes about return types. Adds missing header include directives. Example) // IDL TypeA foo(); // Implementation (.h) TypeB* foo(); // TypeB might inherit from TypeA, but who knows? In this case, there is no way for bindings generator to include an appropriate header "type_b.h" because foo's return type is known as "TypeA". Bindings generator includes "type_a.h", but it doesn't help handle a return value of type TypeB. Correct implementation is either of: TypeA* foo(); or, #include "type_b.h" TypeB* foo(); // TypeB is known to inherit from TypeA Bug: 839389 Change-Id: I5092b46a8579a4406a5567f68f6d4266e29eaa72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051797Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#740607}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/77fb303e58e9..6c218ec60b5f git log 77fb303e58e9..6c218ec60b5f --date=short --first-parent --format='%ad %ae %s' 2020-02-11 afdx@google.com spirv-fuzz: Fuzzer pass that adds access chains (#3182) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@6c218ec60b5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I410a4e373fb7664522ec99306a16748fcf508050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051806Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740606}
-
Henrique Ferreiro authored
The mojom enum for ui::CursorSize in //ui/base/mojom/cursor.mojom isn't used anywhere. Bug: 1040499 Change-Id: I24e4f714c205fa8c933299e86258102ef658da6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980742 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#740605}
-
Saurabh Nijhara authored
MinimumChromeVersionEnforced policy would be supported from M82 as the code for it has been checked in M82 and not M81. For pre M82, the device policy MinimumRequiredChromeVersion is to be used. It is deprecated from M82 onwards. Bug: 1048607 Change-Id: I49219e0ab192541bfec11c7852bd9401d915620d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050310 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#740604}
-
Fabian Sommer authored
The new UI is used both for parent access and by smartcard login. Several options were added to accommodate the second use case. All parent access specific logic moved into ParentAccessController, which is now the single point of access to the UI widget for parent access. Bug: 1001288 Change-Id: Iee728bb5ae77d387ae999741101e356602618d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003169 Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#740603}
-
Tomasz Moniuszko authored
Bug: 1050952 Change-Id: If7767893409c9c3d7f675100df67bc3a6ba81d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050483Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#740602}
-
Nate Fischer authored
During componentization, a rounding workaround was added to android_metrics_service_client_unittest, specifying a number slightly under 0.1 rather than 0.1 itself. It appears this was working around the fact that "0.1f" causes rounding issues that "0.1" does not. There's no benefit to specifying "0.1f" over "0.1" (the return type is double, not float), and since the latter does not have any rounding issues (it was quite reliable when the test lived in //android_webview/ and causes no issues in the new component), this CL removes the workaround and goes back to the desired value. Bug: 1015655 Test: run_components_unittests -f AndroidMetricsServiceClientTest.* Change-Id: I0ddec7da8ed7c98226cec1e49fd312155501ec8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051365 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#740601}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/da4dea33d709..1de518cc2487 git log da4dea33d709..1de518cc2487 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1de518cc2487 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I7b2fc55490cfb076af1b0d0a78b77b5a72ce64ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051803Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740600}
-
Michael Ershov authored
This change fixes a bug that prevented FakeCryptohomeClient from answering on TpmAttestationGetPublicKey request and adds a helper function to configure its result. Bug: 1045895 Change-Id: I4f7a72c2768f78df97c43756932ca7700a62b999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050277Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#740599}
-
James Cook authored
PageStatus.TIMEOUT isn't used, so remove it and the associated HTML content and string. PageStatus.SPINNER is used as the default state for the page, but isn't sent from C++, so eliminate the C++ constant. Bug: none Change-Id: I93b2dadb9bb6cf762faed3a825f0b2eda2ad4308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050033 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#740598}
-
Daniel McArdle authored
Bug: 1050844 Change-Id: I7d485e68ba9466d49aa6dc0c7fa111c39a7ca71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050564 Auto-Submit: Dan McArdle <dmcardle@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#740597}
-
Eric Seckler authored
Trace processor now merges args from begin/end event pairs with the same names, but it doesn't support merging if the value type of the arg changes between the two events. Netlog was previously emitting 'params: ""', i.e. setting the "params" arg to an empty string, if there were no params to be emitted. However, "params" is usually an JSON-object-type argument. Thus, the value types between empty and present arguments are inconsistent and cannot be merged successfully by trace processor. This patch changes netlog to output an empty object ('params: {}') when the argument is empty instead. Bug: 1048815 Change-Id: Id20f66e78bd6f89f81cf6d456925cf7a01aa1d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050689 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#740596}
-
Miyoung Shin authored
This is a follow-up CL of https://crrev.com/c/1993076 and this CL is a part of the effort to use the mojo type in Blink without converting between Blink and Non-Blink. This CL moves out enum types from ScrollIntoViewParams to scroll_enums.mojom as global types. These enums are used by lots of different Blink scroll methods, not just ScrollIntoView. ScrollIntoView just happened to be special because it is called cross process and so required the Blink-internal enum to be cloned into the mojom. Then the internal types were replaced by the mojom. This CL makes these two types be more general than ScrollIntoView. Bug: 1039285 Change-Id: Ie3387e6f0de757336dfd2917ee9a5bf91fac117b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026855 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#740595}
-
Takuto Ikuta authored
runisolatedtest.py seems not used other than by src/infra/scripts/legacy/scripts/slave/runtest.py https://cs.chromium.org/search/?q=runisolatedtest&sq=package:chromium&type=cs runtest.py seems not used other than by src/infra/scripts/runtest_wrapper.py https://cs.chromium.org/search/?q=legacy+scripts+slave+runtest&sq=package:chromium&type=cs slave_utils.py seems not used other than by src/infra/scripts/legacy/scripts/slave/runtest.py https://cs.chromium.org/search/?q=import.*slave_utils+f:%5Esrc&ssfr=1&sq=package:chromium&type=cs xvfb.py seems not used other than by src/infra/scripts/legacy/scripts/slave/runtest.py https://cs.chromium.org/search/?q=import.*xvfb+f:%5Esrc&sq=package:chromium&type=cs runtest_wrapper.py seems not used https://cs.chromium.org/search/?q=runtest_wrapper&ssfr=1&sq=package:chromium&type=cs Bug: 984869 Change-Id: Ifc48db6f7eeeb0127bdfea2b335384c1d4f49312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050052 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#740594}
-
Omar Morsi authored
Currently on network configuration updates through UI, there are some empty fields populated and not omitted before being validated by the ONC validator. One of these fields is the client certificate type. This CL ignores this field if it is empty and adds tests with client certificate type set to empty to make sure that the ONC validator will not complain and that the VPN configurations will get updated as expected. Bug: chromium:1043126 Test: chromeos_unittests -gtest_filter=ManagedNetworkConfigurationHandlerTest.* Change-Id: Ic84e4250e2c01744c6d4632108427d2478f64e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035974Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#740593}
-
Takashi Toyoshima authored
Since CrSettingsV3BrowserTest inheritances depend on OOR-CORS as some other WebUI tests do, we need to flip the OOR-CORS to be enabled explicitly to run tests. These failed at linux-blink-cors fyi bots, for instance at https://ci.chromium.org/p/chromium/builders/ci/linux-blink-cors-rel/1537 Bug: 1042558 Change-Id: I2f01ed89e0793ca04f4c4f325755f42c5b7a1704 Tbr: rbpotter@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050294Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#740592}
-
nancy authored
When an app's state is updated called by OnAppStatesChanged, it should check the pause status and apply the pause app icon effect if the app is paused. BUG=1051066 Change-Id: If84632ddb6a0be72637f545f67cd0b999da169ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050217 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#740591}
-
Daniel Vogelheim authored
Bug: 1033101 Change-Id: I01638e133321abcb0604bfd9f8d72bff61425f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050266Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#740590}
-
Gauthier Ambard authored
This CL cleans up the toolbar search icon as the experiment is launched. Fixed: 1050994 Change-Id: I537f449d817ccc416a1477487292b27bc0de454b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050268Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#740589}
-
Felipe Erias authored
Show a more informative warning message when a link preload uses an "as" attribute that is valid but currently unsupported. Test: link-preload-unsupported-destination.html Bug: 1047945 Change-Id: I6473bc91fb51581358e530ca41a6ffb00b0aa559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041715 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#740588}
-
Hirokazu Honda authored
V4L2VEA has been able to work in Zero-Copy mode when a given VideoFrame's dimension is the same as a resolution configured in Initialize(). This is sufficient to enable Zero-Copy capture in ARC++ case. To enable Zero-Copy capture in chrome case, it is necessary to scale VideoFrame for Simulcast case. This CL enables V4L2VEA to scale VideoFrame by using ImageProcessor interface. See https://tinyurl.com/frame-dimension-in-VEA for how V4L2VEA works. Bug: chromium:1033799, chromium:982201 Test: Hangout Meet on scarlet (with crrev.com/c/1923767 and crrev.com/c/2007802) Test: VEA test on kukui Change-Id: I07d5abfca0f5dd7c4adcfc10191316c5ba3021de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010466 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#740587}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is depreciated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates LayerTitleCache class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I97e6fc0fff2401a8670802b6a20cc8e68b949906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050488Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#740586}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is depreciated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates TabListCoordinator class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I387f85aede020ca88fc626c210fd6a4c9748ef62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049967Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#740585}
-
Hirokazu Honda authored
V4L2VEA creates V4L2IP for a pixel format conversion. The destination buffer is either memory-based VideoFrame or Dmabuf-backed VideoFrame created by V4L2IP internally. This adds GpuMemoryBuffer-based VideoFrame for the destination buffer. The GpuMemoryBuffer is created by V4L2VEA. Bug: 1033799 Test: VEA test on kukui Change-Id: I2284301e6d1ae9334d1b38637b62b0d04d808f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022562 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#740584}
-