- 01 Aug, 2019 40 commits
-
-
Yasmin authored
Bug: 988461 Change-Id: I2cc57ddd1ee3b93036a10a7243045a3f7320d8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725635 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683126}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a4a17b2e..db2e0c7d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id87bf61148d4c00b5abf0ec7333b387b678c0840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729891Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683125}
-
Anders Hartvoll Ruud authored
Because of an unintended behavior change in [1], it's no longer possible to have a nullptr animating element, since StyleResolverState:: GetAnimatingElement will fall back to GetElement() if pseudo_element is nullptr. Previously (pre-[1]), if the PseudoElement* retrieved by StyleResolver::PseudoStyleForElement was nullptr, the animating element would just be nullptr, and not fall back to anything. This CL restores that behavior by passing PseudoId to a dedicated StyleResolverState constructor. That way we know whether we're doing a style resolution for a pseudo element or a regular element, and we can return the correct thing from GetAnimatingElement. Also removed the StyleResolverState constructor which accepted a ElementResolveContext, since it only had one call site which anyway did the same thing as the other constructor. [1] https://crrev.com/c/1724680 Bug: 989151,989402,989437 Change-Id: I0aecf0a7a3a857dbd0664d969abeea7ec5852260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729250Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#683124}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/31590104ec86..5ada98d0bb33 git log 31590104ec86..5ada98d0bb33 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 zoddicus@users.noreply.github.com Update WebGPU validation rules of OpAtomic*s (#2777) 2019-07-31 alanbaker@google.com Treat access chain indexes as signed in SROA (#2776) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@5ada98d0bb33 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I93ad082715bc2577563623306b5992366d3882ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730610Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683123}
-
François Beaufort authored
This CL adds a boolean multisampled to the bind group layout binding. When set to true, it currently raises a validation error as Dawn doesn't support it yet. Bug: 877147 Change-Id: Iad27630add2ce508ed015ddef7ff8930b32547e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731109 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#683122}
-
Vasilii Sukhanov authored
The leak check is supposed to happen on successful sign-in. Bug: 986298 Change-Id: Id4745f70f7723aabeab5eb91ece92bad6f4b48bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727049 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#683121}
-
Christopher Gunadi authored
Hide the above context menu option when CrostiniRootAccessAllowed policy is set to false and kCrostiniAdvancedAccessControls feature flag is enabled. Currently does not support dynamic policy updates, so changes apply after restarting the UI. This will be implemented in a follow up CL. Bug: 983997, 983998 Test: compile Change-Id: Icd1fc61975cd7616efe5e580ce222551a27e75b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712667 Commit-Queue: Christopher Gunadi <chrisgunadi@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#683120}
-
vitaliii authored
TBR=yhirano@chromium.org No-try: true No-Presubmit: true Bug: 989863, 989848, 989825, 989824, 989823, 989811, 989808, 989807, 989806, 989805, 989757, 989879, 989878, 989756, 988074, 948167 Change-Id: Ia5a35e1e81ba5a36758e7ba3397954f40674835a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730154Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#683119}
-
Roman Aleksandrov authored
Bug: 989590 Change-Id: Ie9ad7872a8be684155a44077519580f004b76be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729266Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#683118}
-
Dominic Farolino authored
To get cross-origin prefetches to work with SplitCache enabled, we'll want to create a URLLoaderFactory via CreateNetworkServiceDefaultFactory with a non-default NetworkIsolationKey. To do this, we'll need to communicate a NetworkIsolationKey to CreateNetworkServiceDefaultFactoryInternal. This CL changes both of these methods to accept NetworkIsolationKey parameters. This CL introduces no observable difference, but will make it easier to create the URLLoaderFactories we'd like for cross-origin main-resource prefetch requests. See https://docs.google.com/document/d/1bKGDIePAuF6YXmmrwM33LeLvtuCsla3vTspsxsNp-f8/edit#heading=h.9a0qg5l6gbnj. R=kinuko@chromium.org, yhirano@chromium.org Bug: 939317 Change-Id: Ib2100dc2ad7efd9f33ac22e0bd6edb14cf816c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730572Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#683117}
-
Juan Antonio Navarro Perez authored
This CL implements the basic API layer of the new results_processor, exposing functions to create an argument parser, process options, and finally process results. Currently the results processor only supports the "none" output format, still delegating all output formatting to Telemetry. Depends on catapult CL: https://chromium-review.googlesource.com/c/catapult/+/1718424 Bug: 928275 Change-Id: Ib65cf62eeb59a4ab515f963bfcc7cc3bbd1f13f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692986 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#683116}
-
Kinuko Yasuda authored
Change-Id: I37a084f25288cf473ebb3a37408534cb9a2d3977 Bug: 934009, 985682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728869 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683115}
-
Hirokazu Honda authored
V4L2VideoEncodeAccelerator requests its client to allocate video frame buffer with a frame size. If the client allocates video frame buffer using GBM API, the frame size of the created video frame can be different from the requested one. In that case, we need to reconfigure v4l2 drivers with the new frame size by S_FMT. The reconfiguration must happen only once during encoding and when the first frame is fed. Bug: 979115 Test: CtsMediaTestCases on kevin Change-Id: Ie245001fad631f5d3ff66c0d7280037bea21a8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722835 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#683114}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1dbbc7b3e232..e995d7fb23c5 git log 1dbbc7b3e232..e995d7fb23c5 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 xinghua.cao@intel.com Use memoryBarrier to sync image load and store Created with: gclient setdep -r src/third_party/angle@e995d7fb23c5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: I6f7ab7b8d6e8bc7f743200d576fce70774558bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730613Reviewed-by:
-
Colin Blundell authored
Groups these related methods together and eliminates one method that has no production callers. Bug: 970295 Change-Id: I07c9f79862efcf94b28ad7c2571b0a33a77be316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729264Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#683112}
-
Lowell Manners authored
Since this is the first RenderFrameHostProxy/RenderFrameProxy method to be mojofied, this CL also adds the boilerplate for establishing a mojo connection between RenderFrameHostProxy/RenderFrameProxy. Change-Id: I9153eb01b7a5bef374823a067eaf793a48b6a3fe Bug: 786836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643473 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#683111}
-
Carlos Caballero authored
MessageLoopForUI will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=droger@chromium.org Change-Id: Ieb7595218c6176d258dfbd7d83272a4b9d3704e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717291 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#683110}
-
Chromium WPT Sync authored
Using wpt-import in Chromium adb42687. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I279fbf7fc8c98c38efeef6e9b798ef4023666cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730971Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683109}
-
Takashi Sakamoto authored
This reverts commit 1b08fa8e. Reason for revert: suspect causing unit_tests failure on linux-chromeos-dbg. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/13673 deterministic failures: ArcAppLauncherForDefaultAppTest.AppIconUpdated/0 ArcAppLauncherForDefaultAppTest.AppIconUpdated/1 ... E.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906357365557383728/+/steps/unit_tests/0/logs/Deterministic_failure:_ArcAppLauncherForDefaultAppTest.AppIconUpdated__x2f_0__status_CRASH_/0 [ RUN ] ArcAppLauncherForDefaultAppTest.AppIconUpdated/0 Received signal 11 <unknown> 000000000000 #9 0x7f40f3cfd40b base::ThreadCheckerImpl::CalledOnValidThread() #10 0x5611fbac0319 arc::internal::ConnectionNotifier::RemoveObserver() #11 0x5611f8ea55e9 arc::ConnectionHolder<>::RemoveObserver() #12 0x5611ff697745 apps::ArcApps::~ArcApps() #13 0x5611ff69786c apps::ArcApps::~ArcApps() ... #22 0x7f40e9d8e740 KeyedServiceFactory::Disassociate() #23 0x7f40e9d8e834 KeyedServiceFactory::ContextDestroyed() #24 0x7f40de6a3503 BrowserContextKeyedServiceFactory::BrowserContextDestroyed() #25 0x7f40de6a3677 BrowserContextKeyedServiceFactory::ContextDestroyed() #26 0x7f40e9d8b145 DependencyManager::DestroyFactoriesInOrder() #27 0x7f40e9d8b1f5 DependencyManager::PerformInterlockedTwoPhaseShutdown() #28 0x5611fe3b3fc3 TestingProfile::~TestingProfile() #29 0x5611fe3b43cc TestingProfile::~TestingProfile() ... Original change's description: > Flip the AppServiceAsh feature default to enabled > > BUG=826982 > BUG=989789 > > Change-Id: I49bd3793bf9fcfc89726fd2f7df690421996e0fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728411 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683064} TBR=dominickn@chromium.org,nigeltao@chromium.org Change-Id: Iec931954750b6a58d2274c6479507e99efd2467a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 826982, 989789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731091Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#683108}
-
Kent Tamura authored
elements/toast/.eslintrc.js and kv-storage/.eslintrc.js were identical, and elements/virtual-scroller/.eslintrc.js had some differences. The following describes differences between them and decision for them. * virtual-scroller had '2' for no-magic-numbers exceptions. We keep the '2' exception. * virtual-scroller enabled max-len. We enable max-len. max-len is helpful because clang-format doesn't support *.mjs extension for now. * virtual-scroller had no no-lonely-if and no no-else-return. We drop them. Following these rules is sometimes harmful for code consistency. Change-Id: Icf3118e4d504248a55a284a763f7392c59793769 Bug: 976576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727447 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#683107}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It moves RegisterTokenResponse to private since it's only used by OAuth2AccessTokenManager::Fetcher which is a nested class in OAuth2AccessTokenManager. Bug: 967598 Change-Id: Ic51db4d938f955e920a33d00a6f74e07f88a8763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731029Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#683106}
-
Kenichi Ishibashi authored
The motivation is to avoid creating GarbageCollected objects in WebEmbeddedWorkerImpl so that we can start service worker on the IO thread, not on the main thread. The IO thread runs without Oilpan and thus we can't create GarbageCollected objects on the IO thread. ServiceWorkerGlobalScopeProxy was a GarbageCollected object because it contained ParentExecutionContextTaskRunners which is also a GarbageCollected object. The only usage of the task runners was to get the default task runner so we can replace it with Thread::Current()->GetTaskRunner(), which returns a non GarbageCollected task runner. After this CL, ServiceWorkerThread owns ServiceWorkerGlobalScopeProxy as a unique_ptr, not a Persistent. The ownership of these classes are as follows and there seems no cycle ownership, so that's fine IIUC. WebEmbeddedWorkerImpl --(unique_ptr)--> ServiceWorkerThread ServiceWorkerThread --(was Persistent, now unique_ptr)--> ServiceWorkerGlobalScopeProxy ServiceWorkerThread --(CrossThreadPersistent)--> ServiceWorkerGlobalScope ServiceWorkerGlobalScopeProxy --(CrossThreadPersistent)--> ServiceWorkerGlobalScope ServiceWorkerGlobalScope --(raw reference)--> ServiceWorkerGlobalScopeProxy ServiceWorkerGlobalScope --(raw ptr)--> ServiceWorkerThread Bug: 988335 Change-Id: I5c9104e73300ac14b56f7ad9b337d71c53321d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725530Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#683105}
-
Takashi Sakamoto authored
[Sheriff] Mark http/tests/devtools/indexeddb/live-update-indexeddb-list.js as flaky on Linux Tests (dbg). Bug: 989860 Change-Id: I6aef927384f588221e578d399fc2379f8fa82f6c Tbr: zmin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730553Reviewed-by:
-
Glen Robertson authored
ie. return Result::kUrlLoaded (successful load) when loaded URL matches expected URL up to and including the path. Ignore changes after the "?". Bug: 989376 Change-Id: Ib4f719b879b9074ead66b135b7701863b15b80a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730449 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#683103}
-
Maksim Sisov authored
Fix native GpuMemoryBuffers for Ozone/Wayland by implementing non implemented CreateNativePixmapAsync call. Bug: 989433 Change-Id: Ic178ac2d4f0716e4c4a00a0abb6686e64b980b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728655Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#683102}
-
Yutaka Hirano authored
Bug: None Change-Id: Ic34ec4c6cb84c75a1fe7602fa43bd14fcef1595f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730890Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#683101}
-
Kunihiko Sakamoto authored
This is a preparation for supporting the new bundle format [1]. After this change, ParseMetadata() and ParseResponse() return error as Bundle{Metadata,Response}ParseError struct. At the moment these structs are just wrappers of string, but additional fields will be added in follow up CLs. [1] https://github.com/WICG/webpackage/pull/450 Bug: 969596 Change-Id: I5bdbc84149f818f07470999fc42c8680e46f2385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724150 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683100}
-
Maksim Moskvitin authored
Original CL missed MAYBE prefix and this could lead to test flakiness on tsan tryjobs. Bug: 922900 Change-Id: I1faf72c55b7942ad53b4f0e0bd9efdee979f427b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729633 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#683099}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4828620d0a30..11243c3b6292 git log 4828620d0a30..11243c3b6292 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src f6d0e4f5..9aeb39b9 (441 commits) Created with: gclient setdep -r src/third_party/skia@11243c3b6292 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:None Change-Id: Icba13b9bf2aa706c775df7ee67a00d65747757b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730593Reviewed-by:
-
Benoît Lizé authored
Set the expiration date of these histograms to end of 2019, as they are still useful (and are recorded only once per renderer, so shouldn't be too large). Bug: 974926, 974925, 974924, 974923, 974922 Change-Id: I4a2fc1f2d0c86c8aa3ccf66477250b81515a69d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720871Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#683097}
-
Takashi Sakamoto authored
[Sheriff] Mark http/tests/devtools/indexeddb/live-update-indexeddb-list.js as flaky on Mac10.13 (dbg). Bug: 989860 Change-Id: I7e078ae525b0c2fa6b20c504fcca2d1838557b2d Tbr: zmin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730949Reviewed-by:
-
Yi Su authored
When a11y font size is used, long press on the "New Tab" button in tab grid will show a built-in a11y modal panel which contains an image and a title. Currently the title is missing, and this CL fixes it. BTW, the image is also changed to the larger image for incognito page instead of the small one. Bug: 989016 Change-Id: I706570f1002b82eaf33908006d09cc3498cb6e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726090Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#683095}
-
Kouhei Ueno authored
Bug: 981740 Change-Id: I5993bf635a541032818ade0a6aff183e7835a213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716132Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#683094}
-
Alexey Baskakov authored
Rename PinAppToShelf to AddAppToQuickLaunchBar and CanPinAppToShelf to CanAddAppToQuickLaunchBar. The name should match ExternalInstallOptions::add_to_quick_launch_bar flag and flag's description: // If true, a shortcut is added to the "quick launch bar" of the OS: the Shelf // for Chrome OS, the Dock for macOS, and the Quick Launch Bar or Taskbar on // Windows. Currently this only works on Chrome OS. Delegate CanAddAppToQuickLaunchBar/AddAppToQuickLaunchBar to WebAppUiManager since this is UI-related business. It requires plumbing of WebAppUiManager to InstallFinalizer (InstallFinalizer is already plumbed to all WebAppInstallTasks) In next CLs: We will get rid of chrome/browser/extensions/bookmark_app_extension_util.cc completely. That's the last bookmark_app* prefixed file in extensions/. TBR=dominickn@chromium.org Bug: 901226 Change-Id: I152cdacb6c5c9cbd0ac6e42888a849e39e064af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729402Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#683093}
-
Yue Zhang authored
Bug: 989319 Change-Id: I4ed0bb779e5bca4be0ebb6cc34db8ed74a1ed65a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730190Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#683092}
-
Yuki Shiino authored
- Implements __eq__ / __ne__ for IdlType - Implements VariadicType as a subclass of _ArrayLikeType - Implements UnionType.flattened_member_types (UnionType.__eq__ could be implemented based on flattened_member_types, but it was not used. See a comment of UnionType.__eq__.) Bug: 839389 Change-Id: I215da4624bf26681974e483138cf819d8eb24849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728010Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#683091}
-
David Staessens authored
This CL fixes an incorrect log message in the video_decode_accelerator_tests and video_decode_accelerator_perf_tests. When the VDA requests a set of buffers during testing the number of buffers and size requested is logged, but the size was incorrectly displayed as HxH instead of WxH. TEST=ran new VD tests on eve BUG=None Change-Id: Ia58782e05dfef8b7a51e9ea0a06d7125c5e25790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730950 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#683090}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fd643a4782c9..32eaa7b5baa3 git log fd643a4782c9..32eaa7b5baa3 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d488661c..4b9d9012 (682945:683063) 2019-08-01 mellem@webrtc.org Reland "Only include payload in bytes sent/received." Created with: gclient setdep -r src/third_party/webrtc@32eaa7b5baa3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ifec9ffc7be0522ec9a68f4b9db3677b0a56a67a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730570Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/22b6cbc9..a4a17b2e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2570b7cc3b14f684dde8317e03326082a39d1d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729403Reviewed-by:
-
Kent Tamura authored
formatJapaneseImperialEra() threw an exception for year=275760 month=September. The function is called with these arguments on the startup of a picker because of MonthPopupButton._shouldUseShortMonth(). Bug: 989826 Change-Id: I308ea5087b0f6a8ff857ee1844c83e5970130933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730769Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#683087}
-
