GitLab

BUG=448351

Review URL: https://codereview.chromium.org/870513002

Cr-Commit-Position: refs/heads/master@{#317577}

The new icons are slightly larger than the previous version, per the
feedback we received from various reviews.

BUG=460042

Review URL: https://codereview.chromium.org/946673002

Cr-Commit-Position: refs/heads/master@{#317576}

As recent crashes proved, OnRequestDone was a bowl of spaghetti.

This is an attempt at straightening it up, by separating particular computational steps from one another.

BUG=457646,451018

Review URL: https://codereview.chromium.org/921873002

Cr-Commit-Position: refs/heads/master@{#317575}

DidNavigateToPendingEntry is no longer used and can be removed.

BUG=

Review URL: https://codereview.chromium.org/936373002

Cr-Commit-Position: refs/heads/master@{#317574}

It seems to be caused by bc44c0a9, remove the
single failing target on Win gn bot.

BUG=460828
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/948763003

Cr-Commit-Position: refs/heads/master@{#317573}

The latest editor's draft introduces MIDIPortState state attribute in
MIDIPort. To support the attribute, update the blink API to use enum
for representing MIDIPortState instead of bool isActive flag.

Spec: http://webaudio.github.io/web-midi-api/#idl-def-MIDIPort

This is the second step of three to update the MIDIAccessor blink API.

BUG=279097
TEST=content_unittests

Review URL: https://codereview.chromium.org/945263002

Cr-Commit-Position: refs/heads/master@{#317572}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e2f8f9b..1f42f18

TBR=kbr@chromium.org,hiroshige@chromium.org

Review URL: https://codereview.chromium.org/949823003

Cr-Commit-Position: refs/heads/master@{#317571}

BUG=425785

Review URL: https://codereview.chromium.org/938303003

Cr-Commit-Position: refs/heads/master@{#317570}

The period "Delete button should be shown" is not exactly same as "Delete command can be executed."
For example: While a confirm dialog overlays Files.app, the dialog consumes all input event so the delete command cannot be executed, but still the delete button should be shown under the overlaying dialog.

BUG=459402,457113
TEST=manually checked the repro steps on each issue.

Review URL: https://codereview.chromium.org/951443002

Cr-Commit-Position: refs/heads/master@{#317569}

Call Blink API to notify JavaScript of device connection
status.

BUG=279097

Review URL: https://codereview.chromium.org/664853003

Cr-Commit-Position: refs/heads/master@{#317568}

Revert of Add AwAssets into android_webview/native/public (patchset #4 id:70009 of https://codereview.chromium.org/937863003/)

Reason for revert:
Suspected to cause 'checkdeps' failures on Linux bot:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/20990/steps/checkdeps/logs/stdio

ERROR in /mnt/data/b/build/slave/Linux_Tests/build/src/android_webview/browser/aw_dev_tools_manager_delegate.cc
  Illegal include: "android_webview/native/aw_contents.h"
    Because of "-android_webview" from android_webview/browser's include_rules.

Original issue's description:
> Add AwAssets into android_webview/native/public
>
> This is done so that android_webview/browser doesn't need to depend on
> android_webview/native
>
> BUG=459779
>
> Committed: https://crrev.com/a08360b39730751c5f85797bdff5b748d907c11a
> Cr-Commit-Position: refs/heads/master@{#317475}

TBR=boliu@chromium.org,sgurun@chromium.org,hush@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459779

Review URL: https://codereview.chromium.org/947113002

Cr-Commit-Position: refs/heads/master@{#317567}

Review URL: https://codereview.chromium.org/928253002

Cr-Commit-Position: refs/heads/master@{#317566}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4be3cc6..e2f8f9b

TBR=kbr@chromium.org,hiroshige@chromium.org

Review URL: https://codereview.chromium.org/950793002

Cr-Commit-Position: refs/heads/master@{#317565}

Supervised Users: Replace kForceSafeSearch pref with kForceGoogleSearch and kForceYouTubeSafetyMode.

BUG=458546

Review URL: https://codereview.chromium.org/924033002

Cr-Commit-Position: refs/heads/master@{#317564}

PasswordManager::IsSavingEnabledForCurrentPage should check, whether the last navigation was not going back in the tab history. It is unlikely that the user is submitting a password this way.

This CL ensures this by extending the PasswordManagerClient with a NavigatedThroughBackButton method.

BUG=455630

Review URL: https://codereview.chromium.org/902893003

Cr-Commit-Position: refs/heads/master@{#317563}

Ensure web contents exit fullscreen state by sending a resize message, which includes the fullscreen state. This is required for the situation of the browser moving the view into a fullscreen state "browser fullscreen" and then the contents entering "tab fullscreen". Exiting the contents "tab fullscreen" then won't have the side effect of the view resizing, hence the explicit call here is required.

Fixes a regression caused in the refactoring
 Fullscreen: make fullscreen requests come from RenderFrame
 https://codereview.chromium.org/789533002
 https://crrev.com/7a78d6fd7dc3241a91a614a09f9c59a0e4454135
where the previous implementation's call to WasResized in
RenderViewHostImpl::OnToggleFullscreen was not brought forward to
WebContentsImpl::ExitFullscreenMode().

BUG=458013
TEST=Open http://scheib.github.io/HTMLMisc/PointerLockAndFullscreen.html, enter Browser Fullscreen with F11 key, press Toggle Fullscreen button, press ESC key, expect content to exit fullscreen.

Review URL: https://codereview.chromium.org/928673002

Cr-Commit-Position: refs/heads/master@{#317562}

Workaround a crash in CGContextDrawImage when decoding favicon larger
than 88x88 pixels.

BUG=435068

Review URL: https://codereview.chromium.org/923623003

Cr-Commit-Position: refs/heads/master@{#317561}

It turns out automated echo cancellation only gets enabled for two-way
calls. Since we want to test the complex AEC in WebRTC (and the other
audio processing for that matter), we must make the test call two-way
rather than one-way as it used to be for simplicity. With these
changes, we should be able to catch bugs like 453907 on the desktop
platforms.

Note: should land together with https://codereview.chromium.org/922663002/.

BUG=453907

Review URL: https://codereview.chromium.org/934793002

Cr-Commit-Position: refs/heads/master@{#317560}

To debug tests, they need to be executed with the following switches:
--remote-debugging-port=9222
--enable-file-manager-step-by-step-tests
--enable-pixel-output-in-tests
--ui-test-action-timeout=10000000

Then run http://localhost:9222 in a separate browser window, then select
"chrome manager browser tests" and follow instructions.

TEST=Tested manually.
BUG=460813

Review URL: https://codereview.chromium.org/942393002

Cr-Commit-Position: refs/heads/master@{#317559}

BUG=452493

Review URL: https://codereview.chromium.org/942793002

Cr-Commit-Position: refs/heads/master@{#317558}

The reason for this is that the fake input stream would not work on Mac
where the audio non-worker code runs on the UI thread. Therefore, the
fake input stream would get starved for instance in the WebRTC audio
quality tests and not play any audio (those tests block the UI thread
while recording).

This patch introduces a worker precisely like the fake audio consumer
used by the fake output stream.

BUG=453907,446859

Review URL: https://codereview.chromium.org/922663002

Cr-Commit-Position: refs/heads/master@{#317557}

For plugins listed in
chrome/browser/resources/plugin_metadata/plugins_*.json, the resource
identifier for that plugin becomes the key used in those JSON files.
Previously, the PDF plugin filename was used as the resource identifier
to whitelist the PDF plugin within the PDF extension. This caused the
whitelisting to be ineffective for official builds and also other builds
after r316957 added an entry for the Chromium PDF Viewer plugin. This CL
fixes this by using the keys from the plugin metadata files as the
resource identifiers for whitelisting the PDF plugin.

BUG=459998

Review URL: https://codereview.chromium.org/946293002

Cr-Commit-Position: refs/heads/master@{#317556}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1baadde..4be3cc6

TBR=kbr@chromium.org,hiroshige@chromium.org

Review URL: https://codereview.chromium.org/950773002

Cr-Commit-Position: refs/heads/master@{#317555}

Tested with the following command lines:

$ gn gen out_gn/Debug
$ ninja -C out_gn/Debug device_unittests
$ out_gn/Debug/device_unittests

BUG=None
TEST=see above
R=rockot@chromium.org,jam@chromium.org,thakis@chromium.org,groby@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/919223002

Cr-Commit-Position: refs/heads/master@{#317554}

Just a single new baked-in config.

BUG=

Review URL: https://codereview.chromium.org/938253002

Cr-Commit-Position: refs/heads/master@{#317553}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/52af3a6..1baadde

TBR=

Review URL: https://codereview.chromium.org/942423002

Cr-Commit-Position: refs/heads/master@{#317552}

The lower this number, the more efficient GC.

Add benchmark that reloads top pages and tracks this measurement.

BUG=chromium:450824

Review URL: https://codereview.chromium.org/930333002

Cr-Commit-Position: refs/heads/master@{#317551}

Cr-Commit-Position: refs/heads/master@{#317550}

Change some permission descriptions from MIDI to MIDI devices.

BUG=453680
NOTRY=true

Review URL: https://codereview.chromium.org/942313002

Cr-Commit-Position: refs/heads/master@{#317549}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3e53681..52af3a6

TBR=

Review URL: https://codereview.chromium.org/947843003

Cr-Commit-Position: refs/heads/master@{#317548}

Clean up error logging (more consistent formatting).
Log stack traces.
Ensure most substantial Promise chains used in importer code have catch clause hooked up to logger.

BUG=460614
BUG=449034
TEST=browser_test: FileManagerJsTest.*

Review URL: https://codereview.chromium.org/945933003

Cr-Commit-Position: refs/heads/master@{#317547}

This CL adds a null check around an access to the app list web contents.

BUG=460388

Review URL: https://codereview.chromium.org/949823002

Cr-Commit-Position: refs/heads/master@{#317546}

Running status should be used only for channel voice messages, and
it is recommented that the status is cleared on receiving system
common messages including system exclusive messages.

BUG=456780
TEST=media_unittests

Review URL: https://codereview.chromium.org/949683002

Cr-Commit-Position: refs/heads/master@{#317545}

First-party-only cookies allow servers to mitigate the risk of cross-site
request forgery and related information leakage attacks by asserting that a
particular cookie should only be sent in a "first-party" context.

This patch adds support for the 'First-Party-Only' attribute to the
CookieMonster and CookieStore, but does not yet wire up requests such that
the flag has any effect. https://codereview.chromium.org/940373002 will do so
by correctly setting the first-party URL on the CookieOptions object used to
load cookies for a request.

Spec: https://tools.ietf.org/html/draft-west-first-party-cookies

Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/vT98riFhhT0/3Q-lADqsh0UJ

BUG=459154
TBR=dpolukhin@chromium.org

Review URL: https://codereview.chromium.org/876973003

Cr-Commit-Position: refs/heads/master@{#317544}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3853d6b..3e53681

TBR=

Review URL: https://codereview.chromium.org/944383002

Cr-Commit-Position: refs/heads/master@{#317543}

This CL stops the app list search box disappearing on profile switch.
This was happening because the search box bounds were dependent on the
contents view's bounds but was being calculated before the contents view
was laid out. Moving the search box's layout to be later fixes the issue.

BUG=459074

Review URL: https://codereview.chromium.org/945343002

Cr-Commit-Position: refs/heads/master@{#317542}

This patch adds support for trace call validation in traceAfterDispatchImpl()
which can be called from traceAfterDispatch().

The changes in this patch should be mostly straightforward except for the
introduction of Config::GetTraceMethodType(). The motivation to this change is
based on the fact that we now have four different types of trace functions.
The function is extended from the former Config::IsTraceMethod() so it can
return the type of the trace method as defined in TraceMethodType. The new
Config::IsTraceMethod() is implemented in terms of it.

This patch comes with tests that check traceAfterDispatchImpl() use cases (both
valid and invalid), and some obvious refactorings to follow Chromium coding
style.

BUG=none
R=kouhei@chromium.org
CC=zerny@chromium.org, oilpan-reviews@chromium.org

Review URL: https://codereview.chromium.org/940263004

Cr-Commit-Position: refs/heads/master@{#317541}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/abac9fb..3853d6b

TBR=

Review URL: https://codereview.chromium.org/946233003

Cr-Commit-Position: refs/heads/master@{#317540}

This enables to update location line even when IO is busy for other operation,
e.g. directory rescan.

BUG=460405
TEST=manually tested. Navigate to a directory and see how the UI changes.

Review URL: https://codereview.chromium.org/946543002

Cr-Commit-Position: refs/heads/master@{#317539}

- Fix the task queue so that cancelling a task doesn't leave it hanging out in the queue, which then will jam everything up.
- Fix the error code so that errors are handled consistently (and are non-terminal, as they should be)
- Rename UpdateType.SUCCESS to UpdateType.COMPLETE.  This better reflects the fact that errors can occur during an import task but the task still runs to completion.

BUG=460597

Review URL: https://codereview.chromium.org/947583002

Cr-Commit-Position: refs/heads/master@{#317538}