GitLab

This CL changes how navigations result in focusing the tab contents:

1. Browser-initiated navigations:
   - Before this CL: Focus done in FocusTabAfterNavigationHelper
     which covers both OpenURL and BeginNavigation code paths.
   - After this CL: Focus done in Browser::UpdateUIForNavigationInTab
     (similarly to pre-r737502) which covers only the OpenURL code path.

2. NTP-initiated navigations:
   - No change: Focus done in FocusTabAfterNavigationHelper.

This CL makes sure that the text in the Omnibox is not temporarily
selected during a navigation, by ensuring that the Omnibox is not
focused when OmniboxViewViews::Update runs (see also
https://crbug.com/1048742#c4 and #c5 and #c7).  Regression tests
are added for this problem.

This CL also makes sure that DevTools-initiated navigations
(browser-initiated navigations which go through the BeginNavigation
path) do not result in focus changes (see also
https://crbug.com/1048591).

This CL might also (speculating here) address the performance bugs
tracked in bugs 1048333, 1048556, 1048565, 1048988, 1048988.

Fixed: 1048742, 1048591
Bug: 1048333, 1048556, 1048565, 1048988, 1048988
Change-Id: Ia00cd9143991c260615663fae06f096e9d7cf0f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040234
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739179}

https://android.googlesource.com/platform/external/perfetto.git/+log/999642323280..e6a829e67854

git log 999642323280..e6a829e67854 --date=short --first-parent --format='%ad %ae %s'
2020-02-06 fmayer@google.com Allow ObfuscateMember to fully qualify field name.

Created with:
  gclient setdep -r src/third_party/perfetto@e6a829e67854

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:149006783
Tbr: perfetto-bugs@google.com
Change-Id: I85549f8a42a95a6c6f0218d8745f21a6b354d67d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042246Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739178}

See the linked bugs, which make clear that the functions
touched in [1] and [2] are very hot code paths, at least for
the blink microbenchmarks. This CL marks those functions
ALWAYS_INLINE and optimizes access to IsElementNode() which
is the most-likely used of the DOMNodeType accessors.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1962631
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1965945

Bug: 1036543, 1036088, 1036536, 1036089
Change-Id: If07e3dfc051ed5abd152ac758d27113b63080fee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042374
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739177}

Since https://crrev.com/c/1912502 only enabled DPI awareness for
browser process, this meant utility process showing system UI
was not running at correct DPI.

This adds an explicit call to EnableHighDPISupport in the mojo
IPC to display a file dialog.

BUG=1049324
TEST=Enable high DPI. Load Chrome and push Ctrl-O. Dialog should be shown in High DPI and not blurry.

Change-Id: Ica591e65ba25f3c45485f6676c26436f0d3eb57c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042744Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739176}

This reverts commit 50fdef03.

Reason for revert: The root cause of the slowness is elsewhere, and the
tests will be removed from the configurations they're timing out on.

Original change's description:
> Mark two virtual/android tests as Slow for causing flaky timeouts
> 
> virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html
> and virtual/android/fullscreen/video-scrolled-iframe.html are causing
> flaky timeouts.
> 
> TBR=nator@chromiun.org
> 
> Bug: 1049138
> No-Try: true
> Change-Id: If30b1c39d7b73354e782458c924708bc820934c7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039143
> Reviewed-by: Austin Eng <enga@chromium.org>
> Commit-Queue: Austin Eng <enga@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738592}

TBR=nator@chromium.org,enga@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1049138, 1049138
Change-Id: I4d3135d309c1bf4ca1fc7531fa970d80468d7c76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042321Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739175}

This change updates the Migration guide to contain more up to date
information about the PPAPI to Web API gaps.

Change-Id: Ic5f952e805a656cebf9540fa9c8301fc7160527e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031939Reviewed-by: Ben Smith <binji@chromium.org>
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739174}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f5e5312d2154..4db6affff29a


Created with:
  gclient setdep -r src-internal@4db6affff29a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1015113,chromium:1029449,chromium:1031084,chromium:1049659
Tbr: jbudorick@google.com
Change-Id: I1332a27e6bbb87f598bbb73a1b687475c03834a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042659Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739173}

This CL changes
ChromeMetricsHelper::StartRecordingCaptivePortalMetrics() to take in the
CaptivePortalService instance rather than obtaining it internally from
the Profile and similarly changes ChromeMetricsHelper to take in the
HistoryService instance in its constructor. The motivation is to enable
this class to be componentized in a followup in order to make it
available to WebLayer.

Bug: 1030692
Change-Id: I6447dcc21e317d7ed4ba2b01b821575028066d4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040412
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739172}

This CL removes the `errors` from Page.getInstallabilityErrors since it's
not used by DevTools anymore.

Bug: 946860
Change-Id: I87a8421aedcec4864b364cdcedc4d21c04821bec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026381Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#739171}

When compiling with coverage flags enabled, this class caused a missing
key function error at link-time.
[https://lld.llvm.org/missingkeyfunction]

The fix is to ensure that all non-pure, non-inline, virtual functions
are properly defined somewhere. Given the way this class is used, the
most appropriate response appears to be marking its member functions
as pure virtual.

Bug: 1049383
Change-Id: I2f4c063bb151ac409f41f12c6da6e7f71c0d2a4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040680
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739170}

This change breaks non-curtained multimon since you can no longer
switch between monitors. 

This reverts commit d8b19b69.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Enable cursor compositing for uncurtained Mac.
> 
> I previously thought that the cursor was always part of the captured
> screen on Mac, but it turns out that's only true if curtain mode is
> active. This CL makes creating of a composing capturer conditional
> on the curtain mode setting, which should give the correct beheviour
> for both remote support and uncurtained remote access.
> 
> Bug: 1048774
> Change-Id: I28cc01b0b615794e06cd31308c10a40af550e0e1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036546
> Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
> Reviewed-by: Joe Downing <joedow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738347}

TBR=jamiewalch@chromium.org,joedow@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1048774
Change-Id: I3063609e5a8f7f16e791222fe1782f28a3e37ac6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042537Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739169}

* Rename menu item "Options" to "Settings"
* Remove menu item "Find" since we are not supporting it for now.

Bug: 1016190
Change-Id: I632cbe04c52e83822ffa40a423d96d004f57153e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040503Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Auto-Submit: Jason Lin <lxj@google.com>
Commit-Queue: Jason Lin <lxj@google.com>
Cr-Commit-Position: refs/heads/master@{#739168}

Some undocumented functionality regressed in r713537 with the feature
removal.

Skip presubmit. Change has +1/OWNERS approval, but a linter complains
about changes outside the scope of this CL.

No-Presubmit: true
Bug: 1035051
Change-Id: Ie106df252fcf1784fdeffbcf1d789df5c8b7ea40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040754
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739167}

https://chromium.googlesource.com/angle/angle.git/+log/e9dc0201af3a..463c318ab759

git log e9dc0201af3a..463c318ab759 --date=short --first-parent --format='%ad %ae %s'
2020-02-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src b932cf53f769..c731adec183b (4 commits)

Created with:
  gclient setdep -r src/third_party/angle@463c318ab759

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I4599c43246bc494d01b5d9de16cd38b526da66d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042336Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739166}

This is an initial cl for the contextual nudge of the back gesture.

See screenshot: https://screenshot.googleplex.com/CAagJhL5f7z

Following up work:
1. Add animation for the nudge based on the spec.
2. Add the condition to show the nudge.

Bug: 1009005b
Change-Id: I28471c9f5281b0d1af8e16f3598d802a803d91f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040059Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739165}

Bug: 1026426
Change-Id: I17c488f5e50eaa35522aa39fc395726432ec9a7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040686Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739164}

This patch adds a number of fields to NetworkConfiguration objects
defined in net.mojom in order to pass to ARC information it
currently lacks or infers from the environment:

 - Explictly passing the host IPv4 configuration and DNS addresses:
this effectively replaces the ip_configs field which is both
incovenient to parse on ARC side and not necessary for IPv6 outside of
DNS. Instead it is more straightforward and easier on both sides to
directly pass the IPv4 configuration and IPv4 + IPv6 DNS settings. This
matches better with the interface of android.net.LinkProperties.

- List of DNS search domains: similarly to DNS addresses, ARC should use
the settings set for the host during layer3 provisioning or set
statically. This is important for managed networks and necessary for
resolving "short" hostnames inside ARC. Like DNS addresses, search
domains are aggregated over both v4 and v6 and passed as an explicit
array.

- Static IPv4 configuration for ARC: this replaces the legacy mechanism
of arc-networkd setting the IPv4 address assigned to an Android virtual
network by directly entering the ARC container namespace and setting the
address on Android virtual interface. This is necessary for using ARC's
ArcNetworkService in ARCVM where ns-enter cannot be used.

- MTU value: ARC currently does not set the MTU correctly for network
 with non-standard MTUs (like some cellular networks) and always use a
 default MTU value.

Follow-up patches will start populating these fields.

BUG=b:123431422
BUG=b:143258259
BUG=b:145960788
BUG=crbug:795603
TEST=Compiled

Change-Id: I08dfd5daa9ba2946a847e555bb94a01da3866eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959203Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Hugo Benichi <hugobenichi@google.com>
Cr-Commit-Position: refs/heads/master@{#739163}

This brings in the new library files as a CIPD package and update
DEPS to refer to this updated library.

Fixed: 1049042
Change-Id: I874f1a148bd7c47a4756d25f5edb590a39709b0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042215Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739162}

Bug: 1046682
Change-Id: I9a3addb2f5415b371cd65537223df664215ae8ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039311Reviewed-by: Jazz Xu <jazzhsu@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739161}

This test is no longer flaky.

TBR=kbr@chromium.org

Bug: chromium:928989
Change-Id: I61a0d0a97356a2f4a6d9ef8745fa4d9846063df6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042685Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739160}

Suspect this is also related to the devtools frontend roll in
https://chromium-review.googlesource.com/c/chromium/src/+/2038189

Sample failure at
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/4217

TBR=tvanderlippe@chromium.org

Bug: 1049641
Change-Id: Ic6d75cb6e3644c5fbf2fcbb0e955120ae442e3c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042796Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739159}

R=benmason@chromium.org

Change-Id: I96e100d79408e10e15597596111a010e26a77490
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042751Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739158}

https://skia.googlesource.com/skia.git/+log/6c48aad1a347..c90a8c72af60

git log 6c48aad1a347..c90a8c72af60 --date=short --first-parent --format='%ad %ae %s'
2020-02-06 mtklein@google.com calculate program hash in bulk
2020-02-06 mtklein@google.com refactor out a middle representation
2020-02-06 brianosman@google.com Remove SkClampMax
2020-02-06 jlavrova@google.com Cache should work with INF values
2020-02-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-02-06 mtklein@google.com rm SkPreConfig.h and SkPostConfig.h
2020-02-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@c90a8c72af60

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: scroggo@google.com
Change-Id: I2d3f10f5e97a4ba986171cb97b719b82312fae02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042656Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739157}

This will make it more straightforward to inject dependencies in order
to componentize this class for sharing with WebLayer.

Bug: 1030692
Change-Id: I9628eee6447f842b67654eb1aff925db59c60771
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040411
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739156}

Bug: 964139
Change-Id: I717f9c07920d7843acb93c88566099d8ee92d90a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040392Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739155}

Bug: 989820
Change-Id: Ia64921ca30d66e8f0bcbfff33ffdb0cbdf71e303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026595
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739154}

The tree-priority is set for smoothness when there is active
interaction happening (e.g. scroll, pinch etc.). Keep requesting
begin-frames in such cases.

BUG=1049673

Change-Id: I76348ce1e211baf2554823a23fb2252b66a67f53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005060
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739153}

Adds a utility to call __llvm_profile_reset_counters() function of clang
coverage. This function is used to write incremental coverage data to
the same raw coverage data file.

Bug: 1043273
Change-Id: I548689881b144f879110606a0f932565c5222ea0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029266
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739152}

https://chromium.googlesource.com/catapult.git/+log/3403d9601aa6..7476ab6e9eff

git log 3403d9601aa6..7476ab6e9eff --date=short --first-parent --format='%ad %ae %s'
2020-02-06 lpz@chromium.org [typ] Include trailing_comments when returning Expectation objects.

Created with:
  gclient setdep -r src/third_party/catapult@7476ab6e9eff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC sadrul@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: sadrul@google.com
Change-Id: If114c25602f3c777a6d07c7b16055bbfe11fbe51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042335Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#739151}

The previous failures were just because the test is slow. The runs have
been green since it was marked slow.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=http%2Ftests%2Fdevtools%2Flayers%2Flayer-compositing-reasons.js
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Flayers%2Flayer-compositing-reasons.js

TBR=wangxianzhu@chromium.org

Bug: 859169
Change-Id: I3e798d06da032b0570d0b1f0cd0003153891b869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042529
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739150}

- use ES6 classes
- manually expose window-scoped classes as needed (e.g. in tests)
- manually define prototypes when needed (expected at eval time by js2gtest)
- fix some undeclared vars
- manually extend test classes/add super() calls

Change-Id: I7770b19745ff9e4155067042478ea69fb3fbc3d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039750
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739149}

Several The expectation files were unreferenced, probably a glitch
from a WPT import when "subsetTest()" / and "variant" invocation of
tests wasn't quite operational in Blink.

One test (euckr-decode-ksc_5601.html) was timing out due to not
being sharded, running 17049 cases vs. the 1000 cases per shard
of similar tests. Shard it like the others

Bug: 864994

Change-Id: Ic93517e10337870dc70fe8aea71b6622d4e65540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040532
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739148}

When prompting the user for APP scanning, the "Discard" button is still
present in the download shelf. It hidden behind the "Scan" button,
but still accessible via Tab/Enter keys, leading to accidental discards
when operating via keyboard.

This CL makes no visible changes to the UX.

Bug: 1049748
Change-Id: Ie4cb9fbc42341cca76bc5479e4ca9f207f7e9226
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042388Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739147}

Bug: 1046910
Change-Id: I71360304e19988a111a9364aa57eb401f70ed783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040621Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739146}

The rebaseline expectation from
https://chromium-review.googlesource.com/c/chromium/src/+/2031863 is missing
the border around the month picker.

Bug: 1049650
Change-Id: I8360d3c10547815196f080b2c4d5b6700977ac60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042521Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#739145}

ErrorOr<> makes it easier to return an arbitrary value or an error.
For example, one might:

ErrorOr<std::unique_ptr<int>> Foo() {
  // return a ptr, or a MediaError explaining why not.
}

Change-Id: I819b29c1dcc9ba2512ab709da2ae6b267a24d8b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040374
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739144}

The name AssistantWebView is now freed up in Ash and can be used by
the AssistantWebView2 interface.

Bug: b:146520500
Change-Id: I9ddb0e5e7fe9697a7cc3a350e8607c973d4f22bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040733
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739143}

To limit fetching for URL-keyed hints when no hint is returned, an
empty entry is added to the URL-keyed hint cache so the page navigation
fetch will not continuously re-fetch for the same URL.

This is important for limiting server load before any feature using
URL-keyed hints is enabled.

Bug: 1048717
Change-Id: Ic8250d1f463bde6c5bd71b18910a7f584c80fa6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042271
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Auto-Submit: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739142}

The issue is that we don't reset the contents_changed_ flag to false at
the end of DrawingBuffer::FinishPrepareTransferableResourceSoftware.
Here's the problem:
1) We draw something into webgl canvas (DrawingBuffer) and export it as
   a software resource (FinishPrepareTransferableResourceSoftware).
2) Later we do a readPixels on the canvas (which is
   preserveDrawingBuffer: false).  The readPixels will clear the canvas
   to match spec behavior
   (WebGLRenderingContextBase::ClearIfComposited).
3) The next time blink document lifecycle happens (rAF, resize, etc.)
   DrawingBuffer thinks it needs to export the back buffer to compositor
   again because contents_changed_ is still true.
4) DrawingBuffer exports the cleared back buffer to compositor.

This CL includes a pixel test that simulates the above case by switching
tabs (and calling readPixels) to force a document lifecycle update. The
included test fails before this fix and passes afterwards.

Bug: 1047829
Change-Id: I1496919b974d84e975db28eafd9b8e6ffc71d91e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040732Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739141}

Avoids a UAF by disconnecting the mojo::Receiver from the pre-finalizer.

Bug: 1043603
Change-Id: I1592a517bf74dd4fcb8e947e1122442864e0dacc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042276Reviewed-by: Darin Fisher <darin@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739140}