- 04 Oct, 2018 40 commits
-
-
Roman Sorokin authored
Removed default autocomplete to device domain. Removed message for device name input with regex. BUG=chromium:865474 TEST=manual Change-Id: Ib334f89ae0d4a27153cd69e5100253cce18f40a1 Reviewed-on: https://chromium-review.googlesource.com/c/1255730 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#596692}
-
Kyle Horimoto authored
Before this CL, when such a request was received, the renderer was shut down. This prevents a crash in chrome://oobe resulting from a rejected request. Bug: 890963 Change-Id: Icd54728b877126af218ce762f888f1c252f56ef7 Reviewed-on: https://chromium-review.googlesource.com/c/1258981Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#596691}
-
Lindsay Pasricha authored
Bug: 883489 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie56f18bf3d1c8c6186a6cd7812e873338cda45c8 Reviewed-on: https://chromium-review.googlesource.com/c/1252864 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596690}
-
John Chen authored
Re-implement processing of capabilities based on W3C spec. spec: https://www.w3.org/TR/webdriver/#processing-capabilities Bug: chromedriver:1997 Change-Id: I3304c54ba886b2319b178dad38a09713e349da25 Reviewed-on: https://chromium-review.googlesource.com/c/1260506 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#596689}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e3685e77a08d..dcf4ffb80c01 Created with: gclient setdep -r src-internal@dcf4ffb80c01 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0b27feaf4b6582c95ccde12b2074084b010aa530 Reviewed-on: https://chromium-review.googlesource.com/c/1261956Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596688}
-
Andrew Grieve authored
And also an assert within ApplicationStatus that was failing for webview in the case a non-primary process creates a webview. The isMainProcess() method is tells you whether or not the process has a ":" in it, but is too easy to confuse with "isBrowserProcess", and so better to not have it so readily available. Note that the assert within ApplicationStatus was made redundant by the build-time negative_main_dex_globs check that was added afterwards, so we don't actually lose anything by removing it. TBR=agrieve # trivial refactor Bug: 891868 Change-Id: I883a245134a78a84e704b73a314ce0929672f5d2 Reviewed-on: https://chromium-review.googlesource.com/c/1260495Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#596687}
-
Alex Clarke authored
As a temporary measure, set crash keys before calling CallbackBase::IsCancelled to see if there is any pattern among the crashes. Bug: 798554 Change-Id: I55fcba6b378abdbbd69531faeda91c7c19874eb6 Reviewed-on: https://chromium-review.googlesource.com/c/1257920 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596686}
-
kylechar authored
This reverts commit 837b3c20. Reason for revert: Crash on startup. https://crbug.com/892182 Original change's description: > bluetooth: Add a new BluetoothAdapterClient instance and use it for GetState > > There are two parts to this change: > > 1. Create a new BluetoothAdapterClient instance. For this we add > "alternate_bluetooth_adapter_client()" to the bundle of DBus clients. > This new instance uses a separate DBus Connection through > BluezDBusThreadManager. This ensures actions on one client won't > affect the other client. > > 2. Implement BluetoothSystem::GetState using the new client. > > Bug: 870192, 882771 > Change-Id: I9faa92e8234b14dd374a04b4c9e9acbcfd7e6201 > Reviewed-on: https://chromium-review.googlesource.com/c/1215427 > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596520} TBR=derat@chromium.org,stevenjb@chromium.org,reillyg@chromium.org,sammc@chromium.org,ortuno@chromium.org,sonnysasaka@chromium.org Change-Id: Icf5a244f163152ccc41d84f7ea43220afebae791 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870192, 882771, 892182 Reviewed-on: https://chromium-review.googlesource.com/c/1261878Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#596685}
-
kylechar authored
This reverts commit 6d46cb28. Reason for revert: Crash on startup. https://crbug.com/892182 Original change's description: > bluetooth: Finish implementing GetState() > > Use Adapter's power state for GetState(). > > Bug: 870192 > Change-Id: I4c431fad09e540e8f20b21feb638ae6ba701f637 > Reviewed-on: https://chromium-review.googlesource.com/c/1250581 > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596532} TBR=reillyg@chromium.org,ortuno@chromium.org Change-Id: Ib6da2c1e13a03a86d8daf88eba89ea53d8bd9e45 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870192, 892182 Reviewed-on: https://chromium-review.googlesource.com/c/1261918Reviewed-by:
-
Vaclav Brozek authored
The FormData -> PasswordForm parser has been just a function so far. However, an increasing amount of metadata is being handled (predictions, soon also statistics about the parsing such as whether readonly fields were observed). Therefore this CL encapsulates such optional data into a parser class. Notable changes: * Predictions are set separately and can be reused for subsequent parsing runs. This also avoids passing nullptr for missing predictions. * Some names enclosed in the class have been shortened to avoid redundancy when presented with the class prefix. Bug: 883633 Change-Id: Ib36d37e134d1abff644de2f167e891bd88735f37 Reviewed-on: https://chromium-review.googlesource.com/c/1236315Reviewed-by:Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596683}
-
Martin Šrámek authored
Due to flakiness. TBR=ekaramad@chromium.org Bug: 892085 Change-Id: I96d8a3b14583c340abba18a725941b8ae0c1cf06 Reviewed-on: https://chromium-review.googlesource.com/c/1261700 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#596682}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/test/base/testing_profile.cc. This CL was uploaded by git cl split. R=<anyone> Bug: 809610 Change-Id: I5289c063a35968a1ea2bf9872e1b146e965d4dcf Reviewed-on: https://chromium-review.googlesource.com/c/1259006 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#596681}
-
Stephane Zermatten authored
Before this patch, checking and setting more than one fields with AutofillAction fails. They cannot, at this time, be run in parallel. With this patch, AutofillAction gets and sets field values one after the other, which works. This patch also makes the unit tests for AutofillAction more explicit to make debugging easier. This is not strictly necessary for this change, as the old tests pass with the new code. Bug: 806868 Change-Id: If7574307850c61436b2e6afcaa249ed3d0421225 Reviewed-on: https://chromium-review.googlesource.com/c/1261375 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#596680}
-
Xiyuan Xia authored
Occasionally crash: TouchActionBrowserTest.PanXYAtXAreaMainThreadJanky TouchActionBrowserTest.TouchActionNone TBR=jamescook@chromium.org Bug: 892097, 892098 Change-Id: Icc26e7c5e9dfe632447e185a9567d17f0bd404a9 Reviewed-on: https://chromium-review.googlesource.com/c/1261401Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#596679}
-
Mohamed Amir Yosef authored
Permanent folders such as the "bookmark bar" are placed directly under the bookmarks root node. Before this CL: Permanent folders were assumed to have a specifics parent id. This is wrong, since the bookmark root node is synced and assigned a non-fixed id on the server. This caused dropping the mobile bookmarks folder when received as a remote creation. After this CL: Permanent nodes are detected via the existence of a unique server tag. Bug: 516866 Change-Id: I237613ace3cc037febfb3f57257b24cc36522628 Reviewed-on: https://chromium-review.googlesource.com/c/1257833Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#596678}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/profiles. This CL was uploaded by git cl split. R=skuhne@chromium.org Bug: 809610 Change-Id: Ic45b0fc9fbeb570f14e193b37723234c6ab74ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1257932Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596677}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/views/autofill. This CL was uploaded by git cl split. R=vasilii@chromium.org Bug: 809610 Change-Id: Idd31113f973dcb3906be2c0db166fb8536ee5c99 Reviewed-on: https://chromium-review.googlesource.com/c/1258176Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596676}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/webui/signin. This CL was uploaded by git cl split. R=rogerta@chromium.org Bug: 809610 Change-Id: Ib267c7d43afb0b4682fa8232431169012389e732 Reviewed-on: https://chromium-review.googlesource.com/c/1259004Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596675}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/safe_browsing/settings_reset_prompt. This CL was uploaded by git cl split. R=robertshield@chromium.org Bug: 809610 Change-Id: Ia4da1523758d8091bad781d01026453d4085560f Reviewed-on: https://chromium-review.googlesource.com/c/1259008Reviewed-by:
Robert Shield <robertshield@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596674}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/passwords. This CL was uploaded by git cl split. R=vasilii@chromium.org Bug: 809610 Change-Id: Ibd9fe9cf5088c2c4885b3278073e0979f1b4c6f9 Reviewed-on: https://chromium-review.googlesource.com/c/1257838Reviewed-by:
-
Johannes Kron authored
Bug: chromium:884165 Change-Id: Id84a41af832adcc204e9c6372bc1c85033a0c0b0 Reviewed-on: https://chromium-review.googlesource.com/c/1261476Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#596672}
-
Xi Han authored
This CL originally comes from ran@'s CL(https://crrev.com/c/1102826). It follows up CLs: https://crrev.com/c/1148959 and https://crrev.com/c/1213308. In this CL, we create the local_state in ChromeFetureListCreator, and its ownership is passed to the BrowerProcessImpl when the full browser starts. Classes required to create FeatureList and setup FieldTrial, e.g. VariationsService, MetricsServicesManager etc., are also created in the ChromeFeatureListCreator and the ownerships are passed to the BrowserProcessImpl when it is instantiated. For ChromeOS, we move the initialization of the DBus to ChromeFeatureListCreator as well before creating the BrowserPolicyConnectorChromeOS. The BrowserPolicyConnector is required to create the PolicyService when creating local_state. internal::PreEarlyInitDBus is moved to a helper file with two static functions. Bug: 848615, 729596 Change-Id: I93a31879e566b14eb01b4e63a4ad8786cc7e16da Reviewed-on: https://chromium-review.googlesource.com/c/1173163 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#596671}
-
Etienne Bergeron authored
R=oysteine@chromium.org, sebmarchand@chromium.org Bug: 867931 Change-Id: If49d4168b55b32c46e080018469ff392b8136000 Reviewed-on: https://chromium-review.googlesource.com/c/1259614Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596670}
-
Anthony Vallee-Dubois authored
This CL adds 2 histograms that record languages added and removed from Accept Languages by the user from the Explicit Language Ask prompt during Android Chrome 2nd run. Bug: 891307 Change-Id: I1b6e8feb7e3d56f77c0381ec5870eb9694085b74 Reviewed-on: https://chromium-review.googlesource.com/c/1255575Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#596669}
-
Marc Treib authored
This is a reland of 3efff7c9 Changes from the previous patch: - Fixed the waiting condition in tests to be reliable. TBR=sebsg for autofill_wallet_data_type_controller.cc which is unchanged since the first attempt. Original change's description: > Consistently clear server credit cards with USS > > AutofillWalletDataTypeController is used (pre-USS) for both AUTOFILL_WALLET_DATA > and AUTOFILL_WALLET_METADATA. When Sync is stopped, it calls > PersonalDataManager::ClearAllServerData. Since there are two instances of the > controller, that happens twice (which is unnecessary but doesn't hurt). However, > when AUTOFILL_WALLET_DATA is on USS, then the remaining ClearAllServerData call > (for the metadata controller) still happens, which brings Sync into a bad state > since the data is now gone, but the progress marker is still there (see bug 885211). > > This CL changes AutofillWalletDataTypeController to only call ClearAllServerData > for AUTOFILL_WALLET_DATA (i.e. it won't be called anymore if Wallet is on USS). > Instead, AUTOFILL_WALLET_DATA gets special-cased in ModelAssociationManager to > clear even in the STOP_SYNC case. This achieves the same "clear data on stopping > sync, but *not* on browser shutdown", but without requiring a special side channel > to the SyncService. > > One consequence is that with AUTOFILL_WALLET_DATA on USS, the clearing now happens > asynchronously (because it goes through the DB), which requires some test changes. > > Bug: 889941 > Change-Id: I54c36050c81fa862acfc0052f355ff1645a8b292 > Reviewed-on: https://chromium-review.googlesource.com/1251041 > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Florian Uunk <feuunk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595787} Bug: 889941 Change-Id: I1c577212e06e39cc8fca9a39658d2bd96b6b3bed Reviewed-on: https://chromium-review.googlesource.com/c/1261083 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#596668}
-
Achuith Bhandarkar authored
Bug: 891484 Change-Id: I0bb055d35a1fd9706d26773909837b0526fe4562 Reviewed-on: https://chromium-review.googlesource.com/c/1261655Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/sync. This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 809610 Change-Id: If5762ddf6e72164a48469b451923d757ab2e69c0 Reviewed-on: https://chromium-review.googlesource.com/c/1257933Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596666}
-
Daniel Bratell authored
A local mojom namespace meant that it became ambigious inside the content namespace whether "mojom" meant "::mojom" or "::content::mojom". This problem surfaced in jumbo build experiments where the compiler knew about the ::content::mojom namespace. In most builds the compiler only knows about ::mojom and then it compiles. Bug: 746953 Change-Id: Ifec37f45009693d7e41eb393ca9bbea136f884b2 Reviewed-on: https://chromium-review.googlesource.com/c/1256926Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#596665}
-
Thomas Tangl authored
Bug: 862983 Change-Id: I5313040afd56d6605e3be72a37f07312000b37ef Reviewed-on: https://chromium-review.googlesource.com/c/1259044Reviewed-by:
-
Fredrik Söderquist authored
This allows reusing the data from the KURL - i.e does not require performing canonicalization again. Bug: 889183 Change-Id: I10e5f9b3725a0fb25594bc6dbe61791bb3826fe9 Reviewed-on: https://chromium-review.googlesource.com/c/1257927Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#596663}
-
Andy Paicu authored
As part of checking if the linked bug is still an issue, I have taken the opportunity to fix the current mostly non-sensical tests. Bug: 240058 Change-Id: I716d43d38be6dd161aa0437dbda03f2c77eb6d88 Reviewed-on: https://chromium-review.googlesource.com/c/1225886 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#596662}
-
Valeriya Sinevich authored
It is needed because server can send RETRY status which means the error is transient and we have to retry. Change-Id: Idbaefa1f1a4d79e10d5b5b361409f29fdbbc4525 Reviewed-on: https://chromium-review.googlesource.com/c/1255223 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
-
Daniel Vogelheim authored
Bug: 890316 Change-Id: I529c99ee497b154ca42d3e3ab5bcf1ab52ab00f3 Reviewed-on: https://chromium-review.googlesource.com/c/1256947 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4a72ba99a704..bc2959072dc5 git log 4a72ba99a704..bc2959072dc5 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 barrerap@webrtc.org NetEq: Fix an UBSan error 2018-10-04 mbonadei@webrtc.org Remove noop system_wrappers_default build target. 2018-10-04 minyue@webrtc.org Adding field trial to force target level percentile in NetEQ. 2018-10-04 mbonadei@webrtc.org Revert "Export symbols needed by the Chromium component build (part 1)." 2018-10-04 oprypin@webrtc.org Allow the autoroller service account to commit 2018-10-04 philipel@webrtc.org Don't ovewrite complex member VCMPacket::generic_descriptor when fuzzing. 2018-10-04 saza@webrtc.org Delete deprecated AEC interfaces 2018-10-04 kwiberg@webrtc.org Remove `using` declaration for rtc::Buffer 2018-10-04 mbonadei@webrtc.org Export symbols needed by the Chromium component build (part 1). Created with: gclient setdep -r src/third_party/webrtc@bc2959072dc5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:886904,chromium:836566,chromium:891597 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie1e5ee706877b2abfac26b0f61da440764ba750e Reviewed-on: https://chromium-review.googlesource.com/c/1261420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596659}
-
Matthew Cary authored
* Unnecessary debug art libraries are removed from dependancies. * Command-line flag dash vs underscore usage diverged from what the python script uses. Bug: 875276 Change-Id: Icb308a4ce62bdac4d6341952f6f088ad7aa201da Reviewed-on: https://chromium-review.googlesource.com/c/1261555Reviewed-by:agrieve <agrieve@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#596658}
-
Morten Stenshorne authored
Added a comment to LayoutInline, pointing out that LayoutNG seems to be doing the right thing already, while legacy is wrong. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0f906dab6efa7b3d4c72a297926d542f77251052 Reviewed-on: https://chromium-review.googlesource.com/c/1261575Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#596657}
-
Xi Han authored
Reland "[FeatureList] Change GetApplicationLocale() in VariationsServiceClient to be a local function. [2/3]" TThis is a reland of 08ae48ad(r586711, reverted in r588564). The reland caches the locale value in VariationsFieldTrialCreator after calling GetApplicationLocale() in the constructor. This is because GetApplicationLocale() needs IO work and shouldn't be called on the UI thread. Besides, the locale value won't change after the startup, so it is fine to cache its value. Original change's description: Before this function uses a pref in Chrome so we need to override it in Chrome to access that pref value. As a followup for this cl https://crrev.com/c/1135198, now we can access the pref directly in componment/ and we no longer need to do that. This CL comes from https://crrev.com/c/1140356. See previous discussion there. Bug: 729596 Change-Id: I1519f80d393416b58cdb3fcd599fb15e0dd14280 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/c/1213308 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
Alexander's no longer at Intel, so remove his email from those files. While here, add myself to external/wpt/generic-sensor's OWNERS file. Change-Id: Ic14db99aa9caf7f7ec208da5a26d975edc06d824 Reviewed-on: https://chromium-review.googlesource.com/c/1256787Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#596655}
-
Marc Treib authored
https://crrev.com/c/1030177 introduced lazy creation of the ConfigurationRefresher in SyncTest::InitializeInvalidations. However, it unconditionally re-created it for every Sync client. Re-creating it drops any previous observer registrations, which means the refresher would effectively only work for the *last* client. This CL fixes this by creating it only if it doesn't exist yet. Interestingly, this didn't seem to cause any problems in practice. Bug: 832019 Change-Id: Ic9df260fdc5b8955d591d96678b4e1500035067f Reviewed-on: https://chromium-review.googlesource.com/c/1261439Reviewed-by:
-
Stephane Zermatten authored
Before this patch, unknown action would be skipped and not reported to the server. This made it difficult to see what actions were unsupported. Also, this made the client mistakenly think that response with only unsupported action signalled the end of a script. This patch introduces an unknown action type, which always fail. This way, neither the client nor the developer will be confused by this case. This patch also transition UpdateProcessedAction from taking a boolean to taking a ProcessActionStatusProto, which lets us be more specific in what failed. I also left TODOs for the cases where we should be more specific and distinguish at least "element not found" from other errors. Bug: 806868 Change-Id: I6efe1f2ac733f2048a5028c5ebb51fab2953868c Reviewed-on: https://chromium-review.googlesource.com/c/1257901 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
-
