Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 15 Apr, 2009 19 commits
    • eric.carlson@apple.com's avatar
      2009-04-15 Eric Carlson <eric.carlson@apple.com> · 7a925594
      eric.carlson@apple.com authored 
              Fix incorrect expected result.

        * http/tests/security/local-video-source-from-remote-expected.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@42550 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7a925594
    • justin.garcia@apple.com's avatar
      WebCore: · a2300356
      justin.garcia@apple.com authored 
      2009-04-15  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=25204
        Create a fast path for ReplaceSelectionCommand that merges text nodes
        
        During simple pastes, where we're just pasting a text node into a run of text, we would split the current
        text and insert the new node in between.  This is slow and we hit this bug:

        https://bugs.webkit.org/show_bug.cgi?id=6148

        in the layout and rendering code where adjacent text nodes don't shape correctly in Arabic.
        
        This change creates a fast path for ReplaceSelectionCommand that inserts text directly into the
        text node that holds the selection (very similar to the fast path we wrote for InsertTextCommand).

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        (WebCore::ReplaceSelectionCommand::performTrivialReplace):
        * editing/ReplaceSelectionCommand.h:
        * editing/TextIterator.cpp:

LayoutTests:

2009-04-15  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Dan Bernstein.
        
        https://bugs.webkit.org/show_bug.cgi?id=25204
        Create a fast path for ReplaceSelectionCommand that merges text nodes
        
        Simplified DOM/Render trees:
        * editing/pasteboard/4840662-expected.txt:
        * platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
        * platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-019-expected.txt:
        * platform/mac/editing/pasteboard/paste-xml-expected.txt:

        Removed redundant styles that were generated during nesting prevention that is no longer needed:
        * platform/mac/editing/pasteboard/4076267-2-expected.txt:
        * platform/mac/editing/pasteboard/5156401-1-expected.txt:
        
        No longer incorrectly uncollapsing unrendered whitespace:
        * editing/pasteboard/paste-into-anchor-text-expected.txt:
        * platform/mac/editing/pasteboard/5387578-expected.txt:
        
        No longer invalidating the old selected DOM range during a paste:
        * editing/pasteboard/copy-in-password-field-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@42549 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a2300356
    • darin@chromium.org's avatar
      2009-04-15 Adam Langley <agl@google.com> · a53b1527
      darin@chromium.org authored 
              Reviewed by Darin Fisher.

        Move VDMX parsing into the Chromium Linux port.

        https://bugs.webkit.org/show_bug.cgi?id=25116

        VDMX tables are optional tables in TrueType fonts which contain the
        exact pixel height of a given font at a given pel size. In order to
        match Windows font metrics we have to use these numbers.

        Previously, the parsing was performed in Skia. As part of the merge
        with upstream Skia, an interface for getting table data from a font
        has been added to Skia and we're moving the parsing into WebKit.

        This does not change any layout tests.

        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::uniqueID):
        * platform/graphics/chromium/FontPlatformDataLinux.h:
        * platform/graphics/chromium/FontTrueTypeLinux.cpp: Added.
        * platform/graphics/chromium/FontTrueTypeLinux.h: Added.
        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformWidthForGlyph):



git-svn-id: svn://svn.chromium.org/blink/trunk@42548 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a53b1527
    • darin@chromium.org's avatar
      2009-04-15 Stephen White <senorblanco@chromium.org> · 1926794c
      darin@chromium.org authored 
              Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25180

        Restore stroked outlines to PlatformContextSkia::drawRect().
        These were removed inadvertently in r41805, aka
        https://bugs.webkit.org/show_bug.cgi?id=24662.
        SkRect is { left, top, right, bottom }, not { left, top, width, height }.

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::drawRect):



git-svn-id: svn://svn.chromium.org/blink/trunk@42547 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1926794c
    • mitz@apple.com's avatar
      WebCore: · 332f02bb
      mitz@apple.com authored 
              Reviewed by Dave Hyatt.

        - fix <rdar://problem/6777374> Generated content with display: run-in
          causes a crash

        Test: fast/runin/generated.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::handleRunInChild): Check if the run-in block is
        generated, and if so, make the RenderInline anonymous instead of passing
        a 0 node to the RenderInline constructor. If the run-in itself is
        generated, do move :before and :after children from the block into the
        inline, as they will not be regenerated. Changed nested ifs into early
        returns.

LayoutTests:

        Reviewed by Dave Hyatt.

        - test for <rdar://problem/6777374> Generated content with display:
          run-in causes a crash

        * fast/runin/generated.html: Added.
        * platform/mac/fast/runin/generated-expected.checksum: Added.
        * platform/mac/fast/runin/generated-expected.png: Added.
        * platform/mac/fast/runin/generated-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42546 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      332f02bb
    • darin@chromium.org's avatar
      2009-04-15 Eric Roman <eroman@chromium.org> · 2a035dfc
      darin@chromium.org authored 
              Reviewed by Geoffrey Garen.

        https://bugs.webkit.org/show_bug.cgi?id=25192

        Expose DOMWindow::removeInlineEventListenerForType and
        DOMWindow::inlineEventListenerForType as public.

        * page/DOMWindow.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@42545 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2a035dfc
    • darin@chromium.org's avatar
      2009-04-14 Eric Roman <eroman@chromium.org> · f33fef3e
      darin@chromium.org authored 
              Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25198

        Wrap RegisteredEventListener's markEventListeners and invalidateEventListeners
        in a USE(JSC), since it doesn't compile with V8 bindings.

        * dom/RegisteredEventListener.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@42544 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f33fef3e
    • eric.carlson@apple.com's avatar
      2009-04-15 Eric Carlson <eric.carlson@apple.com> · 315f06d8
      eric.carlson@apple.com authored 
              Reviewed by Alexey Proskuryakov.

        Use a media file inside of LayoutTests/http/ so a cgi isn't necessary to load 
        it. Fixes a test failure introduced in r42533.

        * http/tests/resources/silence.mpg: Added.
        * http/tests/security/local-video-source-from-remote-expected.txt:
        * http/tests/security/local-video-source-from-remote.html: change the
        remote url, update a comment.
        * http/tests/security/resources/load-media.cgi: Removed.


git-svn-id: svn://svn.chromium.org/blink/trunk@42543 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      315f06d8
    • darin@chromium.org's avatar
      2009-04-15 Eric Roman <eroman@chromium.org> · 380569ae
      darin@chromium.org authored 
              Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25194

        Fix a caller of Settings::javaScriptCanOpenWindowsAutomatically() to
        use the new name.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:



git-svn-id: svn://svn.chromium.org/blink/trunk@42542 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      380569ae
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · d515d4c3
      ap@webkit.org authored 
              https://bugs.webkit.org/show_bug.cgi?id=25186
        There is no XSLT component in bugzilla

        * projects/xslt/index.html: Changed to search by bug title.



git-svn-id: svn://svn.chromium.org/blink/trunk@42541 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d515d4c3
    • ariya@webkit.org's avatar
      2009-04-15 Antonio Gomes <antonio.gomes@openbossa.org> · 0f6343a4
      ariya@webkit.org authored 
              Reviewed by Ariya Hidayat.

        Rename extend() method in QWebElementSelection to append().

        * Api/qwebelement.cpp:
        (QWebElementSelection::append):
        * Api/qwebelement.h:
        * tests/qwebelement/tst_qwebelement.cpp:
        (tst_QWebElement::appendSelection):

git-svn-id: svn://svn.chromium.org/blink/trunk@42540 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0f6343a4
    • hausmann@webkit.org's avatar
      2009-04-15 Antonio Gomes <antonio.gomes@openbossa.org> · 1608629e
      hausmann@webkit.org authored 
              Reviewed by Simon Hausmann.

        Fixed nit/typo in QWebElement documentation.

git-svn-id: svn://svn.chromium.org/blink/trunk@42539 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1608629e
    • oliver@apple.com's avatar
      Move CallFrameClosure from inside the Interpreter class to its own file. · c55fba40
      oliver@apple.com authored 
      Reviewed by NOBODY(Build fix)


git-svn-id: svn://svn.chromium.org/blink/trunk@42538 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c55fba40
    • oliver@apple.com's avatar
      Bug 25202: Improve performance of repeated callbacks into the VM · d2d9f36c
      oliver@apple.com authored 
      Reviewed by Cameron Zwarich

Add the concept of a CachedCall to native code for use in Array
prototype and similar functions where a single callback function
is called repeatedly with the same number of arguments.

Used Array.prototype.filter as the test function and got a 50% win
over a naive non-caching specialised version.  This makes the native
implementation of Array.prototype.filter faster than the JS one once
more.


git-svn-id: svn://svn.chromium.org/blink/trunk@42537 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d2d9f36c
    • ap@webkit.org's avatar
      Rubber-stamped by Darin Adler. · 048a4af6
      ap@webkit.org authored 
              Don't keep platform objects for authentication challenge in ResourceHandleInternal.
        We already have a copy in AuthenticationChallenge object.

        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::clearAuthentication):
        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
        (WebCore::ResourceHandle::receivedCredential):
        (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
        (WebCore::ResourceHandle::receivedCancellation):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
        (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
        (WebCore::ResourceHandle::receivedCredential):
        (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
        (WebCore::ResourceHandle::receivedCancellation):



git-svn-id: svn://svn.chromium.org/blink/trunk@42536 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      048a4af6
    • simon.fraser@apple.com's avatar
      2009-04-14 Simon Fraser <simon.fraser@apple.com> · c4b0c277
      simon.fraser@apple.com authored 
              Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=25157

        Move the run loop observer cleanup from -close
        to -_close.

        * WebView/WebView.mm:
        (-[WebView _close]):
        (-[WebView close]):

git-svn-id: svn://svn.chromium.org/blink/trunk@42535 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c4b0c277
    • ggaren@apple.com's avatar
      2009-04-14 Geoffrey Garen <ggaren@apple.com> · 71beed42
      ggaren@apple.com authored 
              Reviewed by Sam Weinig.

        Nixed some now-defunct autogeneration code.

        * bindings/scripts/CodeGeneratorJS.pm:



git-svn-id: svn://svn.chromium.org/blink/trunk@42534 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      71beed42
    • eric.carlson@apple.com's avatar
      2009-04-14 Eric Carlson <eric.carlson@apple.com> · 25b2f291
      eric.carlson@apple.com authored 
              Reviewed by NOBODY (OOPS!).
        
        Fix <rdar://problem/6755724> <audio> and <video> elements can reference local 
        file:/// URLs from remote in Safari

        Tests: http/tests/security/local-video-poster-from-remote.html
               http/tests/security/local-video-source-from-remote.html
               http/tests/security/local-video-src-from-remote.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::loadResource): Don't pass url to media engine if loader->canLoad()
        says it should not be loaded.

2009-04-14  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by NOBODY (OOPS!).

        Fix <rdar://problem/6755724> <audio> and <video> elements can reference local 
        file:/// URLs from remote in Safari

        Test cases to ensure that local 'src', 'poster', and <source> are not loaded.

        * http/tests/security/local-video-poster-from-remote-expected.txt: Added.
        * http/tests/security/local-video-poster-from-remote.html: Added.
        * http/tests/security/local-video-source-from-remote-expected.txt: Added.
        * http/tests/security/local-video-source-from-remote.html: Added.
        * http/tests/security/local-video-src-from-remote-expected.txt: Added.
        * http/tests/security/local-video-src-from-remote.html: Added.
        * http/tests/security/resources/load-media.cgi: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42533 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      25b2f291
    • weinig@apple.com's avatar
      WebCore: · ac869297
      weinig@apple.com authored 
      2009-04-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Part of <rdar://problem/6150868>
        Fix incorrect handling of content that needs to go into the head element
        once the head element has been removed.

        Test: fast/parser/head-content-after-head-removal.html

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::HTMLParser): Remove unneeded initializer of m_head.
        (WebCore::HTMLParser::handleError): Update since m_head is now a RefPtr.
        (WebCore::HTMLParser::createHead): Ditto.
        * html/HTMLParser.h: Make m_head a RefPtr.

LayoutTests:

2009-04-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Part of <rdar://problem/6150868>
        Test for incorrect handling of content that needs to go into the head element
        once the head element has been removed.

        * fast/parser/head-content-after-head-removal-expected.txt: Added.
        * fast/parser/head-content-after-head-removal.html: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42532 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ac869297
  3. 14 Apr, 2009 21 commits