- 30 Apr, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 958b96f3. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16551 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure TBR=lukebjerring No-Export: true Change-Id: I1c1c39343be0dbe8f11415c10ac3142e4e952225 Reviewed-on: https://chromium-review.googlesource.com/1035463 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#554814}
-
Tarun Bansal authored
A boolean value is set to true if the save data feature is enabled in Chrome at the time of page commit. Bug: 827608 Change-Id: I2cfa207694bb5aefe5bcb756fe9443248415e4d4 Reviewed-on: https://chromium-review.googlesource.com/1033821Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#554813}
-
David Black authored
Used to indicate high confidence/low confident text distinctly. Screenshot in bug. Bug: b:78644149 Change-Id: If5b1a19481b124c414b27d310c5a60832d0e4fd6 Reviewed-on: https://chromium-review.googlesource.com/1030978 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#554812}
-
Charlie Harrison authored
Originally landed https://chromium-review.googlesource.com/1031211 This CL makes types more explicit for literal -> stringpiece conversions. TBR=sky@chromium.org Bug: 833419 Change-Id: I3c08259906076216da22623b54d18e269b075bd0 Reviewed-on: https://chromium-review.googlesource.com/1033448Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#554811}
-
https://chromium.googlesource.com/catapult.git/+log/ad4bc36a64cc..21bd95c9099f $ git log ad4bc36a6..21bd95c90 --date=short --no-merges --format='%ad %ae %s' 2018-04-30 perezju [devil] Remove version_codes.O_MR1 Created with: roll-dep src/third_party/catapult BUG=chromium:831199 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ia3183cda3f0fd50f1ed92297d5d503a93dc6a271 Reviewed-on: https://chromium-review.googlesource.com/1035362Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554810}
-
Ian Swett authored
Default enable no stop waiting in versions of QUIC greater than 43, because the stop waiting frame is not in IETF QUIC. Merge internal changes: 192068307 and 194071535 R=rch@chromium.org Change-Id: I9955a11625d19483e5dee661eb8023a72301d72f Reviewed-on: https://chromium-review.googlesource.com/1024074 Commit-Queue: Ian Swett <ianswett@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#554809}
-
Lutz Justen authored
Adds StorePolicy, RetrievePolicy and BlockingRetrievePolicy methods to SessionManagerClient, which map to the new storage interface in Session Manager, and marks the old methods as deprecated. The next step will be to replace all existing Store/Retrieve calls by these three. This also adds support for storing/retrieving extension policy, which is needed for Chromad (see crbug.com/735100). Points all storage/retrieval methods in FakeSessionManagerClient to the generic implementations, reducing the difference between the two code path controlled by the PolicyStorageType enum. In a nutshell, policy is stored - in a file at <stub file path> if PolicyStorageType::kOnDisk is set and - in a memory-based map at key <stub file path> if PolicyStorageType::kInMemory is set. The old way to store different policy in a separate location (device_policy_, user_policies_ etc.) starts to get messy once extension policy is introduced (you'd need an extra dimension of mappings for the extension id aka component id). BUG=chromium:765644 TEST=Ran some affected tests (DeviceSettingsServiceTest, UserCloudPolicyStoreChromeOSTest SiteIsolationFlagHandlingTest DeviceCloudPolicyManagerChromeOSEnrollmentTest OwnerSettingsServiceChromeOSTest), but mostly rely on trybots. Change-Id: I1794d9264dc2ac8e7702cec4a079d6c9eb4c4091 Reviewed-on: https://chromium-review.googlesource.com/1024034 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#554808}
-
Emily Hanley authored
Now that shards as tags are being sent down on perf jobs, this code can stop sending specific device ids, but instead smartly tries to allocate perf jobs to bots based on to following: 1) what bot we last triggered it on by querying swarming for a list of tasks based on the dimensions and shard 2) what bots are currently alive by querying swarming for all bots with the given dimensions and checking that they are not quarantined and not is_dead. This requires that the dimensions for perf hardware is unique, which it will be with the new set of devices that will run this recipe. Bug: 831252 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2bfb708a1bb65dbdf85c85b976c463605fb28335 Reviewed-on: https://chromium-review.googlesource.com/1017304Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#554807}
-
Daniel Cheng authored
Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //mojo. This CL was uploaded by git cl split. R=jam@chromium.org Bug: 837148 Change-Id: Iface36adbfe57737c6601cc17d528e04254ee3df Reviewed-on: https://chromium-review.googlesource.com/1031186Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554806}
-
Eugene But authored
Old test was loading http://mock/redirect and because this URL did not exist the load was failing because of DNS resolution error. New test uses EmbeddedTestServer, which closes the socket to simulate ERR_INTERNET_DISCONNECTED error. Bug: 694662 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib8974954403f868aa8b41df49da8e83a7902a61e Reviewed-on: https://chromium-review.googlesource.com/1033952Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#554805}
-
Nasko Oskov authored
The ProcessManagerBrowserTest.HostedAppAlerts test uses a hardcoded URL to localhost without a port number. Since the server runs on non-default and randomized port number, navigation to URL without port is expected to fail. This test needs to be updated to ensure navigation succeeds. Bug: 838161 Change-Id: Iedf309114dfc60f7b10745d96daf6b669f657c14 Reviewed-on: https://chromium-review.googlesource.com/1035363Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#554804}
-
rbpotter authored
Migrate tests that validate automatic printer selection logic for various scenarios. Bug: 814860 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia926f9431d587ffea95b86352b6cee4a3a35283b Reviewed-on: https://chromium-review.googlesource.com/1026167 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#554803}
-
Chris Blume authored
The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. SurfaceHittest unit tests some such call site. BUG=759031 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I2d15885b14805d230f8ee67d1dfa453d3f46804f Reviewed-on: https://chromium-review.googlesource.com/1034388Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#554802}
-
Mike Wasserman authored
Make EventRewriterController create the keyboard rewriter itself. Simplify EventRewriterController, add rewriters immediately. Add ash::mojom::EventRewriterController for use by Chrome/OOBE. (one central interface seems better than one for each rewriter) This should allow Mash to support this rewriter in the future. (for now, Ash doesn't get Window Service events sent to Chrome) Bug: 647781 Test: No Hangouts Meet keyboard driven OOBE regressions; see Issue 251272 Change-Id: I7b731298d612b1d93dab825b12a9d36431d1b711 Reviewed-on: https://chromium-review.googlesource.com/1033424Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#554801}
-
David Bokan authored
The linked bug occurs because Android WebView sets the scroll offset on the viewport layers when an overscroll occurs. The root bug here is that scrolling a non-viewport scroller past its extent produces overscroll notifications to the browser. The fix is to only return overscroll delta from compositor scrolling when we're currently scrolling the viewport. Bug: 823273 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5f9726eb4329611884f921bd1f77db19c7ccd43d Reviewed-on: https://chromium-review.googlesource.com/1029130Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#554800}
-
Oystein Eftevaag authored
Added chiniforooshan@ who has contributed to tracing for a long time and is as familiar with the codebase as anyone. Moved some inactive owners to emeritus. R=primiano@chromium.org CC=chiniforooshan@chromium.org Change-Id: I2d2ae64677b7d33228101ceaa10f5b23eceba0a9 Reviewed-on: https://chromium-review.googlesource.com/1033324Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#554799}
-
Mounir Lamouri authored
When the player is destroyed, it notifies the element which then hides the interstitial. In a regular scenario, when the interstitial is hidden, the layer on the page should be visible again. However, when the player is destroyed, there is no more layer. Bug: 838147 Change-Id: I1d3a8970246d8f867fecd7ed7a5a1d9f371f7e5c Reviewed-on: https://chromium-review.googlesource.com/1035262Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#554798}
-
Bo Liu authored
The effective change is that foreground subframes get moderate instead of important binding. Note this is only half of the change that's in the chart at the bottom of this design doc: https://docs.google.com/document/d/1PTI3udZ6TI-R0MlSsl2aflxRcnZ5blnkGGHE5JRI_Z8/edit?usp=sharing Background subframe renderer is not yet lowered to waived. At the same time refactor ChildProcessLauncherHelper.setPriority to be easier to read and understand. Compute the effective importance from all available input, and then update bindings based on the effective importance. BindingManager.increaseRecency is now based on gaining effective "important" importance, which is effectively the same as before for chrome since ChildProcessImportance.IMPORTANT is not used by src/chrome. Bug: 813232 Change-Id: I8969f37edfec8b39b53d3a8ffe740585f3a802a6 Reviewed-on: https://chromium-review.googlesource.com/1033802Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#554797}
-
Takuto Ikuta authored
This CL was uploaded by git cl split. R=jam@chromium.org Bug: 428099 Change-Id: I385a2a8f3bb72ff91b477ee3b29fd0bd3b501fdb Reviewed-on: https://chromium-review.googlesource.com/1032467Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#554796}
-
Bo Liu authored
Use moderate binding instead which has the exact same flags, and also supports refcounting. Bug: 813232 Change-Id: I22a56345a835c5916e6604bfb7cb2fc5cae6ceb5 Reviewed-on: https://chromium-review.googlesource.com/1033799Reviewed-by:
-
Tao Bai authored
Bug: 821606 Change-Id: Ifcb799a450ff1940b673fcd3a23fa6e64a6b382a Reviewed-on: https://chromium-review.googlesource.com/981182Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#554794}
-
codeimpl authored
std::make_unique<Type>(...) and base::WrapUnique<new Type(...)) are equivalent but std::make_unique should be preferred, because it is harder to use unsafely than base::WrapUnique. Ref: https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Prefer-MakeUnique-to-WrapUnique Bug: None Change-Id: I0e13e0fa0088e3f9adcbcbbee341eea04a3f2307 Reviewed-on: https://chromium-review.googlesource.com/1034048Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#554793}
-
Mounir Lamouri authored
This doesn't fix the cause but only the crash because we will need to send this to Beta. A proper fix will require some refactoring. It means that M67 will probably have slightly different data for time to dismiss and time to action. Bug: 835748 Change-Id: Iec87eb0b05f07c54c3c292180a6a59a1aa35666d Reviewed-on: https://chromium-review.googlesource.com/1034742Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#554792}
-
Alexander Hendrich authored
Fixed typo from "free form strings" to "free-form strings" as requested. Bug: b:78365996 Change-Id: I7534888a2bb4993c4e53660c5398782c628ceebe Reviewed-on: https://chromium-review.googlesource.com/1035122 Commit-Queue: Alexander Hendrich <hendrich@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#554791}
-
chaopeng authored
In some cases, ScrollAnimator::WillAnimateToOffset called with run_state_ == RunState::kRunningOnCompositorButNeedsAdjustment. Bug: 825351 Change-Id: I805625d87d469c77564391c83d381eb179c665c8 Reviewed-on: https://chromium-review.googlesource.com/1033015Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554790}
-
Raymond Toy authored
First, don't need to specify the name for the AudioParam when constructing it because we can derive a good name from the type. Except for AudioWorkletNode which has user-defined AudioParam names. So add a method to allow setting the name (but only if the type is AudioWorklet). Second, add another Create method that accepts the context, the type enum, and the default value, letting the rate, mode, and limits default to the most common values of "a-rate", changeable, min and max float values. Bug: 834863 Test: no user-visible changes Change-Id: Ic6895f8f6683cda6bc5aa6b381a1c8a1c6558759 Reviewed-on: https://chromium-review.googlesource.com/1020237 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#554789}
-
Owen Min authored
Change the caption to follow the policy caption pattern. Change-Id: I0746c5a9b83ac2f0483cac6c23ff5682cff35128 Reviewed-on: https://chromium-review.googlesource.com/1033418Reviewed-by:
Marc-André Decoste <mad@chromium.org> Reviewed-by:
-
Charlie Harrison authored
This is obsolete with PlzNavigate. Bug: 789577 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I29cb9c7fa986cf6c564d9dad29c46b10df301be5 Reviewed-on: https://chromium-review.googlesource.com/1031392Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#554787}
-
Christopher Grant authored
If the exit-VR prompt shows while content is editing text, we should hide the keyboard. A side effect of this change is that, when the keyboard disappears, it notifies content that this has happened, and content loses focus. In the case of autofill settings, this means that if the user chooses autofill settings but dismisses the exit-VR prompt to return to their page, that the input field will no longer be focused for edit (and the keyboard won't be showing). In the 2D case, the keyboard is also hidden, but the cursor is still blinking in the field. Therefore, VR is not at parity with 2D, but this feels better than having the keyboard persist through VR modal dialogs. BUG=835483 R=asimjour Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I753ec31273e2473a21ea5cd2c2dddf70c962f71a Reviewed-on: https://chromium-review.googlesource.com/1030873Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#554786}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8550fd41. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16550 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=lukebjerring No-Export: true Change-Id: I242d7b49b84235bf3f2adef8a7226116134736e7 Reviewed-on: https://chromium-review.googlesource.com/1035102 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Varun Mohan authored
Previously, the Occluded state only applied to Chrome-OS. When the Occluded state was added to Mac, the description of the histogram was not updated. This CL updates the decsription to reflect the current state. Change-Id: Icca3356f55a9402d483ab991c69bdf49089866d7 Reviewed-on: https://chromium-review.googlesource.com/1035063Reviewed-by:
-
Quinten Yearsley authored
These builders were migrated and renamed, and the buildbot builders are now removed. Bug: 790378,790311,790308 Change-Id: If9c58d228613901a16ff591188c9bba780ad9678 Reviewed-on: https://chromium-review.googlesource.com/1033488Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#554783}
-
https://chromium.googlesource.com/angle/angle.git/+log/bb3255b5a507..b90779ebf018 $ git log bb3255b5a..b90779ebf --date=short --no-merges --format='%ad %ae %s' 2018-04-27 jmadill Vulkan: Pass fewer Context pointers around. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Iaa89bd7345b6f6011763b686fb82df0072ade5aa Reviewed-on: https://chromium-review.googlesource.com/1034783 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554782}
-
Elly Fong-Jones authored
Bisecting the linked bug. TBR=jbudorick@chromium.org Bug: 828031 Change-Id: Ia93130623463909ee7898965b782a82bf19a69a1 Reviewed-on: https://chromium-review.googlesource.com/1035104Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#554781}
-
Sergey Aranovskii authored
This CL is consist of two patches: 1. Turn the unload controller tests on for fast unload controller. This patchset (the file unload_browsertest.cc only) returns back the functionality reviewed and merged on https://chromium-review.googlesource.com/c/chromium/src/+/1012118 and reverted on https://chromium-review.googlesource.com/c/chromium/src/+/1022553 2. Fixed crash in the fast unload controller browser tests. The original CL was reverted because of that crash. The reason of the crash is, the callback resets itself. The same issue has already been fixed in the unload controller (CL https://codereview.chromium.org/471763008 ), but not applied to the fast unload controller. This patchset (the file fast_unload_controller.cc only) brings the missed fix. Change-Id: I9d867131897457efad0c96bc7d2fe0ffa2a65729 Reviewed-on: https://chromium-review.googlesource.com/1025714Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#554780}
-
John Abd-El-Malek authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ice8a52e161cf99193ed341573e7a5d035c7e1c96 Reviewed-on: https://chromium-review.googlesource.com/1035082Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#554779}
-
https://webrtc.googlesource.com/src.git/+log/f22550175b96..71a720ba160c $ git log f22550175..71a720ba1 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibd6eed4d9606e6737d223bc068e52038cd368981 Reviewed-on: https://chromium-review.googlesource.com/1035084Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554778}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1c736c3e..434bb526 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I088dcd2ad1f8bf40d3a46840425fe800bb8e0f30 Reviewed-on: https://chromium-review.googlesource.com/1035043Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#554777}
-
Majid Valipour authored
Introduce WorkletAnimation::UpdateCompositingState which is resposible to update cc side when necessary (e.g., during start or when there is a change while running). WorkletAnimation now notifies its controller that it has been invalidated once its timing has changed. This ensures it gets a change to update its compositing state on the next commit cycle. While animation is running, the state update is done by canceling and starting the keyframe effect on compositor side. This ensures the animation instance continues to live (with the same id) and thus keep any associated state while also updating its keyframes and timings. Other minor changes: - Use GetEffect() to access the main effect for the animation. - Refactor start logic. Tests: - virtual/threaded/fast/animationworklet/worklet-animation-set-timing.html test timing updates are reflected in cc. - virtual/threaded/fast/animationworklet/worklet-animation-set-keyframes.html test keyframe updates are reflected in cc. Bug: 833846 Change-Id: Icab984331a0584d9bd1eb38d24aef2f657070970 Reviewed-on: https://chromium-review.googlesource.com/1020239 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#554776}
-
David Bokan authored
The focus call in fragment navigation can run arbitrary script which can cause the document to become detached. Thus, we need to check whether we're still attached before continuing. Bug: 837255 Change-Id: I4b35f66e39ace801a59230234264757ba4d6be04 Reviewed-on: https://chromium-review.googlesource.com/1033958Reviewed-by:
-
