- 20 Oct, 2016 40 commits
-
-
fdoray authored
In preparation for the migration of many Chrome threads to TaskScheduler, we want to get rid of MessageLoop destruction observers. This CL removes the code that deletes DeviceMonitorLinux from a destruction observer and uses a LazyInstance::Leaky to manage the lifetime of DeviceMonitorLinux. This CL also helps reducing the amount of work done during shutdown https://groups.google.com/a/chromium.org/d/msg/chromium-dev/AMB2Y7Sqj48/QltA07wUCQAJ BUG=650318 Review-Url: https://chromiumcodereview.appspot.com/2433933004 Cr-Commit-Position: refs/heads/master@{#426518}
-
tbansal authored
The estimates are computed by the network quality estimator (NQE) and are pushed to CronetUrlRequestContext. Embedders can query for the estimates by calling appropriate methods on CronetEngine. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_cronet BUG=654498 Review-Url: https://chromiumcodereview.appspot.com/2417643007 Cr-Commit-Position: refs/heads/master@{#426517}
-
avayvod authored
Notifies RemotePlayback about the attribute being set that rejects the pending prompt() promise and cancels all availability watch callbacks. BUG=657566 TEST=RemotePlaybackTest Review-Url: https://chromiumcodereview.appspot.com/2432173006 Cr-Commit-Position: refs/heads/master@{#426516}
-
skobes authored
This prevented LayoutBlockFlow::layoutBlockFlow from seeing that the height had changed. As a result, it failed to set relayoutChildren = true. The bug affects fixed-pos objects in abs-pos containers, so it got worse with http://crrev.com/1172153004 but existed before. An equivalent patch for width was made in http://crrev.com/171463003. Additionally, update the early return for the case where the abs-pos container is the LayoutView. (This is just an optimization.) BUG=640639 Review-Url: https://chromiumcodereview.appspot.com/2429113002 Cr-Commit-Position: refs/heads/master@{#426515}
-
mathp authored
See bug for many failing tests. Example: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/47887/steps/browser_tests%20on%20Ubuntu-12.04/logs/EditDictionaryWebUITest.testNoCloseOnSearchEnter BUG=657514 TBR=aboxhall NOTRY=true Review-Url: https://chromiumcodereview.appspot.com/2436063002 Cr-Commit-Position: refs/heads/master@{#426514}
-
sanjoy.pal authored
Specification: https://w3c.github.io/browser-payment-api/ There are some circumstances where a cross-origin iframe wants to make a payment request. A cross-origin iframe needs explicit permission from the embedding page to invoke the payment request API. BUG=652148 Review-Url: https://chromiumcodereview.appspot.com/2394473002 Cr-Commit-Position: refs/heads/master@{#426513}
-
mstensho authored
This code no longer has any effect, since we now fragment and set the correct row heights way BEFORE cell alignment and flexing. It was also buggy, in that it didn't recalculate intrinsic padding after resizing the row. BUG=534751 Review-Url: https://chromiumcodereview.appspot.com/2433413002 Cr-Commit-Position: refs/heads/master@{#426512}
-
pkl authored
The removed utility functions are no longer used. The improved unit tests give better coverage to the functions that remain. Review-Url: https://chromiumcodereview.appspot.com/2364373002 Cr-Commit-Position: refs/heads/master@{#426511}
-
robpercival authored
As suggested by Ryan Sleevi (https://codereview.chromium.org/2348393002/diff/80001/components/certificate_transparency/mock_log_dns_traffic.cc#newcode47), MockLogDnsTraffic will no longer CHECK-fail when given invalid test expectations. Instead, it will return false and the tests using it can ASSERT_TRUE. BUG=624894 Review-Url: https://chromiumcodereview.appspot.com/2389993003 Cr-Commit-Position: refs/heads/master@{#426510}
-
qyearsley authored
This is a follow up to http://crrev.com/2360893002, which made it so that lines in the generic test expectations file (LayoutTests/TestExpectations) are updated when tests are removed or renamed in the upstream repo. It turns out that this should be done for all test expectations files, not just that one. BUG=649010 Review-Url: https://chromiumcodereview.appspot.com/2432883003 Cr-Commit-Position: refs/heads/master@{#426509}
-
jkarlin authored
Since we don't know for sure what the outcome will be and need to perform field trials, default to disabled. BUG=655585 Review-Url: https://chromiumcodereview.appspot.com/2441633002 Cr-Commit-Position: refs/heads/master@{#426508}
-
wangxianzhu authored
This is to avoid costly analysis for a display item containing huge number of operations, especially drawRect operations drawing small rects. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://chromiumcodereview.appspot.com/2425323002 Cr-Commit-Position: refs/heads/master@{#426507}
-
rouslan authored
When the credit card editor launches because of, for example, a missing billing address, the card number should be formatted for easy grokking. BUG=657585 Review-Url: https://chromiumcodereview.appspot.com/2433093003 Cr-Commit-Position: refs/heads/master@{#426506}
-
eyaich authored
This CL is blocked on the master/slave configuration in https://codereview.chromium.org/2437923003/ BUG=chromium:633253 Review-Url: https://chromiumcodereview.appspot.com/2439733002 Cr-Commit-Position: refs/heads/master@{#426505}
-
olka authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/0ec7a44..9c4cafa $ git log 0ec7a44..9c4cafaa --date=short --no-merges --format=%ad %ae %s 2016-10-20 danilchap@webrtc.org Append second nack list in same compound rtcp packet instead of replace 2016-10-20 aleloi@webrtc.org Made AudioReceiveStream a mixer participant. 2016-10-20 sakal@webrtc.org Fix org.mockito.Matchers deprecation warnings in DirectRTCClientTest. 2016-10-20 aleloi@webrtc.org Split audio mixer into interface and implementation. 2016-10-20 brandtr@webrtc.org Add FlexfecReceiveStream. 2016-10-20 kjellander@webrtc.org Remove all traces of Dr Memory. 2016-10-20 palmkvist@webrtc.org Make GN build screenshare_loopback 2016-10-20 magjed@webrtc.org iOS: Optimize video scaling and cropping 2016-10-20 minyue@webrtc.org Moving WebRtcVoiceMediaChannel::SendSetCodec to AudioSendStream. 2016-10-20 magjed@webrtc.org Android YuvConverter: Use OpenGL Framebuffer instead of EGL pixel buffer 2016-10-20 magjed@webrtc.org Android: Extend functionality of EglRenderer 2016-10-20 nisse@webrtc.org Revert of Delete unused file mediacommon.h. (patchset #1 id:1 of https://codereview.webrtc.org/2437703002/ ) 2016-10-20 sakal@webrtc.org Remove check for numberOfCameras from AppRTC Mobile PeerConnectionClient. 2016-10-20 sakal@webrtc.org Suppress deprecation warning in CallFragment. 2016-10-20 aleloi@webrtc.org Added a level controller initialization value to MediaConstraints. 2016-10-20 denicija@webrtc.org Add loopback option and improve UX of AppRTCMobile for Mac. 2016-10-20 kthelgason@webrtc.org Prevent stripping of C interfaces in framework 2016-10-20 danilchap@webrtc.org Add to rtc::Optional equality/unequality comparisions with object 2016-10-20 nisse@webrtc.org Delete unused file mediacommon.h. 2016-10-20 kthelgason@webrtc.org QualityScaler reset bugfix 2016-10-20 perkj@webrtc.org Change RefCountedObject to use perfect forwarding. The main reason for doing this is to allow refcounted objects to accept rvalue references in ctor and be able to std::move ctor rvalue arguments. Also, refcounted.h is now generated using pump.py instead of manually creating each ctor version. 2016-10-19 zijiehe@chromium.org A variable in ScreenCapturerWinDirectx has a bad name 2016-10-19 kthelgason@webrtc.org Revert of Move bitstream parser to more appropriate directory. (patchset #4 id:60001 of https://codereview.webrtc.org/2370853005/ ) 2016-10-19 kthelgason@webrtc.org Move current bitstream parser to more appropriate directory. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://chromiumcodereview.appspot.com/2439673003 Cr-Commit-Position: refs/heads/master@{#426504}
-
xlai authored
The reference images generated for Accelerated2D and Unaccelerated2D cases look correct. TBR=zmo@chromium.org BUG=655311 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://chromiumcodereview.appspot.com/2423413002 Cr-Commit-Position: refs/heads/master@{#426503}
-
tkent authored
BUG=623613 NOTRY=true Review-Url: https://chromiumcodereview.appspot.com/2434933002 Cr-Commit-Position: refs/heads/master@{#426502}
-
tedchoc authored
BUG=621464 Review-Url: https://chromiumcodereview.appspot.com/2434893003 Cr-Commit-Position: refs/heads/master@{#426501}
-
mcasas authored
This CL does the migration of the last Vid Capture IPC message to mojo, namely OnBufferCreated(). This message shared a SharedMemoryHandle, which is now send using mojo::{Wrap,Unwrap}SharedMemoryHandle(). This needs a few small changes elsewhere in the code, in particular there is no need to ShareToProcess() a given ShMem (and this in turn makes us think that the whole data-sending can be simplified in later CLs). Following suggestion in PS1, VideoCaptureBufferTracker() is changed to mojo::ScopedSharedBufferHandle GetHandleForTransit();, which causes changes in a few other classes; - SharedMemoryBufferTracker, MojoSharedMemoryBufferTracker - VideoCaptureBufferPool & Impl, - VideoCaptureController (no need for render process id). (all these changes are in services/video_capture/ and content/browser/renderer_host/media/) VideoCaptureHost is still a BrowserMessageFilter, and VideoCaptureMessageFilter is not completely gone yet, but will disappear soon -- I didn't want to mix the changes in the ShMem management with other changes just in case. BUG=651897 TEST=local capture, {content,capture,video_capture}_unittests Review-Url: https://chromiumcodereview.appspot.com/2410383002 Cr-Commit-Position: refs/heads/master@{#426500}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/a29a956d0e27..65820db5e152 $ git log a29a956d0..65820db5e --date=short --no-merges --format='%ad %ae %s' 2016-10-20 reed use 'real' SkImageDeserializer 2016-10-20 mtklein Viewer on Mac. 2016-10-20 mtklein Slim down builder CIPD packages. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=mtklein@google.com Review-Url: https://chromiumcodereview.appspot.com/2436013002 Cr-Commit-Position: refs/heads/master@{#426499}
-
csharrison authored
This prevents needlessly creating empty StringImpls. BUG=348655 Review-Url: https://chromiumcodereview.appspot.com/2441493002 Cr-Commit-Position: refs/heads/master@{#426498}
-
dtseng authored
This cl makes div output the same way as classic: - when a div receives either ChromeVox or page focus, read its text content or its aria label - this cleans up output and retains the previously hardened behavior in Classic. TEST=browse on a variety of sites like Gmail, Groups. Verify that despite bad markup, ChromeVox performs well and provides a smooth experience. BUG=619279 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://chromiumcodereview.appspot.com/2433823003 Cr-Commit-Position: refs/heads/master@{#426497}
-
fdoray authored
This CL introduces SchedulerWorker::Delegate::OnDetach() and records TaskScheduler.NumTasksBeforeDetach.* from this new method. BUG=553459 Review-Url: https://chromiumcodereview.appspot.com/2430633003 Cr-Commit-Position: refs/heads/master@{#426496}
-
treib authored
BUG=627747 Review-Url: https://chromiumcodereview.appspot.com/2412093002 Cr-Commit-Position: refs/heads/master@{#426495}
-
tyoshino authored
The spec phrase "credentials flag" is not so useful for those who are not familiar with the Fetch spec. Mention the withCredentials attribute so that XHR users can understand what's wrong with their code easily. I tried to show this only for XHR by using the RequestContext value, but RequestContextXMLHttpRequest is used not only for XHR but for EventSource. So, I refrained from taking the approach. R=yhirano@chromium.org BUG=566239 Review-Url: https://chromiumcodereview.appspot.com/2419063002 Cr-Commit-Position: refs/heads/master@{#426494}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9a5ffe0a..d2709daf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2437093002 Cr-Commit-Position: refs/heads/master@{#426493}
-
treib authored
BUG=657038 Review-Url: https://chromiumcodereview.appspot.com/2438543003 Cr-Commit-Position: refs/heads/master@{#426492}
-
kylechar authored
Display resolution with zero for either width or height aren't valid. Catch this problem and fail parsing the display spec string. BUG=none Review-Url: https://chromiumcodereview.appspot.com/2437053002 Cr-Commit-Position: refs/heads/master@{#426491}
-
pkl authored
This depends on https://chromereviews.googleplex.com/523537014 which deleted the code for Back to Calling App button. BUG=633626 Review-Url: https://chromiumcodereview.appspot.com/2427883002 Cr-Commit-Position: refs/heads/master@{#426490}
-
fdoray authored
BUG= Review-Url: https://chromiumcodereview.appspot.com/2435673003 Cr-Commit-Position: refs/heads/master@{#426489}
-
wuchengli authored
The official V4L2 flush begins by issuing VIDIOC_DECODER_CMD with cmd=V4L2_DEC_CMD_STOP. The driver will set the last output buffer with V4L2_BUF_FLAG_LAST. BUG=558206 TEST=Run VDA unittest and CTS on elm. Run VDA unittest on peach pi and nyan big. Review-Url: https://chromiumcodereview.appspot.com/2408703002 Cr-Commit-Position: refs/heads/master@{#426488}
-
arthursonzogni authored
BUG=657834 Review-Url: https://chromiumcodereview.appspot.com/2430953005 Cr-Commit-Position: refs/heads/master@{#426487}
-
https://crbug.com/644833flackr authored
BUG=644833,651305 Review-Url: https://chromiumcodereview.appspot.com/2439573002 Cr-Commit-Position: refs/heads/master@{#426486}
-
sdefresne authored
BUG=475439 Review-Url: https://chromiumcodereview.appspot.com/2437003003 Cr-Commit-Position: refs/heads/master@{#426485}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/fb5055947efd..73895de7dea3 $ git log fb5055947..73895de7d --date=short --no-merges --format='%ad %ae %s' 2016-10-20 dsinclair Cleanup unused methods and return values in FWL code. 2016-10-20 dsinclair Remove IFWL_*::Create methods, use new Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2442443002 Cr-Commit-Position: refs/heads/master@{#426484}
-
lukasza authored
BUG=647772 Review-Url: https://chromiumcodereview.appspot.com/2410303006 Cr-Commit-Position: refs/heads/master@{#426483}
-
mvanouwerkerk authored
BUG=651058 Review-Url: https://chromiumcodereview.appspot.com/2438033002 Cr-Commit-Position: refs/heads/master@{#426482}
-
mkwst authored
BUG=657799 Review-Url: https://chromiumcodereview.appspot.com/2433413003 Cr-Commit-Position: refs/heads/master@{#426481}
-
bokan authored
Since https://codereview.chromium.org/2400123002 has landed, the navigate step waits for an additional frame before returning. I suspect the redirect navigations happen in that frame so when the page calls WaitForNavigate it'll timeout. BUG=655627 Review-Url: https://chromiumcodereview.appspot.com/2440503002 Cr-Commit-Position: refs/heads/master@{#426480}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/e1d6ff172e21..a29a956d0e27 $ git log e1d6ff172..a29a956d0 --date=short --no-merges --format='%ad %ae %s' 2016-10-20 robertphillips Add SkRRectsGaussianEdgeMaskFilter Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=mtklein@google.com Review-Url: https://chromiumcodereview.appspot.com/2437083002 Cr-Commit-Position: refs/heads/master@{#426479}
-