- 02 Aug, 2018 40 commits
-
-
Colin Blundell authored
There are three sections of AccountTracker unittests: - Primary account only - Secondary accounts - Interaction between primary and secondary accounts In each of these sections, non-ChromeOS tests were scattered throughout. This CL consolidates the non-ChromeOS tests so that there is one set of non-ChromeOS tests at the end of each section. Followup to https://chromium-review.googlesource.com/c/chromium/src/+/1148200. Change-Id: I5e89a78a1d493ecd25b75d495969dda68f2b136e Reviewed-on: https://chromium-review.googlesource.com/1158830 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#580120}
-
Gauthier Ambard authored
This CL creates the personalization view displayed when the user taps for more options in the ConsentBump. For now, this CL is only adding the ScrollView, images and labels. The settings will be added later. Bug: 866506 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icce065f189b2f0047a5caba7b4630255693d3589 Reviewed-on: https://chromium-review.googlesource.com/1158575 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580119}
-
Ramin Halavati authored
Preferences related to Supervised Users are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I74259a24fa1747298f80a627247f5777fad163f4 Reviewed-on: https://chromium-review.googlesource.com/1159365Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#580118}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e43024a5bab7..64cc576b1fa7 git log e43024a5bab7..64cc576b1fa7 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 stephana@google.com [infra] Make GS buckets for images and hash file URL configurable Created with: gclient setdep -r src/third_party/skia@64cc576b1fa7 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I7c699afd0360be8226d0155d8dd7c2217b1b37d2 Reviewed-on: https://chromium-review.googlesource.com/1159784Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580117}
-
Alexander Hendrich authored
This CL implements the UI changes for the new AllowOnlyPolicyNetworksToConnectIfAvailable policy in chrome settings. Bug: 848719 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I41c9b935f291e2cdfb95c6ef52b216b2a268af43 Reviewed-on: https://chromium-review.googlesource.com/1124448 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#580116}
-
Christos Froussios authored
This reverts commit 323e8611. Reason for revert: Disabled non-offending test Original change's description: > Disable CustomFrameViewAshTest.ActiveStateOfButtonMatchesWidget on linux-chromeos-rel > > It is flaking. > > TBR=sky@chromium.org > > Bug: 869830 > Change-Id: Id455349e683f1adda690457faffc40d12c977d38 > Reviewed-on: https://chromium-review.googlesource.com/1158584 > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579789} TBR=cfroussios@chromium.org Change-Id: I1904d3f8febf2d9c0fcac0032e2622df2bdb009d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869830 Reviewed-on: https://chromium-review.googlesource.com/1160222Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#580115}
-
Oscar Johansson authored
Without jumbo, omnibox takes around 3 CPU minutes to build which is around 0.5 % of the total build time. This commit enables jumbo support in components/omnibox. Bug: 869381 Change-Id: Ifb51dab5a6b034a384c6bf07ee2f5b8c17b952a7 Reviewed-on: https://chromium-review.googlesource.com/1156593Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#580114}
-
Martin Robinson authored
This will make it easier to catch new ones. Change-Id: I468c496b547d6042b6ca45b888a15ca4b9917dd3 Reviewed-on: https://chromium-review.googlesource.com/1157004 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#580113}
-
stkhapugin@chromium.org authored
Removes the omnibox_popup_row.h header left for downstream compilation. Bug: 814732 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic7eb3c6f6d2b72496998ce58d7a81fc63614be69 Reviewed-on: https://chromium-review.googlesource.com/1158576Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#580112}
-
Markus Heintz authored
TBR=alemate@chromium.org Bug: 865902 Change-Id: I4ea0613be8db3bb2120d1be9c5137ca81ecd54f4 Reviewed-on: https://chromium-review.googlesource.com/1145318 Commit-Queue: Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#580111}
-
yoshiki iguchi authored
- message_center::UiController -> ash::MessageCenterUiCiontroller - message_center::UiDelegate -> ash::MessageCenterUiDelegate These CL moves these classes into ash/, since they are used only from ash. Bug: 869278 Test: trybot passes Change-Id: I15390ba972f5c522c5a95bad8c2e1b6281ee8d24 Reviewed-on: https://chromium-review.googlesource.com/1152756Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#580110}
-
yoshiki iguchi authored
- NotificationViewMDTest.TestClick - NotificationViewMDTest.TestClickExpanded I found the tests were missing during working around here. Bug: 869278 Test: trybots pass Change-Id: Ieb428fa8884755ed63ea2fe6d1c346629ab35ed8 Reviewed-on: https://chromium-review.googlesource.com/1158448Reviewed-by:
-
Ross Mcilroy authored
BUG=v8:7786 Change-Id: I2325c003da6db08a72eb442ea4f9641ca62d78ad Reviewed-on: https://chromium-review.googlesource.com/1159071Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580108}
-
Olli Etuaho authored
The ANGLE_multiview extension was erroneously enabled by default if available in the GPU passthrough command buffer. This was visible as the GL_OVR_multiview preprocessor macro being defined in shaders even if the WEBGL_multiview extension was not enabled. This is now fixed so that the extension is only enabled when requested. BUG=864524 TEST=WebGL conformance tests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie6e684fb91af4bb50aac7027ee9f85cd4420fe37 Reviewed-on: https://chromium-review.googlesource.com/1158569Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> Cr-Commit-Position: refs/heads/master@{#580107}
-
Christos Froussios authored
This reverts commit 20f64257. Reason for revert: Suspected of breaking device_unittests on Win10 Tests x64 (dbg) Original change's description: > [Bluetooth][WinRT] Implement Obtaining Gatt Descriptors > > This change implements obtainining Remote Gatt Descriptors for WinRT by > hooking up the appropriate logic into GattDiscovererWinrt. Furthermore, > appropriate tests are enabled. > > Bug: 821766 > Change-Id: I20475478367c2ab6b18940b4271de70ec138f676 > Reviewed-on: https://chromium-review.googlesource.com/1156392 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579830} TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org Change-Id: If5128ebf0c9dd1f585bd98b9729a57340f4493a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821766, 870208 Reviewed-on: https://chromium-review.googlesource.com/1159943Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I255165c5a91fc2b49962b5cd940d68c78a77502e Reviewed-on: https://chromium-review.googlesource.com/1159997Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580105}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3a995feda7bb..c988ddf7b193 git log 3a995feda7bb..c988ddf7b193 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 nednguyen@google.com Update chrome reference builds Created with: gclient setdep -r src/third_party/catapult@c988ddf7b193 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:868675 TBR=sullivan@chromium.org Change-Id: I575647f62ecf7212efab0ce3e9ab910405def5ea Reviewed-on: https://chromium-review.googlesource.com/1159882Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580104}
-
Tetsui Ohkubo authored
We need a way to let users know that notifications are hidden in lock screen. Similar message was preaviously shown on NotificationTray in lock screen. Screenshot: http://screen/BNWeniKkuR5 TEST=manual BUG=864964 Change-Id: If7fa3bf1e61b1bce77b355c907a4dfef254a8601 Reviewed-on: https://chromium-review.googlesource.com/1156203 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#580103}
-
Matt Falkenhagen authored
ServiceWorkerContextCore owns provider hosts, and stores them in a map from <process id, provider id> to host. But precreated hosts are created before the process id is known. So the hosts are first stored in <-1, provider id> before being moved to <process id, provider id>. That complicates adding a Mojo error connection handler to the host, which tries to call RemoveProviderHost(process_id, provider_id). Fortunately, precreated hosts have a unique provider id anyway, so the process id isn't needed. This CL makes it so precreated hosts always live in <-1, provider id>, so a Mojo error connection handler can be added to them immediately. Note that we can't easily make renderer-assigned provider ids unique since they are generated by each renderer process on its own. But eventually the renderer-created providers will go away anyway, since they aren't used since PlzNavigate except for non-S13nServiceWorker shared worker. Some more design at: https://docs.google.com/document/d/1FDaAwQ9O1Z2am1XEMPiEsVzWXgqCkT1ZqpVlcGmBve4/edit This will allow fixing the linked bug, by the next CL: https://chromium-review.googlesource.com/c/chromium/src/+/1159544 Bug: 854993 Change-Id: I3f638496e0e7436e484c956531709ff6931418ff Reviewed-on: https://chromium-review.googlesource.com/1159542 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580102}
-
Colin Blundell authored
This CL completes the conversion of GCM's production code to talk to IdentityManager rather than legacy signin classes by converting AccountTracker. The GCMAccountTracker unittest remains to be fully converted away from the legacy signin classes; this will be done in a followup CL. TBR=rohitrao@chromium.org, rockot@chromium.org Bug: 809923 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1513b33850f52b532d83ac389a78464b68ed1a45 Reviewed-on: https://chromium-review.googlesource.com/1148200Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Robert Ogden authored
Currently not used anywhere, but will be in the near future as more code for this feature is added. Bug: 870045 Change-Id: I9d8beafcfd99098889fa1e200379ebd59aa90450 Reviewed-on: https://chromium-review.googlesource.com/1157546Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580100}
-
Matt Falkenhagen authored
Including: - std::move() when appropriate. - Change diagnostic CHECKs to DCHECKs. - |self| doesn't seem like Chromium style. - Don't repeat base class documentation in overrides. Bug: 866353 Change-Id: I9d7d3653cd801770251936bcae330bf1610d0fdb Reviewed-on: https://chromium-review.googlesource.com/1159933Reviewed-by:
-
Kinuko Yasuda authored
TBR=chaopeng Bug: 841567 Change-Id: I824e726b2399870b6ba821b2c79adbd3673b7b31 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1160063Reviewed-by:
-
Marc Treib authored
This removes some unnecessary "virtual"s, and adds "Virtual for testing" comments to the remaining ones. (Many of those are questionable, but that's out of scope for this CL.) Bug: none Change-Id: I6b742769ef256416fd737f2c16b0379c359bdd6c Reviewed-on: https://chromium-review.googlesource.com/1148056Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#580097}
-
mrefaat authored
AppLauncherAbuseDetector & AppLaunchingState classes were on ios/chrome/browser/web. But they are not related to web. Moving these classes put togather all app launching logic on the same place, and also breaks app_launcher target dependency on ios/chrome/browser/web:web_internal which can be a reason for cyclic dependency for targets that depend on AppLauncherTabHelper. Bug: 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I743c9add64b939430c287b6fddd9cd77c082d697 Reviewed-on: https://chromium-review.googlesource.com/1158125 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#580096}
-
Findit authored
This reverts commit 0ea2267a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 580029 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzBlYTIyNjdhN2NlZmE0OWZmZDNmMzA4MGRjZWEyNDFkOWJiY2RmZDcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/9359 Sample Failed Step: not_site_per_process_browser_tests Original change's description: > Fix crash when right clicking link in CastUI > > This CL adds a null check to RenderViewContextMenu::AppendLinkItems() > ensuring we have an associated Browser before attempting to use it. > > Bug: 869280 > Change-Id: Ib1ffecd9dfbe27fb4fc6f6c77762c6337c36d4d4 > Reviewed-on: https://chromium-review.googlesource.com/1158110 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580029} Change-Id: Ie3a0067047c42fc8682ca8663eede8f1195afaed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869280 Reviewed-on: https://chromium-review.googlesource.com/1159804 Cr-Commit-Position: refs/heads/master@{#580095}
-
Joel Hockey authored
Perform sshfs mount to termina/penguin immediately when container starts. Mounting code has moved from the chrome.fileManagerPrivate extension functions into CrostiniManager. This change will make FilesApp more responsive to users who are likely to use terminal or some other crostini app before using FilesApp. Bug: 846917 Change-Id: I9fc246e45e54390e7a75f15a5571a24218cf2d5c Reviewed-on: https://chromium-review.googlesource.com/1158317Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#580094}
-
Sergey Ulanov authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic382e5fc990c6cd94bb43aca18104901ee0595eb Reviewed-on: https://chromium-review.googlesource.com/1158722Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Toshiki Kikuchi authored
In the login or lock screen, the settings and lock buttons are inactive so that we made them invisible to improve UX. In the previous implementation, these buttons are just disabled instead of invisible. TEST=TopShortcutsViewTest BUG=864233 Change-Id: I44b633187b475386732bfa9df5b78e740529d1e7 Reviewed-on: https://chromium-review.googlesource.com/1157666Reviewed-by:
-
Nicholas Verne authored
It uses a blocking PathExists call under the hood, so cannot be called sync on the UI thread. The IsRegistered check now runs when MaybeUpgradeCrostini runs, which is at user session startup time Bug: 870117 Change-Id: I000887e2e76a0cbebfe7c12a37fe1e7d7911e22d Reviewed-on: https://chromium-review.googlesource.com/1159936Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#580091}
-
Jiajia Qin authored
This CL implements MemoryBarrier and MemoryBarrierByRegion APIs for webgl2-compute context. Bug: 859249 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icfa6a081f09df01ccebbed07cb3cc30f23ca3301 Reviewed-on: https://chromium-review.googlesource.com/1156133Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This is a follow-up from: https://chromium-review.googlesource.com/c/chromium/src/+/583977 which removed unused InlineBox::HasSelectedChildren(). The patch left an unused variable |root_has_selected_children| dangling. This patch removed that. Bug: 789870 Change-Id: I6f5d4cf4f50630e558a314782212949ccd5ad2bc Reviewed-on: https://chromium-review.googlesource.com/1159555Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#580089}
-
Tetsui Ohkubo authored
UnifiedSliderBubbleController was not handling events properly when the previous bubble was closing e.g. volume key was pressed during brightness slider is fading out. TEST=manual BUG=866301 Change-Id: I93087c01b38cbd7d5f64f8c99c9e0c539113f8d8 Reviewed-on: https://chromium-review.googlesource.com/1159924Reviewed-by:
-
Tetsui Ohkubo authored
Rather than closing popups immediately, we should close the popups with animation and let MessagePopupCollection::Update() close them eventually. Ideally MarkAllPopupsShown is problematic and this should be cleaned up along with UiController, but for now the fix should be acceptable as it just replicates the behavior of old MessagePopupCollection. Steps to repro: 1. Create a notification 2. Click on a notification TEST=manual(asan build) BUG=869593,869716 Change-Id: Ifdfc7c2a362727740401e6e16845d8d770877730 Reviewed-on: https://chromium-review.googlesource.com/1158118Reviewed-by:
-
Ramin Halavati authored
Preferences defined in: 'components/metrics/metrics_pref_names.h' are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Change-Id: I3cf9ee5bb0ad248a95fbcbef51cd0c18e5d513be Reviewed-on: https://chromium-review.googlesource.com/1149365 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#580086}
-
Tim Song authored
This very basic implementation currently only supports one active advertisement. Future work will add tests and better handle concurrent advertisements. BUG=846881 Reviewed-on: https://chromium-review.googlesource.com/1142294Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#576712} Change-Id: Iaca4f7d319ea72fb3fc8915fef2c7cf78f6c9bc8 Reviewed-on: https://chromium-review.googlesource.com/1150843Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#580085}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e41c89b3..0283df9b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I816128672ee5b8e79dd393d84220a74ed1323a1b Reviewed-on: https://chromium-review.googlesource.com/1159846Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580084}
-
Yuki Yamada authored
Removed V8WorkerOrWorkletEventListener::GetReceiverObject() because its behavior is equivalent to V8AbstractEventListener::getReceiverObject() as commented in FIXME. Bug: 869778 Change-Id: If000f1351ec1ab2d5904c853a1dddc2be9d96648 Reviewed-on: https://chromium-review.googlesource.com/1158318 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#580083}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3fe4043d9320..7d059ce0a2a3 git log 3fe4043d9320..7d059ce0a2a3 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@7d059ce0a2a3 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifd250cda5cff5391fc9fc8c61e2f3d7f864f0b4e Reviewed-on: https://chromium-review.googlesource.com/1159443Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580082}
-
Ryan Hamilton authored
Change-Id: I488254610602049fc45d6770bb926f8020e29b5d Reviewed-on: https://chromium-review.googlesource.com/1159165 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580081}
-
