GitLab

This reverts commit cac286db.

Reason for revert:
This should have been landed after the CL to move the
password_store_signin_notifier_impl.


Original change's description:
> Revert "[ios][PhishGuard] Port code to ios_chrome_password_store_factory"
>
> This reverts commit 8d720de8.
>
> Reason for revert: Compile failure on ios-device
>
> 'components/password_manager/core/browser/password_store_signin_notifier_impl.h' file not found
>
> https://ci.chromium.org/p/chromium/builders/ci/ios-device/172358
>
> Original change's description:
> > [ios][PhishGuard] Port code to ios_chrome_password_store_factory
> >
> > Design doc: go/bling-phishguard
> >
> > The password_store_factory had already been forked between
> > //chrome and //ios. This CL ports password reuse detection code
> > from //chrome into the //ios implementation.
> >
> > Runtime changes are behind the kPasswordReuseDetectionEnabled
> > feature flag.
> >
> > Bug: 1147962
> > Change-Id: Iaa5c31759383870753ab94aac14f798ab6634cfe
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544748
> > Commit-Queue: edchin <edchin@chromium.org>
> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#828562}
>
> TBR=vasilii@chromium.org,edchin@chromium.org
>
> Change-Id: I2286176790447a0dc192c01a6f4a888699f77c70
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1147962
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546302
> Reviewed-by: Jiewei Qian  <qjw@chromium.org>
> Commit-Queue: Jiewei Qian  <qjw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#828566}

TBR=vasilii@chromium.org,edchin@chromium.org,qjw@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1147962
Change-Id: I5771528c764e83a7ce50f382eb65b93097283c1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546172Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828831}

Bug: 1143271
Change-Id: I1b24f23d1e3749bf4a4283b38f79a607129180cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544547
Auto-Submit: Erik Språng <sprang@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828830}

Bug: 936906
Change-Id: Ibbb8fad9bd4680a91e0a595e10db9b752c1450a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538330
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828829}

Since the downstream code uses PrivacyPreferencesManager, left a class with a single getInstance() method.

Bug: 1132805
Change-Id: Ia1d2d9861c5a4782bb374d09fd36107d0ee2580c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543936
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Auto-Submit: Andrey Zaytsev <andzaytsev@google.com>
Cr-Commit-Position: refs/heads/master@{#828828}

When a NearbyConnectionBrokerImpl object is deleted, invoke
DisconnectFromEndpoint() if a connection had been established during the
lifetime of the object. Specifically, if OnConnectionInitiated() has
been called but OnDisconnected() has not, we disconnect.

Bug: 1149770, 1106937
Change-Id: I1c805475400d84d87092fbfafae20f0c48b7208c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545670Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828827}

- Remove DEFINE_DOCUMENT_TYPE_CASTS() macro
  It's not used.

- Remove DEFINE_TRACK_TYPE_CASTS() macro
  It's not used.

- Remove DEFINE_TYPE_CASTS() for PresentationConnectionAvailableEvent
  The code generated by this DEFINE_TYPE_CASTS() are not used.

This CL has no behavior changes.

Bug: 891908
Change-Id: I8a60227c042f85c7d25184258e105b1ba2a9eebb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546393
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828826}

This is the first stage of replacing the existing
linux-wpt-payments-fyi-rel builder with this new 'input' builder. The
next set of CLs will switch to using 'input' instead of 'payments' in
wpt-importer smoketests.

Bug: 1127055
Change-Id: I2f3aab01e99991733cc2f936d729dbb21e666b4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545286Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828825}

- Will be updated to adhere to the spec in the future.

Screenshot: http://shortn/_17jazhYXnr

Bug: 1125150
Test: browser_tests --gtest_Filter=DiagnosticsApp*
Change-Id: I55770ae52546b055f77766eb31644d3218ec8658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530452
Commit-Queue: Michael Checo <michaelcheco@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828824}

Use slightly wider tiles, but request fewer at a time. This should
reduce memory overcommit. On low mem devices don't request more than 1
tile at a time.

Bug: 1144768
Change-Id: I115524c5a226487675d040d37865e0a858abf28c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546964Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828823}

Note: Classic shelf colors can now be safely removed.

https://bugs.chromium.org/p/chromium/issues/detail?id=1146464

Bug: 1145356
Change-Id: If106ff7954e0b1c6f8b4136dd89fac3ceb7b075e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545489Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828822}

https://skia.googlesource.com/skia.git/+log/9ef7e206b9a2..fcc4e85f3c0b

2020-11-18 bsalomon@google.com Remove SkYUVAInfo::PlanarConfig

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: lovisolo@google.com
Change-Id: I2c8318582bbb31e98a7a000e432ad4f37f690e95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547145Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828821}

The browsertest related to javascript blacklist is moved into
url_blacklist_policy_browsertest.

Bug: 1149970
Change-Id: Ifa5a946907389d335b3f83f87fd3ce9e6d388af2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544723
Commit-Queue: Saurabh Nijhara <snijhara@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828820}

What in fact happened before:
* Test suite is instantiated
* New TestingBrowserProcess is created
* ScopedTestingLocalState is created and substitutes browser local state
* If the test case is not the first one, no DlpRulesManager
initialization happens. This also means that PrefChangeRegistrar is
bound to the destroyed object.

This led to the situation that after first successful test run
DlpRulesManager stopped receiving policy updates and failed on all other
test suites.

To fix this, we need manually delete instance of DlpRulesManager after
the test run, so it initializes itself correctly for next test.

Ideally, instead of using DlpRulesManager as a singletion we could
transfer its ownership to one of more general policy objects. We
wouldn't need to delete the instance manually in that case.

Bug: 1131392
Change-Id: Ifa51f1c0d68a900d6ab62b19504148814844bbd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547241Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Aya Elsayed <ayaelattar@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828819}

Design doc: go/bling-phishguard

This CL moves the Impl file so that it can be compiled on iOS as well.

Bug: 1147962
Change-Id: Icbdb4cfc0a06b79a11012230700d676f5408e8f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544070
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828818}

This has been flaky since being added in http://crrev/c/2512367.

enga@chromium.org

Bug: 1150490
Change-Id: Iac75b4ba6422e68a4ed87001d80e0fb55857bcda
No-Try: True
TBR: johnchen@chromium.org
CC: behdadb@chromium.org, jonross@chromium.org, sadrul@chromium.org,
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546966
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828817}

Bug: chromium:1127088
Change-Id: I9c383eba922eafc94d87f4362bfaa37c076aafcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545877
Commit-Queue: Jacob Kopczynski <jkop@chromium.org>
Auto-Submit: Jacob Kopczynski <jkop@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828816}

Probably because of a typo, we where parsing the
Content-Security-Directive 'treat-as-public-address' as 'worker-src'
instead. Since 'treat-as-public-address' is ignored in Blink anyway,
the only real problem was that if a CSP directive list contained both
'treat-as-public-address' and 'worker-src', in this order, then
'worker-src' would be ignored. This CL fixes that.

Bug: 1150314
Change-Id: I7876ddd3440dd761289619afaf92b4ff3e6a9c88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544885Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828815}

Updating these metrics' expiry to match the others.

Bug: 1149509
Change-Id: I4d0c20572eef024e169c71df9daab868c3f72606
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542842
Auto-Submit: Nick Burris <nburris@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828814}

This has been flaky for awhile since at least November 11th.

Bug: 1149983
Change-Id: Ia478a5bb9af6720bec2ac895c29529182e087e73
No-Try: True
TBR: johnchen@chromium.org
CC: tmrts@chromium.org, mythria@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547660
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828813}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I4419a69301e267f273e36311b93fbd4e1fa6803f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547140Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828812}

Change-Id: I5da8da1fec48214f7b7051793954ded89380e6a5
Bug: 1104817
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490105Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828811}

https://swiftshader.googlesource.com/SwiftShader.git/+log/50066a3edffa..43fcd32b4fae

2020-11-18 rnk@google.com Use pragmas to work around MSVC x86_32 debug miscompile bug

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I3bdab05f7c4e00d09c9c2006a446e5998f1cab2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547144Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828810}

Bug: 11297512
Change-Id: I51a1de2a77553f2122ca01c62c1e5cb067c3b05f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544893Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828809}

Command line help for the unit test launcher indicates that the command
line variable "--gtest-repeat" is supported when it is actually the
variable "--gtest_repeat" that works.


Change-Id: Ice54828defdd30347d637a7d809bcbe6ae8e7c08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547201
Commit-Queue: Peter McNeeley <petermcneeley@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828808}

This change simplifies the NameToLabel helper inside CSVPasswordSequence
to use the new base::fixed_flat_map and return a simple pointer instead
of a base::Optional.

Bug: 934326
Change-Id: I1325a7470151ee31af37dcc21919d696d829edbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544606Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828807}

This CL removes NOTIFICATION_KIOSK_ENABLED and
NOTIFICATION_KIOSK_APPS_LOADED notifications.
These were used for the tests. Replaced with
ash::LoginScreenTestApi::WaitForUiUpdate

I'm gonna fix KioskErrorScreenTest.OpenCertificateConfig in a separate
CL

Bug: none
Change-Id: I61a19f708683c16d7a2ec764a29a978c023893e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544523Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828806}

Bug: 1145379
Change-Id: I24ed2a6ddb656558144dde3949363428881ca3e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542664
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Reviewed-by: Adam Trudeau-Arcaro <adamta@google.com>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828805}

This reverts commit dedbddfa.

Reason for revert: Breaks windows perf bot compile crbug/1150494

Original change's description:
> Migrate non-inclusive terminology in chrome/browser/win/conflicts.
>
> Bug: 1097283
> Change-Id: Ic54679c9d4b86fbe074b77067bd1bfa8b5d388f4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546842
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Commit-Queue: Chris Hamilton <chrisha@chromium.org>
> Auto-Submit: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#828770}

TBR=pkasting@chromium.org,chrisha@chromium.org

Change-Id: Id51371b5e0add5122cd34323c7fc3461d9ad118a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1097283,1150494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547049Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828804}

After attempting to decipher the stack trace, I couldn't pinpoint why
some of these tests were failing/flaking. I decided to removed the @Batch
annotation and it seems to be passing the builder it was failing before.

Bug: 1145783
Change-Id: I96d9d1bde213eed4df8432460e45dabe158adcbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533534
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828803}

Disable MetricsCollected, it's flaky.

Bug: 1080922
Tbr: knollr@chromium.org
Change-Id: Ib58a1be47de8f31856bcd6b52e70177789c0995e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547381Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828802}

This change migrates uses of base::Bind to BindOnce/BindRepeating, and
uses of base::Callback to OnceCallback/RepeatingCallback.

Please see crbug.com/714018 for full details about the migration.

Bug: 1147284
Change-Id: If5d750d21d63fd24c7da0c75bc4532d8d52b5383
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535394Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#828801}

Bug: None
No-Try: True
Change-Id: I49c1e945a3052eb187546c4a42a4d1f043e34a40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545879
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828800}

If the transient child gets removed before OverviewItem destroyed, it
will not be removed as an observer. Rather than add some logic to
OverviewItem to listen to transient changes, shuffle some codes and use the
logic that is already in place in ScopedOverviewTransformWindow.

Bug: b/172880323
Test: manual
Change-Id: Id0438a59e7050dfc7cf694088393cd181bb37f51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546168Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828799}

Generate DIR_METADATA files and remove metadata from OWNERS
files for directories under //chromeos/.

R=khorimoto@chromium.org

Bug: 1113033
Change-Id: I5315597ca79f139c8b2b35514f00ec928c28d144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545871
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Gavin Mak <gavinmak@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828798}

Save the port value of the response that set a cookie in
CanonicalCookie. This will first be used for metrics leading to a
potential cookie spec change.

This value is connected up to the persistent store which was
modified to support it in an earlier CL: https://crrev.com/c/2505468

Bug: 1148013, 1141135, 1031721
Change-Id: Ic849bb71403a05ab31fd37d3acf37453dac8ebb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537938Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828797}

There are various test helper methods to add:
AutofillProfile(s)
CreditCard
To the PersonalDataManager.

All of these only use the Browser* reference to reach the Profile*
object. Changing these methods to use Profile* directly.

This allows us to remove the Browser* references so we can run tests
on Android.

Bug: 1148435
Change-Id: I7ba1bb0491e487e5965fa837edc8abecdb15a471
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545775Reviewed-by: Matthias Körber <koerber@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
Cr-Commit-Position: refs/heads/master@{#828796}

Change-Id: Idad80a48f1fa5fb70373f9fc618668188897cd11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528936Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Chris Fredrickson <cfredric@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828795}

CHROME_BROWSER_CLOUSE_MANAGEMENT_NAME ->
CHROME_BROWSER_CLOUD_MANAGEMENT_NAME

Change-Id: Id6312c92d2312ae776a18681c72033b0c38882f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546986
Commit-Queue: Owen Min <zmin@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Auto-Submit: Owen Min <zmin@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828794}

Generate DIR_METADATA files and remove metadata from OWNERS
files for directories under //chromeos/.

R=khorimoto@chromium.org

Bug: 1113033
Change-Id: Ie14097dd12af3f57e9cffbab771c47c90fc2beb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545750
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Gavin Mak <gavinmak@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828793}

Bug: b:157739366
Change-Id: I8a33f9fd88ec1d0eae8743d443e3c618b5a1919b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544879
Commit-Queue: Zach Trudo <zatrudo@google.com>
Reviewed-by: Zach Trudo <zatrudo@google.com>
Auto-Submit: Leonid Baraz <lbaraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828792}