- 13 Jan, 2021 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610495996-7189a1d14c9908600535ebce9352fe55a59722e6.profdata to chrome-win64-master-1610505994-ce0c95957b1d27284e834682f26210d976ec22d1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iba2277867181ab35c0d0d717e70c991b989ec491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627027Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842919}
-
Luciano Pacheco authored
Add JS modules for //ui/file_manager/file_manager/foreground/js/ : - task_history.js - quick_view_model.js - metadata_update_controller.js - last_modified_controller.js Add JS modules for //ui/file_manager/file_manager/foreground/js/ui/ : - actions_submenu.js - actions_submenu_unittest.m.js Remove tearDown() from actions_submmenu_unittest because now the setUp() always replace the whole DOM content, so the DOM reset in tearDown() isn't necessary anymore. Bug: 1133186 Change-Id: I8ca80a94dd2be9e5f354bcc54b6883b8df3cedd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626678 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#842918}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2881d6b22d1e..44ba8e1708ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib65ede43af21321eb33d7a95b032c1f72eda5c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626460Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a69b4bb071c..be2a8614c5d6 2021-01-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from b9b9a8a5 to 8aca3b4d (503 revisions) 2021-01-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5b8dec52b68f to 2ed9671a0ddd (8 revisions) 2021-01-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 9ff83f6c957f to 424fd828893e (13 revisions) 2021-01-12 mtklein@google.com Revert "sketch Half in skvm" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Test: Test: Test: Aztec Ruins MECTest: Test: Fortnite on ANGLE Change-Id: Icfd629e6053b4280fc21eed25d4def3c80f5428a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625845Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3889691dd695..178c01be65a4 2021-01-13 dberris@chromium.org chromeperf: Anomaly configs in subscriptions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1158326 Tbr: eseckler@google.com Change-Id: I6fe53482f865121820fa4cab5b144194e813a213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627028Reviewed-by:
-
Maksim Sisov authored
.. number_formatting.cc It was required to initialize ICU with InitializeICUForTesting to fix that as WaylandBufferManagerHost may call base::FormatNumber in certain conditions that requires ICU initialized. Also, remove call expectation for zwp_linux_dmabuf_v1.CreateParams as it's not guaranteed that it will be called (if parameters are invalid, zwp_linux_dmabuf_v1 is never called). Last but not least, always check if the terminate gpu callback is fired. If it is fired, set a callback again and continue running current fuzz test case to verify that WaylandBufferManagerHost doesn't crash even after it has already fired one terminate gpu callback that a potential client just ignored. Bug: 1164654 Change-Id: Ia3f0c248a1e9587a63d9d4cc230defc39357e8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624210Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#842914}
-
Junji Watanabe authored
CAS is already available on production, and developers should be able to use it instead of Isolate server. Bug: 1163817 Change-Id: I1ea0333725eb8c6337507605781e9c3e29b4f5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626816 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#842913}
-
Wolfgang Beyer authored
Introduced in https://crrev.com/c/2574985 Bug: 1072335 Change-Id: I57a42b17dafa55c4f7b4c12bae32f72d7be12321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623945Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842912}
-
Vidhan authored
Currently, FieldFiller static_casts AutofillDataModel to either AutofillProfile or CreditCard. These casts are not guarded and may prevent autofilling. This is prevented by introducing absl::variant<const AutofillProfile*, const CreditCard*> and removing the static_casts. Bug: 1147883 Change-Id: I4768c8f60429ede281e4a804512e519af34dc111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560746Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#842911}
-
Ramin Halavati authored
"Signin.Intercept.Guest.Availability" metric is added to record if Guest option is available at signin intercept or not and why. Bug: 1157764 Change-Id: I00dc3bb07b6b6cec758c206b1046a0c2e767d7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620621Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/76d89fa22033..08b9eb7a896f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yukishiino@google.com Change-Id: I9daf3dfd7eb0c419a63096bf3549f5525f5f21d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625844Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842909}
-
Alex Moshchuk authored
Looks like one line of a comment near the end of this function was accidentally deleted in https://chromium-review.googlesource.com/c/chromium/src/+/2230632. This CL restores it. Change-Id: I081e0a184f2468e5e6e60a63446a9fa5cca2a0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626907 Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842908}
-
Sara Kato authored
Bug: crbug/1159562 Test: build Change-Id: Icc582dd5ffe43c94e9d06bf98d4ac470af01ea27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617401Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#842907}
-
Koji Ishii authored
In order to make the function to be more testable and easier to maintian. This patch has no behavior changes. Bug: 762493 Change-Id: Ia0e4838bfa3fec644067dea1edf0e53915931153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612630 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#842906}
-
Simon Zünd authored
Design doc: https://bit.ly/devtools-trust-tokens This CL adds a new getter to the NetworkContext interface to make the current state of the Trust Token store available to DevTools. The information will be shown on the Application tab in DevTools so developers can inspect the Trust Tokens currently available to their site. Bug: chromium:1126824 Change-Id: I69bfc596b1c42fab25bb91d3dd7e3116ec20fd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592990Reviewed-by:
David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#842905}
-
Ramin Halavati authored
Profile picker does not show Guest profiles, it should ignore their addition or removal. Bug: 1166076 Change-Id: I60ea43ed5368e163cbed7fa1aa320ea55c726b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623211 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Theo Johnson-kanu authored
Bug: 1163556 Change-Id: I196b9c9f73fecb169b53ac3d3ed5635a799b7138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625275 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#842903}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e2ffb3742633..26ac0bee0167 2021-01-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-13 soxia@microsoft.com Hide span button for single screen device If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I344bf31701aa28575246297b90dba5f0fbe599e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625840Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/51e1fea7385f..44ba8e1708ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3e41d615239ad27c9926b9db5ef4b89c9c5fa3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626358Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2881d6b22d1e..44ba8e1708ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib25cf0bee1810276529f6a001f3236cd61ae158b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626458Reviewed-by:
-
Thomas Guilbert authored
|VideoFrame::metadata_| is now a value type, and guaranteed to never be null. This CL updates the return value of VideoFrame::metadata() to use a const VideoFrameMetadata&. This should save an indirection every time metadata() is used. Bug: 1096727 Change-Id: I1ba6fb2a9df4605ab0c015d1e92c6a3838276d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604398 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#842899}
-
Yuki Shiino authored
This reverts commit 8a443cd6. Reason for revert: Suspicious about breaking chrome_all_tast_tests. https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-eve-chrome/12106/overview Original change's description: > Reland "Move crostini section under Advanced in settings." > > This is a reland of 3ece5c0f > > Original change's description: > > Move crostini section under Advanced in settings. > > > > Bug: 1163003 > > Change-Id: I9b2b439007c80bc0385128da4817ac001ee7eb0c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610407 > > Auto-Submit: Nicholas Verne <nverne@chromium.org> > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Commit-Queue: Nicholas Verne <nverne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#840920} > > Bug: 1163003 > Change-Id: If8e1b56cda55269d67df5e9aad21464dc9245f5f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623571 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842785} TBR=khorimoto@chromium.org,nverne@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ia2686a1edb8bcc773503329b6a30b34ed891a36e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1163003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626698Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#842898}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3d7f91cf..1e60bce4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0023d7943ed0ab0a8d39651fe80e9bbc722ac50e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625802Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842897}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - fake_file_selection_handler.js - file_selection.js - file_transfer_controller.js - file_transfer_controller_unittest.m.js - holding_space_util.js - path_component.js Bug: 1133186 Change-Id: I410a81add17eeb9a3f4e8d85258bf202f15e42f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622132 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#842896}
-
Yuta Hijikata authored
The change replaces deprecated variable names is_lacros and IS_LACROS with is_chromeos_lacros and IS_CHROMEOS_LACROS. Bug: 1052397 Change-Id: I9d4664ed4f9ef0b95a43e51183f92a29fd0a5040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623611Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#842895}
-
Yuta Hijikata authored
The change replaces deprecated variable names is_ash, is_lacros, IS_ASH, IS_LACROS with is_chromeos_ash, is_chromeos_lacros, IS_CHROMEOS_ASH and IS_CHROMEOS_LACROS. Bug: 1052397 Change-Id: Id8e24910248b5537ba7e558b02be10c2ee7c2a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621793Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#842894}
-
David Black authored
Holding space is enabled for guest sessions but previously redirected to use original profile instead of OTR profile. This caused: - Thumbnails to fail to render - Opening Files app via util to fail These failures are due to expectations further downstream that guest sessions use OTR profiles. To address this: - Redirect to primary OTR profile in holding space for guest sessions - Allow OTR profiles in FileChangeService for guest sessions Note that FileChangeService was previously *not* created for OTR profiles but they will now be allowed if the profile is a guest session. This CL also modified FileChangeService to *not* create the service w/ the browser since the service does not need to exist until interacted with. Bug: 1165733, 1164329 Change-Id: I032aea25171594bdb0666c87564a80f7c0cfe203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625799 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#842893}
-
Asami Doi authored
This CL fixes origin comparison on IsSameOriginClientContainerHost() for blob url workers. This fixes WPTs for clients.claim() when PlzDedicatedWorker is enabled. Before this CL, IsSameOriginClientContainerHost() took an origin from ServiceWorkerContainerHost::url() that returns GURL. However, this didn't work when the function returns a blob url (e.g., when the container host is for a blob url worker) because GURL::GetOrigin() cannot retrieve an origin from blob URLs (see https://crbug.com/1144717). After this CL, the function takes the origin from ServiceWorkerContainerHost::GetUrlForScopeMatch(). Even for blob url workers, this returns a non-blob URL inherited from their parent. It should be valid to take the origin from the alternative URL because it's guaranteed that they are in the same origin. This might not align with the spec based on the discussion in the issues, but we implement this to keep compatibilities: - https://github.com/w3c/ServiceWorker/issues/1265 - https://github.com/w3c/ServiceWorker/issues/1554 Bug: 1017034 Change-Id: Ia167c1acaa665ac08e433d37f78d4c5b22383ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600420 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#842892}
-
Sammie Quon authored
This patch tries to different between users who want to use the trackpad to quickly switch desks and users who use the trackpad to look at the contents of adjacent desks. For the former, we introduce a threshold of 500ms. If the user ends their swipe within 500ms, we will move them to the next desk if the next desk is more than 10% visible. For the latter, we keep the old logic of moving them to the desk which is most visible when the swipe ends. Also lowers the threshold when starting a swipe. We had some feedback that this was too high. Bug: 1158065, 1158067 Test: manual, added tests Change-Id: I9feb8f8a8f591227f883d58bfe9c38b1653f7fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617044 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#842891}
-
Yoshifumi Inoue authored
This patch changes |Text:splitText()| to avoid having empty |LayoutText| as other text modifying functions, e.g. deleteData(), replaceData() to reduce changes that AX tree having AX objects with empty |LayoutText|. Note: The root cause of issue 1149171 is |Range#insertNodes()| calling |Text#splitText()| with offset 0. Bug: 1149171 Change-Id: Ibfecb14111ff16f3901fe23cdba6d3fcae1ddda1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623371 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842890}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d79335daa04a..76d89fa22033 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150968 Tbr: yukishiino@google.com Change-Id: Ia02af77d9c9551bfdb0d8ab2cc59dbcec1716b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625818Reviewed-by:
-
Xiaohan Wang authored
Add this metrics to help track EME session type usage. Manually tested on Shaka Player Demo and saw the following in about://histograms: Histogram: Media.EME.Widevine.CreateSession.SessionType recorded 1 samples, mean = 1.0 (flags = 0x41) 0 O (0 = 0.0%) 1 ------------------------------------------------------------------------O (1 = 100.0%) {0.0%} 2 ... Tbr: foolip@chromium.org Bug: 1165438 Test: See above Change-Id: Ie6482f0f66b94d743866304ff56eef8d7cf0b2e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622724Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
-
Simon Jackson authored
The `MediaRecorder` spec was recently updated to allow either constant bitrate (CBR) or variable bitrate (VBR) encoding to be specified with `MediaRecorderOptions`, previously VBR was assumed when using anything other than uncompressed PCM. This change adds support for the updated specification and for enabling the hard CBR mode of the Opus encoder when CBR mode is configured for the `MediaRecorder`. Intent-to-ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/ewJTgBMTxGg/m/w2qGgVCeAQAJ Bug: 980559 Change-Id: I2e4d6305e951dedfbbcd2447b69fc4f81209a3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731907Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Felicia Lim <flim@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#842887}
-
Regan Hsu authored
* Disconnect button is now a single chromevox stop. * Feature title and labels are no longer chromevox stops. "Learn more" link is still a tab stop though, because it's actionable. * Tooltip icon now announces tooltip content. Fixed: 1163773 Bug: 1106937 Change-Id: I7e97743d53ccf55128e18f5210ac35350ac3b0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618521 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#842886}
-
Kuo Jen Wei authored
Bug: b/176266123 Test: Manually test grid line transition animatation when toggling and change grid type in grid setting. Change-Id: I91653609c0eea082de8091bc1b45a8a1f301d6d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626695 Commit-Queue: Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#842885}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c13ea848e6b5..fdd89469d681 2021-01-13 jzern@google.com update stale codereview.chromium.org links If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I41183926532ee2506b8072dbafddbfad4c7119c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626908Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/22eff1eb8c2f..7faa362ea9c2 2021-01-12 shrekshao@google.com Fix SamplerFilterAnisotropicTests mipmap 2021-01-12 dsinclair@chromium.org Convert WGSL comments to // If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ic56b7d7ab7199e9e4e54348746cda08252c63eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626456Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610485069-629e2dfa0196177c8ad81665d7b0a927aebce730.profdata to chrome-win32-master-1610495996-5598384ad8a00037e18a56fd00981ea765e31cd1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If883530a91fd7799828ae6824d69cff7ad53a900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626371Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d38b9f86ff8c..2ed9671a0ddd 2021-01-12 cnorthrop@google.com State: Provide reference to image unit binding vector 2021-01-12 jmadill@chromium.org Vulkan: Add YUV G8_B8_R8_3PLANE_420_UNORM format. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: Aztec Ruins MEC Change-Id: I4fe0c1c2a41b7105947fa8098cc12e9630118392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626093Reviewed-by:
-
Yuta Hijikata authored
This change renames deprecated macro IS_LACROS to IS_CHROMEOS_LACROS. Bug: 1052397 Change-Id: I55fe9e33983a75f340d953b12c8c72d69b7eee6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623733Reviewed-by:
-
