GitLab

- remove the profile preference that used to keep track of showing the
tutorial any time the user manager was shown for a particular profile.

- show the upgrade bubble for local profiles as well (so that local profiles
have a chance to see the tutorial)

- for the local profiles upgrade bubble, don't show the "Not you?" link as
it doesn't really make sense.

BUG=399679
TBR=rpetterson@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288817

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289005

Review URL: https://codereview.chromium.org/454153002

Cr-Commit-Position: refs/heads/master@{#289636}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289636 0039d316-1c4b-4281-b951-d872f2087c98

Implementation of the Battery Status API for the Windows platform.
Implementation uses a message window to receive battery notifications.
On versions prior to Vista there is limited support as the
RegisterPowerSettingNotification function is not available.

BUG=122593
TEST=http://jsbin.com/battery-status-test (manual)

Review URL: https://codereview.chromium.org/447853002

Cr-Commit-Position: refs/heads/master@{#289634}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289634 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/1633

BUG=55915
TBR=avi@chromium.org

Review URL: https://codereview.chromium.org/470953003

Cr-Commit-Position: refs/heads/master@{#289632}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289632 0039d316-1c4b-4281-b951-d872f2087c98

This prefix was added in https://src.chromium.org/viewvc/chrome?revision=207246&view=revision,
and even then it was a no-op. Despite the no-op-ness, the test flakiness
was fixed over a year ago (see bug).

Now the prefix serves only to it only serves to confuse sheriff-o-matic.

BUG=251742
TBR=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/475063002

Cr-Commit-Position: refs/heads/master@{#289631}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289631 0039d316-1c4b-4281-b951-d872f2087c98

Usign an empty scopes set leads to a server response "code: BAD_REQUEST,
http status: 400, MISSING_SCOPE" on iOS. This CL uses a non-empty
scopes set for the account id tracker.

BUG=NONE

Review URL: https://codereview.chromium.org/472773002

Cr-Commit-Position: refs/heads/master@{#289630}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289630 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402766
TBR=xhwang@chromium.org

Review URL: https://codereview.chromium.org/476683003

Cr-Commit-Position: refs/heads/master@{#289628}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289628 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/472903002

Cr-Commit-Position: refs/heads/master@{#289627}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289627 0039d316-1c4b-4281-b951-d872f2087c98

GetOpenFileName can cause 3rd-party shell extensions to be loaded into the caller's process. By putting it in a separate process we protect the browser process from potential instability.

BUG=73098

Review URL: https://codereview.chromium.org/419523006

Cr-Commit-Position: refs/heads/master@{#289625}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289625 0039d316-1c4b-4281-b951-d872f2087c98

This change adds atomic operations for MIPS64.

BUG=400684

Review URL: https://codereview.chromium.org/450343002

Cr-Commit-Position: refs/heads/master@{#289624}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289624 0039d316-1c4b-4281-b951-d872f2087c98

Extensions won't get installed if they declare a managed storage schema
and the schema is invalid. But if the schema is modified or deleted
after the extension is installed then this CHECK will be hit whenever
Chrome restarts.

If the schema is modified or becomes invalid then the managed storage
API won't pickup the right policies for the extension, but that's
better than crashing the browser.

BUG=399208

Review URL: https://codereview.chromium.org/464893002

Cr-Commit-Position: refs/heads/master@{#289623}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289623 0039d316-1c4b-4281-b951-d872f2087c98

The CL adds tests for 

 * Copy
 * Delete
 * Zip

operations of the class.

BUG=315439
TEST=run the test

Review URL: https://codereview.chromium.org/460963002

Cr-Commit-Position: refs/heads/master@{#289622}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289622 0039d316-1c4b-4281-b951-d872f2087c98

The feature will work only when the flag is on.

BUG=305511
TEST=Confirms the cast icon doesn't appear when the flag is off.

Review URL: https://codereview.chromium.org/471903002

Cr-Commit-Position: refs/heads/master@{#289621}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289621 0039d316-1c4b-4281-b951-d872f2087c98

TBR=asvitkine@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/475653002

Cr-Commit-Position: refs/heads/master@{#289620}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289620 0039d316-1c4b-4281-b951-d872f2087c98

BUG=388504
TEST=build
TBR=sky@chromium.org for include fix under chrome/browser

Review URL: https://codereview.chromium.org/470523002

Cr-Commit-Position: refs/heads/master@{#289619}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289619 0039d316-1c4b-4281-b951-d872f2087c98

Due to the latency of running separate shell commands, the length of a test
could sometimes be largely incorrect with respect to the cpu idle sample
times, causing c-state residency percent of some states to be several
points below zero.

BUG=336561

Review URL: https://codereview.chromium.org/425133002

Cr-Commit-Position: refs/heads/master@{#289618}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289618 0039d316-1c4b-4281-b951-d872f2087c98

R=pbos@chromium.org, ronghuawu@chromium.org
TBR=ronghuawu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/475833002

Cr-Commit-Position: refs/heads/master@{#289617}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289617 0039d316-1c4b-4281-b951-d872f2087c98

This eliminates the ENABLED_COMPONENT state, and fixes the path CHECK failure.

BUG=402377

Review URL: https://codereview.chromium.org/462533002

Cr-Commit-Position: refs/heads/master@{#289616}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289616 0039d316-1c4b-4281-b951-d872f2087c98

BUG=311897

Review URL: https://codereview.chromium.org/463113002

Cr-Commit-Position: refs/heads/master@{#289615}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289615 0039d316-1c4b-4281-b951-d872f2087c98

The URLFetcher will send an X-Privet-Auth token, which it gets from the
delegate, for PrivetV3. It will not send an X-Privet-Token.

BUG=

Review URL: https://codereview.chromium.org/454623002

Cr-Commit-Position: refs/heads/master@{#289614}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289614 0039d316-1c4b-4281-b951-d872f2087c98

This is the last patch to get the About overlay showing in the Settings page
on Chrome OS when Settings in a window is enabled, so that we can hide the
uber navigation frame and truly display Settings in its own window.

BUG=379348
R=dbeam@chromium.org,ben@chromium.org

ben: please review:
    chrome/browser/browser_about_handler.cc
i hope i'm not doing anything blasphemous here!

Review URL: https://codereview.chromium.org/449623003

Cr-Commit-Position: refs/heads/master@{#289613}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289613 0039d316-1c4b-4281-b951-d872f2087c98

According to http://chromium-build-logs.appspot.com/gtest_query?gtest_query=ServiceWorkerBrowserTest.Reload this test failed only on Android after r288301.

BUG=393486

Review URL: https://codereview.chromium.org/475543005

Cr-Commit-Position: refs/heads/master@{#289610}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289610 0039d316-1c4b-4281-b951-d872f2087c98

This reduces telemetry_perf_unittests by 30s.

BUG=388256

Review URL: https://codereview.chromium.org/474493002

Cr-Commit-Position: refs/heads/master@{#289609}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289609 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402931
TEST=manually tested

Review URL: https://codereview.chromium.org/477603002

Cr-Commit-Position: refs/heads/master@{#289608}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289608 0039d316-1c4b-4281-b951-d872f2087c98

Nothing sets or uses the position, its name suggests nothing will.

R=enne

Review URL: https://codereview.chromium.org/470753002

Cr-Commit-Position: refs/heads/master@{#289607}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289607 0039d316-1c4b-4281-b951-d872f2087c98

On my L-release flash, dumpsys has version number 9 now.

However, it still seems to work with the dumpsys power monitor parser, so I think we should allow it to accept 9 also.

BUG=

Review URL: https://codereview.chromium.org/474653002

Cr-Commit-Position: refs/heads/master@{#289606}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289606 0039d316-1c4b-4281-b951-d872f2087c98

This allows both to be used while Blink and the tests are transitioned.

BUG=385874

Review URL: https://codereview.chromium.org/472493003

Cr-Commit-Position: refs/heads/master@{#289605}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289605 0039d316-1c4b-4281-b951-d872f2087c98

This avoids oversleeping.

BUG=388256

Review URL: https://codereview.chromium.org/464343004

Cr-Commit-Position: refs/heads/master@{#289604}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289604 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402134
TEST=gpu_unittests

Review URL: https://codereview.chromium.org/463673002

Cr-Commit-Position: refs/heads/master@{#289603}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289603 0039d316-1c4b-4281-b951-d872f2087c98

This is the GYP version. The GN change was done in
https://chromium.googlesource.com/chromium/src/+/4eebe74dc1fd6d3780180361f75707a6be33c3ce

BUG=400860
TEST=None
R=jamesr@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/468733002

Cr-Commit-Position: refs/heads/master@{#289602}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289602 0039d316-1c4b-4281-b951-d872f2087c98

Adds loading indicator for long distilled pages.

BUG=383630

Review URL: https://codereview.chromium.org/444143002

Cr-Commit-Position: refs/heads/master@{#289601}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289601 0039d316-1c4b-4281-b951-d872f2087c98

The thread watcher appears to be kicking on when we're trying to
remove a handle. Not sure why. This converts some DCHECKs to CHECKs
and fixes handling of the deadline. I suspect none of this will help,
but it's worth a shot.

BUG=399769
TEST=none
R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288949

Review URL: https://codereview.chromium.org/454433003

Cr-Commit-Position: refs/heads/master@{#289600}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289600 0039d316-1c4b-4281-b951-d872f2087c98

This issue: https://code.google.com/p/chromium/issues/detail?id=398549,
was difficult to debug because gin/shell/gin_shell_unittest.cc didn't verify
that its input files existed before forging ahead.

The unit test now verifies that the gin_shell and hello_world.js paths
exist before launching the former and loading the latter.


BUG=398549

Review URL: https://codereview.chromium.org/471623002

Cr-Commit-Position: refs/heads/master@{#289599}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289599 0039d316-1c4b-4281-b951-d872f2087c98

Disable MigrationSingleClientTest.AllTypesIndividually* since they're timing out sometimes on Windows

BUG=403778
TBR=akalin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/471993002

Cr-Commit-Position: refs/heads/master@{#289598}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289598 0039d316-1c4b-4281-b951-d872f2087c98

Before this patch, when register() fails to install a worker, it would
result in ServiceWorkerRegistrationHandle::OnRegisterFailed nulling out
its reference to the registration in order to allow the registration
to die. This was flawed for two reasons:
- When the handle is destructed, it would dereference the null pointer.
- SWRegistrationHandle is responsible for listening for ref count changes from
Blink-side about the corresponding JavaScript ServiceWorkerRegistration object.
It's a weird state for Handle to forget about the Chromium-side registration
while Blink-side is alive. The Chromium-side Registration lifetime should be
tied to Blink's.

BUG=384119, 396400

Review URL: https://codereview.chromium.org/461233004

Cr-Commit-Position: refs/heads/master@{#289597}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289597 0039d316-1c4b-4281-b951-d872f2087c98

This reverts https://src.chromium.org/viewvc/chrome?revision=288555&view=revision

It caused ASAN failures on the Blink Linux ASAN bots.

BUG=403412,400158

Review URL: https://codereview.chromium.org/470683002

Cr-Commit-Position: refs/heads/master@{#289596}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289596 0039d316-1c4b-4281-b951-d872f2087c98

of pending transactions for PUT/DELETE operations independently.
It means that both counters counts the operation for the entry, if an entry is put and deleted.


BUG=347425
TEST=./unit_tests --gtest_filter="LevelDBWrapper*"

Review URL: https://codereview.chromium.org/466373004

Cr-Commit-Position: refs/heads/master@{#289595}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289595 0039d316-1c4b-4281-b951-d872f2087c98

GL drivers are allowed to generate errors when NaN is supplied to
functions under GLES 3.0 section 2.1.1 or OpenGL 4.5 section 2.3.4.1.
NVIDIA OpenGL driver generates an error when NaN is supplied to
glLineWidth. Make this behavior consistent for Chromium, which removes
the possibility of drawing with an undefined line width, and makes sure
that errors don't leak from the GL driver.

BUG=402847
TEST=WebGL conformance tests on debug build with virtual contexts,
gpu_unittests

Review URL: https://codereview.chromium.org/469673003

Cr-Commit-Position: refs/heads/master@{#289594}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402811

Review URL: https://codereview.chromium.org/454083002

Cr-Commit-Position: refs/heads/master@{#289593}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289593 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403033

Review URL: https://codereview.chromium.org/467853002

Cr-Commit-Position: refs/heads/master@{#289590}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289590 0039d316-1c4b-4281-b951-d872f2087c98

Using EXPECT_EQ(false, condition_expr) assertion gets the following error with gcc 4.8.x toolchain on linux
when building unit test:

error: converting ‘false’ to pointer type for argument 1 of ‘char testing::
internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Werror=conversion-null]

It is a mysterious problem occurred in gtest. Only EXPECT_EQ(false, condition_expr) cause the compile error, while EXPECT_EQ(true, condition_expr) can work well.

BUG=139326
TBR=rkc@chromium.org

Review URL: https://codereview.chromium.org/474773003

Cr-Commit-Position: refs/heads/master@{#289586}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289586 0039d316-1c4b-4281-b951-d872f2087c98