- 12 Nov, 2019 40 commits
-
-
Askar Aitzhan authored
The experiment CloudPolicyOverFCM was tested on 50% Dev and Canary and the result were expected. Prior to moving to 50% Beta the experiment is added to Field Trial Testing Config. The results of experiment: * https://screenshot.googleplex.com/6ZNs6sQ7QxM Bug: 939039 Change-Id: Id8d7107a93d64a93f3b8363909fd691af517cab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906215Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Cr-Commit-Position: refs/heads/master@{#714478}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f34cdc70ca1b..37dcb894574e git log f34cdc70ca1b..37dcb894574e --date=short --no-merges --format='%ad %ae %s' 2019-11-12 johnkslang@users.noreply.github.com Merge pull request #1973 from KhronosGroup/fix-fmod-int Created with: gclient setdep -r src/third_party/glslang/src@37dcb894574e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,cnorthrop@google.com Bug: None Change-Id: I51cf1697dfe9418e362d025ba447a2158d5df73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910791Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714477}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/229035db8cc6..bd27b14638e4 git log 229035db8cc6..bd27b14638e4 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 mbonadei@webrtc.org Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."" 2019-11-12 danilchap@webrtc.org Mark scoped_refptr move and swap operations as noexcept 2019-11-12 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." 2019-11-12 mbonadei@webrtc.org Add 2 more RTC_EXPORT. 2019-11-12 yvesg@webrtc.org Fix NetworkEmulationManagerTest.ThroughputStats flakiness (again). Created with: gclient setdep -r src/third_party/webrtc@bd27b14638e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Iee5d33aa45af765b261f53a8385ad7548ce9f6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910789Reviewed-by:
-
Charlie Hu authored
Changing the frame policy when a navigation is already in-flight must not affect the in-flight navigation because of https://html.spec.whatwg.org/multipage/iframe-embed-object.html#attr-iframe-allow The snapshot is made at the beginning of a local_frame_client navigation and used on document initialization(after commit of navigation). If the frame owner is a remote one, the old value is used. - capture frame policy at the start of navigation - local_frame_client_impl - NavigationInfo - render_frame_impl.BeginNavigationInternal - pass it from renderer process to browser process through CommonNavigationParams in navigation_params.mojom - MakeCommonNavigationParams - use value in CommonNavigationParams to init navigation_params - render_frame_impl.CommitNavigationInternal - web_navigation_params -> DocumentInit -> Document::InitializeFeaturePolicy More detailed information could be found on crbug page. A document_loader_test is added to further strengthen the test on frame policy value used. Verified that the added test would fail without the patch. Bug: 972089 Change-Id: I694aa46b6e8e04bebc86b0e7886b856a9a302905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796119Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#714475}
-
Yoshifumi Inoue authored
This patch makes |NGFragmentItem::GetWritingMode()| not to crash for |kGeneratedText| for preparation of migrating |NGFragmentItem|. Below is sample stack trace when |GetWritingMode()| called with kGeneratedText Sample file: fast/css/text-overflow-ellipsis.html - NGFragmentItem::GetWritingMode() - NGFragmentItem::IsHorizontal() - WriteTextFragment() - Write() - Write() - Write() - LayoutTreeAsText::WriteLayers() - LayoutTreeAsText::WriteLayers() - LayoutTreeAsText::WriteLayers() - ExternalRepresentation() - ExternalRepresentation() - WebFrameContentDumper::DumpLayoutTreeAsText() Bug: 982194 Change-Id: Iae8a55a3fff57a487ac9d21c47c06fd19cae2c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911345 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714474}
-
Roger Tawa authored
Added more permutations of the combination of: - has / doesn't have feature flag - has / doesn't have policy set - has / doesn't have DM token Tests for the secondary policies will be added along with those features. Bug: 1021940 Change-Id: Ic0d105d41d3f8ba3aa71a6880ce974d48dfac051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904114 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#714473}
-
Vadym Doroshenko authored
Bug: 959776 Change-Id: I1398b271633dd731a363b32b2c69a67764f0aa6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911204 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714472}
-
Mia Glaese authored
Fix bug that tab carousel is hidden any time a tab is closed. Added corresponding test. Bug: 982018 Change-Id: I59cc4709fc322e509bcb48575b10f32bcca14ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910427Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#714471}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7b689b5ced7d35d672ee08974888f6af810f5554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910790Reviewed-by:
-
Rob Buis authored
The following mappings are performed: dir => direction mathbackground => background-color mathcolor => color mathsize => font-size See https://mathml-refresh.github.io/mathml-core/#global-attributes Note that the mapping of display, displaystyle, mathvariant and scriptlevel will be added later. Bug: 6606 Change-Id: I1b00c2981071dc1127570a5f7351f8b8e2b89357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908533 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#714469}
-
Alex Chau authored
- Also log network error - Log net::OK(0) when ResponseHead is not present Bug: 1021896 Change-Id: I0da6ccda68c5b914349cdc011752897e2e10bcd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901470 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#714468}
-
Alex Chau authored
- Disabled ClickToCall/SharedClipboard SyncTurnedOff browser test when UnidoOnSignIn is on as it no longer applies - Disabled Sharing registration when device is in local sync mode if deriving VAPID key as derived key is not availalbe in local sync mode - Add DeviceInfo to allowed type in transport mode in sync_integration_tests when UnidoOnSignIn is on Bug: 1009516 Change-Id: I59a48d6feb2aee941ae6adb867c3a72c1ce70f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905946 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#714467}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/867f8c92ed1a..b9b1bae4effb git log 867f8c92ed1a..b9b1bae4effb --date=short --no-merges --format='%ad %ae %s' 2019-11-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 3e4abc9ac382..12e54dae167c (1 commits) Created with: gclient setdep -r src/third_party/angle@b9b1bae4effb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:None Change-Id: I188d0376588fe44d4a3096953ec5b3c19bccf8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911959Reviewed-by:
-
Thomas Tellier authored
Bug: 1010259 Change-Id: I1c05b5cee396cb3bfa9ecf91e5f15700958d73aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900000 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#714465}
-
Henrique Ferreiro authored
Move blink::WebIDBDatabaseException into //third_party/blink/public/mojom/indexeddb.mojom. Bug: 1022358 Change-Id: I77cd44bb7bad473692342d49070771632348fe30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899612Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#714464}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/29cbe0b3..e8fc00fb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9989c1ff7f0910ee3da24fce721408de11c2cb7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911244Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714463}
-
Roman Sorokin authored
Bug: 750060 Change-Id: Ie27b75f03835c7cf64cedea5b06f34a441b33216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900994Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714462}
-
Dominik Röttsches authored
Work around a crash reported in issue 1022968 occurring mostly on Windows 7 SP1 systems where SkFontMgr is unable to get instantiated. If that happens, do not attempt calling matchFamilyStyleCharacter() on a null SkFontMgr. Bug: 1022968 Change-Id: I5358fe982ba85c65285b965a816a16f94aa11287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911783Reviewed-by:
-
Ilya Nikolaevskiy authored
This change reflects change in Webrtc API: Now update_rect in VideoFrame is optional and should only be set if capturer knows that update is contained in some rect and is close to it. Bug: webrtc:11058 Change-Id: Ia8bbfb8dfbd0c51828386a8b2420d0053dfaa259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911784 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#714460}
-
Nikita Podguzov authored
* Move CupsWrapper to separate class * Move heavy tasks to inner CupsWrapper::Backend class Bug: 996785 Change-Id: I481e0df807017ee7e1221473baacf0d2f1a52d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904170 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#714459}
-
Javier Fernandez authored
The test word-break-break-all-inline-006.html is incorrectly defined, as it was agreed in the corresponding CSS WG issue [1]. This CL changes the expected result of the test and updates the TestExpectations accordingly, since it was failing for LayoutNG before. The new expected result matches current LayoutNG's and Gecko's behavior, but it implies that it fails in legacy and WebKit. [1] https://github.com/web-platform-tests/wpt/issues/19903 Change-Id: Ia31c89f1a4084607fbb29fd0422354b754a092d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905549 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/faf13a0c3fdc..ed16d1d29e2f Created with: gclient setdep -r src-internal@ed16d1d29e2f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id5b683752502cab04d60a3f50ff4c294f2da5c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910738Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714457}
-
Yoshifumi Inoue authored
This patch makes |LayoutText::AbsoluteQuadsForRange()| to utilize |NGInlineCursor| for prepration of migrating to |NGFragmentItem|. Bug: 982194 Change-Id: I53a0fc41f6d9dc52823949382864aa3c7f91211a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910988 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Migrates RetrieveDMToken calls to use the new BrowserDMToken class. Bug: 1020296 Change-Id: I4ae3d33f228d418ddd7444a4ea5a1094ec2db1d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909889Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#714455}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8cbb33c0d04b..229035db8cc6 git log 8cbb33c0d04b..229035db8cc6 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 mbonadei@webrtc.org Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."" 2019-11-12 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." Created with: gclient setdep -r src/third_party/webrtc@229035db8cc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I08a88843c87688600d8f102a3f5354766a1f648f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910786Reviewed-by:
-
Harald Alvestrand authored
Bug: chromium:1023736 Change-Id: I38f81d9445741321e61e84145591a5e589364b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911203Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#714453}
-
Rohit Rao authored
This feature prevents tabs from stacking and constraining themselves to the width of the tabstrip, instead allowing the tabstrip to scroll horizontally as a normal scroll view would. This is done in preparation for enabling this mode when VoiceOver is on, to fix a bug where stacked tabs would not properly become visible when focused by VoiceOver. Tabs continue to be stacked by default. A new feature flag is added to force "unstacked" mode, and a second feature flag is added to enable unstacked mode whenever VoiceOver is running. BUG=979803 Change-Id: I4e4ad9f53cad1c43a0ad8d16917bd848ac2142fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833741 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#714452}
-
Jit Yao Yap authored
Sync changes from https://critique.corp.google.com/#review/277300793 to client side. Change-Id: Ife0ce7048700f84879bb2c978fe8e251c378b79c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910223Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#714451}
-
Antonio Gomes authored
CL converts the uses of base::BindOnce and base::BindRepeating in renderer/platform/peerconnection to use their WTF counterparts. BUG=787254 R=guidou@chromium.org Change-Id: I2f450c10a0e35525283ef281e5746b36ef0c8490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908925 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Olya Kalitova authored
Shows container configuration dialog while default Crostini container is being configured using Ansible and provided by policy Ansible playbook. Based on: https://crrev.com/c/1813342 --gtest_filter="Ansibe*" && browser_tests --gtest_filter="Crostini*" Test: unit_tests --gtest_filter="Crostini*" && unit_tests Bug: 998097 Change-Id: I856c16e4c63db3a3f96e0a3337bad9eba5745c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893264Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#714449}
-
Andreas Haas authored
Crashes caused by the OOM_CRASH macro are currently not classified as OOM crashes by Chrome Crash at the moment. The reason is that Chrome Crash analyzes the stack trace to do the classification, and OOM_CRASH does not show up in the stack trace at the moment. This CL changes OOM_CRASH to call the NOINLINE function OnNoMemory, which then causes the crash. Thereby the OOM crash is visible on the stack trace and can thus be classified correctly by Chrome Crash. R=rmargold@chromium.org, yuzus@chromium.org Bug: chromium:1019661 Change-Id: Id1a755076db4464b5de9a36aaf4ddeaa9a7dbc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906148 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
-
Stephen Nusko authored
This reverts commit f8dd1ecf. Reason for revert: Seems to be causing the mac-builder-perf to fail (see linked bug). Original change's description: > Capture test_api.js javascript dependencies in 2 places (rather than ~13). > > test_api.js depends on a bunch of JS libraries that appear in many lists. > > This CL consolidates those dependencies to two places: > - js2gtest.gni, and > - A JsTestApiConfig class declared in chrome/test/base/js_test_api.h > > Note not all lists captured the axs_testing.js dependency, but this change > uses the same dependency list in all locations for consistency. > > TBR=aboxhall@chromium.org (mechanical change) > > Bug: 1000989 > Change-Id: If6e0716c03e42783a2d3529baa70475a9d305045 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900512 > Commit-Queue: Trent Apted <tapted@chromium.org> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714421} TBR=tapted@chromium.org,dbeam@chromium.org,aboxhall@chromium.org,blundell@chromium.org Change-Id: I3d93382a9833f85aabe2eb0e0469c16e451c65ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1000989,1023795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911748Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#714447}
-
Bo Liu authored
See documentation on Reference.reachabilityFence for why this is needed. Change-Id: I38e51364a5bf6542be65904ea30b0c65fd8dbe2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887151 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#714446}
-
Anqing Zhao authored
To support uploading usage data for Chrome OS. We need support ChromeOsUserReport in CloudPolicyClient similar to ChromeDesktopReport. Bug: 1010213 Change-Id: I7c6467fcbd8b1f5f6d6bb68fae3bc1af52601eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893195 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#714445}
-
Jinsong Fan authored
For the writing-mode: vertical-*, the bounds of the selection are horizontal, so the variable names of |top| and |bottom| are confused. The |start| and |end| are more better, the CL adjusts the variable names through the entire call chain for consistency. Bug: 1015274 Change-Id: I724c9720c998586d00c98c090dd1ea7da55e645d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897555Reviewed-by:
AJITH KUMAR V <ajith.v@samsung.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#714444}
-
Giovanni Ortuño Urquidi authored
Remove createRequest() and createProxy(). Bug: 968369 Change-Id: Iecccafcbe8189e70e6426a5b947b9e6e0e5b134d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906849Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#714443}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3e4abc9ac382..12e54dae167c git log 3e4abc9ac382..12e54dae167c --date=short --no-merges --format='%ad %ae %s' 2019-11-12 ehsannas@gmail.com Update Offset to ConstOffset bitmask if operand is constant. (#3024) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@12e54dae167c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,cnorthrop@google.com Bug: None Change-Id: I2323c371aadb7bcedc8cf0d889320626154036a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911685Reviewed-by:
-
Gabriel Charette authored
Details @ https://docs.google.com/document/d/13PIBPuSPJbrgHAgyRbY22EWAfH2narnxpa_CgBmZbSY/edit R=fdoray@chromium.org Bug: 1022972 Change-Id: I89b0404b28c92fc144b40352eed95a847f1a19ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906637 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#714441}
-
Mitsuru Oshima authored
* frame mode is either normal, immersive (auto hide) or none if the window is frameless. * frame is visible if the frame is fully visible (normal, maximized), or revelaed state in immersive. Bug: 1021604 Test: covered by unittests Change-Id: I62f2e176af3d690fb4a8c7da557c0ba522d7eea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906951Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ricardo Quesada <ricardoq@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#714440}
-
Stephen Nusko authored
It was already disabled for nexus5 and nexus5x but its failing now on, pixel2 and nexus6x. It only seems to run and pass on linux-perf. NOTRY=true TBR=crouleau@chromium.org Bug: 1023792,894147 Change-Id: Ie183a3715d0b32e7ab378ea21187bea598555cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911744Reviewed-by:
-
