- 10 Aug, 2020 40 commits
-
-
Ryan Harrison authored
https://dawn.googlesource.com/tint.git/+log/f18d737b4e93..bc80805c4b04 $ git log f18d737b4..bc80805c4 --date=short --no-merges --format='%ad %ae %s' 2020-08-09 dneto [spirv-writer] Infer and emit matrix layout 2020-08-07 sarahmashay [validation] v-0021: cannot re-assign constants 2020-08-06 sarahmashay [Validation] v-0006: variables must be defined before use 2020-08-05 dneto [spirv-reader] Remove support for NumWorkgroups builtin variable 2020-08-05 sarahmashay [validator] implement variable_stack_ Created with: roll-dep src/third_party/tint/src Change-Id: I3531ae47e02d7b10f2317d40b85052eeb32ee125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346330 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#796578}
-
Alexander Surkov authored
suitable for nested attribute calls Bug: 1100991 AX-Relnotes: n/a Change-Id: Ib0c4512242bad94abf8a0231e129951172e6b584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274545 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#796577}
-
Xianzhu Wang authored
It was to return the visual rect calculated from the cc::Layer's bounds. It has been doing nothing since we removed DisplayItemClient::VisualRect(). Change-Id: I9104ab23fdd58b4b9362e0c6f4babeef2680e24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346993Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796576}
-
Gayane Petrosyan authored
Mockito is unable to mock WindowAndroid for Android L, because it uses Display.Mode that was added in Android M. Changing tests to use BaseRobolectricTestRunner as unit tests are good enough for these tests and it also uses sdk 28, which solves the issue. Bug: 1111408 Change-Id: I1635fcb0ac62372d1a364fd2f72f1fad7927f88f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346790Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#796575}
-
Mark Pearson authored
Bug: 1108130 Change-Id: I455ec24f639ca920d94a4018939f3c602a778c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346966Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#796574}
-
Sebastien Lalancette authored
- Adds a Share action definition to the action factory, - Adds a Share action to the History context menu, - Move the Copy action to comply with UX's actions sorting, - Adds HistoryEntry as a Sharing scenario, with metrics and all. Bug: 1093302 Change-Id: Iebb8a36e60b823c3adc8ba609373ff27d8b3f7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333684 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#796573}
-
Dale Curtis authored
In preparation for VP9 support, consolidate the multiple paths for creating VTDecompressionSessions. We had one that was exclusively for sandbox startup and one for normal decoding. These can be the same thing, with an admittedly large number of parameters. R=sandersd Bug: 1103432 Change-Id: Ic87d9e0e3aef69f7b7356af4d1060f4c55983943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346995Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#796572}
-
Scott Violet authored
This reverts commit 0745b831. Reason for revert: We still have 10.10 bots on the waterfall. This breaks the Mac10.10 bot. See https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/56807 and the blink_python_tests . Sample error: [1690/1762] blinkpy.web_tests.servers.cli_wrapper_unittest.CliWrapperTest.test_main_server_error_after_start failed unexpectedly: Traceback (most recent call last): File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper_unittest.py", line 54, in test_main_server_error_after_start argv=[]) File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper.py", line 87, in main port_obj = host.port_factory.get(options=options) File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/port/factory.py", line 91, in get self._host, port_name, options=options, **kwargs) File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/port/mac.py", line 71, in __init__ assert self._version in self.SUPPORTED_VERSIONS AssertionError Original change's description: > Remove retired mac versions from blinkpy. > > This cl removes blinkpy support for Mac10.10, Mac10.11, and Mac Retina. > blink web tests for these versions has been removed from waterfall. > > Bug: 1077312, 1107003, 1114680 > Change-Id: I819d0bf7316119b2f5bc127f6eda1deaba7e0cd9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343548 > Commit-Queue: Ilia Samsonov <isamsonov@google.com> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796476} TBR=wangxianzhu@chromium.org,isamsonov@google.com Change-Id: I196b5f27ab989ea18e0ebccf2164f578826b6a68 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1077312 Bug: 1107003 Bug: 1114680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347326Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#796571}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/c626b912dc45..9f09e3fd0930 2020-08-10 rharrison@google.com Roll 5 dependencies and update expectations (#1129) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Id4aec573c21c9b7b8c82779bce352d54018b1fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346858Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796570}
-
Wei-Yin Chen (陳威尹) authored
Features.InstrumentationProcessor is already one of the default test rules in ChromeJUnit4ClassRunner Bug: 1114451 Change-Id: I86f7e2cdaaa48282d0791d891e326ed6fa8f9fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344806Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796569}
-
Matt Menard authored
This external data policy is used to handle the DeviceExternalPrintServers policy which corresponds with the existing ExternalPrintServers policy used to manage a list of print servers. Bug: 1100777 Change-Id: I86028c0451212e506001bbdd8dae8010e88d8608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290968 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#796568}
-
Sven Zheng authored
The latest/ash-chromium.txt contains the latest version number. Bug: 1109287 Change-Id: I1797c00ee22720eceb4ea3b43c8d29717b0e6f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343544 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#796567}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id50ac4360650c9319396efaca0a27e717440b940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347307Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796566}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/03b15131d393..531d992f00bb 2020-08-10 saagarsanghavi@google.com Changed naming convention If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112667 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I3432c796d49288ab10457261d461379105173fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347191Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796565}
-
Adlai Holler authored
This allows us to remove the staging flag to use the image's own context as the context for the color space conversion. Bug: skia:104662 Change-Id: Ibe5947dd0be652de11dfbf5d8b1066183eb9ad2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341018Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Adlai Holler <adlai@google.com> Cr-Commit-Position: refs/heads/master@{#796564}
-
Scott Violet authored
This reverts commit 4d9f6afe. Reason for revert: Reason for revert: We still have 10.10 bots on the waterfall. This breaks the Mac10.10 bot. See https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/56807 and the blink_python_tests . Sample error: [1690/1762] blinkpy.web_tests.servers.cli_wrapper_unittest.CliWrapperTest.test_main_server_error_after_start failed unexpectedly: Traceback (most recent call last): File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper_unittest.py", line 54, in test_main_server_error_after_start argv=[]) File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper.py", line 87, in main port_obj = host.port_factory.get(options=options) File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/port/factory.py", line 91, in get self._host, port_name, options=options, **kwargs) File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/port/mac.py", line 71, in __init__ assert self._version in self.SUPPORTED_VERSIONS AssertionError Original change's description: > [blinkpy] Drop mac-retina detection from MacPort > > Also remove Retina tags from all expectation files. > > Bug: 1104846 > Change-Id: If16ec3610f4120628f834a72fe02750e70418320 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346855 > Commit-Queue: Robert Ma <robertma@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Auto-Submit: Robert Ma <robertma@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796546} TBR=wangxianzhu@chromium.org,robertma@chromium.org Change-Id: I62bf3d1704dd3740f16a69e3c9bdf834a379a82c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1104846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347250Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#796563}
-
Jeongwoo Park authored
As RFC 4517 spec, it is printable string not utf8 string. ref : https://tools.ietf.org/html/rfc4517#section-3.3.4 Bug: 1114433 Change-Id: Ic60df7bfc3e4b1d94fb045004006fa068b34e985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315561 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#796562}
-
Toby Huang authored
When working with downstream branches chained to upstream branches, it helps to use `git rebase -i @{u}` twice to pull upstream changes into the downstream branch. Expect a lot of merge conflicts when you do this, as git is often not smart enough to figure out which change happened more recently, and should take precedence. Bug: None Change-Id: Ic742439981d6d63e8d6bd1e10776fa920c88eb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341387Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#796561}
-
Moe Ahmadi authored
The server provided suggestion header map may come with entries that do not correspond to any of the matches. Using that map to display suggestion headers can result in empty headers. This CL fixes that by using the header information in the matches themselves as the source of truth about what headers actually exist in the server response. It also modifies the type annotations to consistently use the "number" type for the suggestion IDs. Bug: 1113447 Change-Id: I5f685595cfe5a295d483447e6965cb77b7c581fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347047 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796560}
-
Fred Mello authored
https://docs.google.com/document/d/1DcIumJ7I-gSFaB0kbrjhfxqvNxKAVvcfKavUVWkxKB0 Bug: 1112872 Change-Id: I3b512197f2969722d5a6cadad18614d5ffd4cac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346849 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#796559}
-
Liquan (Max) Gu authored
Change: * Before - when Profile is not available when PaymentRequest is created, Chrome crashes. After - at the same condition, the transaction becomes off the record. * When Profile is not accessible from the ChromeActivity when PaymentRequest is created, the transaction is dealt with in the manner as in off-the-record mode. Bug: 1114138 Change-Id: Ie5b9064e695dda9939543836201523a899ac9f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342249 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#796558}
-
Ryan Hansberry authored
Partially implement a concrete location::nearby::api::BluetoothClassicMedium, using the shared bluetooth::mojom::Adapter reference in Chrome's Nearby Connections. Also fully implement a concrete location::nearby::api::BluetoothDevice, constructed using the device info returned during device discovery in BluetoothClassicMedium. Only device discovery methods are implemented in this CL. Subsequent CLs will implement methods to create outgoing, or listen for incoming, BluetoothSocket connections. api::BluetoothClassicMedium is a synchronous interface, so this CL converts the following bluetooth::mojom::Adapter methods it consumes to [Sync]: SetClient() and StartDiscoverySession(). Please see design doc go/nearby-chrome-bt for more details. Bug: b:154849033, b:158848873 Change-Id: If603fb716421fdabd756f3ff34b58a69f64f6352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314024Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#796557}
-
Daniele Castagna authored
SkiaRender HW overlays support has been added with various per-platform ifdefs. Since Android and CrOS share a lot of the same code, this CL simply adds defined(OS_CHROMEOS) along with OS_ANDROID in places where the code can be reused by CrOS. Bug: 1114290 Change-Id: I385003892c6013f90d09d8ed8d747372d1f59b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342262Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#796556}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e780571c. With Chromium commits locally applied on WPT: ee8e46f5 "COOP: add redirect WPT tests" a518a41e "Check in wpt if a pointer event has corresponding compat mouse event" 6c2ddda1 "Generate one promise_test() for each image format" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox mstensho@chromium.org: external/wpt/css/css-break external/wpt/css/css-multicol NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I2430db9addaa6d1b7dfdfbb6568f9843afb606b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347264Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796555}
-
Anatoliy Potapchuk authored
There was a mistake in test code, which was creating a race condition when we were setting network state to offline, and KioskLaunchController assumed that we should resume app launch automatically as soon as we have the network connection. Bug: 1109651 Change-Id: I825dd7660e1f256a23f99bc2118ad9d7ce48bd7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346429 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796554}
-
manuk authored
This reverts commit 14f12b97. Reason for revert: As mpearson pointed out, this CL has an unintended affect on HQP suggestions. This is a partial revert. A full revert would fail tests due to other changes since the original CL landed. This revert keeps test changes from the original CL and updates another test. Additionally, it retains a variable rename and formatting change since those have no functional effect and we prefer the newer versions. Original change's description: > [omnibox] Dedup history matches HQP matches. > > This CL filters duplicate history matches in > URLIndexPrivateData::HistoryItemsForTerms used by the HQP. Previously, > we relied on the autocomplete controller's deduping which > 1) may affect performance since it occured after additional processing > of each suggestion (I would guess it's insignificant), and > 2) prevented the HQP provider from making full use of it's allocated > per-provider-limit. > > Also update a few HQP unit tests. > > Bug: 591981 > Change-Id: I1c6ce02050ba1b674e3507368c1a095f5a5b0c6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219027 > Commit-Queue: manuk hovanesian <manukh@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773185} TBR=tommycli@chromium.org,jdonnelly@chromium.org,manukh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 591981 Change-Id: I00ad1ebdcb40163b0eb488dd5771f1b703566aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327955Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#796553}
-
Wei-Yin Chen (陳威尹) authored
Before this CL, when FieldTrials.collectFieldTrials() is invoked, mergeFeatureLists() has not been called, so enabled features are not correctly populated. This makes collectFieldTrials() produce incorrect data, which leads to the crash in applyFieldTrials(). This CL makes sure the enabled/disabled features specified in the command line arguments are visible to FieldTrials. Bug: 1113847, 1102633 Change-Id: I5c49c41c87fd0219c73a967db2ee33dc8237f52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344805Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796552}
-
Livvie Lin authored
Change-Id: I82144f8ae9653006132b7aaef81c4810b8d8cf9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342128Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796551}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7b17f160f76a..ff337e33c90c 2020-08-10 fawazm@google.com [WebAuthn] Add Credential Table 2020-08-10 brgoddar@microsoft.com Add histograms for Devtools Experiments If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1034663,chromium:1107636 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2faad8bb00b68217ebdfb933ea78e32f027c89eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347186Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796550}
-
Matt Wolenetz authored
To prepare for cross-thread HTMLMediaElement+MediaSource API attachments, aka "MSE-in-Workers", this CL decouples the MediaSource object from what is directly registered. A new type, MediaSourceAttachment, is used to register available MediaSource objects, and a simple concrete implementation is included in this type to resolve the underlying MediaSource for use in actual attachment. This CL is needed as a prerequisite for cross-thread attachments because subsequent CLs are significantly complex. They will: 1) Move MediaSourceRegistry singleton creation to modules initializer to ensure it is owned on the main thread, even if a worker thread was the first to need it (see bullet 3, below). 2) Update MediaSourceAttachment to be an interface and move the communication between HTMLMediaElement and the MediaSource to be done via the interface with concrete implementation(s) in modules. 3) Add a cross-thread attachment implementation. This part will be complex, and will be better handled if the existing same-thread behavior and the new cross-thread behavior are distinct implementations of a common attachment interface. Further, having a non-oilpan type (the concrete implementations of MediaSourceAttachment) as the registrable enables the implementations to safely operate when lifetimes of either side of the attachment vary. And such a non-oilpan type must be used as the registrable if the registry singleton's internal initialization is done prior to Oilpan being ready (during the modules initializer). 4) Refine the interface and concrete implementations for performance and quality specific to the types of attachment being used. BUG=878133 Change-Id: I8376f6483142d3653e5d39d76f5a245c80365b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300804Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#796549}
-
Sven Zheng authored
Tests are based on recent jobs: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/829? https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/828? https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/827? Bug: 1111979 Change-Id: Ife35a71ae4a90697ee39ad7c0d8eba23d456a522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347364Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#796548}
-
Xianzhu Wang authored
We should invalidate the tilings only when we are updating tiles for the sync tree. Bug: 1110872d Change-Id: Id00da58c78bf86423eba368085b9a3a75b855e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344808 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#796547}
-
Robert Ma authored
Also remove Retina tags from all expectation files. Bug: 1104846 Change-Id: If16ec3610f4120628f834a72fe02750e70418320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346855 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796546}
-
Etienne Pierre-doray authored
Best effort max tasks always acts like MayBlock. This is to prevent issue where many WILL_BLOCK BEST_EFFORT tasks increase the thread pool capacity, which is undesirable. This new behavior is similar to FixedMaxBestEffortTasks, but keeps the increase around to prevent deadlocks. https://uma.googleplex.com/p/chrome/variations/?sid=4a990d53992445c75cf9665227ab221c Bug: 1026785 Change-Id: I4be2f478c730cc75f8d358665edec72ad651902f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300343 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#796545}
-
Dana Fried authored
Due to cautious rollout of WebUI/tablet tabstrip and hover card preview images, we need more time with these metrics. Bug: 1112398 Change-Id: I97558bc5b715f3f8e401bb021feacec3721489c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343874Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#796544}
-
chrome://flagsMoe Ahmadi authored
Adds chrome://flags/#promo-browser-commands in order to facilitate testing the promo browser commands. For every new command, an option should be added to this flag. Selecting that option would replace the middle-slot promo on the NTP with a mocked promo and replaces the promo URL with command:<ID>. Bug: 1106421 Change-Id: I53e07d8fcdea057f43d9ff086c49a93565d79969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346834Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796543}
-
Kramer Ge authored
CommitOverlays is a more generic IPC that packages multiple overlay configurations for a frame before sending it to browser process. This replaces the CommitBuffer IPC. This CL merely adds CommitOverlays. It does not send multiple buffers using it. This is 3/? CL for overlay forwarding using wl_subsurface. Bug: 1063865 Change-Id: Id71d055bdb14b3d2e97cb2eef8811dca56323899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314665Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#796542}
-
Varun Khaneja authored
Bug: 1104919,1114674,1114498,1114447 Change-Id: I3f795b4084d6c8346a6a9c0ead9719e84be88ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347144 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#796541}
-
Sam Sebree authored
This change uses native_theme_base.cc and controls_refresh.cc to update the styling for the range native controls in dark mode. Bug: 1107287 Change-Id: Id176b010a0be12c192452b0cefcfb9166881ba3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342306 Commit-Queue: Sam Sebree <sasebree@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796540}
-
Becca Hughes authored
We have our own product in Feedback for Kaleidoscope so we should use that for feedback. BUG=1111981 Change-Id: I107a8d9a50557e6e1ffcb308a94ba5760e1c1062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343633Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#796539}
-