GitLab

For the help of comparing two implementation design of "Imperative Shadow DOM
Distribution API", this CL introduces some performance tests.

Some of the tests are micro benchmark tests for each function, assign, assignSlot, assignElements,
insertBefore, and appendChild, that manual slotting mode uses.
In another tests, the performance of the new custom element, <my-detail>/<my-summary> are testes
when assigned nodes are over 100.
In addition, some algorithm　for the new custom element are added to do the previous tests.

Bug: 869308
Change-Id: Ib2ad2f2ea304d0f7ddbb25b5b85e739af7ee465b
Reviewed-on: https://chromium-review.googlesource.com/1214964
Commit-Queue: Kyoko Muto <kymuto@google.com>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591293}

This is a reland of 40a87fcf

The patch was reverted due to fail in windows 'compile confirm no-op'.
Compile failed because of empty linux specific gn component which
resulted after applying sources_assignment_filters on windows builds.
Relanding patch now by refactoring ime_linux gn component.

Original change's description:
> [ozone/wayland] Refactor IME deps for ozone platform
>
> Refactor base/ime components and dependencies for ozone
> plaform integration to avoid cyclic dependencies.
>
> - Groups ui/base/ime common types into their own GN component
>   (ime_types) to break a dependency cycle that ozone ime context
>   integration would cause on ChromeOS.
> - Groups some of ui/base/ime/linux interfaces into their own GN
>   component (ime_linux) to break a dependency cycle that ozone
>   ime context integration would cause on ChromeOS.
> - Move chromeos source files under is_chromeos flag to avoid
>   depending them when chromeos is not used, but ime is needed
>   (kudos to msisov@igalia.com).
>
> Bug: 791920
> Change-Id: I0b1668564dde22c6e2b05ee1323ebbe4a1343475
> Reviewed-on: https://chromium-review.googlesource.com/1193871
> Commit-Queue: Jani Hautakangas <jani.hautakangas@lge.com>
> Reviewed-by: Shu Chen <shuchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590072}

Bug: 791920
Change-Id: I16de600ac66eb53e4e925bc8b8ab292f89a787dc
Reviewed-on: https://chromium-review.googlesource.com/1224370Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Jani Hautakangas <jani.hautakangas@lge.com>
Cr-Commit-Position: refs/heads/master@{#591292}

https://webrtc.googlesource.com/src.git/+log/f682624062b3..e899629be4d8


git log f682624062b3..e899629be4d8 --date=short --no-merges --format='%ad %ae %s'
2018-09-14 buildbot@webrtc.org Roll chromium_revision 2338e7cc..2c0c7dfd (591117:591272)


Created with:
  gclient setdep -r src/third_party/webrtc@e899629be4d8

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I0cdd9575f60e6592463a4b65c0c8e108fbf33d85
Reviewed-on: https://chromium-review.googlesource.com/1226377Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591291}

The current code (using fetch() API) seems to always use cached .ndjson
file, even when server is restarted (on a different .ndjson file), and
Shift-Ctrl-R is used to refresh. This CL changes API use to disable
cache, so when .ndjson files are loaded by data_url, refreshing the
HTML viewer would fetch the up-to-date version.

There does not appear to be a performance cost to this.

Bug: 880671
Change-Id: I9aab99c18895dc52bc9de0ec788c1c617ec06e8f
Reviewed-on: https://chromium-review.googlesource.com/1225652
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591290}

All of CrSearchFieldBehavior users use 'incremental' attribute and
'search' event handler in the same way. So CrSearchFieldBehavior
dispatches CustomEvents named 'search' regardless of existence of
'incremental' attribute, and 'search' event handlers continue to work
well.

This CL has no behavior changes.
This is a preparation to remove 'incremental' attribute and 'search'
event.


Bug: 690143
Change-Id: I5ababa9276be6c527bc1b0c4ac571fbdfb9ceccd
Reviewed-on: https://chromium-review.googlesource.com/1218483
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591289}

This fixes the following GCC error:

error: 'constexpr' needed for in-class initialization of static data

chrome/browser/browser/tab_manager_stats_collector.o
../../chrome/browser/resource_coordinator/tab_manager_stats_collector.cc:644:49:

member 'const base::TimeDelta
resource_coordinator::TabManagerStatsCollector::kLowFrequencySamplingInterval'
of non-integral type [-fpermissive]
 const base::TimeDelta
                                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: 'constexpr' needed for in-class initialization of static data
TabManagerStatsCollector: :kLowFrequencySamplingInterval;
Change-Id: I5ddcd2ef64c22e88a21d157f125c930d54a155ac
Reviewed-on: https://chromium-review.googlesource.com/1213155
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591288}

Timing out from crashing on Linux.

TBR=beccahughes@chromium.org

Bug: 883706
Change-Id: I4c618b6c4ad88a895ba53cd177106487fec8eba7
Reviewed-on: https://chromium-review.googlesource.com/1226475
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591287}

If ScopedFD is initialized with some integer, its dtor will close it as a file
descriptor. Because close will cause an error if there is no file descriptor,
this will fail VideoFrame unittest.
To solve this issue, ScopedFD is initialized without anything (i.e. default
ctor) is called.

BUG=chromium:883249
TEST=media_unittest on linux

Change-Id: If89a59d882fd887e4dc443bfd00153e69e336751
Reviewed-on: https://chromium-review.googlesource.com/1223167
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591286}

Before, the web_apps.extension_ids prefs stored only the extension_id:

"web_apps": {
  "extension_ids": {
    "https://events.google.com/io2016/?utm_source=web_app_manifest": "mjgafbdfajpigcjmkgmeokfbodbcfijl",
    "https://www.chromestatus.com/features": "fedbieoalmbobgfjapopkghdmhgncnaa"
  }
}

After, it stores both the extension_id and the install_source:

"web_apps": {
  "extension_ids": {
    "https://events.google.com/io2016/?utm_source=web_app_manifest": {
      "extension_id": "mjgafbdfajpigcjmkgmeokfbodbcfijl",
      "install_source": 1
    },
    "https://www.chromestatus.com/features": {
      "extension_id": "fedbieoalmbobgfjapopkghdmhgncnaa",
      "install_source": 1
    }
  }
}

This gets us closer to having uninstallation from one source not
interfere with other sources, addressing the TODO added in
https://chromium-review.googlesource.com/c/chromium/src/+/1212251/3/chrome/browser/web_applications/components/pending_app_manager.h

Bug: 855281
Change-Id: I9e101e3bf508df03b1887151c3ab4056e76a8bf4
Reviewed-on: https://chromium-review.googlesource.com/1223349Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591285}

https://webrtc.googlesource.com/src.git/+log/bdc115c23d21..f682624062b3


git log bdc115c23d21..f682624062b3 --date=short --no-merges --format='%ad %ae %s'
2018-09-14 emircan@webrtc.org Reland Profile 2 to default profiles


Created with:
  gclient setdep -r src/third_party/webrtc@f682624062b3

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I7f0fc3c11c980ae0c057cc4a7dc7e6e09063bb4a
Reviewed-on: https://chromium-review.googlesource.com/1226375Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591284}

These were lost in the shuffle during refactoring for proactive discarding, and
are causing a small spike in user complaints.

BUG=883071

Change-Id: I367398a4a148d760910f2c2edca73765f5f3dcc5
Reviewed-on: https://chromium-review.googlesource.com/1224954
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591283}

We'll switch it to WTF::Vector<blink::mojom::blink::FileChooserFileInfoPtr>
in a later CL. This CL will make it easier.

This CL has no behavior changes.

Bug: 869257
Change-Id: I4c2b75d72cd80795b84f3ce3f5e2086f0e2059dc
Reviewed-on: https://chromium-review.googlesource.com/1226533Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591282}

This CL measures PageLoadMetrics for pages loaded
through SignedExchange:
- Introduces SignedExchangePageLoadMetricsObserver and its unit test.
- Adds the new PLT metrics to histograms.xml.
- NavigationSimulator test infra adjusted to simulate signed exchange navigations.

Bug: 863305
Change-Id: Ia0aa85153e61b7e30cd92d5f9ce047cdc11b546e
Reviewed-on: https://chromium-review.googlesource.com/1209130Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591281}

It is used to set VideoFrameLayout according to hardware's
response in S_FMT command.

BUG=b:73752373
TEST=Build and deploy media_unittests to a CrOS DUT and run
media_unittests --gtest_filter=V4L2DeviceTest*

Change-Id: I332f46db85832a14b82d551249113f71711dc01c
Reviewed-on: https://chromium-review.googlesource.com/1189314
Commit-Queue: Shuo-Peng Liao <deanliao@google.com>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591280}

This CL updates the title text color for Linux and Windows 7 hosted
app windows to be more consistent with Windows 10, Chrome OS, Android
and text colors used by Gmail and Inbox.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=357634&signed_aid=ONM068fpCagoCFdrDrfYuw==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=357642&signed_aid=2gnT0P6z9_fNMEZAGLKLnw==&inline=1
See bug for more screenshots.

Bug: 883177
Change-Id: Ic24e1cf0b445251ebfdcd1aa0ae74c9343b1ff8e
Reviewed-on: https://chromium-review.googlesource.com/1218186
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591279}

First, splits TtsExtensionEngine out of tts_engine_extension_api
and renames it TtsEngineDelegateImpl, since it implements the
TtsEngineDelegate interface. Basically there were two separate
things in one source file, so I split it into two.

Then, this change makes TtsEngineDelegateImpl into a BrowserContext-keyed
service with a factory, so that we can have one instance per
BrowserContext. This will be handy for future changes because
I'd like to cache the vector of VoiceData per-BrowserContext.

For now, this is just a pure refactoring. There should be no
functional changes.

Bug: 862710

Change-Id: I34d92b244a1c5c684c2505ac0076a2f818e85b1a
Reviewed-on: https://chromium-review.googlesource.com/1220687Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591278}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: Ib128557b2ecbe3b578260410f1d5f52c123f719a
Reviewed-on: https://chromium-review.googlesource.com/1226294Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591277}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/71ddeb9859d4..4aefea51330c


git log 71ddeb9859d4..4aefea51330c --date=short --no-merges --format='%ad %ae %s'
2018-09-14 lannm@chromium.org Add tael and tatl to default PreCQ


Created with:
  gclient setdep -r src/third_party/chromite@4aefea51330c

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I9d239847dace3359a8436a6a41ef418bb0606ab2
Reviewed-on: https://chromium-review.googlesource.com/1226374Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591276}

This CL splits the impl of ALS reader into an abstract interface (AlsReader) and
its actual implementation (AlsReaderImpl) and a fake version (FakeAlsReader).
Later CLs will use FakeAlsReader for testing.

Bug: 881215
Change-Id: I0d877c5ba8253b883349c85976729f225fc2f7b6
Reviewed-on: https://chromium-review.googlesource.com/1220847
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591275}

This syncs Chrome's version of the ML Service Mojo interface with
Chrome OS's version in src/platform2/ml/mojom.

The incorporated mojom changes introduce error/status responses from
most of the mojom methods.

No clients depend on this yet so the only required C++ change is an
update to the LoadModel helper in the client library.

Bug: 836095
Change-Id: I15a7ba831792290c7b68db889332efd356163d28
Reviewed-on: https://chromium-review.googlesource.com/1226650
Commit-Queue: Andrew Moylan <amoylan@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591274}

The initialization of |memory_pressure_listener_| has been doing in the
destructor of GpuImageDecodeCache. This should be done by the constructor.
This CL fixes it.

Bug: 856527
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0e4d4ace3976285cf236596d9f6eafb8d4a350dd
Reviewed-on: https://chromium-review.googlesource.com/1223552Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#591273}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I673a09242fe66141ccd6d8e56da5b317b8d96bf6
Reviewed-on: https://chromium-review.googlesource.com/1226522Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591272}

Currently this test is flaky because we do not wait for the ack of the
touch start from the main thread.

This CL fixes this issue by using a ack waiter, to ensure that the ack
from the main thread has arrived.

TBR=alexmos@chromium.org

Bug: 871062
Change-Id: Ia883bcbb1b483d8fb481ce88dd5c947ea623d506
Reviewed-on: https://chromium-review.googlesource.com/1221476
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591271}

Following bot results are included.
9636 9639 9658 9665 9672 9674 9680 9686 9688 9689 9696 9701
9715

4 lines were removed and 0 lines were deflaked by consecutive
results since 9639.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ice237b24b715110f3a4669c52d1b49bc331c4fb4
Reviewed-on: https://chromium-review.googlesource.com/1221346
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591270}

This CL changes CrContainerShadowBehavior to add the shadow before the
parent of the container element, instead of assuming the container is
a direct child of the elemenent implementing the behavior. This allows
the behavior to work correctly for Print Preview, and does not break
any existing implementers of this behavior (SettingsUI, various
extensions pages).

This also adds the behavior the print-preview-app along with the
specified styles for the shadow.

Bug: 883583
Change-Id: I5cc110d33d00d5e4c84e8fafcc0e0bbc0a8e96a4
Reviewed-on: https://chromium-review.googlesource.com/1225861
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591269}

While working on [1], it was noticed that the ExtensionDownloader class
(extensions/browser/updater/extension_downloader.cc|h) had some orphan
logic that used to handle blacklist'ed Extensions loads in-memory.

After a bit of git archaeology, I could found [2], which seems
to have nuked out the "in memory" blacklist download handling code,
but missed out some bits (eg ExtensionDownloader::StartBlacklistUpdate
that has no callers).

This CL removes the left over extension blacklist code in
ExtensionDownloader.

[1] https://crrev.com/c/1066370
[2] https://chromiumcodereview.appspot.com/23591050/diff/133001/chrome/browser/extensions/updater/extension_downloader.cc

BUG=844928

Change-Id: I8abc9a9924a4621926ebe1604c7191dce8e25494
Reviewed-on: https://chromium-review.googlesource.com/1219231Reviewed-by: Minh Nguyen <mxnguyen@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#591268}

There are not used after PlzNavigate launch.

Bug: 789577
Change-Id: Ic4ce9701e2c66b9999a53ea238d6f500417ef93e
Reviewed-on: https://chromium-review.googlesource.com/1226268Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591267}

Replace the use of internal ShapeResult notions in ShapeResultBloberizer
with the new ShapeResult::ForEachGraphemeClusters API, modeled after the
existing ForEachGlyph API.

Also fixes emphasis mark painting for LayoutNG and rebaselines the tests
for emphasis painting, some of which had incorrect expectations.

Bug: 881110
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ic147f68d98453fa32d1527b090bc1915f7af8ac1
Reviewed-on: https://chromium-review.googlesource.com/1225101Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591266}

https://skia.googlesource.com/skia.git/+log/b4d5af9c05f0..64b0fb599517


git log b4d5af9c05f0..64b0fb599517 --date=short --no-merges --format='%ad %ae %s'
2018-09-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 daab00149ee5..7f2329398fe8 (8 commits)


Created with:
  gclient setdep -r src/third_party/skia@64b0fb599517

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: Ib9cc1af2563c2b8ef4f3bc8f2af4fafc7b3f0566
Reviewed-on: https://chromium-review.googlesource.com/1226373Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591265}

In incognito mode, Android download notification no longer shows file
names and file size for privacy reasons. We also show "Incognito tab" as
subtext to inform the user that they are using incognito mode.

Also plumbs isOffTheRecord for failed download notifications, so failed
download notification will not show file details as well.

Bug: 880359
Change-Id: I85aaf73db8ad566aad912f0d826213777dec90f2
Reviewed-on: https://chromium-review.googlesource.com/1214076
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591264}

Remove getShareUrl and the underlying implementation.

Bug: 854482,854468
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Tbr: tzik@chromium.org
Change-Id: I2a78eb0e7c474b11e9d7ac18543b652a7c332114
Reviewed-on: https://chromium-review.googlesource.com/1183045
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591263}

https://webrtc.googlesource.com/src.git/+log/c0af56b9fb65..bdc115c23d21


git log c0af56b9fb65..bdc115c23d21 --date=short --no-merges --format='%ad %ae %s'
2018-09-13 buildbot@webrtc.org Roll chromium_revision e3170c4f..2338e7cc (590991:591117)
2018-09-13 sprang@webrtc.org Don't pad to min bitrate for streams with alr probing enabled
2018-09-13 henrika@webrtc.org Fixes issue where WebRTC.Audio.RecordSampleRateOffsetInPercent can report 100%


Created with:
  gclient setdep -r src/third_party/webrtc@bdc115c23d21

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:b/113648245
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib3b196fc9a52d3847c75243c41b26b30baf591c6
Reviewed-on: https://chromium-review.googlesource.com/1226091Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591262}

This reverts commit 7e40ef38.

Reason for revert: 883892

Original change's description:
> Roll src/third_party/catapult 3e071665b9f9..c4d326feb2ff (5 commits)
>
> https://chromium.googlesource.com/catapult.git/+log/3e071665b9f9..c4d326feb2ff
>
>
> git log 3e071665b9f9..c4d326feb2ff --date=short --no-merges --format='%ad %ae %s'
> 2018-09-13 anthonyalridge@google.com Add clip path at to prevent overlap with x axis label.
> 2018-09-13 wangge@google.com Add functions to include APK, generate isolate and upload it.
> 2018-09-13 cbruni@chromium.org Add more helpers in preparation for v8.loading.cluster_telemetry benchmark
> 2018-09-13 anthonyalridge@google.com Add padding to numeric labels for stacked bar plotter.
> 2018-09-13 ulan@chromium.org Output DevTools error messages as warnings while running a story.
>
>
> Created with:
>   gclient setdep -r src/third_party/catapult@c4d326feb2ff
>
> The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
>
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
>
> BUG=chromium:866423,chromium:863390,chromium:883322,chromium:866423,chromium:880432
> TBR=sullivan@chromium.org
>
> Change-Id: I68916abd79b995d8c990f4fc64c65dce5cdbaa23
> Reviewed-on: https://chromium-review.googlesource.com/1224473
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#591005}

TBR=sullivan@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com

Change-Id: Iacf4973a98666f6030cb3373629cefdfc58f95e2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:866423, chromium:863390, chromium:883322, chromium:880432
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1226534
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591261}

Enter should only close the dialog if the text field has been modified.

Bug: 878740
Change-Id: I103ca78f501b33957dd2895a0a67b2a2942fe4ff
Reviewed-on: https://chromium-review.googlesource.com/1226272Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591260}

It is possible that while waiting for the ack of a previous draw, another
draw is attempted and aborted. In such cases, the trace-event for the
first draw would incorrectly be terminated. Fix that bug by fixing the
trace-id for such canceled draw events. Also, instrument such events so
that telemetry tests can identify such events.

Also, fix the trace-id to be int64_t in SurfaceAggregator, which was
mistakenly left unchanged in crrev.com/590805

BUG=883592, 879884

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Id39bf22559bd9f02e2765e69cc32a8cb1e9c62a2
Reviewed-on: https://chromium-review.googlesource.com/1223326Reviewed-by: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591259}

The underlying failure has been fixed.

Tbr: danakj@chromium.org
Bug: 882103
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I195c7a76e020542667d92a642e4631d78bf1c7a3
Reviewed-on: https://chromium-review.googlesource.com/1226460Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591258}

After https://chromium-review.googlesource.com/c/chromium/src/+/1214709,
now we can just use the corresponding mojom type directly and remove
this WebServiceWorkerClientQueryOptions.

BUG=879019

Change-Id: I68af28b30a403a32db5cff4e4a147437b127e875
Reviewed-on: https://chromium-review.googlesource.com/1221086
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591257}

Embedders can disable code caching and we need to handle those cases
when clearing the caches.

Bug: chromium:812168
Change-Id: Ib9f2b60faa07c3e023298f46c5fdc2ef049ee797
Reviewed-on: https://chromium-review.googlesource.com/1219227
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591256}

As part of the effort to deprecate kNotSharableCrossOrigin, stop using
it in WorkerOrWorkletScriptController::Evaluate. There are three users:
 - worker toplevel scripts
 - importScripts
 - ScheduledAction

Workers are origin-bound, so we can use kSharableCrossOrigin (the name
is misleading, I will rename it, after all the refactoring is done).

importScripts() always use "no-cors" mode, so we can calculate the
AccessControlStatus by using SecurityOrigin::CanReadContent. I don't
want to place the ad-hoc logic, but plumbing it to response type is
hard because of LoadScriptFromInstalledScriptsManager.

For ScheduledAction, I gave up removing kNotSharableCrossOrigin this
time, as it seems consistent with Execute(LocalFrame*). I will remove
the occurrence in a subsequent CL.

Bug: 875153
Change-Id: I0d3c65e5fc152caed0265e7868e45ea9882ce487
Reviewed-on: https://chromium-review.googlesource.com/1180638
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591255}

BUG=859260

Change-Id: I9262c7b4c96fad43576d020d2a4660c2c86b81e5
Reviewed-on: https://chromium-review.googlesource.com/1222693Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591254}