GitLab

Add the override annotation to all necessary methods in .../quic/.

Merge internal change: 59008686
https://codereview.chromium.org/126243002/


Enabled StopPacketProcessing unit test.
Added EXPECT_CALL for OnUnauthenticatedPublicHeader.

R=rch@chromium.org
BUG=331630
https://codereview.chromium.org/113073003/


Add an end-to-end test which verifies that QUIC 13 does not generate
QUIC_STREAM_RST_BEFORE_HEADERS_DECOMPRESSED errors.

Merge internal change: 58990354
https://codereview.chromium.org/121883003/


Fix a bug in QuicSentPacketManager::ClearPreviousRetransmissions where
the high water mark is not raised past the current transmission of a
packet whose previous packet has been ACKed. This bug was first
observer in jri's lab experiments.

Fix QUIC bug related to ACKs of previous transmission of packets.

Merge internal change: 58760014
https://codereview.chromium.org/125183004/


Correctly handle NACK-based "retransmission" of packets which no longer
have retransmittable data associated with this. These can be the result
of TLP retransmission or a current transmission of a packet whose
previous transmission have been acked.

Fix QUIC bug related to ACKs of previous transmission of packets.

Merge internal change: 58758718
https://codereview.chromium.org/125183003/


Simplify RTO interaction between the QUIC sent packet manager and the
send algorithm. The manager no longer needs to abandon each packet
individually.

Merge internal change: 58755766
https://codereview.chromium.org/125253004/


Remove a QUIC test only flag(limit_rto_increase_for_tests) to limit the
RTO increase in EndToEndTests.

This is no longer necessary now that two TLP's and early retransmit have
been added.

Merge internal change: 58591658
https://codereview.chromium.org/112953003/

Review URL: https://codereview.chromium.org/126513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243507 0039d316-1c4b-4281-b951-d872f2087c98

BUG=311902
TEST=run install-build-deps.py in saucy chroot.

Review URL: https://codereview.chromium.org/126333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243506 0039d316-1c4b-4281-b951-d872f2087c98

In both aura and win this function is Not Implemented

BUG=

Review URL: https://codereview.chromium.org/126053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243505 0039d316-1c4b-4281-b951-d872f2087c98

This CL simplifies how DriveAppRegistry stores App info.
Main purpose is to add |all_apps_|, the explicit list of
all application currently registered.

BUG=332014

Review URL: https://codereview.chromium.org/125813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243504 0039d316-1c4b-4281-b951-d872f2087c98

Since these tests run on non-Windows platforms, the pak file seems to be loaded
fine and these .rc files should not be necessary.

BUG=297672
NOTRY=true

Review URL: https://codereview.chromium.org/125103007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243503 0039d316-1c4b-4281-b951-d872f2087c98

Moved the 'if' clause to check if the translation is performed automatically to TranslateManager. TranslateBubbleView::ShowBubble is called not only from TranslateManager but also when the user clicks the icon explicitly. In the latter case, the translate bubble should be shown whether the automatic translation is done or not.

BUG=330684
TEST=manual

Review URL: https://codereview.chromium.org/124833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243502 0039d316-1c4b-4281-b951-d872f2087c98

Adds various metrics related to GCM connection stability and persistent store
usage.

BUG=284553

Review URL: https://codereview.chromium.org/123453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243501 0039d316-1c4b-4281-b951-d872f2087c98

The new design of the window headers does not use a super transparent window header when there is just one window on screen.
The solo window feature is also broken in the M32 and M33 branches (crbug.com/330212)

BUG=297187
TEST=None
R=jamescook
TBR=oshima (For trivial change in chrome/browser/chromeos/login/login_display_host_impl.*)

Review URL: https://codereview.chromium.org/123023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243500 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary to remove the WebGraphicsContext3D getter from
cc::ContextProvider.

TBR=maruel@ for trivial PRESUBMIT.py change
BUG=181120

Review URL: https://codereview.chromium.org/117233006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243499 0039d316-1c4b-4281-b951-d872f2087c98

Add local_id to DirectoryFetchInfo.
After this change, there is no need to set dummy resource ID for the grand root.

BUG=324719
TEST=unit_tests

Review URL: https://codereview.chromium.org/107293013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243497 0039d316-1c4b-4281-b951-d872f2087c98

This basically reverts r222408 for iOS

BUG=330074
TEST=net_unittests

Review URL: https://codereview.chromium.org/103533012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243495 0039d316-1c4b-4281-b951-d872f2087c98

[Import] [OSX] Don't create an empty folder when importing from Safari with an empty Bookmarks Menu.

Also moves test files around:
  (1) The data previously in chrome/test/data/safari_import/ was moved to chrome/test/data/import/safari/default/.
  (2) A new test data directory was created at chrome/test/data/import/safari/empty_bookmarks_menu/.

BUG=248431
TEST=unit_tests
R=jeremy@chromium.org

Review URL: https://codereview.chromium.org/119833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243494 0039d316-1c4b-4281-b951-d872f2087c98

base::TimeTicks is a monotonic clock, unlike base::Time, which may change if
the system time is changed.  Switch over the video capture pipeline to use this
clock.

BUG=249215
TEST=local build, run on CrOS snow, desktop Linux

Review URL: https://codereview.chromium.org/101843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243493 0039d316-1c4b-4281-b951-d872f2087c98

... that accepts a RefCountedMemory. This saves some buffer copying in
many places, specially welcome with big images.

Review URL: https://codereview.chromium.org/78903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243492 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243486 0039d316-1c4b-4281-b951-d872f2087c98

> [telemetry] Implement per-pixel algorithms in Bitmap as a C++ extension.
> 
> The extension provides fast bitmap operations with no external
> dependencies. However, it is not available on all platforms.
> 
> BUG=323813
> TEST=telemetry bitmap_unittest
> R=bulach@chromium.org, tonyg@chromium.org
> 
> Review URL: https://codereview.chromium.org/121493004

TBR=szym@chromium.org

Review URL: https://codereview.chromium.org/127533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243478 0039d316-1c4b-4281-b951-d872f2087c98

With the exception of the chrome.app.runtime.onLaunched() event,
events will only be dispatched to ephemeral apps that are running.
This was implemented by adding a "can_load_ephemeral_apps" flag to
extensions::Event. Only events which enable this flag will have the
ability to load the event page of apps.

BUG=312460
TEST=browser_tests (EphemeralAppBrowserTest.*)

Review URL: https://codereview.chromium.org/118033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327430

Review URL: https://codereview.chromium.org/120753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243476 0039d316-1c4b-4281-b951-d872f2087c98

The "Mappy" sample still provides an example of a content script searching for
text.

The new icon comes from http://en.wikipedia.org/wiki/File:Video_icon2.png, which
is public domain.

TEST=Install the extension, and visit http://www.html5rocks.com/en/tutorials/video/basics/. The page action icon should show up.
BUG=330359
NOTRY=true

Review URL: https://codereview.chromium.org/124603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243475 0039d316-1c4b-4281-b951-d872f2087c98

There are two issues:
1. App laucher uses the active profile's original profile to determine
if we're in guest mode (and thus always assuming guest session is not
active).
2. Every file manager event router (each profile has one) opening
a file manager window when removable device is inserted. So the
original profile's event router will open a window too.

BUG=329658
TEST=
1. Login as guest, launch file manager from the app launcher, open a doc file
from the file manager using quick office, and verify the doc is opened in off
the record window (Ctrl-T should open guest tab).
2. Login as guest, insert an SD card, make sure only 1 file manager window is
opened. From the opened file manager window, open a doc file using quick
office and make sure the document is opened in off the record window.

Review URL: https://codereview.chromium.org/115733007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243474 0039d316-1c4b-4281-b951-d872f2087c98

Then we don't have to handle SHN_COMMON in the native link.
Normally, pnacl-clang adds -fno-common to force definition
of common symbols. However, the x86 shims are compiled by
nacl-gcc so it showed up.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=3762
R=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/116043012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243473 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/127203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=309847
NOTRY=true
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/126513008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243471 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a class for extraction of audio and video metadata using ffmpeg.

This is needed to implement the Media Galleries Metadata API for Chrome extensions.

BUG=318450

Review URL: https://codereview.chromium.org/121383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243470 0039d316-1c4b-4281-b951-d872f2087c98

The extension provides fast bitmap operations with no external
dependencies. However, it is not available on all platforms.

BUG=323813
TEST=telemetry bitmap_unittest
R=bulach@chromium.org, tonyg@chromium.org

Review URL: https://codereview.chromium.org/121493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243469 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322682
TEST=covered by existing unit tests

Review URL: https://codereview.chromium.org/113653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243468 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Added to existing tests
R=sky

Review URL: https://codereview.chromium.org/126883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243467 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: Caused a 30% rasterization regression

TBR=reveman@chromium.org,senorblanco@chromium.org,vangelis@google.com,reed@google.com
BUG=310796,332137

Review URL: https://codereview.chromium.org/126343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243466 0039d316-1c4b-4281-b951-d872f2087c98

- Removed unused fields from DriveAppInfo.
  It is easy to recover them later when needed.
- A bit of rewriting for FindPreferredIcon.

BUG=332014
R=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/125163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243465 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/125403006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243462 0039d316-1c4b-4281-b951-d872f2087c98

Ignore offset parameter in encode callback. It is ignored/deprecated by the caller, and bitmap.pixelRefOffset() is also deprecated

BUG=

Review URL: https://codereview.chromium.org/116693005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243461 0039d316-1c4b-4281-b951-d872f2087c98

The TrackableCallback manages the callback and the request ID so that we don't
need to manage them separately.

Also in this CL:
- Using media::Decryptor in .cc file.
- Renaming: pending_foo_cb_ -> foo_cb_

Review URL: https://codereview.chromium.org/105743010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243460 0039d316-1c4b-4281-b951-d872f2087c98

Before this, an OWNER of the entire directory that a new DEPS rule was pointing to would be required, even when the DEPS rule specified an individual file for which there are per-file OWNERS in the OWNERS file.

BUG=290401

Review URL: https://codereview.chromium.org/116443011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243459 0039d316-1c4b-4281-b951-d872f2087c98

The EME infobar should be dismissed when it was requested
in an iframe and it is navigated away.

BUG=297891

Review URL: https://codereview.chromium.org/107413006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243458 0039d316-1c4b-4281-b951-d872f2087c98

BUG=310389
NOTRY=True

Review URL: https://codereview.chromium.org/117833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243457 0039d316-1c4b-4281-b951-d872f2087c98

Trying to get rid of GetDefaultProfile since it was depricated since 2011. See https://docs.google.com/a/google.com/document/d/1Fo0_ixnmOYDZKjcdzU3btED3yWINpdBvzpgl7EBOZro/edit#heading=h.5pkgd9yd16w5 for more informations!

BUG=322682
TEST=covered by existing unit tests

Review URL: https://codereview.chromium.org/101653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243456 0039d316-1c4b-4281-b951-d872f2087c98

It was previously "chrome_app_list" regardless of which build we are in.

BUG=331729

Review URL: https://codereview.chromium.org/120723006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243453 0039d316-1c4b-4281-b951-d872f2087c98

The structs are internal to the pnacl_shim.c.

BUG=none
R=teravest@chromium.org

Review URL: https://codereview.chromium.org/126343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243452 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124445
NOTRY=true
TBR=wtc@chromium.org

Review URL: https://codereview.chromium.org/127253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243451 0039d316-1c4b-4281-b951-d872f2087c98

(Except for two-phase read/writes in "may discard" mode, which isn't
supported yet.)

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/126663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243450 0039d316-1c4b-4281-b951-d872f2087c98