- 19 Jun, 2018 40 commits
-
-
Tetsui Ohkubo authored
This CL replaces UI strings of Network feature pod button in UnifiedSystemTray. TEST=manual BUG=813499 Change-Id: I1c6b4bbf2fc5e5441eed5c88123f32b58fa0df9e Reviewed-on: https://chromium-review.googlesource.com/1103996Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#568312}
-
Kent Tamura authored
node.h is used in 4,700+ compilation units, and this CL reduces its estimated expanded size from 3.47MB to 2.58MB. Node depended on enum blink::MutationObserver::MutationType. This CL makes it to blink::MutationType, and moves it out from mutation_observer.h. Also, NodeMutationObserverData in node_rare_data.h depended on mutation_observer_registration.h. This CL moves member functions of NodeMutationObserverData from node_rare_data.h to node_rare_data.cc to remove #include mutation_observer_registration.h. Bug: 242216 Change-Id: I7a603bda1442dedc45674daab1b5d8f5b369f123 Reviewed-on: https://chromium-review.googlesource.com/1102291Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#568311}
-
Xiangjun Zhang authored
Add the audio mirroring client side code for Mirroring Service. Bug: 734672 Change-Id: I2a503fb5a059861a9cc4aa190a80134876eade4b Reviewed-on: https://chromium-review.googlesource.com/1083626 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568310}
-
Peter Boström authored
We haven't been able to figure out why profiles outside the user data directory make any sense whatsoever. It seems more reasonable to reject or sanitize this directory path than taking it into account when trying to spawn the profile switcher. Bug: chromium:849912 Change-Id: I8386bee829c95ff6450b676d39091adf7bfad9d6 Reviewed-on: https://chromium-review.googlesource.com/1105495Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#568309}
-
Adolfo Victoria authored
Allows administrators to set time intervals in which the managed devices should not check for updates. Unless the updates are forced. BUG=chromium:852860 TEST=Tested locally and used unit tests CQ-DEPEND=CL:1097698 Change-Id: Ibd9ff26fb537a966f86d9a824845fa4cf7f92d8e Reviewed-on: https://chromium-review.googlesource.com/1097990 Commit-Queue: Adolfo Higueros <adokar@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#568308}
-
Kent Tamura authored
execution_context.h is used in 4,800+ compilation units, and this CL reduces its estimated expanded size from 3.17MB to 1.95MB. This CL removes #includes for single_thread_task_runner.h, security_context.h, and kurl.h from execution_context.h. Bug: 242216 Change-Id: I2e37b1c58902a58ba3370c26a5a38513ca1e3cbc Reviewed-on: https://chromium-review.googlesource.com/1102293Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#568307}
-
Mathieu Perreault authored
According to designers and internal spec (https://goo.gl/oRp6PA), some colors are a shade lighter. Bug: 850571 Test: Visual Change-Id: I2c593ed0019c9497873f0f8efa42b592e187d89b Reviewed-on: https://chromium-review.googlesource.com/1099687 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#568306}
-
Tetsui Ohkubo authored
This CL adds all remaining UI strings for UnifiedSystemTray. String freeze will happen soon, so we have to make sure they land before that. TEST=manual BUG=813499 Change-Id: I8fed8fd079643fc37957a82628a24d09343fb70a Reviewed-on: https://chromium-review.googlesource.com/1103435Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#568305}
-
James Cook authored
Move the code to //ash/keyboard. Add yhanada to OWNERS. This should make it easier for the people working on keyboard support to get approvals from nearby time zones. Bug: none Change-Id: Idbb3023913c7e34daad9b42718dd90ad7ed8e319 Reviewed-on: https://chromium-review.googlesource.com/1105396Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#568304}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/86e1b8b5a23b..efd58885b78d git log 86e1b8b5a23b..efd58885b78d --date=short --no-merges --format='%ad %ae %s' 2018-06-19 yunlian@google.com eve-arcnext: remove USE="cfi" Created with: gclient setdep -r src/third_party/chromite@efd58885b78d The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853946 TBR=chrome-os-gardeners@chromium.org Change-Id: Ie4cc0a653204b46ba77c162abce07734cff42d76 Reviewed-on: https://chromium-review.googlesource.com/1105219Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568303}
-
Frank Barchard authored
https://chromium.googlesource.com/libyuv/libyuv.git/+log/196e2e72a319..780cdfed4eb2 $ git log 196e2e72a..780cdfed4 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 thomasanderson Remove manual references to exe_and_shlib_deps 2018-06-12 fbarchard Add AR30 and AB30 to ConvertToARGB() and fix negative NV12 height Created with: roll-dep src/third_party/libyuv Bug: libyuv:799, libyuv:446 Change-Id: I5527214fa010bd829a93e3936626d67bf969533e TESTED: try bots build Reviewed-on: https://chromium-review.googlesource.com/1103580Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Frank Barchard <fbarchard@chromium.org> Commit-Queue: Frank Barchard <fbarchard@chromium.org> Cr-Commit-Position: refs/heads/master@{#568302}
-
Saman Sami authored
Some tests that were disabled for being irrelevant to viz are not actually that irrelevant; they just need some minor adjustments. - RenderWidgetHostViewAuraSurfaceSynchronizationTest.DiscardDelegatedFrames - RenderWidgetHostViewAuraSurfaceSynchronizationTest.DropFallbackWhenHidden - RenderWidgetHostViewAuraSurfaceSynchronizationTest.SurfaceChanges - RenderWidgetHostViewAuraTest.DiscardDelegatedFramesWithLocking - RenderWidgetHostViewAuraTest.DiscardDelegatedFramesWithMemoryPressure - RenderWidgetHostViewChildFrameTest.SwapCompositorFrame Bug: 844469 Change-Id: Iddc1fdf6ebdb984afa277d537b326e7005ab1777 Reviewed-on: https://chromium-review.googlesource.com/1105312Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#568301}
-
Istiaque Ahmed authored
Add manifest key ("service_worker_script") to specify a script for SW based background page. Registers the provided script as a worker. Add extension registry observers to observe the begin/finish of the SW registration. Change ServiceWorkerTaskQueue to support queueing tasks. Queueing is done if the SW registration is pending. Add a browser_test to load such extension, that doesn't use any background page. Doc: https://goo.gl/j4ca5d Bug: 853378, 850792, 850786 Change-Id: I11c0bdbbbdb6e2ca1e7423330ebd455bdd45fb11 Reviewed-on: https://chromium-review.googlesource.com/1088162 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568300}
-
Varun Khaneja authored
This mimics the behavior of zip_analyzer. Also, mark contained archives as ARCHIVE instead of ZIPPED_ARCHIVE or RAR_COMPRESSED_ARCHIVE. Bug: 853922, 853971 Change-Id: I159126518c1de29029c0a3a0fd435fb997cb2952 Reviewed-on: https://chromium-review.googlesource.com/1105195Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#568299}
-
Steven Bennetts authored
This CL eliminates the deprecated --disable-network-settings-config flag and the networkSettingsConfig JS property. The NetworkConfigView and related code will be eliminated in a followup. For comment-only change to ash/public/interfaces/system_tray.mojom: TBR=tsepez@chromium.org Bug: 848090 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I63bd4c79fc3041c1e6b25769fd2cc755664f4247 Reviewed-on: https://chromium-review.googlesource.com/1103057 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#568298}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f5557accff71..2dabb4a367c3 git log f5557accff71..2dabb4a367c3 --date=short --no-merges --format='%ad %ae %s' 2018-06-18 geofflang@chromium.org Make a context current when destroying it. 2018-06-18 ehmaldonado@chromium.org Remove DEPS .chromium 2018-06-18 fjhenigman@chromium.org Vulkan: fix third_party path. Created with: gclient setdep -r src/third_party/angle@2dabb4a367c3 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:782846 TBR=cwallez@chromium.org Change-Id: I75e7143b670fb0110c98607556572454f8205958 Reviewed-on: https://chromium-review.googlesource.com/1105417Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568297}
-
Sadrul Habib Chowdhury authored
Reduce the number of repititions to avoid a timeout in the test. BUG=853762 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I08f70316da5c28d92ccb142e71ecd6c903bca612 Reviewed-on: https://chromium-review.googlesource.com/1105063Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#568296}
-
Kyle Horimoto authored
This class generates BleListenerOperations. Bug: 824568, 752273 Change-Id: I4c196efc3636b48b1542b533d6a6462c79a53201 Reviewed-on: https://chromium-review.googlesource.com/1103538 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#568295}
-
Xi Cheng authored
Bug: 851163 Change-Id: I0f37ac73c90f152b05a02904967fecd33cf10b31 Reviewed-on: https://chromium-review.googlesource.com/1105286 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568294}
-
Sergey Ulanov authored
ScenicWindow now creates View and listens to input events (mouse and keyboard). Bug: 829980 Change-Id: If5d05bf1107fec553aecf2537fd197d177d2fbb1 Reviewed-on: https://chromium-review.googlesource.com/1081609 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#568293}
-
Victor Costan authored
In Firefox, File.readAsDataURL's default MIME type is to application/octet-stream. Chrome currently leaves the MIME type out when it is unknown. While this meets all relevant specifications, matching Firefox's behavior makes the platform easier to reason about. Bug: 48368 Change-Id: If480df5cc3a1177a58c7c3dc68c57f3d6408b9eb Reviewed-on: https://chromium-review.googlesource.com/1104183 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#568292}
-
Victor Costan authored
https://crbug.com/850369 moved Blink>FileAPI to Blink>Storage>FileAPI. The File API is a client-side storage mechanism, just like the other components under Blink>Storage. There is no logical reason for File API to be separate from everything else. This CL updates the OWNERS references. While at it, the CL also updates an incorrect Blink>Quota reference to Blink>Storage>Quota. Change-Id: I774620b86f1a60635b68db68ce2ac2a3b7d7ac1a Reviewed-on: https://chromium-review.googlesource.com/1103186Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#568291}
-
Mohit Hotwani authored
BUG: 79499685 Change-Id: If6502ded7f8c6d5d90cc27a271cbe2c29347808e Reviewed-on: https://chromium-review.googlesource.com/1098386 Commit-Queue: Mohit Hotwani <hmohit@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#568290}
-
Ben Pastene authored
It appears that the timeout+retries I added in CL:1102121 are successfully making the test more stable. See the following tests that froze, were caught+retried, and passed: https://chromium-swarm.appspot.com/task?id=3e2d8a94a80e7a10 https://chromium-swarm.appspot.com/task?id=3e2d2fdf269c5910 Bug: 840967 Change-Id: Ie4f02862201965e27af437c88e9a5e4ec0feccbf Reviewed-on: https://chromium-review.googlesource.com/1105314Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#568289}
-
bsheedy authored
Regular APK roll to the current release version (1.15) TBR=bajones@chromium.org Change-Id: Ibb0ca2051ec19be49ec384bb12554553d6f0fe1a Reviewed-on: https://chromium-review.googlesource.com/1105515Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568288}
-
John Budorick authored
TBR=kbr@chromium.org Bug: 853307 Change-Id: Id7ec4011b055a592f5a6499b1495425acd64474d Reviewed-on: https://chromium-review.googlesource.com/1105512Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#568287}
-
Christopher Cameron authored
Change IPC messages in app_shim_messages to a mojo interface. - Remove the AppShimMsg_RequestUserAttention method - Remove the warning that the interface needs versioning Update how the connection between shim and browser is initialized - The connection process is initiated in the shim process in the AppShimController::CreateChannelAndSendLaunchApp function - Make the socket created be an AppShimHost interface (the interface used to send from the shim to the browser) - Immediately enqueue a LaunchApp message to the browser process, and add an AppShim interface to the LaunchApp method, to allow the browser to call back to the shim process - Update AppShimHost::ServeChannel to bind itself as a AppShimHost to the created socket - Update AppShimHost::LaunchApp to initialize its AppShim pointer. Intentionally do not update this method to have a reply, to minimize functional changes. Rather, send the reply via the passed AppShim. Update how channel errors are handled by adding an error callback to the mojo bindings created in AppShimHost::LaunchApp and AppShimController::CreateChannelAndSendLaunchApp. Update unit tests to use the mojo interfaces. Change AppShimHostTest to use a weak pointer to the AppShimHost, because, when its message loop is allowed to run, AppShimHost will delete itself on Close. Remove the comments about requiring that the interface between the shim and the browser versioned. Bug: 821651 Change-Id: Ibad84de4ec25d1121e4ef4d8075a20bb3abd8642 Reviewed-on: https://chromium-review.googlesource.com/1103844Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#568286}
-
Malay Keshav authored
This patch replaces the logic to generate the zoom levels for displays that have default device scale factor with a static initialized table. This patch also modifies the table to include beyond native resolution for FHD 1.25 DSF devices as well as sub FHD devices that have a 1 DSF. Bug: 851646 Change-Id: If67d155ce389537b6889e709650e9f9111c62d9c Component: display zoom, display scaling, display manager Reviewed-on: https://chromium-review.googlesource.com/1096357 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#568285}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1bb47df4fc8e..63b3bfb711d7 git log 1bb47df4fc8e..63b3bfb711d7 --date=short --no-merges --format='%ad %ae %s' 2018-06-18 brianosman@google.com Reland "Remove old references to SampleApp" 2018-06-18 borenet@google.com [infra] Include cpython CIPD package on Windows 2018-06-18 brianosman@google.com Revert "Remove old references to SampleApp" 2018-06-18 brianosman@google.com Remove old references to SampleApp 2018-06-18 herb@google.com Use x text skew to position text 2018-06-18 ethannicholas@google.com added GrSkSLFP and converted DitherEffect to use it 2018-06-18 mtklein@chromium.org remove lowp bilerp_clamp_8888 stage 2018-06-18 fmalita@chromium.org [skottie] Fix OOB access in Parse<SkPoint> 2018-06-18 mtklein@chromium.org clean up defines that do nothing 2018-06-18 mtklein@chromium.org remove SkTCast 2018-06-18 bsalomon@google.com Change how vertex/instance attributes are handled in geometry processors. 2018-06-18 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 50cf2be0758b..f6fd48fd329f (1 commits) 2018-06-18 brianosman@google.com Remove GrNonlinearColorSpaceXformEffect 2018-06-18 csmartdalton@google.com ccpr: Implement path mask caching 2018-06-18 egdaniel@google.com Always use dedicated VkImage memory on NexusPlayer and Mali. 2018-06-18 mtklein@chromium.org remove stray SkTLList includes 2018-06-18 csmartdalton@google.com ccpr: Use lazy proxies with GrCCAtlas 2018-06-18 brianosman@google.com Implement nonlinear (as-encoded) blending in GrColorSpaceXform Created with: gclient setdep -r src/third_party/skia@63b3bfb711d7 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Ia22db55e0e8c6191f89b26da745526d8d61e9b5a Reviewed-on: https://chromium-review.googlesource.com/1105218Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568284}
-
Ken Rockot authored
Fixes a data race on the boolean |error_| field. This is almost certainly innocuous in practice but is technically UB, and TSan complains. Bug: 850091 Change-Id: Icc6bfbc0a2e2bda6a87c455856ff5f3153568a02 Reviewed-on: https://chromium-review.googlesource.com/1105340Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#568283}
-
Sky Malice authored
Because time_serialization.cc stored Time and DeltaTime in microseconds, and Time since the windows epoch, which is the exact same way that PrefService is storing these time fields, this change should be fully backwards compatible. Bug: 853755 Change-Id: I22d734d030ca550a654319e37abf6653890c1bdb Reviewed-on: https://chromium-review.googlesource.com/1104581Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#568282}
-
Xida Chen authored
This CL removes that attributes. It also adds a gesture scroll bubbling case to ensure that the behavior is correct. Due to our previous temporary fix, we set |scrolling_touch_action_| to Auto at GSB if it has no value. To prove that this CL is actually working, we do: PS#1: remove the set |scrolling_touch_action_| to Auto at GSB, and the test will crash. PS#2: Keep 1, add a line in CrossProcessFrameConnector::BubbleScrollEvent which sets the |scrolling_touch_action_| to Auto. The test will pass. PS#3: Keep the temporary fix which sets |scrolling_touch_action_| to Auto at GSB. TBR=pdr@chromium.org Bug: 852835, 841270 Change-Id: Ib33a39b4b0ef61e88645da427b920687bbcc80c9 Reviewed-on: https://chromium-review.googlesource.com/1101315 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568281}
-
dpapad authored
Bug: 853958 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1a9848f3bb1cba427e229b387516ffa1764c1096 Reviewed-on: https://chromium-review.googlesource.com/1105401Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#568280}
-
Giovanni Ortuño Urquidi authored
This reverts commit 1977b793. Reason for revert: breaks WebKit Linux Trusty MSAN Tests seem to time out since this CL: https://test-results.appspot.com/data/layout_results/WebKit_Linux_Trusty_MSAN/8393/layout-test-results/results.html https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/8393 Original change's description: > Remove blink::CallExtraOrCrash > > CallExtraOrCrash is a function to call into V8 Extras and crash if it > fails. Unfortunately, calling into V8 Extras can fail under normal > conditions such as stack overflow and Worker destruction, causing a lot > of unnecessary crashes. Remove CallExtraOrCrash. > > This is a stopgap change designed to be mergable to version 68. It > avoids major code restructuring but as a result lacks robust > encapsulation. > > The general strategy is to pass a boolean pointer to functions in > ReadableStreamOperations that call into V8 Extras. If the internal call > fails, the boolean is set to true, and the call returns a default value. > > BodyStreamBuffer keeps the boolean as member variable. Once a call to a > V8 extra function fails, the boolean is set and no more calls will be > made. This is to avoid us taking action based on information that is > incorrect. > > For Tee() and the from-stream version of the BodyStreamBuffer > constructor, we use an ExceptionState object instead. In these cases, it > is straightforward to pass through ExceptionState object from the Blink > bindings. This allows the failure to be propagated safely back to > Javascript. > > Conversely, DefaultReaderRead() has been switched from using > ExceptionState to using an error-signalling bool. This is because its > callers do not have access to a real ExceptionState object. Previously > callers used a NonThrowableExceptionState, but this was not suitable as > DefaultReaderRead() can throw. > > BodyStreamBuffer mostly wraps access to ReadableStreamOperations, so > some degree of encapsulation has been retained. > > 7 new layout tests exercise each of the deterministically reachable > crashes, using stack overflows. Because they depend on stack layout and > whether DCHECKs are enabled, they only hit the crashes in particular > environments. > > Bug: 829790, 849312 > Change-Id: I47481b33a47b418dc6916e3b4311e60b5fd89e3d > Reviewed-on: https://chromium-review.googlesource.com/1097047 > Commit-Queue: Adam Rice <ricea@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568009} TBR=ricea@chromium.org,yukishiino@chromium.org,yhirano@chromium.org Change-Id: I4234c9a5ebb7bed44f3f0a66b266b65a80efb295 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829790, 849312 Reviewed-on: https://chromium-review.googlesource.com/1105577Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#568279}
-
Devlin Cronin authored
Add IPv6 support to match patterns (URLPatterns). This is most necessary for implementing activeTab support on IPv6 addresses, and will also be needed for runtime host permissions. Bug: 853064 Change-Id: I0ac1980af679476c17112137575d37ad77490dcc Reviewed-on: https://chromium-review.googlesource.com/1102118Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568278}
-
Ryan Hansberry authored
This change only plumbs DeviceSyncClient into MessageTransferOperation in Tether; it does not actually use it. A subsequent CL will utilize DeviceSyncClient and SecureChannelClient, instead of BleConnectionManager, inside MessageTransferOperation. Bug: 824568, 752273 Change-Id: I8895110082bfa9b3d33f012b62e32e44c2331189 Reviewed-on: https://chromium-review.googlesource.com/1104721Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#568277}
-
Tien-Ren Chen authored
This is a band-aid for a null pointer crash when layer_state_ is accessed. We don't know why a null state can ever happen, and there is no meaningful fallback. This CL skips painting for the offending layer so at least it won't crash. BUG=853096 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I52ae41253440d6937909cc69f1711852fc4efd6b Reviewed-on: https://chromium-review.googlesource.com/1105342Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568276}
-
Daniel Cheng authored
There's no need to pass this by copy. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0a4b7b66d31d040f36bac790a76c3bf7baad91b9 Reviewed-on: https://chromium-review.googlesource.com/1103674Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#568275}
-
Paul Meyer authored
As per this spec: https://wicg.github.io/reporting/#dictdef-reportingobserveroptions Bug: 731810 Change-Id: I50840a97c2858fd04f397fd9799156d8e1e873c5 Reviewed-on: https://chromium-review.googlesource.com/1101312 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#568274}
-
Pedro Amaral authored
The naming convention is coordinator. The controller is the combination of the coordinator and mediator. Change-Id: I80346b7a606cd5e2d86dee0f6d8ef2594a62cbda Reviewed-on: https://chromium-review.googlesource.com/1103386 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568273}
-