- 28 Oct, 2020 40 commits
-
-
Darren Shen authored
Korean used to be supported as a separate extension, where the IDs started with "hangul_". However, in [1], we added first-party support for Korean on Google branded builds, but the ID is "ko-t-i0-und". Currently "ko-t-i0-und" is recorded as T13N for metrics. Add an additional branch in the metrics code so that "ko-t-i0-und" is recorded as Korean too. [1] https://codereview.chromium.org/2898873002/diff/1/chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json Change-Id: If6c6c1af12d0ae7715a561fecbb803a7940575d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497630Reviewed-by:
David Vallet <dvallet@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#821566}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6b087819dd1e..47ee61679da0 2020-10-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from bfd81096a5e6 to adb10d60de32 (1 revision) 2020-10-27 dneto@google.com Fix CMake build when building examples 2020-10-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 70a3f152f2f0 to bfd81096a5e6 (2 revisions) 2020-10-27 kainino@chromium.org Allow unaligned source offset in writeTexture 2020-10-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from fcbc6efa8fd3 to 70a3f152f2f0 (1 revision) 2020-10-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 57694c8dab3c to fcbc6efa8fd3 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I3ed0dccd15ec3afa56b5222925c00947aad39394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504771Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821565}
-
Matt Mueller authored
Quic: add histogram for number of packets that failed decryption, only if a decryption key was present. Bug: b/170619368 Change-Id: Ifb9e2cde75e8e6ff79ed98372b26e35f2fd65a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503572 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821564}
-
Thomas Tellier authored
Bug: 1109266 Change-Id: Ia930e9aa352fe24eb5b10ecad2b47d4a7d2b21c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414394 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#821563}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ia99a7f19f6407024f36b6085b9478060ca630bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504689Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821562}
-
Matt Menke authored
This reverts commit 1421dac0. Reason for revert: A fix has been landed in the internal repo. Original change's description: > Revert "Remove SpawnedTestServer from BrowserTestBase." > > This reverts commit 89540fb3. > > Reason for revert: Causing all desktop builds to fail on perf waterfall (crbug.com/1142930) > > Original change's description: > > Remove SpawnedTestServer from BrowserTestBase. > > > > The last browser tests using the built-in SpawnedTestServer have > > finally been migrated the EmbeddedTestServer, so nothing is using it. > > This also helps reduce visibility of the SpawnedTestServer, so makes > > accidental use of it harder. > > > > This CL also fixes a bunch of IWYU issues that the removal unearthed. > > > > Bug: 492672 > > Change-Id: If2358789b250c62886c352c466cd2ad5c2d6a0d5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495401 > > Commit-Queue: Matt Menke <mmenke@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#821288} > > TBR=jam@chromium.org,mmenke@chromium.org > > Change-Id: Id5e778839d034d0d3c2e7e94241da5e370d1777d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 492672, 1142930 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503315 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821375} TBR=jam@chromium.org,mmenke@chromium.org,johnchen@chromium.org # Not skipping CQ checks because this is a reland. Bug: 492672 Bug: 1142930 Change-Id: I3b0e8ffccf7566c4a96c836d384520f2a08d5a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503332Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#821561}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/22ef2257c862..2acd43d7c9ba 2020-10-27 herb@google.com switch unique_ptr with deleter to GrMemoryPool 2020-10-27 tdenniston@google.com [svg] Implement gradientUnits="objectBoundingBox" 2020-10-27 adlai@google.com Add a bot to run with reduced ops task splitting 2020-10-27 jgaillard@google.com Use shared version of libcutils for host Android builds 2020-10-27 fmalita@chromium.org [skottie] Black & White effect 2020-10-27 johnstiles@google.com Revert "Update the SkSL pool interface to take an allocation size." 2020-10-27 herb@google.com replace GrOpMemoryPool with GrMemoryPool If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I6e5a18702f611c4d5d01f7ec757ae886f038f372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503336Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821560}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5d3967cb630c..daba50861af8 2020-10-27 landrey@webrtc.org Fix issues with setting error message to measurements and tokens If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1128357 Tbr: zhanliang@google.com Change-Id: Iced5a60f310acb8c492b5cba0b6f6d2cfdaf1d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504691Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821559}
-
Matt Mueller authored
Stable rollout is starting in M87 now, update ending milestone to match. Change-Id: I6654f5ccc836430900a59ae4c58637175df1255e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499175Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#821558}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ebb6a5523374..dfa44daef92d 2020-10-27 sokcevic@google.com Add git-migrate-default-branch 2020-10-27 brucedawson@chromium.org Print message when waiting for editor 2020-10-27 tandrii@google.com git-cache: pack refs to reduce # of files downloaded. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I29234dddee17f37edaac7f41912b6ecaa9c64921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504692Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821557}
-
Lei Zhang authored
It is unused, and so are DeprecatedGetMockTickClock(), LegacyMockTickClock and LegacyMockClock. Fixed: 789079 Change-Id: Ic5c504a19dae5217c6e7971cecb3c3325d533c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496506 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#821556}
-
Dale Curtis authored
This changes our reporting to only log the last buffering state change and caps the mp3 stream parser errors at 5 (same as we use in FFmpegDemuxer). To enact this change it requires dropping const status on the MPEG stream parser which is fine. I took the time to move a bunch of unnecessary variables in the header to the .cc file. R=tmathmeyer Bug: 1141985 Test: Updated unittests. Change-Id: I2fd286f654bebb90ab9b0f60cb7d17fbc2c6e146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504008 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#821555}
-
Darren Shen authored
This reverts commit 5588dd6c. Reason for revert: Causing breakages in https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/18895 Original change's description: > Roll DevTools Frontend from ea2a4adced5c to 202a67eebb92 (11 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ea2a4adced5c..202a67eebb92 > > 2020-10-27 brcui@microsoft.com Update Console Error/Warnings Counters CSS for consistency > 2020-10-27 pfaffe@chromium.org Implement support for recursive JS formatters > 2020-10-27 janscheffler@chromium.org [Puppeteer] Add unit test to make sure puppeteer runs in the browser > 2020-10-27 cpinnamaneni@microsoft.com Service worker button to show network panel in drawer. > 2020-10-27 w.hernandez.code@gmail.com Prevent “Emulated Devices” text from wrapping > 2020-10-27 changhaohan@chromium.org Move geometry-related utility functions to ui/Geometry > 2020-10-27 janscheffler@chromium.org [Puppeteer] Update puppeteer to v.5.4.0 > 2020-10-27 tvanderlippe@chromium.org Typecheck formatter/SourceFormatter.js with TypeScript > 2020-10-27 andoli@chromium.org [ts] Typecheck source_frame/ResourceSourceFrame.js with TypeScript > 2020-10-27 andoli@chromium.org [ts] Typecheck source_frame/BinaryResourceViewFactory.js with TypeScript > 2020-10-27 andoli@chromium.org [ts] Typecheck source_frame/ImageView.js with TypeScript > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: chromium:1011811,chromium:1127915,chromium:1133060 > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: I74359b54777be38acd0db3786e3af55fef836dd5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503594 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#821543} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id83b0c90a4041186c94eb6216f55b0e460d0069d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1011811 Bug: chromium:1127915 Bug: chromium:1133060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503530Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#821554}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I6b71e4751b7127a7a8aa38cabd225f6ff4502a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504502Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821553}
-
Minoru Chikamune authored
Context: Per-AgentSchedulingGroup task runners should be used where appropriate. What this CL does: Use per-AgentSchedulingGroup task runners for WebViewImpl's mojo interfaces instead of per-thread task runners. Bug: 1105403 Change-Id: I799dca8fc4425f7f8459c2964de838e292a76edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497785 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#821552}
-
David Dorwin authored
Bug: 1133984 Test: https://crrev.com/c/2503653 Change-Id: If73406bb71f3a0403a53891a260ff99a68e6c410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504052 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821551}
-
Brandon Wylie authored
Bug: 1123209 Change-Id: Ia457b50bd07fe007158a7169c449b8be4cf3d92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492662Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#821550}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I56893579f4ef6f99ee388dfd5a573e763d413505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504501Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821549}
-
Haiyang Pan authored
Also reorder the linux one in mb_config so that the inverse-fieltrials builders are grouped together. Bug: 1099916 Change-Id: I8f38f0f5d1494948836084d55a6872bbafe144ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503403Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#821548}
-
Jose Magana authored
This reverts commit 1bac67ba. Reason for revert: Deprecating custom builder linux-chromeos-chrome-easwa Original change's description: > Custom builder for EA SWA > > For review with: > https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/3268904 > > Bug: b:156979639, chromium:1094203 > Change-Id: I569ea223107ac93a235fa7fe9fa25adb6656a444 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407999 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Auto-Submit: Jose Magana <jomag@chromium.org> > Commit-Queue: Jose Magana <jomag@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806872} Bug: b:156979639 Bug: chromium:1094203 Change-Id: Ic2af2b1862c2ac4b88732fa07912195d1a679cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503989 Commit-Queue: Jose Magana <jomag@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#821547}
-
James Hollyer authored
Changes to the Radio Button's was not properly committing because the wrong CommitChange method was being called. The method needed is the override from the ContentSettingSingleRadioGroup. Bug: 1139250 Change-Id: I9d8d74f21debe7fbeed5acac80d1b24615d5ad3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490783Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#821546}
-
Zhaoyang Li authored
git grep -l '12b5025f' | xargs sed -i '' -e 's/12b5025f/12b5035g/g' Bug: 1140148 Change-Id: Ic3ab0fac78b49a07cf64e9cb13c3cb6ead1d9d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503834Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#821545}
-
Min Qin authored
ChromeDownloadManagerDelegate is owned by DownloadCoreServiceImpl. So it may outlive DownloadManagerImpl. This CL fixes the use-after-free issue by checking whether DownloadManagerImpl is still alive. BUG=1142069 Change-Id: I6d7e39c3911ec6a27be3d8a99463929cc2a45527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504591Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821544}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ea2a4adced5c..202a67eebb92 2020-10-27 brcui@microsoft.com Update Console Error/Warnings Counters CSS for consistency 2020-10-27 pfaffe@chromium.org Implement support for recursive JS formatters 2020-10-27 janscheffler@chromium.org [Puppeteer] Add unit test to make sure puppeteer runs in the browser 2020-10-27 cpinnamaneni@microsoft.com Service worker button to show network panel in drawer. 2020-10-27 w.hernandez.code@gmail.com Prevent “Emulated Devices” text from wrapping 2020-10-27 changhaohan@chromium.org Move geometry-related utility functions to ui/Geometry 2020-10-27 janscheffler@chromium.org [Puppeteer] Update puppeteer to v.5.4.0 2020-10-27 tvanderlippe@chromium.org Typecheck formatter/SourceFormatter.js with TypeScript 2020-10-27 andoli@chromium.org [ts] Typecheck source_frame/ResourceSourceFrame.js with TypeScript 2020-10-27 andoli@chromium.org [ts] Typecheck source_frame/BinaryResourceViewFactory.js with TypeScript 2020-10-27 andoli@chromium.org [ts] Typecheck source_frame/ImageView.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1127915,chromium:1133060 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I74359b54777be38acd0db3786e3af55fef836dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503594Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821543}
-
David Tseng authored
This implements part 1 of go/switch-access-setup Demo: https://drive.google.com/file/d/1COzbS5mllNqgnASFZDFgdTQPX_HPoOa9/view?ts=5f9183e7 Bug: 1140325 Change-Id: Ib58aa8a73a204a900e4e44da7112dc0986584079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477522 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#821542}
-
Lei Zhang authored
Change-Id: I4f5915aaf17e3aa44e1c3d8d70059c4ce97c3347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496196 Auto-Submit: Lei Zhang <thestig@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#821541}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/20aa521f..25d53b85 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I31c75faf7586de6a5c3f3aef471bba4fdc0185a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503430Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821540}
-
Peter Boström authored
Removes manual label-width calculations. Bug: 1142902 Change-Id: Ibd09f522a3b2ce59ccc76281121974cec30190e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503310 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#821539}
-
Nico Weber authored
No bots should set this anymore, so we can make the assert a bit stricter. Bug: 1132930 Change-Id: Ic76c777faf4b3d58761c3063b6371bc1a7e18393 Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472267 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#821538}
-
Tommy Li authored
This CL stops building IntranetRedirectDetector on Android. It seems that on Android, this functionality is active today, and after startup, sends redirect detecting requests 7 seconds after startup, just like on Desktop. This information is not used on Android. This CL modifies the BUILD.gn files to no longer build this functionality on Android or any other non-Desktop platform. Android will no longer make these redirect detect requests after this. Desktop will have a policy to control this behavior. Bug: 1090985, 935772 Change-Id: I9b5e527af01133c3f8a091bcfe807d11c9ea982b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498952 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#821537}
-
Dan Sanders authored
The lifetime was reduced in commit 8d00b895, making the use of base::Unretained() unsafe in this case. Bug: 1142675 Change-Id: I57e16ee028c02313601b9a611e7e335dfdcb4aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504592Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#821536}
-
Alex Turner authored
Use of base::Bind and base::Callback is deprecated in favor of the more explicit Once/Repeating versions. A presubmit enforces this, except on a set of files and directories that have not yet been converted. This list, however, has not always been updated when a directory is migrated. Unfortunately, a few such directories have since regressed. This cl fixes those regressions and removes the legacy exemption for the directories to prevent any future regressions. Bug: 1141533, 1007678, 1007729, 1007733, 1007793 Change-Id: I5efa002606ebacb4efa9db14016cc96f3ac72fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500563 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821535}
-
Sammie Quon authored
From logs, on some scale factors (1567x1044), root window's get bounds functions will return one pixel shorter width (1566x1044). Add a new const member variable that calculates using SnapBoundsToDisplayEdge, and use that variable in all desk animation calculations instead of aura::Window::bounds() and similar. This will prevent off by one pixel bugs like the linked one. Test: manual Bug: 1134391 Change-Id: I3a20c6b21bae63df4d8137a50635320b34d503f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500454Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#821534}
-
Minoru Chikamune authored
Context: per-AgentSchedulingGroup task runners should be used where appropriate. What this CL does: Use per-AgentSchedulingGroup task runners for WidgetBase's mojo interfaces instead of per-thread task runners. Bug: 1105403 Change-Id: I5e59d59520320e50ebccce460da1735b8ee071d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497784Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#821533}
-
Christopher Cameron authored
The Chat PWA is not receiving notifications or badge updates when no tabs are open. This may be an issue with Chrome or somewhere in Chat. The result is that the Chat PWA runs, but does not update the dock icon on new messages coming in, which is a negative user experience. Bug: 1080729 Change-Id: I230ae8041bda448d865ccb48ad4980a1846ed617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504576 Commit-Queue: ccameron <ccameron@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#821532}
-
Yuly Novikov authored
Not running any tests at the moment. Bug: 1134735 Change-Id: I73a977405cfeaca42e0c110b1fc5df5a437e6dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504049Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#821531}
-
Javier Fernández García-Boente authored
When a sequence of preserved space is longer than the line size, we are handle it as trailing space. The HandleTrailingSpace function creates a new ItemResult to handle this trailing preserved spaces. In general, it doesn't need to enable the 'should_create_line_box' flag, since the previous ItemResult associated to that line already has it. However, in case of a ItemResult longer than the line, we would end up with this newly created instance, which flag is disabled by default. This CL enables the 'should_create_line_box' flag for ItemResult with 'end' offset exceeding the line size. This ensures that lines that are all preserved spaces will required a LineBox, hence it should account for computing the box's size. Bug: 1136748 Change-Id: I0df602d3c13129e4369e351c142601c1806214c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503550 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#821530}
-
Tommy Li authored
Currently, when Sync tries to delete the Default Search Provider, Chromium will uniquify the keyword by appending an underscore, and send sync an ACTION_ADD for the deleted engine. The CL that originally added this logic was here: https://chromiumcodereview.appspot.com/10694096 In that CL, there's not an explicit reason why the client is sending an ACTION_ADD to undelete the deleted entry, but I suspect this is attempting to make sure that all clients have the same set of search engines. Instead, I recommend the browser ignore the ACTION_DELETE and leave the existing search engine entry alone. It's not a big deal to have a lingering deleted search engine in this edge case, and it's certainly better than creating a duplicated search engine with an underscore appended to the keyword. If we were really extremely clever, we could mark the attempted deleted TemplateURL as pending deletion, and then later delete it when the default provider pref update comes in, but I think that's over-engineering and creating potentially more problems. Bug: 1022775 Change-Id: Ibc5ab594b5506d27b32334d8f34696479c504c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454833Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#821529}
-
Jordan Bayles authored
Currently, in Chrome when trying to cast the screen we check for permission and tell the user to check System settings if we aren't allowed to cast the screen. However, apps don't show up in System settings until the user has already approved or denied permission for them through a modal dialog that only appears if you try to capture a stream in your application without checking permission. This patch adds a call to CGDisplayStreamCreate in a new method in permissions_utils.h, TryPromptUserForScreenCapture. Bug: 1139695 Change-Id: I719aa6fb4188e723faa1fee3d3b51243edb0059e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495824 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#821528}
-
Roman Arora authored
Fixes: - Close button shifting on focus - Button ripple behavior for different platforms - Remove outline from focused tab search item Related CL: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3314941 Bug: 1128599 Change-Id: I5904e2050b3714b38d4b928197512e81714878f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503193Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#821527}
-