GitLab

BUG=286319

Review URL: https://chromiumcodereview.appspot.com/24027005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221749 0039d316-1c4b-4281-b951-d872f2087c98

http://crrev.com/23478020 was incomplete and this CL implements the rest.

BUG=280219
TEST=none

Review URL: https://chromiumcodereview.appspot.com/23615013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221748 0039d316-1c4b-4281-b951-d872f2087c98

UI for the consent prompt is not ready yet but we want a way to perform an
end-to-end integration test.  This allows the consent to be explicitly given
on the command line.

BUG=chromium:270316
TEST=unit, manual

Review URL: https://chromiumcodereview.appspot.com/23470003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221747 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23688006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221745 0039d316-1c4b-4281-b951-d872f2087c98

NativeViewAccessibilityWin needs to do hit testing in
web content as well as views. While implementing this,
I realized that it isn't necessary to have a special
interface to a RWHV to get an object by child id - we
can just rely on WebView overriding
GetNativeViewAccessible and do the lookup using a
native call.

The same trick works for hit testing - we check if
the point is inside a child's bounding rect, and if so
we call accHitTest on that child's native view
accessible - and since WebView overrides
GetNativeViewAccessible, the recursive call to
accHitTest will return the correct result from inside
the web content.

We still need AccessibleWebViewRegistry (because
looking up objects from child ids gets called A LOT,
but it's much simpler now, just a set of Views.

BUG=284803

Review URL: https://chromiumcodereview.appspot.com/23506027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221744 0039d316-1c4b-4281-b951-d872f2087c98

Will update data to match (including both new and old URLs) before landing.

R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/23450024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221743 0039d316-1c4b-4281-b951-d872f2087c98

oobe timeout error is no longer accurate, so update it.
Do not copy the chrome_login_ext if it's not going to be used.

BUG=None
Test=login_CryptohomeTelemetry, login_CryptohomeIncognitoTelemetry, and telemetry unittests for cros (regular + guest)
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23710017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221742 0039d316-1c4b-4281-b951-d872f2087c98

* Move files out of the roout of examples/ to resources/
* Move files from examples/resources to resources/
* Move Makefile templates to resources/ and rename them.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/23919004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221741 0039d316-1c4b-4281-b951-d872f2087c98

Restoring the change. Verified that this was not the cause of bug 278543.

> Revert 219146 "[sync] Force re-auth during sync setup if Oauth2 ..."
> 
> > [sync] Force re-auth during sync setup if Oauth2 token is unavailable
> > 
> > If an enterprise user disables sync via a dashboard clear, and goes on
> > to re-enable sync at a later time, set up can fail due to an expired or
> > missing Oauth2 token.
> > 
> > This patch updates SyncSetupHandler::OpenSyncSetup to first check if an
> > auth token is available for sync, and if not, force a re-auth.
> > 
> > R=atwilson
> > TBR=fgorski,rogerta
> > BUG=276650
> > TEST=Disable sync for an enterprise user, exit chrome, delete "Web
> > Data*" from the profile dir, restart chrome, and set up sync. Re-auth
> > must be forced in this case.
> > 
> > Review URL: https://chromiumcodereview.appspot.com/23005016
> 
> TBR=rsimha@chromium.org
> 
> Review URL: https://codereview.chromium.org/23759003

TBR=sail@chromium.org

Review URL: https://codereview.chromium.org/23458028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221740 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/23999002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221739 0039d316-1c4b-4281-b951-d872f2087c98

BUG=280900
TBR=erg

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221619

Review URL: https://chromiumcodereview.appspot.com/23437015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221738 0039d316-1c4b-4281-b951-d872f2087c98

The ChromeOS Wifi provider was erronously reporting an initial
scan of 0 wifi access points when the shill's scanning had not
yet completed. This resulted in a fallback to IP geo for the
first request and then proper Wifi based location on the
second request.

BUG=236418

Review URL: https://chromiumcodereview.appspot.com/23889009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221737 0039d316-1c4b-4281-b951-d872f2087c98

BUG=260494
TEST=None
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/22903016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221736 0039d316-1c4b-4281-b951-d872f2087c98

Reposting happens when a menu is running and you click outside the
menu. The code was not setting the root_location of the newly created
event, resulting in anyone attempting to use the root (such as the app
list) getting the wrong thing.

BUG=285662
TEST=see bug
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23694022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221735 0039d316-1c4b-4281-b951-d872f2087c98

Retrieves list of printers for Google Cloud Print. Lets users look up printers
by ID or iterate over all printers.

BUG=286157

Review URL: https://chromiumcodereview.appspot.com/23658020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221733 0039d316-1c4b-4281-b951-d872f2087c98

This will CC reviews of changes to SDK documentation to
native-client-reviews@googlegroups.com

R=eliben@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/23475024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221732 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=bulach@chromium.org

Review URL: https://codereview.chromium.org/23601019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221731 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=stip@chromium.org

Review URL: https://codereview.chromium.org/23601022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221730 0039d316-1c4b-4281-b951-d872f2087c98

BUG=278546

Review URL: https://chromiumcodereview.appspot.com/23867002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221729 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221728 0039d316-1c4b-4281-b951-d872f2087c98

R=siggi@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/23506034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221727 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221726 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157357:157368&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/23480041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221725 0039d316-1c4b-4281-b951-d872f2087c98

RenderViewHost::FromID() should only be accessed in the UI thread. So use
ExtensionRendererState::GetWebViewInfo() instead to determine if the render
view is hosting a guest.

BUG=230655
R=jam@chromium.org

Review URL: https://codereview.chromium.org/23717034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221724 0039d316-1c4b-4281-b951-d872f2087c98

This assures that we're not hanging for a long time at login on the
initial policy fetch for Chrome OS user policy to happen.

BUG=chromium:285694
TEST=See bug, unit tests.

Review URL: https://chromiumcodereview.appspot.com/23450022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221723 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pam@chromium.org,pneubeck@chromium.org
BUG=280674

Original review: https://chromiumcodereview.appspot.com/23466004

Review URL: https://chromiumcodereview.appspot.com/23594007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221722 0039d316-1c4b-4281-b951-d872f2087c98

This delegates timeout logic to the step command.

BUG=
R=bulach@chromium.org, craigdh@chromium.org

Review URL: https://codereview.chromium.org/23784006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221721 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103846

Review URL: https://chromiumcodereview.appspot.com/23587012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221720 0039d316-1c4b-4281-b951-d872f2087c98

> rAc: Wallet: UMA for wallet response codes.
> 
> BUG=261814
> 
> Review URL: https://chromiumcodereview.appspot.com/23461033

TBR=ramankk@chromium.org

Review URL: https://codereview.chromium.org/23604043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221718 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23979003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221716 0039d316-1c4b-4281-b951-d872f2087c98

This function copied an empty GUID leading to Shill not matching the right networks.
This change prevents copying an empty GUID and also checks that all other (required) identifying properties are non-empty.

BUG=280146

Review URL: https://chromiumcodereview.appspot.com/23819024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221715 0039d316-1c4b-4281-b951-d872f2087c98

BUG=261814

Review URL: https://chromiumcodereview.appspot.com/23461033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221713 0039d316-1c4b-4281-b951-d872f2087c98

- LoadDirectoryIfNeeded calls GetResourceEntryByPath for directory metadata.
- GetResourceEntryByPath calls LoadDirectoryIfNeeded for its parent if needed.

The cycle enables to fetch deep entries at any time without waiting for
the full feed nor user to dig down the hierarchy from the root.

Along the way, I removed the handling of  ReadDirectoryByPath("drive/other")
that waited the full feed to arrive. By removing it, all FileSystem
operations are now clearly ensured not blocked by full feed fetching.
Listing up "drive/other" is meaningless; Files.app never does that.

BUG=285614

Review URL: https://chromiumcodereview.appspot.com/23441049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221712 0039d316-1c4b-4281-b951-d872f2087c98

It's multi-sided patch, so again it has ugly ifdefs.

Corresponding blink patch:
https://codereview.chromium.org/23704004/

BUG=257349
TEST=try, both with and without Blink patch

Review URL: https://chromiumcodereview.appspot.com/23762002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221710 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221709 0039d316-1c4b-4281-b951-d872f2087c98

The style guide says that the _test suffix should be used for tests, and the
_unittest suffix is deprecated. Rename all the src/net/websockets test files to
match.

BUG=280943
TEST=net_unittests --gtest_filter="WebSocket*"

Review URL: https://chromiumcodereview.appspot.com/23614009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221708 0039d316-1c4b-4281-b951-d872f2087c98

R=reed@google.com

Review URL: https://codereview.chromium.org/24021004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221707 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221706 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157337:157356&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/24029002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221705 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vrk@chromium.org
BUG=276894

Review URL: https://chromiumcodereview.appspot.com/23480030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221704 0039d316-1c4b-4281-b951-d872f2087c98