GitLab

Also adds:

  assertNotReached("message");

as a rough equivalent of

  NOTREACHED() << "message";

in Chromium and:

  ASSERT_NOT_REACHED();

in blink.

R=arv@chromium.org
BUG=393873
TEST=gyp --depth . ui/webui/resources/js/compiled_resources.gyp ui/webui/resources/js/chromeos/compiled_resources.gyp && ninja -C out/Default/

Review URL: https://codereview.chromium.org/405743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287403 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces ChannelMojo IPC::Channel implementation
and optionally applies it for renderer-browser IPC channel.

Current stability is like 5-seconds browser and There are rough edges.
It often closes the channel so needs to be more robust.
Even though the level of stability, having it in the tree will helps
team to try and improve it.

BUG=377980
R=darin@chromium.org,jam@chromium.org,viettrungluu@chromium.org
TEST=ipc_channel_mojo_unittest.cc

Review URL: https://codereview.chromium.org/382333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287402 0039d316-1c4b-4281-b951-d872f2087c98

The fix basically works in the following way. Look at Zoom Observer overridden methods which is implemented in Browser.cc. When the zoom state changes send relevant messages to Command_Updater to enable / disable Zoom Menu Items.

BUG=32919
TEST=Open a NTP , load a url. Zoom-In max and the Zoom-In menu item should be disabled likewise zoom-out max and the zoom-out menu should be disabled.

When a NTP or a page is loaded by default the zoom scale is 100% hence the Actual size menu item should be disabled.
R=ben@chromium.org

Review URL: https://codereview.chromium.org/310913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287401 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397120,400503,400509,400511,400521
NOTRY=true
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/436363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287400 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400490,400495
NOTRY=true
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/439343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287397 0039d316-1c4b-4281-b951-d872f2087c98

CQ corrupted the PNGs when it landed them. crbug.com/339068

> Copy test data to //extensions
> 
> This copies some assets from //chrome test data into //extensions for use with extensions_unittests.
> 
> BUG=None
> NOTRY=True
> 
> Review URL: https://codereview.chromium.org/443473003

TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/439723007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287395 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287393 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179474:179479&mode=html
TBR=pdr@chromium.org,enne@chromium.org,rjwright@chromium.org
BUG=

Review URL: https://codereview.chromium.org/421293012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287392 0039d316-1c4b-4281-b951-d872f2087c98

* Adding ability to add, remove and load account info
to device mappings in GCMStore with Tests.
* Moving the code resetting load results to LoadResult
structure (fixed a bug where last_checkin_accounts
where not cleared upon failure to load)

R=zea@chromium.org
BUG=374969

Review URL: https://codereview.chromium.org/429073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287391 0039d316-1c4b-4281-b951-d872f2087c98

chrome/android still used system gcc as host compiler, and system gcc is
gcc 4.6 on Ubuntu Precise. This is too old.

Instead, use clang by default as host compiler (except when building for
AOSP, see http://crbug.com/377684 for that). This is controlled by a new
gyp variable host_clang, which only has an effect if clang=0. The existing
clang gyp variable means "use clang for everything"; if it's not set then
host_clang means "use clang for host compiles".

If your system gcc is 4.8+ and you don't want to use clang, you can set
host_clang=0 to use system gcc for host compiles instead.

In host_clang mode, our clang plugins currently aren't used (I figure if you
want plugins, you can just use clang=1). clang_warning_flags on the other
hand are used, to make sure the build stays warning-free.

BUG=360311
R=hans@chromium.org

Review URL: https://codereview.chromium.org/430383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287386 0039d316-1c4b-4281-b951-d872f2087c98

The component has been unused for a long time, is getting stale, and requires maintenance from time to time.

BUG=370966

Review URL: https://codereview.chromium.org/271673006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287385 0039d316-1c4b-4281-b951-d872f2087c98

This copies some assets from //chrome test data into //extensions for use with extensions_unittests.

BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/443473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287384 0039d316-1c4b-4281-b951-d872f2087c98

And Make EventRouterTest inherit ExtensionsTest to setup for test.

R=kalman@chromium.org
BUG=354046
TEST=unittest

Review URL: https://codereview.chromium.org/430243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287383 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
1) Run clang-format through source and header files.
2) Rename data member variables to use unix_hacker_ style.
3) Rename methods to use CamelCase style.
4) Rename file name to test_common.
5) Removed un-used test_common header.

BUG=331299

Review URL: https://codereview.chromium.org/436133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287382 0039d316-1c4b-4281-b951-d872f2087c98

Linux.

This is part #1 for fixing the remaining cases where tab dragging leaves the
user in a weird state if the mouse is released at the "right" time.

BUG=392480
TEST=DesktopWindowTreeHostX11Test.CaptureEventForwarding
TBR=erg (For ui/views/views.gyp)

Review URL: https://codereview.chromium.org/380943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287381 0039d316-1c4b-4281-b951-d872f2087c98

I've landed all client side patches necessary for this feature.
Time to enable it by default for M38.

BUG=382968
R=rogerta@chromium.org

Review URL: https://codereview.chromium.org/437013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287379 0039d316-1c4b-4281-b951-d872f2087c98

This patch changes what we heapify in tile manager raster tile priority
queue. Instead of using objects, we now use pointers to those objects.

The reasoning behind this is that since make_heap et al copy things
around to maintain a heap order, it is significantly cheaper to move
pointer around instead of objects.

Perf results:
Before:
tile_manager_raster_tile_queue_construct:
2= 1348545 runs/s
10= 1297846.75 runs/s
50= 1098756.25 runs/s

tile_manager_raster_tile_queue_construct_and_iterate:
2_16= 74439.5546875 runs/s
2_32= 36854.30078125 runs/s
2_64= 17582.240234375 runs/s
2_128= 8018.2802734375 runs/s

After:
tile_manager_raster_tile_queue_construct:
2= 1294338.75 runs/s (-4%)
10= 1254695 runs/s (-3%)
50= 1047427.375 runs/s (-5%)

tile_manager_raster_tile_queue_construct_and_iterate:
2_16= 298292.03125 runs/s (+300%)
2_32= 176878.578125 runs/s (+380%)
2_64= 93562.8515625 runs/s (+430%)
2_128= 43368.1796875 runs/s (+440%)

R=reveman

Review URL: https://codereview.chromium.org/431433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287378 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370850
TBR=blundell

Review URL: https://codereview.chromium.org/439353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287376 0039d316-1c4b-4281-b951-d872f2087c98

Separate out the Recommended parsing from NetworkPropertyUIData so that
it can be used independently.

BUG=279351

Review URL: https://codereview.chromium.org/433143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287375 0039d316-1c4b-4281-b951-d872f2087c98

Followup for some style issues identified in https://codereview.chromium.org/432083003/

* move windows source files into the main list
  (and filter *_win.{cc,h} on non-windows platforms for all targets)
* remove exclusions of files that don't exist (*_android.cc & *_portable.cc)
* exclude header files corresponding to excluded .cc files

BUG=381456

Review URL: https://codereview.chromium.org/433203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287374 0039d316-1c4b-4281-b951-d872f2087c98

Adding clearer description for DataReductionProxy.BypassedBytes.NotBypasssed histogram as to avoid ambiguity from the naming.

BUG=381416

Review URL: https://codereview.chromium.org/438443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287373 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287372 0039d316-1c4b-4281-b951-d872f2087c98

During extension initialization we should not rely on GetActiveUserProfile().

BUG=397971
TEST=manual

Review URL: https://codereview.chromium.org/428783008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287371 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/dddc18a6bba67ad43a65f4c244b95f76cefef617..41ebbddd76b747d5fb32c02dda0de3d03a3edda5

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel
TBR=bungeman@google.com
BUG=

Review URL: https://codereview.chromium.org/438063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287370 0039d316-1c4b-4281-b951-d872f2087c98

The PNG files are corrupt.

> Add test data for extensions ImageLoaderTest
> 
> Binary data for https://codereview.chromium.org/439023002/
> 
> BUG=397164
> TEST=none
> TBR=yoz@chromium.org
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/433583004

TBR=jamescook@chromium.org

Review URL: https://codereview.chromium.org/430823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287367 0039d316-1c4b-4281-b951-d872f2087c98

IsCurrentUserNew always returned true for supervised users after recent
refactoring of UserManager.

BUG=387614

Review URL: https://codereview.chromium.org/437233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287366 0039d316-1c4b-4281-b951-d872f2087c98

R=rockot@chromium.org
BUG=354046

Review URL: https://codereview.chromium.org/418413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287365 0039d316-1c4b-4281-b951-d872f2087c98

The culmination of all this USB gadget nonsense... the HidConnection
tests can now use the USB gadget framework I have built to validate
device I/O works. This replaces the code based on a specially programmed
Arduino running the LUFA library.

BUG=396682

Review URL: https://codereview.chromium.org/423473008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287364 0039d316-1c4b-4281-b951-d872f2087c98

The new message is called sendMessageToBrowser.

BUG=398049

Review URL: https://codereview.chromium.org/423673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287363 0039d316-1c4b-4281-b951-d872f2087c98

This test breaks on iOS Simulation.

Introduced by https://codereview.chromium.org/425593002

BUG=400382
TBR=nednguyen

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287361

Review URL: https://codereview.chromium.org/438043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287362 0039d316-1c4b-4281-b951-d872f2087c98

This test breaks on iOS Simulation.

Introduced by https://codereview.chromium.org/425593002

BUG=400382
TBR=nednguyen

Review URL: https://codereview.chromium.org/438043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287361 0039d316-1c4b-4281-b951-d872f2087c98

BUG=264859
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/433023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287359 0039d316-1c4b-4281-b951-d872f2087c98

I have no idea why some builds pass now. Locally without this dll, it fails 100% of the time.

TBR=maruel

Review URL: https://codereview.chromium.org/435193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287358 0039d316-1c4b-4281-b951-d872f2087c98

Relocations with addend use the addend rather that the location pointed
to by the relocation as the target of the relocations.  For RELA
relocations, ignore the target and instead adjust the addend for the
hole being created in the file.  Change unit test data accordingly.

Ensure that sections we resize are never zero-length when we load the
Elf file, and that we never set either to zero-length on packing.

BUG=385553

Review URL: https://codereview.chromium.org/423393010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287354 0039d316-1c4b-4281-b951-d872f2087c98

BUG= 399517

Review URL: https://codereview.chromium.org/422863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287353 0039d316-1c4b-4281-b951-d872f2087c98

Binary data for https://codereview.chromium.org/439023002/

BUG=397164
TEST=none
TBR=yoz@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/433583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287352 0039d316-1c4b-4281-b951-d872f2087c98

OOBE shows the network selection screen first. This screen will change
the application locale when it finishes loading and once again when it
loses focus.

This CL ensures that tests wait until both events have happened before
proceeding so that locale switches initiated by the network selection
screen do not interfere with the locale switching code that is actually
under test.

BUG=214904,241790
TEST=DeviceLocalAccountTest.SelectLanguageAndKeyboardWithTermsOfService
R=pneubeck@chromium.org

Review URL: https://codereview.chromium.org/423073009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287350 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the options for tracing were passed around with different ad hoc
systems. Strings in some places, base::debug::TraceOptions enum in others,
and a content::TraceOptions in yet another. There were two separate ad-hoc
string formats. Similar messes were present with category filters: sometimes
we passed strings, sometimes the CategoryFilter.

This patch though enormous looking simply consolidates all this ad-hockery
into base::debug::TraceOptions. It may look like the call sites have gotten
more verbose,
but the end result of this is a consistent understanding of TraceOptions.

There is one exception to this consolidation: devtools has to maintain its own
mapping of string->TraceOptions encoding. This is because DevTools makes
guarantees about backward compatibility: if base changes its mind about the
string form of a TraceOption, devtools needs to keep supporting the old form.

BUG=396081
TBR=cevans@chromium.org

Review URL: https://codereview.chromium.org/425593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287348 0039d316-1c4b-4281-b951-d872f2087c98

This test is flaky on Android, so disable it there.

BUG=392446
TBR=nduca@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/439243006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287347 0039d316-1c4b-4281-b951-d872f2087c98

R=pdr
NOTRY=true

Review URL: https://codereview.chromium.org/441673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287346 0039d316-1c4b-4281-b951-d872f2087c98