GitLab

R=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/296483005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271736 0039d316-1c4b-4281-b951-d872f2087c98

BUG=351479
TBR=hans@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/274533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271732 0039d316-1c4b-4281-b951-d872f2087c98

- Some bitmaps end up with a NULL getPixels(). Don't try to copy ot of that.
- Only try to copy 32-bit bitmaps
- Protect against overflow in size computation

BUG=369621

Review URL: https://codereview.chromium.org/289573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271730 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271729 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=29&start=14795
TBR=
BUG=

Review URL: https://codereview.chromium.org/296483006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271728 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313788
TBR=gbillock@chromium.org

Review URL: https://codereview.chromium.org/295983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271727 0039d316-1c4b-4281-b951-d872f2087c98

This disables blink platform since there's an error in that file caught by this new build.

TBR=scottmg

Review URL: https://codereview.chromium.org/296053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271726 0039d316-1c4b-4281-b951-d872f2087c98

[This is take three. I believe that I've now fixed all the static
initializers (including both files named debug_utils.cc that were
including <iostream>), the packaging failures, and the black border
on the app list as pointed out by mgiuca@.]

Running chrome with the "--open-ash" parameter will create an ash
desktop window. Ash on Linux has some problems, but at least we're now
compiling the code into the binary.

TODO: The applist isn't positioned correctly, and some details of the
system tray aren't correct.

BUG=300084, 303862
TBR=sky@chromium.org
First Review URL: https://codereview.chromium.org/25108005

Review URL: https://codereview.chromium.org/292443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271725 0039d316-1c4b-4281-b951-d872f2087c98

Parameterize webrtc enabling.

Add use_seccomp_pbf flag

Add a webkit version target

Work on ui/base GN build, especially on Windows. This target is a mess (in GYP). This patch tries to make it make a bit more sense while fixing the errors I found.

Fix ui/gl target for non-Linux platform. A bunch of X11 stuff was not parameterized.

Add unscaled resources target

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/287343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271724 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/291163007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271723 0039d316-1c4b-4281-b951-d872f2087c98

This removes CompositeAndReadback support from the scheduler, since the
code path is now removed.

R=brianderson
BUG=251936

Review URL: https://codereview.chromium.org/292533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271722 0039d316-1c4b-4281-b951-d872f2087c98

As discussed in the linked bug, the toolchain2013.py script in
depot_tools is no longer workable (because the update for Update 2 is
supplied as a .msp that must be applied against a system-installed
VS2013).

As such, the Express hash here is not updated.

The hash zip referenced here was built as follows:
- Install VS2013 Update 2 on a clean VM
- Copy DIA SDK\, VC\
- Copy DLLs from VC\redist to sys32\ and sys64\
- Copy win8sdk unchanged from previous .zip.
- Delete various unused arm\ subdirectories
- Delete the IDE-only Snippets, etc. subdirectories in VC\
- Patch VC\include\xtree to disable warning 4702 per request in
  http://crbug.com/346399 .

A followup change will be to write a script that does these steps
semi-automatically, hopefully for Express too, though there is the
added complication of the WDK/ATL/MFC hacking required there. In
particular, this script will not be useful for a dev to actually run
as part of runhooks, but will be a bit useful for deployment/
documentation of the above process.

In the interim there are no extremely-pressing reasons for Express
users to update to Update2 that I'm aware of, so they get non-Update2
for now.

R=iannucci@chromium.org
BUG=372451,346399,371847,339215,350639

Review URL: https://codereview.chromium.org/284663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271721 0039d316-1c4b-4281-b951-d872f2087c98

Rebased version of https://codereview.chromium.org/287083003/

BUG=364604, 351655
TEST=existing tests
TBR=sky,zelidrag

Review URL: https://codereview.chromium.org/294033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271720 0039d316-1c4b-4281-b951-d872f2087c98

This lifts more manifest processing code out of the trusted plugin.
Specifically, instead of the trusted plugin receiving a PP_Var with the contents
of the manifest and making another method to create the manifest id, the
trusted plugin now simply receives the manifest ID directly.

BUG=239656

Review URL: https://codereview.chromium.org/287153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271719 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/298743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271718 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes it possible to enable dynamic mode on any platform without
breaking all of the browser tests that rely upon translation functionality
working properly. Basically, we copy a static version of the CLD data file
into the place where it would be put by the dynamic data mechanism that has
been built. This allows the browser to find it immediately, and tests can
run as normal. Without this patch, all tests that rely directly or
indirectly upon language detection will fail.

BUG=367239

Review URL: https://codereview.chromium.org/285293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271717 0039d316-1c4b-4281-b951-d872f2087c98

Failing on Linux Debug bot on Blink waterfall as well. See Issue 375103.

BUG=375103
TBR=ncbray@chromium.org

Review URL: https://codereview.chromium.org/299623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271716 0039d316-1c4b-4281-b951-d872f2087c98

In the WebView shouldInterceptRequest is called on the IO thread.
The CookieManager used to post cookie monster tasks to a thread
which was sometimes the IO thread (if the WebView was started 
before the CookieManager) but sometimes a special thread (if the
CookieManager was started before the WebView).

getCookie is synchronous and blocks waiting for the result after
posting its task so if getCookie was called from
shouldInterceptRequest and the cookie monster was on the IO thread
then it deadlocked.

We fix this by always starting the special thread for the cookie
monster.

Android Issue: https://code.google.com/p/android/issues/detail?id=65786

BUG=374203

Review URL: https://codereview.chromium.org/284313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271715 0039d316-1c4b-4281-b951-d872f2087c98

- Make SigninScreenHandler a ScreenlockBidge::LockHandler and
  get rid of middle layers;
- Remove deprecated custom button click;
- customButton -> customIcon renaming and HTML/js/css update;
- Move api test out of cros;

R=asargent@chromium.org, isherman@chromium.org, rogerta@chromium.org, tengs@chromium.org

Review URL: https://codereview.chromium.org/289013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271714 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98313,374943
NOTRY=true

Review URL: https://codereview.chromium.org/294763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271712 0039d316-1c4b-4281-b951-d872f2087c98

In this case, it's not very useful and full of false positives.
NOTRY=true

Review URL: https://codereview.chromium.org/293843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271711 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271710 0039d316-1c4b-4281-b951-d872f2087c98

Remove suppressions for false positives / intentional leaks in Blink code. They
have since been annotated with in-code annotations.

BUG=121729, 242672
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/292663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271709 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374838
R=kareng@google.com

Review URL: https://codereview.chromium.org/294113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271708 0039d316-1c4b-4281-b951-d872f2087c98

Hooks up the blink GN build to the main GN build. Android is currently disabled
(some dependencies are not complete yet).

R=eseidel@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/296513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271707 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374452
R=benchan@chromium.org, jennyz@chromium.org

Review URL: https://codereview.chromium.org/286923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271706 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271705 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174366:174386&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/298723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271704 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves the New Window API and navigation to chrome.

This CL removes a lot of unnecessary content APIs for BrowserPlugin now that permissions no longer live in content.

Up next, in a separate CL will be a huge cleanup that removes all WebContentsDelegate code out of BrowserPluginGuest and into WebViewGuest. This should significantly reduce the size of the BrowserPlugin content API.

BUG=364141, 330264
TBR=kenrb@chromium.org for trivial browser_plugin_messages.h change.

Review URL: https://codereview.chromium.org/272573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271703 0039d316-1c4b-4281-b951-d872f2087c98

internal server.

Merge internal change: 67534473

R=rch@chromium.org

Review URL: https://codereview.chromium.org/290893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271702 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162740
NOTRY=true

Review URL: https://codereview.chromium.org/290493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271701 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
Test=Internal cleanup.

Review URL: https://codereview.chromium.org/288393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271700 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/295893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271699 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None (cleanup only, does not change behavior)

Review URL: https://codereview.chromium.org/278013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271698 0039d316-1c4b-4281-b951-d872f2087c98

Breaks android builder due to PNG corruption from ASCII conversion (same error
as on try job).

http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Builder%20%28dbg%29&number=58007

> Web MIDI: add permission infobar icon for Android
> 
> On Android, permission infobar appears for Web MIDI permission,
> but correct icon is not used. This change add a proper icon.
> 
> Submit with NOTRY=true since it contains binary files and the patch
> fails on try.
> 
> BUG=339767
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/292743004

TBR=toyoshim@chromium.org

Review URL: https://codereview.chromium.org/291213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271697 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271693 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/287063010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271692 0039d316-1c4b-4281-b951-d872f2087c98

Right now TSan doesn't support suppressions for any lock inversion stacks but the top one.

BUG=374135
TBR=jyasskin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/295933004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271691 0039d316-1c4b-4281-b951-d872f2087c98

We need SurfaceFactoryOzone initialized in the GPU process.

TBR=sadrul
NOTRY=true

Review URL: https://codereview.chromium.org/288033019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271689 0039d316-1c4b-4281-b951-d872f2087c98

I accidentally typed "git svn dcommit" instead of "git cl dcommit", which used
my local commit message instead of the CL description. :(

> i

TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/289353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271688 0039d316-1c4b-4281-b951-d872f2087c98