- 06 Mar, 2020 40 commits
-
-
Dominique Fauteux-Chapleau authored
Fixed by moving the file-reading callback to where it's actually needed. Bug: 1058891 Change-Id: Id90f7de25ce747a7647c1259a7e7cb48885caecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090511Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#747784}
-
Ben Joyce authored
Bug: 1052460 Change-Id: I044ee0b2e13e9cafd51c64ffa92f4de5e152f79a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087173 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#747783}
-
Boris Sazonov authored
Consistently fails on K. Example build: https://ci.chromium.org/p/chromium/builders/ci/KitKat%20Phone%20Tester%20%28dbg%29/20759 TBR=meiliang@chromium.org Bug: 1059299 Change-Id: I63fa06d7aeb69d994175bcd0eb11bd56f3b81add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091726Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#747782}
-
Mei Liang authored
This CL enables baseline_tab_suggestions under the Immediate variation for close tab suggestion. Change-Id: Ibe37fe0060fd00d6d56e530e18bc9eee1ab81efc Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090798Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
David Maunder <davidjm@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747781}
-
ckitagawa authored
Clairfy the correct thread behaviors for PaintPreviewClient and PaintPreviewBaseService. Largely just a documentation change. Change-Id: Ia1f9cadc8420a80610b3fd8ddb17d77bae3b12d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090198Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#747780}
-
Jose Lopes authored
Change-Id: I5c8a7f25889b7dfeca4c4b9693e456dac749c63a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087725 Auto-Submit: Jose Lopes <jabolopes@google.com> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747779}
-
Gabriel Charette authored
We opted for this instead of outright removing the code since a semi-recent change requires the migration logic. R=davidbienvenu@chromium.org, grt@chromium.org Bug: 1055349 Change-Id: Ie137bca4801f3647d37f1e12ad65bea353c43b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087982 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#747778}
-
Deepanjan Roy authored
Now that trace processor can read and emit proto annotations, we no longer need a separate json config. I turned the description into comments, and it will likely stay that way because descriptions are rarely used. We eventually want the requiredCategories to be a file/message option instead of the comment, but right now trace processor only supports field options and not file/message options, so we'll have to wait until that's implemented. Bug: 1012687 Change-Id: I4ef713ebef151e959b9c373a220f9f2630415ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090452Reviewed-by:
Deep Roy <dproy@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Deep Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#747777}
-
Yann Dago authored
Bug: 1033573 Change-Id: I82212918f95850c8e650011d54dd9f6c752e99c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087696 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#747776}
-
Andrey Kosyakov authored
Use v8::StackTrace::CurrentStackTrace() rather than v8_inspector::captureStackTrace() to capture stack trace when looking for script origin. This allows us to bypass forced resolution of location info (line numbers, method names etc) and when the related v8 change is landed (http://crrev.com/c/v8/v8/+/2080663), greatly speeds DOM operations on certain pages with DOMSnapshotAgent enabled. Bug: 1057211 Change-Id: Ifbb5c7fb89b1f752f5d353d138d3b2c52bcd7e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079165Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#747775}
-
Peter Kasting authored
This is never subclassed. Inline its functionality into ScopedViewsTestHelper and clean up a bunch of stuff as a result. Bug: none Change-Id: Ib8abbd30a8d19becfa6de78309cbc9a2f2581263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091272 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#747774}
-
Maks Orlovich authored
Change-Id: I13376d67fadeed4b7fe6e6c4114876d4a21c10ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090338 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#747773}
-
Vladimir Levin authored
This patch rewrites and cleanups the subtree visibility wpt tests - Consistent naming - Consistent reference and style in the tests - Removed duplicate and unnecessary tests R=chrishtr@chromium.org Fixed: 1007291 Change-Id: Ia0ebcc9d380f26a2e7ac10ad745416c570779ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090017Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#747772}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/93731aec6bd2..9d8c9bf34d9c git log 93731aec6bd2..9d8c9bf34d9c --date=short --first-parent --format='%ad %ae %s' 2020-03-06 jacktfranklin@chromium.org Remove Sinon and associated deps Created with: gclient setdep -r src/third_party/devtools-frontend/src@9d8c9bf34d9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib3ec218fc8a16e1d7beaa200f17424ecc09e8512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091424Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747771}
-
gogerald authored
getCurrentUrl returns the NTP url in overview mode after this CL https://chromium-review.googlesource.com/c/chromium/src/+/1894293 Overview mode is considered visible before finished hiding. So, previously, getUrlBarData in handleOmniboxInOverviewMode would return the data for overview mode. In this CL, I moved the update to after finished hiding the tab switcher. Bug: 1049847 Change-Id: I08e7508ec3426314d924b008bb2e472103ae77e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088020Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#747770}
-
Collin Baker authored
This reverts commit 4093df97. Reason for revert: build failures (e.g. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Builder%20(dbg)/169420?) Original change's description: > Move ExecutionContext to LocalDOMWindow > > This actually changes the structure, so that LocalDOMWindow inherits > ExecutionContext, rather than Document. > > I left as much logic as I could on Document, and had LocalDOMWindow > call in to it. A few things needed to move for consistency, and I moved > anything where the Document override of a ExecutionContext function > was only called through the ExecutionContext interface. > > Added null-checks and updated code to final format where it was necessary > to keep tests passing, otherwise left transitional code/helpers intact. > > Updated many unit tests that needed an ExecutionContext to use > DummyPageHolder instead of just a standalone Document. > > Bug: 1029822 > Change-Id: I9e4276aaeba476289e260e7a28e500db9982a424 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051021 > Commit-Queue: Nate Chapin <japhet@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747759} TBR=dcheng@chromium.org,yhirano@chromium.org,haraken@chromium.org,japhet@chromium.org Change-Id: I50475a6d5d6f50ba1891a18c078031555806fae5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090204Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#747769}
-
Adam Norberg authored
This introduces types to represent update states and update priority. Bug: 1048654 Change-Id: I9c09df32cad49a7e9901ed93e7cf3dd43ead6a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073399 Commit-Queue: Adam Norberg <norberg@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747768}
-
Mike Rorke authored
Fix for potential deadlock between crashpad and ExitCodeWatcher during launch - Bug:1057774. In the case where we fail to fully initialize crashpad, we need to explicitly stop the ExitCodeWatcher. Bug: 1057774 Change-Id: I31befef2bf25477d38d78c4d136a76d3aaa3be52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087900Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mike Rorke <mrorke@microsoft.com> Cr-Commit-Position: refs/heads/master@{#747767}
-
Dana Fried authored
Extension icons were the wrong size *and* inkdrops were rendering at the wrong size. This CL creates a common point for determining the appropriate size for both toolbar icons and extension icons, and by simplifying how inkdrop size and insets calculations happen. Bug: 1006162, 1051393, 1055239 Change-Id: I6f5719f9904a21288f3caab0cb0da6a37b9a77f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042263 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#747766}
-
Jun Cai authored
This CL converts base::Bind and base::Callback in //components/domain_reliability to Once or Repeating Bug: 1007684 Change-Id: Ieee7760f16aaf9f46720b6918b0797b929f62b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090029Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#747765}
-
Kevin McNee authored
Tbr: oysteine@chromium.org Bug: 1008387 Change-Id: I5641418a0822f80dc281481248e6008f62125b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091705Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#747764}
-
adamta authored
When running on a non-windows platform, MachineIdProvider will provide the hardware model name. Bug: 981408 Change-Id: I1edae511b1e79cb2360630c1253c4e7209aeec3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088531 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#747763}
-
Jan Wilken Dörrie authored
This change adds an extract() and replace() API to base::flat_tree which are inspired by the equivalently named API mentioned in the standardization proposal of std::flat_map and std::flat_set. References: - https://wg21.link/p0429 - https://wg21.link/p1222 Bug: 682254 Change-Id: If517376aa7a682064d55882a0eecf4ff1ce89eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091352Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#747762}
-
Ahmed authored
- Focusing the desk name should select all text, unless the user clicks and drags to make their own selection. - Tab / Shift+Tab should commit any pending name changes. - Commit changes on: - Clicking on empty places in the desks bar. - Creating / removing desks. - Dragging a window in overview. - Reduce the vertical spacing before and after the DesksNameView. BUG=1040980 TEST=Manually, added some tests. Change-Id: I834c24890ff92a9e72b485328a90a6dd63b117e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083870Reviewed-by:James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#747761}
-
Henrique Nakashima authored
This allows caching double-typed field trial parameters for use before native is loaded. Also implement methods to read and write double-typed values with SharedPreferencesManager. Bug: 1041865, 1012975 Change-Id: Ieba6e8b41ed566bbd087ddba84c53260a16d481c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087429Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#747760}
-
Nate Chapin authored
This actually changes the structure, so that LocalDOMWindow inherits ExecutionContext, rather than Document. I left as much logic as I could on Document, and had LocalDOMWindow call in to it. A few things needed to move for consistency, and I moved anything where the Document override of a ExecutionContext function was only called through the ExecutionContext interface. Added null-checks and updated code to final format where it was necessary to keep tests passing, otherwise left transitional code/helpers intact. Updated many unit tests that needed an ExecutionContext to use DummyPageHolder instead of just a standalone Document. Bug: 1029822 Change-Id: I9e4276aaeba476289e260e7a28e500db9982a424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051021 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Nohemi Fernandez authored
This patch concerns the change in the skip button text to 'No Thanks' and the presentation of the user sign-in as fullscreen. Note that the first run logging will be extracted in a separate patch. Bug: 971989 Change-Id: I372937780288b190948819605a913d50dae81cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087617 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747758}
-
Koji Ishii authored
This patch fixes: 1. |LayoutNGBlockFlowMixin<Base>::AddOutlineRects| to call |NGPhysicalContainerFragment::AddSelfOutlineRects| if it has |NGFragmentItems|. This is needed to include inline continuation when FragmentItem is enabled. 2. |NGPhysicalContainerFragment::AddOutlineRectsForNormalChildren| to include child boxes of line boxes. Fixes two failures. Bug: 982194 Change-Id: I9d4f73caa2f7f7e063a8db667aeb88f1dce7ac62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967096Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#747757}
-
Kevin McNee authored
Tbr: afakhry@chromium.org Bug: 1049178 Change-Id: I54c8d2e9a480917ab1bd8466f9232effb0f6aee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090200Reviewed-by:
-
Mohsen Izadi authored
Each thread (impl and main) will be processing at most one event at a time. This means that EventsMetricsManager does not need to have a list of active events. A single active event would suffice. Bug: 1054007 Change-Id: Iebaa9deb0f88dc73bcf7d0612e989fac7b7d03f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067356Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#747755}
-
Mark Schillaci authored
This CL addresses missing actions that were added in various Android SDK's after version M. Here we add all those actions, and for a subset of them we have fully implemented their behavior: - ACTION_PAGE_UP - ACTION_PAGE_DOWN - ACTION_PAGE_LEFT - ACTION_PAGE_RIGHT - ACTION_SET_PROGRESS For other actions we have included them and stubbed methods but have not fully implemented them. Namely ACTION_IME_ENTER will be addressed in an upcoming CL. Bug: 1057254 Change-Id: I9e29a3bc0c895a9110a297d1cef607a1d5dba6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082088Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#747754}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a095711c5d77..8c13b2f02094 git log a095711c5d77..8c13b2f02094 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 capn@google.com Explicitly compile with warnings-as-errors 2020-03-05 capn@google.com Support launching PowerVR samples from Visual Studio using SwiftShader Created with: gclient setdep -r src/third_party/swiftshader@8c13b2f02094 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1059196 Tbr: swiftshader-team+autoroll@google.com Change-Id: Ica8b2d431aef339a35dc45dcf467dbffbb0dfa13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091422Reviewed-by:
-
Maks Orlovich authored
1) If we're navigating a top-level, feature policy isn't generally available; this broke its application for client hints in fresh tabs. Instead, just use 1P check since we don't have feature-policy yet. 2) The 1P/3P check is also needed if we don't have feature policy use enabled. 3) The bug in #2 was unnoticed because the virtual testsuite for feature policy integration off only disabled it on renderer and not browser. Bug: 1050726 Change-Id: I9a26e8f818656e96ba130da38d08ccd017867f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087977 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#747752}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8e9fd4857e2e..74dadc1e8e33 git log 8e9fd4857e2e..74dadc1e8e33 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 minyue@chromium.org Ready to support of absolute capture timestamp header extension. 2020-03-06 hbos@webrtc.org Correct email address in OWNERS file. 2020-03-06 hbos@webrtc.org [Overuse] Initial version of VideoStreamAdapter (Restrictor moved). 2020-03-06 danilchap@webrtc.org Migrate RtcpTransceiver to use webrtc::TaskQueueBase instead of rtc::TaskQueue Created with: gclient setdep -r src/third_party/webrtc@74dadc1e8e33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I224dd4e7fb84c7eddb14c10d98dc5c6410eb462c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089783Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e85398565d3..6535f4251dfc Created with: gclient setdep -r src-internal@6535f4251dfc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I293bf7ce8a5c0ab2d63f2d4c6791aac42e321600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091419Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747750}
-
Mathias Bynens authored
This reverts commit e4048c2e, and applies the fix from https://chromium-review.googlesource.com/c/chromium/src/+/2087672. Original change's description: > [DevTools] Support vision deficiency emulation in CDP > > This patch makes it possible to emulate various vision deficiencies, > including color vision deficiencies and blurry vision, in the Blink > Renderer. The various deficiencies can be triggered by the new > Emulation#setEmulatedVisionDeficiency command in the Chrome DevTools > Protocol. > > Design doc: https://goo.gle/devtools-cvd > > Bug: chromium:1003700 > Change-Id: Ie86d14b215b93aa219b91b0e7877898d2d47bc5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063136 > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746715} TBR=caseq@chromium.org,vogelheim@chromium.org,mathias@chromium.org,futhark@chromium.org Bug: chromium:1003700 Change-Id: I3f3e91dd72e7fb479eb7d73ba8452fc876e20b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087347Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#747749}
-
Mark Cogan authored
As part of preparing for multi-window, the URLLoadingService needs to be migrated to be a BrowserAgent instead of a KeyedService. That change is itself fairly large, but as an additional complication URLLoadingService is used in downstream code. This CL is the first in a series of changes needed to complete this refactor: 1. Add a new provider API upstream that passes both a Browser and temporary URL loading shim to CreateLogoVendor. 2. Implement this new API downstream and add support for initializing the LogoController with both Browser and the loading shim. Use the loading shim for loading URLs if it is present. 3. Upstream, call the new CreateLogoVendor() API. 4. Downstream, remove support for the old CreateLogoVendor() API and update LogoController to only be initialized with a Browser and the shim loader. Remove downstream use of the URLLoadingService. 5. Upstream, refactor URLLoadingService to be URLLoadingBrowserAgent, including updating the upstream implementation of the loading shim passed downstream in CreateLogoVendor(). 6. Upstream, add a new provider API that no longer passes the loading shim into CreateLogoVendor(). 7. Downstream, remove use of the loading shim from LogoController and have it fetch the URLLoadingBrowserAgent from its Browser parameter. Implement the new shim-less CreateLogoVendor() API. Remove the implementation of the shimmed API. 8. Upstream, remove the loading shim protocol and the old shimmed CreateLogoVendor() API. Call only the new shimless API. Specifically, this CL creates a shim URLLoadingBridge protocol so that the implementation of the actual URL load can be changed upstream in a single CL upstream (step 5 in the process above). At the same time, a Browser object is also passed into the provider so that after the loading service is changed, it can be fetched (via Browser) in the downstream code. This CL doesn't introduce any implementation of the shim protocol; that will be in step 3. Bug: 1046374 Change-Id: Ic2388c0f9680dabc8cb10349255cc9ab281cccbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089687Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#747748}
-
sandromaggi authored
Previous to this CL, when detaching / attaching the UI the form would be recreated in its initial state. This CL reads the already existing data from the last result and uses it to initialize the form. Bug: b/150929960 Change-Id: If416659092dae45f282be120af0128ff6fcbd2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091486Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#747747}
-
Jan Wilken Dörrie authored
This change implements sending a PasswordCheckStatusChanged event to JavaScript whenever the status of the password check changes. Bug: 1047726 Change-Id: I68361cef3ab1eb232b1ff4883bf56158adfa4be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087676 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747746}
-
Peter Kotwicz authored
This CL: - Makes StatusBarColorController use TopToolbarThemeColorProvider instead of StatusBarColorController.StatusBarColorProvider - Deletes CustomTabStatusBarColorProvider.java - Renames TabThemeColorProvider to TopToolbarThemeColorProvider and makes it return the correct value when there is no active tab. - Moves StatusBarColorController owners to RootUiCoordinator BUG=1015627 Change-Id: I0aff744a8901c00c6198adfa1a086b7de6193a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063966 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#747745}
-
