GitLab

This CL:
* Introduces ShowKeyboard, HideKeyboard, and IsKeyboardVisible
  to keyboard_controller.mojom.
* Includes HideReason for HideKeyboard (User or System).
* Introduces keyboard::mojom::KeyboardEnableFlag::kTemporarilyEnabled
  for temporarily enabling the keyboard and showing it.
* Renames keyboard::mojom::ReloadKeyboard() -> RebuildKeyboardIfEnabled().
* Introduces keyboard::mojom::ReloadKeyboardIfNeeded() which calls
  KeyboardUI::ReloadKeyboardIfNeeded() which updates the keyboard URL if
  it has changed and otherwise does nothing.
* Replaces direct calls to KeyboardController from most of src/chrome
  Notable exception: ChromeVirtualKeyboardDelegate which will be
  transitioned in a follow up CL.

Bug: 843332
Change-Id: I2faf000c8233ee0253b799a6e4780020ba3bbe1f
Reviewed-on: https://chromium-review.googlesource.com/c/1309215
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606311}

type-change-state.html contains assertions for the following operation in [1]:
> ..., and set its selection direction to "none".

However it had an issue that the assertions checked if
input.selectionDirection was "none". According to [2],
input.selectionDirection can be "forward" on specific platforms.

> update the element's selection direction to the given direction, unless
> the direction is "none" and the platform does not support that direction;
> in that case, update the element's selection direction to "forward".

[1] https://html.spec.whatwg.org/multipage/input.html#the-input-element:set-the-selection-direction
[2] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#set-the-selection-direction

Change-Id: Idc1a97fbb2036e351a788a1f758b3239308d8c71
Reviewed-on: https://chromium-review.googlesource.com/c/1322264Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606310}

Extensions can download and execute a pyo or pyd with no user gestures,
allowing for remote code execution. By marking pyo and pyd as
ALLOW_ON_USER_GESTURE and DANGEROUS, respectively, we prevent this
behavior.

Bug: 902234
Change-Id: I295cdd2906ebe779670afb55196cea7715dc88f4
Reviewed-on: https://chromium-review.googlesource.com/c/1324419
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606309}

This reverts commit 7acd0b52.

Reason for revert: Re-landing with crashfix

Original change's description:
> Revert "Perfetto: Optimization to avoid string table lookup for _END events"
> 
> This reverts commit a7afe430.
> 
> Reason for revert: I suspect this may have caused crashes on https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi#
> 
> Original change's description:
> > Perfetto: Optimization to avoid string table lookup for _END events
> > 
> > If we're emitting an _END trace event, we know that the string
> > table entries for the name and the categories have already been
> > emitted and so we don't need to check the string table in this
> > case.
> > 
> > R=​primiano@chromium.org,skyostil@chromium.org
> > 
> > Change-Id: I9107bffb0b48f7b71d0a42961a78a3861ffcb76f
> > Reviewed-on: https://chromium-review.googlesource.com/c/1258043
> > Commit-Queue: oysteine <oysteine@chromium.org>
> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#600183}
> 
> TBR=primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: Ia460750fcaf338c4bf24ee7317d58b7aeede9520
> Reviewed-on: https://chromium-review.googlesource.com/c/1293612
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601586}

TBR=cbiesinger@chromium.org,primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I8f3b5c21494d66fe9e6c25363627ec156f5abf12
Reviewed-on: https://chromium-review.googlesource.com/c/1325077
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606308}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/49c8eafcd54c..75fa8552337b


git log 49c8eafcd54c..75fa8552337b --date=short --no-merges --format='%ad %ae %s'
2018-11-07 kylixrd@chromium.org Quote the full path to ninja.exe.


Created with:
  gclient setdep -r src/third_party/depot_tools@75fa8552337b

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:902930
TBR=agable@chromium.org

Change-Id: I1b849e997ef8e1b4a02affbd5dc8575bfb3b8664
Reviewed-on: https://chromium-review.googlesource.com/c/1324856Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606307}

base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
explicit counterpart.

It should have been replaced by :
 * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
 * base::ScopedAllowSyncPrimitives in non-test files
 * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads
   that don't allow blocking
The last one is strongly frowned upon but this CL aims to document existing
behavior rather than address it. Owners are encouraged to follow-up by fixing
unnecessary waits and more particularly unnecessary waits
outside-blocking-scope.

Note: The non-for-testing versions require friend'ing in thread_restrictions.h
but care was taken to add these friends ahead of git cl split (since it wasn't
possible to do a line-by-line associated CL split).
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1288533

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=backer@chromium.org

Bug: 766678
Change-Id: I91a476bd46437c98a53cfdb2ac5c438dde1e495c
Reviewed-on: https://chromium-review.googlesource.com/c/1325193Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606306}

An enumerated histogram with 3 buckets:
1) “New user, potential host exists”,
2) “Existing user, host switched”, and
3) “Existing user, new Chromebook added”.

Tracks if users are actively dismissing our notifications.

Bug: 870138
Change-Id: If46245c1be7528d63a92d51607c63bded8b391d2
Reviewed-on: https://chromium-review.googlesource.com/c/1316446Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606305}

This CL adds support to js2gtest for Mojo Lite WebUI Browser
Tests. This involves adding an extra mojo_lite_webui test type, and
adding the lite bindings to the page when a test is run.

Bug: 849993
Change-Id: Idadb098fb4c4a67535f59c80c8b4781a635da59b
Reviewed-on: https://chromium-review.googlesource.com/c/1309556Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606304}

Right now the trend is to just add a null check every time there is a
crash in native code. I'm going to reverse this by putting all remaining
WebContentsImpl native calls behind an IllegalStateException check. Then
we'll know exactly what code is causing these exceptions, and fix the
client code accordingly.

Inspired by crbug.com/901130 although this is not directly relevant.

Change-Id: I444b912db01567925b6f662d2c11267d60e54624
Reviewed-on: https://chromium-review.googlesource.com/c/1324992Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606303}

Fuchsia's SDK FVM file now includes its own minfs partition which
collides with the minfs partition that we create in our runner scripts.
We relied on the partition to supply client public keys to sshd on the
device.

This change adds the keys directly to the Zircon boot image at runtime
and boots using the modified image.

Rolls SDK to 9853d7bcb5f3944a9f3e599dbd4ec6ee1ce95852.

Bug: 902908
Change-Id: I5bb15756039d1b3b58a4f3989b13a5b88496d1fd
Reviewed-on: https://chromium-review.googlesource.com/c/1324234
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606302}

IndexedDB's Put() call from the renderer runs across a Mojo
interface.  The args to the interface call are serialized by Mojo
and then received by the browser process.

Users can submit args to the call that are arbitrary in size.  If the
args are too large, Mojo will detect the message is too large to
send to the browser process and will crash the renderer.

To avoid the crash, we first check the size of the args before
calling the interface method.  Previously, this check only looked
at the value and key args.  Extend the check to also look at the
index_keys arg, which could also be arbitrarily large.

Bug: 901269
Bug: 717812
Change-Id: Ifb67c8c72f2db37a412c6583d8418454dbc85713
Reviewed-on: https://chromium-review.googlesource.com/c/1325078Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606301}

This CL is in preparation for adding more WebAPK shared prefs.

Change-Id: I98d59aaa37d26eb28552822231f610714ee1f1c6
Reviewed-on: https://chromium-review.googlesource.com/c/1315388
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606300}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b90faf57..bda725f7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia8874a200164ced4a0480e91e9eff753b4a74f39
Reviewed-on: https://chromium-review.googlesource.com/c/1325076Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606299}

Previously there were no presubmit checks to verify that all watchlist
entries are valid e-mails. Bogus watchlist entries break git-cl-upload.
The new check will ensure that WATCHLISTS contains only valid e-mails.

Change-Id: I5d808327029fafa945582f5abba500eaacb500ba
Reviewed-on: https://chromium-review.googlesource.com/c/1325086
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606298}

+ Added a ModalDialogModel and ModalDialogViewBinder
+ Migrate DownloadLocationDialog to use the model

Bug: 899318
Change-Id: I61d019cb4d707a65b09d30c2c3e185a63fd6caca
Reviewed-on: https://chromium-review.googlesource.com/c/1313763
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606297}

When https://chromium-review.googlesource.com/c/chromium/src/+/1307032
landed these tests started failing on developer machines because the
default was to use the GTK theme. This was not caught because on trybots
the default is not to use the GTK theme (see
GtkUi::GetDefaultUsesSystemTheme()).

This CL fixes the tests by explicitly enabling/disabling GTK as appropriate.

Bug: 896146
Change-Id: I75fe33105f0478dcd9d06164041b7b4f2b6e4de0
Reviewed-on: https://chromium-review.googlesource.com/c/1314017
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606296}

Bug: 883496
Change-Id: I2a769b4779ff0f56622ed62099ee0b620aefb16e
Reviewed-on: https://chromium-review.googlesource.com/c/1318745
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606295}

https://android.googlesource.com/platform/external/perfetto.git/+log/8621cb09ab31..ff46b65fdb14


git log 8621cb09ab31..ff46b65fdb14 --date=short --no-merges --format='%ad %ae %s'
2018-11-07 treehugger-gerrit@google.com Merge "trace_processor: Add lowmemory_kill events to instants table"


Created with:
  gclient setdep -r src/third_party/perfetto@ff46b65fdb14

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I218561947e7d211ffcae0e92d574c8e59dbe1aec
Reviewed-on: https://chromium-review.googlesource.com/c/1325130Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606294}

Bug: 902432
Change-Id: Ia551251759af9c285a9d371393028ee02628718d
Reviewed-on: https://chromium-review.googlesource.com/c/1324372Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606293}

This patch allows computing NGOffsetMapping for legacy inline
formatting context.

For an experimental project "Invisible DOM"[1][2] to support
the find-in-page feature, it is needed to compute the text
content with whitespace collapsing applied, along with the
mapping to the DOM offset. This patch adds an API to compute
NGOffsetMapping even when the LayoutBlockFlow is not laid out
by LayoutNG for that purpose.

Note that the project is still in the early phase. We may
revisit the design as it moves forward.

[1] https://github.com/rakina/searchable-invisible-dom
[2] https://www.chromestatus.com/feature/5105291213406208

Bug: 636993, 873057
Change-Id: I101b411960813a7b9b5c9c6e2db85d28737af882
Reviewed-on: https://chromium-review.googlesource.com/c/1322184Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606292}

This is a reland of ed0f2f84

We changed a test to call WaitUntilShown before setting the size.

TBR=jamescook@chromium.org

Original change's description:
> [VK] Automatically notify when test keyboard UI is loaded.
>
> Previously, test implementations of KeyboardUI did not call
> KeyboardController::NotifyKeyboardWindowLoaded. KeyboardController
> requires that function to be called in order to proceed to show the
> virtual keyboard. Thus, individual test files had to manually call
> NotifyKeyboardWindowLoaded.
>
> We change the test implementations to automatically call
> NotifyKeyboardWindowLoaded (through a callback) and move the function
> to be private. We use PostTask to simulate asynchronity.
>
> Bug: 849995
> Change-Id: I1eae9a94c785622ed645c2437a0457f5516fed47
> Reviewed-on: https://chromium-review.googlesource.com/c/1277129
> Commit-Queue: Darren Shen <shend@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605980}

Bug: 849995
Change-Id: I0af055fd0d47ec3969e110e9ef6cced089692446
Reviewed-on: https://chromium-review.googlesource.com/c/1324529Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606291}

Bug: 897998
Change-Id: I040aa20d9c388c8490db51e120227a3bdecb6aab
Reviewed-on: https://chromium-review.googlesource.com/c/1318535Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606290}

Add previous and next track buttons to the media
notification.

BUG=893296

Change-Id: I2918e82bfa3ef11ce65e0fd8d21783e683cd3203
Reviewed-on: https://chromium-review.googlesource.com/c/1300114
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606289}

Report the delta between the swap-time in the renderer, and the
presentation time in the gpu. This would allow us to understand
how switching to presentation-time would affect the paint-timing
metrics.

BUG=899847

Change-Id: I31dd6f5f9ef159e464d7616d2ad04a9c971d7d4a
Reviewed-on: https://chromium-review.googlesource.com/c/1305249Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606288}

https://chromium.googlesource.com/angle/angle.git/+log/1bf18ce9e2ca..448b99f1a580


git log 1bf18ce9e2ca..448b99f1a580 --date=short --no-merges --format='%ad %ae %s'
2018-11-07 jmadill@chromium.org Add WebKit bounds checking to Chrome credits.


Created with:
  gclient setdep -r src/third_party/angle@448b99f1a580

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:None
TBR=syoussefi@chromium.org

Change-Id: I138225b150709c3489ff3e5daa47147927f0818c
Reviewed-on: https://chromium-review.googlesource.com/c/1324855Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606287}

Before this CL, we didn't save webkitRelativePath values on saving
a tab session, and we computed them with the longest common ancestor
directory of all files on restoring the tab session. After this CL,
we save webkitRelativePath values, and restore them without finding
the common ancestor directory.  This CL is a preparation of fixing
crbug.com/124187.

* FileInputType::SaveFormControlState():
Save webktiRelativePath.

* FormStateSignature() in form_controller.cc:
Increment the version string due to the format change.

* FileInputType::RestoreFormControlState():
Create |File| instances from FormControlState directly.  We used to
create a FileChooserFileInfoList from a FormControlState, and
FileInputType::CreateFileList() converted it to |File| instances. We
bypass FileChooserFileInoList because it can't represent
webkitRelativePath.

* FileInputType::FilesFromFormControlState(), HTMLInputElement::
  FilesFromFileInputFormControlState(), and SavedFormState::
  GetReferencedFilePaths():
Pass Vector<String> instead of FileChooserFileInfoList.  These
functions just need Vector<String>.

Bug: 124187
Change-Id: I225463694d164c1f6ed1cb61da8a5bc42e2542c6
Reviewed-on: https://chromium-review.googlesource.com/c/1322671Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606286}

These logs were added as part of debugging flakiness, which has been
fixed, so removing the logs.

Test: No change in behaviour.
Bug: 899664
Change-Id: Ifb66c9beb6ab22bd1002dbda64dcbe461d5fb8e3
Reviewed-on: https://chromium-review.googlesource.com/c/1325269
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606285}

Currently, we assume that debugd sends back a boolean success/fail
value in the response when asked to shutdown vm_concierge, but in fact
the response is empty, resulting in spurious error messages. This CL
changes this behaviour to assume success when receving any response,
including an empty one.

Bug: 900841
Change-Id: I04682973c6dc9d190d43c1626c9b4e05cfa35484
Reviewed-on: https://chromium-review.googlesource.com/c/1312140
Commit-Queue: Fergus Dall <sidereal@google.com>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606284}

chrome_public_test_apk is now the union of:
* chrome_public_apk_for_test
* chrome_public_test_apk
* chrome_sync_shell_apk
* chrome_sync_shell_test_apk

Motivation is to simplify the targets, as well as to work around
multidex restrictions.

This change disabled two tests because fixing wasn't trivial:
* FirstRunIntegrationTest.java
* FirstRunTest.java
https://crbug.com/902774 will track un-@Disable'ing them.


NOTRY=true  # linux bot flakiness
TBR=agrieve  # Trivial rename in a couple files.

Bug: 833545, 841628, 901488
Change-Id: I9ebe035e86f1b6e5a208e36040baf038efa6cc15
Reviewed-on: https://chromium-review.googlesource.com/c/1319335
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606283}

Add edit shortcut menu check before starting the reorder flow. This will
prevent the flow from being initiated when the edit shortcut menu is
clicked.

Bug: 851335
Change-Id: I064d3553b52215152671d9d4c1573ca9450dec0a
Reviewed-on: https://chromium-review.googlesource.com/c/1325075Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606282}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/85b2efb9fc33..c9546dc1a494


Created with:
  gclient setdep -r src-internal@c9546dc1a494

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:883003
TBR=mmoss@chromium.org

Change-Id: I154009eb3cb098d05e2bcd207851ccfb50900b59
Reviewed-on: https://chromium-review.googlesource.com/c/1324854Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606281}

We will need to customize the test targets that run on coverage bots, so
this change creates a dedicated suite. Also, this creates the config for
the new cq trybot.

R=jbudorick,stgao,liaoyuke

No-Try: true
Change-Id: I08563dd9b5375fa140356d36d536aa5d9e1c6418
Reviewed-on: https://chromium-review.googlesource.com/c/1324142
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606280}

https://pdfium.googlesource.com/pdfium.git/+log/19757a1acfeb..4a463d57e9aa


git log 19757a1acfeb..4a463d57e9aa --date=short --no-merges --format='%ad %ae %s'
2018-11-07 tsepez@chromium.org Remove redundancy between CFX_KeyValue and JSGlobalData.
2018-11-07 tsepez@chromium.org Tidy some small TODOs in CFX_GlobalData.
2018-11-07 tsepez@chromium.org Make public IndirectObjectHolder orphan tracking feature.


Created with:
  gclient setdep -r src/third_party/pdfium@4a463d57e9aa

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:901654
TBR=dsinclair@chromium.org

Change-Id: Iaec4b0444581e37c7063fe0df49e77885cea999b
Reviewed-on: https://chromium-review.googlesource.com/c/1324853Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606279}

Updates several VR JavaScript golden images that have started failing
due to some recent text formatting changes.

TBR=mthiesse@chromium.org

Change-Id: I9a41cdd0c32741cc50a1f64821652ee372c31ad1
Reviewed-on: https://chromium-review.googlesource.com/c/1324930Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606278}

The test has PRE_DataAvailableOnRestart part which creates a note in
lock screen note storage. DataAvailableOnRestart then verifies that a
onDataItemsAvailable event is dispatched as the user session is started.
The event is dispatched early on during the test - before the test body
is run, which means there is no guarantee that a result catcher created
in the test body will be created before the test app runs all the tests,
and thus it might miss a test result message.

To fix the issue, update the LockScreenNoteTakingTest setup to create a
result catcher just after the browser main parts are created - this should
be early enough to catch any messages from the test app (i.e. before the
event observed by the test app is dispatched), but late enough to have
NotificationService available (without it extensions::ResultCatcher
cannot be created).

BUG=901616

Change-Id: I58b3ccda9b93bc355bab7fb1f24e2d4a769c44d8
Reviewed-on: https://chromium-review.googlesource.com/c/1324870
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606277}

Only allow frames who are ancestors of the drag_src_ to reset a drag_src_

Created layout test to show previous lack of dragend when moving iframe in dom as a result of dragging
Created layout test to verify lack of regression when frames containing drag source are moved/detached

Bug: 737691
Change-Id: Ic6cc8ac0528d35ac93a21612b453d6b3203a152d
Reviewed-on: https://chromium-review.googlesource.com/c/1265818
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606276}

This lets tests supply PageRenderData to the MetricsWebContentsObserver
through the plumbing added in crrev.com/603785.

Also remove an unused declaration and make SimulatePageLoadTimingUpdate
private in PageLoadMetricsObserverTester.

Bug: 581518
Change-Id: I89409eff3346855c03450ceeb2030b63068d6d3a
Reviewed-on: https://chromium-review.googlesource.com/c/1318058
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606275}

This CL removes a few unused libraries from HatService and fixes small
style nits. Funcionality is untouched.

Bug: None
Test: Build.
Change-Id: Ic6132da73f728b86a0a8b58afb7021125166a3ac
Reviewed-on: https://chromium-review.googlesource.com/c/1324609
Commit-Queue: David Jacobo <djacobo@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606274}

Recently the chrome pip windows have WindowStateType::PIP and behaves as
pip windows. Pip windows moves with animation but the mask bounds was
not synced with these animation. As the result, the test was flaky (see
the bug).

This CL adds the observer of window bounds and make it sure that the
layer bounds is synced with the window bounds.

Bug: 901235
Test: Ran PictureInPictureWindowControllerBrowserTest.
    EnterPictureInPictureThenFullscreen 10 times and observed no error.

Change-Id: Ide03ab1465170ccaf35af08377d3dd1df0cf7ee2
Reviewed-on: https://chromium-review.googlesource.com/c/1316986
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606273}

This allows mocking of the NotificationManager in places where
areNotificationsEnabled() is called.

Added in preparation of the mobile tracing feature, which requires
mocking this method for tests.

TBR=mvanouwerkerk@chromium.org,nyquist@chromium.org

Bug: 898512
Change-Id: Ic739269858970a2365ae6772f269e0aff19d4f5c
Reviewed-on: https://chromium-review.googlesource.com/c/1321730Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606272}