- 03 Apr, 2018 40 commits
-
-
Koji Ishii authored
Following bot results are included. 4497 4499 4505 4509 4513 4516 4521 4524 4526 8 lines were removed and 9 lines were deflaked by consecutive results since 4466. Following test was converted to testharness and that text dump was removed: editing/selection/extend-by-sentence-001.html TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I3541c45d6961f8ad9cc08f9ea095c64f66c56e0a Reviewed-on: https://chromium-review.googlesource.com/989520 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547626}
-
https://skia.googlesource.com/skia.git/+log/1a291b354f54..873086957bdf $ git log 1a291b354..873086957 --date=short --no-merges --format='%ad %ae %s' 2018-04-02 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ ad0c4f19b..75dc22828 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I378c5d27e98ca1032b6465c776df5b0c9c0ae2b6 Reviewed-on: https://chromium-review.googlesource.com/991335Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547625}
-
John Abd-El-Malek authored
Bug: 825242 Change-Id: Id08270e339e5a7ae33d2374f77d56d2de0da2254 Reviewed-on: https://chromium-review.googlesource.com/988693 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#547624}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0f51564af246..5d0fcc3fa3ad $ git log 0f51564af..5d0fcc3fa --date=short --no-merges --format='%ad %ae %s' 2018-04-02 ihf chromeos_config: mark eve-arcnext-chrome-pfq important. Created with: roll-dep src/third_party/chromite BUG=chromium:826755 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6d5ed64763d7d87533683ad14220a98e82d1b422 Reviewed-on: https://chromium-review.googlesource.com/991600Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547623}
-
Takashi SAKAMOTO authored
[Sheriff] Mark fast/text/color-emoji.html, emoticons.html, fast/text/international/002.html, wrap-CJK-001.html as failure on Win10 The following tests are failing (Image failures) on Win10: fast/text/color-emoji.html fast/text/emoticons.html fast/text/international/002.html fast/text/international/wrap-CJK-001.html TBR=jam@chromium.org Bug: 828260 Change-Id: Iad45ebc9bf0db86515487d93a43eab94e41de434 Reviewed-on: https://chromium-review.googlesource.com/991618 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#547622}
-
John Abd-El-Malek authored
Also change network::TestURLLoaderFactory to behave more like net::FakeURLFetcherFactory to make test conversions simpler. In particular, now it has persistent setting of responses instead of being consumed once used. Bug: 825242 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If49f1671979267aa1551c8e391e6a6aae41cb017 Reviewed-on: https://chromium-review.googlesource.com/989835 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#547621}
-
https://chromium.googlesource.com/angle/angle.git/+log/5a7e61bbda82..30b604d8d174 $ git log 5a7e61bbd..30b604d8d --date=short --no-merges --format='%ad %ae %s' 2018-03-12 jdarpinian Check that transform feedback will not overflow its buffers. Created with: roll-dep src/third_party/angle BUG=chromium:820639 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I5a67f73f69ce29fe55a8318a22b6bf5de941fe7e Reviewed-on: https://chromium-review.googlesource.com/991599Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547620}
-
Daniel Murphy authored
This change is necessary for mojo'd SessionStorage to manage observers for shallow copying. Bug: 716490 Change-Id: I5a899be566327decc3a447fe56b72bfba735ffd6 Reviewed-on: https://chromium-review.googlesource.com/984859Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#547619}
-
Wez authored
This reverts commit 2a112566. Reason for revert: Unfortunately the SDK this CL rolled us to is subtley but badly broken. The CL fell narrowly short of Breaking All The Things, because some of the Things just don't touch the broken bits. :( Original change's description: > Fuchsia: extend the size of the blobstore FVM at build time. > > This CL grows Fuchsia blobstore by a specified amount, large enough to > accommodate packaged executables installed at machine (QEMU) runtime. > > Roll SDK from 32a56ad5 to de50ae25 for "fvm extend" and the inclusion > of fvm.blk. > > Bug: 798851, 707030 > Change-Id: I5a6b6be21cc443e6ad46271918a2f40e191a26f6 > Reviewed-on: https://chromium-review.googlesource.com/987012 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547568} TBR=wez@chromium.org,kmarshall@chromium.org Bug: 828232, 828229, 798851, 707030 Change-Id: I3ac0d1586c1a70700fbbd88d9f5762728bedc868 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/991672Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#547618}
-
Patti authored
Omnibox autocomplete results show an icon next to the result listing. Often this is the favicon of the website or extension that was found, but sometimes this can also include default search engine searches, bookmarked results, or pages without a favicon. These latter autocomplete matches show VectorIcons instead of favicons, however, their size is hard-coded in OmniboxPopupView. Move the vector icon creation outside of components/omnibox/ so clients can control the vector icon size. Bug: 801583 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If80bbb64bc4021f0bdc8bc33744b3e0a157acc7b Reviewed-on: https://chromium-review.googlesource.com/928054 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#547617}
-
kristipark authored
The z-index fix for the theme attribution placed the OneGoogleBar behind the ntp-contents div, which made the OneGoogleBar unclickable. Removing the z-index of OneGoogleBar fixes it from being rendered below ntp-contents. Bug: 827969 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5d36f8b1c727a614ef6e2707a440af5413ecbc57 Reviewed-on: https://chromium-review.googlesource.com/990235 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#547616}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cce37ea2. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15286 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=ajuma No-Export: true Change-Id: I410afda3411e51dc56a5e2f089135be2afd83f0a Reviewed-on: https://chromium-review.googlesource.com/991412 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#547615}
-
Yoshifumi Inoue authored
This patch changes "extend-by-sentence-002.html" to utilize |selection_test()| for ease of maintenance. Bug: 679977 Change-Id: I11ed2197c147ef589654c6e6899a4a0f84d9aad9 Reviewed-on: https://chromium-review.googlesource.com/989385Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547614}
-
https://webrtc.googlesource.com/src.git/+log/3d954a6962e5..5b4f075f9c59 $ git log 3d954a696..5b4f075f9 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I515a0df8532c8906ca42a3b14d5137dc39a5f82b Reviewed-on: https://chromium-review.googlesource.com/991594 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547613}
-
Filip Gorski authored
* Wires evend reporting for Explore on Content from the bridge to the contextual content suggestions service Bug: 824185, 824186 Change-Id: Ie03931a90c6ad7bb2db204fe26ce2a769c81d141 Reviewed-on: https://chromium-review.googlesource.com/989410 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#547612}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I6cc15c09a93ea06cb91a64a624ecc9d25226642d Reviewed-on: https://chromium-review.googlesource.com/991573Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#547611}
-
Charlie Harrison authored
This caused a spike in metrics tracking users allowing the redirect via native UI. Addionally, it seems plausible that it breaks legitimate auth cases (though I have no direct repro). It is unfortunate that it allows the popup-redirect case, but that is not an abused vector (yet), and we are trying to be conservative to increase the chances of launch. Bug: 733736 Change-Id: I3559fa6d9e050e476da4c22346ea3ca81526bf06 Reviewed-on: https://chromium-review.googlesource.com/990996 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547610}
-
John Chen authored
ChromeDriver is only interested in Target.receivedMessageFromTarget events from iframe targets. Ignore messages from other types of targets, instead of returning errors. Bug: b:76419159 Change-Id: I1e8545aa780d35d2069e4443e674b892ad272151 Reviewed-on: https://chromium-review.googlesource.com/991597Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#547609}
-
Jun Mukai authored
Previously both TouchDevicesController and TouchpadAndKeyboardDisabler control the availability of the internal touchpad, which causes weird behaviors as reported. This CL moves the control into TouchDevicesController -- now it can recognize both the user prefs and the device configuration (i.e. tablet-mode). As the result, the lifetime control of TouchpadAndKeyboardDisabler becomes unnecessary, so the entire class is removed. The remaining code (i.e. keyboard disabling) moves to ScopedDisableInternalMouseAndKeyboardOzone. This also renames an enum of TouchscreenEnabledSource, because it's not only for touchscreen anymore but also for touchpad. Several files are edited because of this rename. Change-Id: I481388125a55aad9270b897f3f3a15f59d5ab0ac Bug: b/75019660 Reviewed-on: https://chromium-review.googlesource.com/990677Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#547608}
-
Chris Nardi authored
The font shorthand had a short-circuit in StylePropertySerializer, which meant that it was never serialized as a shorthand for style.cssText, citing reasons of web incompatibility. However, it appears that all other major browsers serialize font as a shorthand instead of having style.cssText expand to all properties. Remove this short-circuit to match other browsers. Bug: 827921 Change-Id: I4d522b41a6153808b6b8dab17831afdd8315fdc3 Reviewed-on: https://chromium-review.googlesource.com/989834 Commit-Queue: Chris Nardi <cnardi@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#547607}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b90af5c203f7..0f51564af246 $ git log b90af5c20..0f51564af --date=short --no-merges --format='%ad %ae %s' 2018-03-21 dgarrett cros tryjob: Switch to swarming tryjobs by default. Created with: roll-dep src/third_party/chromite BUG=chromium:752342 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic463ecbc145afc4cacb6ed670e17fd9c2c5ba45c Reviewed-on: https://chromium-review.googlesource.com/991404Reviewed-by:
-
Vadim Bendebury authored
One more prod TPM version was released and the existing pre-pvt version 0.2.2 was re-signed as 0.4.4. Add appropriate hashes to the TPMVersionFingerprint set. BUG=b:chromium:728134 TEST=none Change-Id: Ice7035677d993500110cadb81afdc83d43344b35 Signed-off-by:
Vadim Bendebury <vbendeb@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/991465Reviewed-by:
-
Gyuyoung Kim authored
This CL introduces a new command line to control the image decoded size for embedded devices. According to the comment of |ImageDecoder::max_decoded_bytes_|, the decoded image size should be limited if it causes excessive memory or even crashes on low-memory devices. It would be good if we give embedders the power to limit the memory usage of image decoded size. Bug: 827936 Change-Id: Ia67fc12f8f8554a6dcc0b42ea07e80d0d4dee2ce Reviewed-on: https://chromium-review.googlesource.com/989382Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#547604}
-
https://pdfium.googlesource.com/pdfium.git/+log/3998067026e9..75304f915c5c $ git log 399806702..75304f915 --date=short --no-merges --format='%ad %ae %s' 2018-04-02 vtsyrklevich Enable cfi-icall type generalization for libopenjpeg20 Created with: roll-dep src/third_party/pdfium BUG=chromium:828069 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia02df952b5fd29a6567cfac2aa3f6c9f52776b64 Reviewed-on: https://chromium-review.googlesource.com/991055Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547603}
-
Yoshifumi Inoue authored
This patch changes "extend-by-sentence-001.html" to utilize |selection_test()| for ease of maintenance. Bug: 679977 Change-Id: Ia7035dc7d2deb476e75d62e71f33942a0ecff124 Reviewed-on: https://chromium-review.googlesource.com/989458Reviewed-by:
-
Reilly Grant authored
This Group Policy flag, "DefaultWebUsbGuardSetting" can be used to control the default value of the WebUSB guard permission. Bug: 771703 Change-Id: Ic93b4b1760e8891a75c5f612c97b9275d40422c0 Reviewed-on: https://chromium-review.googlesource.com/982898 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#547601}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/81b26429c8f6..c7d0b34084e5 $ git log 81b26429c..c7d0b3408 --date=short --no-merges --format='%ad %ae %s' 2018-03-28 ehmaldonado presubmit support: Run all tests in parallel. 2018-04-02 agable Kick recipe roller 2018-04-02 agable presubmit: don't die when skipping unknown checks Created with: roll-dep src/third_party/depot_tools BUG=chromium:819774,chromium:828154,chromium:770408,chromium:828154 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I25169163511e6438ed68514290681cc3213ab7d1 Reviewed-on: https://chromium-review.googlesource.com/991352 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547600}
-
David Grogan authored
This doesn't produce anything good yet. It's a basic implementation that interacts with FlexLayoutAlgorithm for a very narrow range of flex items and stuffs the results into NGLayoutResult. There's no attempt at painting or copying results back to legacy. Abusing LayoutNGBlockFlow in LayoutObject.cpp will have to be fixed soon. This will be the first layout type that doesn't inherit from LayoutBlockFlow, but in this patch it still uses LayoutNGBlockFlow. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I82195d5c561ba8ff67b00894b17ad72f14a52535 Reviewed-on: https://chromium-review.googlesource.com/961793 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#547599}
-
Chris Palmer authored
Linux: We're not sure what the performance benefits of MADV_FREE are, and it makes our measurements less predictable. macOS: MADV_FREE_REUSABLE seems to have been failing, and the error was hidden by the recovery case intended for Linux MADV_FREE. The result was an unnecessary, failing call to `madvise`. Bug: 755284 Change-Id: Ic7aa3089ada131f6a1b5c40b5ddd353d34ed2c20 Reviewed-on: https://chromium-review.googlesource.com/990584 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#547598}
-
Yoshifumi Inoue authored
Validate offset parameter of Position constructor with introducing Position::CreateWithoutValidation() This patch changes |PositionTempalte<Strategy>| constructor to validate offset parameter for improving code health. This patch also introduces |CreateWithoutValidation()| for callers which need out of bound positions, and deprecated version for callers without sane reason. Change-Id: I0f072aacd34fe5af5b5398c824632ce6ac7a1772 Reviewed-on: https://chromium-review.googlesource.com/987655 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
Utilize selection_test() in "editing/selection/modify_move/move_forward_sentence_empty_line_break.html" This patch changes "move_forward_sentence_empty_line_break.html" to utilize |selection_test()| for ease of maintenance. Bug: 679977 Change-Id: Id068b0544eb17e5b2ba4ad184f9011b1481c5000 Reviewed-on: https://chromium-review.googlesource.com/989388Reviewed-by:
-
Nico Weber authored
host_tools is already in deps, so this shouldn't be necessary. The only case where this makes a difference is if someone manually touches the built executable in the build dir. Bug: none Change-Id: I6abd3143bf0ec9b17f7ff3fc0f6681a80dff5827 Reviewed-on: https://chromium-review.googlesource.com/990497Reviewed-by:
-
btolsch authored
This change also fixes the showing of LocationBarView in PresentationReceiverWindowView on Mac by forcing a call to Layout if its state isn't correct after calling SetFullscreen on the frame. Bug: 809682 Change-Id: Ia7ee354be489354ad65165c6b13e474345e0ffdf Reviewed-on: https://chromium-review.googlesource.com/988269Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#547594}
-
https://webrtc.googlesource.com/src.git/+log/7eca09361d6d..3d954a6962e5 $ git log 7eca09361..3d954a696 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2510482eee6e29c02dcc91b3f3e078ccd8de93f6 Reviewed-on: https://chromium-review.googlesource.com/991199Reviewed-by:
-
Mike Wittman authored
TBR=sullivan@chromium.org Change-Id: Ib495ea4e4f1bcb82470bc242bb4f613e2c323b3f Reviewed-on: https://chromium-review.googlesource.com/991459Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#547592}
-
Xiaohan Wang authored
According to the gn reference (and from brettw@): the "loadable_module" target type allows you to create an object file that is (and can only be) loaded and unloaded at runtime, which is exactly what we want for Clear Key CDM. Bug: 584449 Test: Existing tests pass. Change-Id: I2a3a322cb13a7c052c7c43fdd1235ccadd0742ce Reviewed-on: https://chromium-review.googlesource.com/988814Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#547591}
-
Shenghua Zhang authored
Flipped LUCI and Buildbot for Android x64 Builder (dbg) and Android x86 Builder (dbg). Removing them from migration side-by-side UI. Bug: 790521, 790536 Change-Id: I593f5c76205b1264b81f0851a5e5ff9eac2fed3a Reviewed-on: https://chromium-review.googlesource.com/990811Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#547590}
-
Aaron Leventhal authored
When two spans are separated by a line break, and the second span's text node also begins with a line break, the space shown in the layout is not rendered in the accessibility presentation. The computation to determine if there is rendered space adjacent to a space-only node must use the inline text boxes to get the most accurate representation of what is ultimately rendered. Bug: 821906 Change-Id: Ie81134a95a8878d22a370e97b330e0eae5101d67 Reviewed-on: https://chromium-review.googlesource.com/988375 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#547589}
-
Ovidio Henriquez authored
This change updates the blocklisted UUID tests to use the Web Bluetooth Test API. This will allow the test to be migrated into wpt/. BUG=509038 Change-Id: I72acd10e5aabc4c03f955dc4c7b2a8620930cc2d Reviewed-on: https://chromium-review.googlesource.com/894738 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#547588}
-
dpapad authored
With this change, the user is correctly forwarded to chrome://extensions, if an invalid URL is entered, for example chrome://extensions/foo/bar.html. Bug: 828174 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I18598c6b3367bcb972efda64bf56cdd1496f2ed7 Reviewed-on: https://chromium-review.googlesource.com/991083Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#547587}
-
