- 25 Apr, 2018 40 commits
-
-
Rakina Zata Amni authored
We are moving find-in-page related functions out of web_local_frame_impl_find_in_page.cc to its own class (FindInPage) for easier mojoification and so that we can add new find-in-page related functions more easily. In this CL, we are introducing find_in_page.h. WebLocalFrameImpl still have the find-in-page functions, but TextFinder ownership is moved to the FindInPage class. The functions in web_local_frame_impl_find_in_page.cc are changed to call the FindInPage functions (that are in the same file for smaller CL), and will be removed entirely in the next CLs. Previous CL: crrev.com/c/956648 In the previous CL, we moved find-in-page related functions to a new file, but it's still in the WebLocalFrameImpl class. After more discussions, we decided to do the old plan of refactoring the functions to its own class. Next CLs: Move functions from "web_local_frame_impl_find_in_page.cc" to "find_in_page.cc" Remove find-in-page functions from WebLocalFrame Refactor plan doc: https://goo.gl/CtLsFR Further plans: Mojoification https://goo.gl/JenyGm Find-in-page APIs https://github.com/rakina/find-in-page-api/ Bug: 819919 Change-Id: Icc8da3b321c72f2e7a210d5b350711b673eedfec Reviewed-on: https://chromium-review.googlesource.com/1025242Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#553459}
-
Daniel Cheng authored
Bug: 706466 Change-Id: Ibfca7f6baf3fcb475dd3bb78f3453624ef79c83c Reviewed-on: https://chromium-review.googlesource.com/1027118Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553458}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f05d63ff48c5..c56c9493dbc3 $ git log f05d63ff4..c56c9493d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic4a1167e611d611c3006647683f60588870502a9 Reviewed-on: https://chromium-review.googlesource.com/1027201 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553457}
-
Lei Zhang authored
This reverts commit 4596c802. Reason for revert: UnalignedSharedMemoryTest failing on multiple bots. Original change's description: > [media] Add interface for VDAs to Decode() media::DecoderBuffers. > > Using DecoderBuffer removes the need to provided SharedMemoryHandles in > cases that SharedMemory is not already allocated (in particular, when > VDAs are used through MojoVideoDecoder+VdaVideoDecoder). Since > base::SharedMemory is not an interface, a new type is required, and > DecoderBuffer already implements a suitable interface for this use case. > > This CL adds: > - A VideoDecodeAccelerator::Decode() overload for decoding > DecoderBuffers, which VDAs may optionally implement. > Note that VdaVideoDecoder will require this, and therefore all VDAs > will be updated to support DecoderBuffers over time. > - Support for SHM in DecoderBuffer. This eases the transition by > allowing BitstreamBuffers to be easily converted to equivalent > DecoderBuffers. > - An implementation of the new VideoDecodeAccelerator::Decode() > overload in VTVideoDecodeAccelerator. > - Calling the new overload from VdaVideoDecoder. > > Bug: 522298 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Ib932c3524b37e339f592b150685937ea94d4199d > Reviewed-on: https://chromium-review.googlesource.com/1015965 > Reviewed-by: Pawel Osciak <posciak@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553364} TBR=posciak@chromium.org,dalecurtis@chromium.org,sandersd@chromium.org Change-Id: Iad674ebb5286d5f068b2fc7bb6c67ab5f9a26fc0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 522298 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1026914Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#553456}
-
Philip Rogers authored
With root layer scrolling the layout view clips and we need to ensure the clip occurs in the correct (un)scrolled space for fixed position. This patch changes the fixed position case: we stop applying the layout view scroll, clip, and then do not counter-scroll. There is a similar codepath for the !RLS case which has not been changed in this patch. Here's a summarized description of where scroll offsets apply: 1) MapToVisualRectInAncestorSpaceInternal calls MapVisualRectToContainer 2) MapVisualRectToContainer calls MapContentsRectToBoxSpace 3) MapContentsRectToBoxSpace applies the layout view scroll offset 4) MapContentsRectToBoxSpace clips 5) MapToVisualRectInAncestorSpaceInternal un-applies the scroll offset This patch removes #3 and #5 for fixed position. Bug: 831380 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3437d3933155960abfcbebd437ddb6cb606ea37e Reviewed-on: https://chromium-review.googlesource.com/1025329Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#553455}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=sky@chromium.org Bug: 825327 Change-Id: Ieae521d62d35bae3cd5c54309796f2b0c702679c Reviewed-on: https://chromium-review.googlesource.com/1024378Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553454}
-
Antoine Labour authored
It is not used any more \o/ Bug: 738190 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic0bfa65a3ed9c43ff28450c305abbf7d0a93d3a5 Reviewed-on: https://chromium-review.googlesource.com/1023160 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#553453}
-
Kent Tamura authored
which is the new name of run-webkit-tests. This CL also replaces references to "run-webkit-tests" with "run_web_tests.py". * //blink/tools/run_layout_tests.py Show a message, and run run_web_tests.py. * //BUILD.gn "webkit_layout_tests" doesn't need //third_party/WebKit/Tools/Scripts any longer. * //testing/buildbot/gn_isolate_map.pyl Replace run-webkit-tests with run_web_tests.py. * //third_party/blink/tools/run_web_tests.{bat,py} Added. * //third_party/WebKit/Tools/Scripts/run-webkit-tests Show a message. * Other files: Really trivial changes. In many files, this CL replaces "run-webkit-tests" with "run_web_tests.py" in comments or strings. Note that we decided to rename LayoutTests to web_tests. https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/KKNbuzj-3HY/H8FWgtKrBgAJ Bug: 829697 Change-Id: I899457cb3bcdb306aa47843a4c767c5980d9edc0 Reviewed-on: https://chromium-review.googlesource.com/1025543 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:Nico Weber <thakis@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#553452}
-
Xi Cheng authored
Bug: 734095 Change-Id: Idf5637bb57a7cbfb0b5831cf99e45806d8a9abc6 Reviewed-on: https://chromium-review.googlesource.com/1026972Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#553451}
-
Xiaocheng Hu authored
We previously deduplicated left and right traversal algorithm in SelectionModifierCharacter, but haven't changed the variable names and comment yet, which is finished by this patch. Change-Id: Ie4a801b8b203433c189c70d8cb3824bd06931037 Reviewed-on: https://chromium-review.googlesource.com/1026835Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#553450}
-
Yoshifumi Inoue authored
This patch simplifies |FixLeadingWhiteSpaceForReplacedElement()| of |TextIteratorTextNodeHandler| by moving conditional expression into another function for improving code health. Change-Id: I6d83dd5e78696c808b87ce2998bccbd9b1edaa9c Reviewed-on: https://chromium-review.googlesource.com/1025675Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553449}
-
Devlin Cronin authored
Migrate the FeatureSwitch::scripts_require_action feature to a base::Feature. base::Features are a little more flexible than FeatureSwitch is now, since they are set up for finch experimentation and are always sent to the renderer (avoiding a commandline hack in place for the FeatureSwitch approach). Also rename scripts_require_action to kRuntimeHostPermissions. This is a little more descriptive, since the feature affects host permissions beyond just scripting (e.g., cookies and webRequest). Bug: 835339 Change-Id: I8b2a5c46a194655a811766114d8115da967719c0 Reviewed-on: https://chromium-review.googlesource.com/1022082 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#553448}
-
Daniel Cheng authored
Bug: 706466 Change-Id: I6f9db18aaca1c24a3da055907786943e55ea36d9 Reviewed-on: https://chromium-review.googlesource.com/1027115Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553447}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=ssid@chromium.org Bug: 825327 Change-Id: I69f4952b57c7693c441abe1a6173f453aa10e7e6 Reviewed-on: https://chromium-review.googlesource.com/1024288Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553446}
-
Kouhei Ueno authored
This CL removes unused flag BackgroundHTMLParser::should_coalesce_chunks_. The flag is always false and never true. Bug: None Change-Id: I46fbb259dfe9cf7b814935037c026d2db9e33beb Reviewed-on: https://chromium-review.googlesource.com/1026332Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#553445}
-
Dongseong Hwang authored
Chromium uses Quaternion for only rotation quaternion, so make it report rotation info. For the information, for the given rotation quaternion q, q = (con(abs(v_theta)/2), v_theta/abs(v_theta) * sin(abs(v_theta)/2)) Change-Id: I11c574d05c621078b3b9a15ad647e9ddfe501828 Reviewed-on: https://chromium-review.googlesource.com/920749 Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#553444}
-
Daniel Cheng authored
Bug: 706466 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2241db1730ea7a11e13801eea2e6d3a6662f4105 Reviewed-on: https://chromium-review.googlesource.com/1027114Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553443}
-
Jinsuk Kim authored
Change-Id: I7ed46656f2a6d72732af4788f06f98be3e39c553 Reviewed-on: https://chromium-review.googlesource.com/1025230Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Grace Kloba <klobag@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#553442}
-
Esmael El-Moslimany authored
Bug: 781703 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib511cc9e225f7a1f5123fe86051b1ceea6a6d7b9 Reviewed-on: https://chromium-review.googlesource.com/1022126 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#553441}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=dtrainor@chromium.org Bug: 825327 Change-Id: I74a210d1851a7f98217ee43c83bad9c369740f0a Reviewed-on: https://chromium-review.googlesource.com/1024762Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553440}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I78da3580d059c4e8a5ff447220917b175eaa7010 Reviewed-on: https://chromium-review.googlesource.com/1027310Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#553439}
-
Hajime Hoshi authored
We've decided to use the 'freeze' to represent suspending tasks on background tabs instead of 'stop'. Change-Id: I9aeadf58ddeb9b8f9d749ce8280d9de706c5d1cc Reviewed-on: https://chromium-review.googlesource.com/1025671Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#553438}
-
Robert Ma authored
external/wpt/content-security-policy/inside-worker/dedicated-inheritance.html TBR=thestig Bug: 836627 Change-Id: I2cfb34b295cfcbcbecfac15e414eab20a36bea66 Reviewed-on: https://chromium-review.googlesource.com/1027009Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#553437}
-
Daniel Cheng authored
Bug: 706466 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2d8a62e693af7a3c335f3401817988deae9f87bb Reviewed-on: https://chromium-review.googlesource.com/1027001Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553436}
-
Tetsui Ohkubo authored
This CL embeds old SystemTray's detailed views to UnifiedSystemTray. Although this is temporary, this feature is important to start early dogfooding, and requested multiple times from PM. When we launch the feature, SystemTray instance is completely removed, so this temporary hack will not work. Before launch, we're going to replace all of them with our own implementation of detailed views. TEST=manual BUG=835733 Change-Id: Ic94f3ffa1976e3812f6bf200b64f1ec03878715c Reviewed-on: https://chromium-review.googlesource.com/1023354Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#553435}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2337b0d45c46..f05d63ff48c5 $ git log 2337b0d45..f05d63ff4 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:None The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia5379743f5f372e50265c644d3bdb84282ae9a07 Reviewed-on: https://chromium-review.googlesource.com/1026877Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553434}
-
Tetsui Ohkubo authored
This CL changes DateView and TimeView to directly observe ClockModel. It removes unrelated logic from SystemTrayItem and makes embeding these views easier. TEST=ash_unittests BUG=none Change-Id: I70b3a873c0ac259a05597d3f93b77fd7519dd462 Reviewed-on: https://chromium-review.googlesource.com/1025615 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#553433}
-
Hirokazu Honda authored
On ChromeOS, CL:950007 changed the decoder output format to NV12 instead of RGB. So we need to update MD5. This updates md5 for h264 on ivybridge and rambi platforms. TBR=hoegsberg@chromium.org TBR=mcasas@chromium.org BUG=chromium:827032 TEST=video_VideoDecodeAccelerator on link Change-Id: I3a117ada2038c41077ab116a8c72ba2f4c96df08 Reviewed-on: https://chromium-review.googlesource.com/1023615Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#553432}
-
Qiang Xu authored
changes: This CL adds the support for async getting menu model for app list. Bug: 803291 Test: tests app list context menu still works fine Change-Id: I990ef8ffe38f303a5359a3605c3ba9e56fbf024d Reviewed-on: https://chromium-review.googlesource.com/1023064 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#553431}
-
Yafei Duan authored
In StartupMaintenanceTask and PersistentPageConsistencyCheckTask, there was a step to get persistent/temporary namespaces, which didn't use the existing function. This CL fixed it. Bug: NONE Change-Id: I7b4a1f6255003886917790dff875c20b43cfc032 Reviewed-on: https://chromium-review.googlesource.com/1027111Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#553430}
-
https://pdfium.googlesource.com/pdfium.git/+log/b242943f5e94..a1d344230925 $ git log b242943f5..a1d344230 --date=short --no-merges --format='%ad %ae %s' 2018-04-24 tsepez Fix include order for cpdfxfa_context.h Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia4ccffecf6023bdd7cfa251632c826bf1c93e057 Reviewed-on: https://chromium-review.googlesource.com/1026884Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553429}
-
xlou authored
In printing, 2-up, 3-up, or more generally N-up refers to a page layout strategy in which multiple pages are composited onto a single page. 1. Added ability to pass the N-up feature UI settings (which will be added in the next CL) to the print preview workflow, so that the PDF plugin can take action based on user's input. 2. Added N-up feature support to pdfium_engine, so that when the source is PDF, pdf plugin will generate the N-up output doc based on user's input. Bug: 775999 Change-Id: I27933d1a7da65376e70bdcb538393bb8bb3ec688 Reviewed-on: https://chromium-review.googlesource.com/1014628 Commit-Queue: Shirleen Lou <xlou@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#553428}
-
https://chromium.googlesource.com/angle/angle.git/+log/f2807385cbc9..2565d48b47aa $ git log f2807385c..2565d48b4 --date=short --no-merges --format='%ad %ae %s' 2018-04-12 courtneygo Add angle library apk Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I87a9fd3f91e7be063ceea27109bae0142c08bc87 Reviewed-on: https://chromium-review.googlesource.com/1027075Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553427}
-
Xiaocheng Hu authored
This patch improves the readability of the file by moving variable |line_layout_item| into the iteration body and making it const. The refactoring is correct because: - Every time |box| is modified, |line_layout_item| is modified accordingly - Every time |box| is modified, the iteration either breaks or continues Bug: 771398 Change-Id: I2a4eecc27870f33a0f16e50762742fff9811cda1 Reviewed-on: https://chromium-review.googlesource.com/1026801Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#553426}
-
Yoshifumi Inoue authored
This patch changes |TextIteratorTextState::EmitText()| to take |const Text&| since it doesn't take |nullptr| and all call sites passed non-null |Text| node for improving code health. Change-Id: I6ef1fb5d5dc85f0e4edc16be3d27913ac73648d4 Reviewed-on: https://chromium-review.googlesource.com/1025452Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553425}
-
Zhiheng Vincent Li authored
Set cast fragment to invisible when detach from activity to avoid a flash of cast app view at the last frame Bug: internal b/77214997 Change-Id: I18b11a8159f2d308dea6c3a8294b4059cbe1864a Reviewed-on: https://chromium-review.googlesource.com/1023056 Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#553424}
-
Makoto Shimazu authored
Bug: 830291 Change-Id: I1b1b6fe8c20bd1384e8e01cb9521481b38c4c1cb Reviewed-on: https://chromium-review.googlesource.com/1025672 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#553423}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/18483452ccd2..cf1d296fd683 $ git log 18483452c..cf1d296fd --date=short --no-merges --format='%ad %ae %s' 2018-04-24 dgarrett chromeos_config: Remove WIMPY builders. 2018-04-24 chrome-bot Update config settings by config-updater. Created with: roll-dep src/third_party/chromite BUG=chromium:836383 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibc160b3c8ed67c67c5b0f024af68a2d98afee92a Reviewed-on: https://chromium-review.googlesource.com/1026887Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553422}
-
Ned Nguyen authored
This isolate will also be used by Cluster Telemetry to create isolate that contains perf code without Chrome. So formalize its name to reflect the purpose. Bug: skia:7796 Change-Id: I29566b047ab04b27def5e800f7174d1fd20b5db4 Reviewed-on: https://chromium-review.googlesource.com/1025131Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#553421}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0cf37360..a5f8be1f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Id20af56c11fc4639ce6cc21154dafc72f1d27de0 Reviewed-on: https://chromium-review.googlesource.com/1026480Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#553420}
-