- 15 Jan, 2020 40 commits
-
-
Dan Beam authored
These rules should be integrated into //.eslintrc.js when more of the codebase uses ===/!==. R=dpapad@chromium.org BUG=720034 Change-Id: I2b84fa8e952472d62a4f1241a6224dd17e78d6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001717 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#732079}
-
Josh Nohle authored
During v2 DeviceSync, if device metadata cannot be decrypted due to an error or because the group private key was not returned by CryptAuth, the device is still added to the registry without the new decrypted metadata. Currently, old device metadata is cleared in the registry until the new metadata can be decrypted. In this CL, we ensure that any existing decrypted metadata from the device registry will remain there until the new metadata can be decrypted. Because we do not expect that metadata--namely the device public key and beacon seeds--to change often or urgently, we preserve existing decrypted data for the sake of continuity. (Note: the device public key currently *never* rotates and the beacon seeds are valid for roughly 6 weeks.) As an example, consider a verified BetterTogether host phone using Instant Tethering. If a DeviceSync call from the Chromebook rotates the group key, all other devices, including the host phone, will need to upload newly encrypted metadata that the Chromebook can decrypt. During this interim period, we can most likely continue using the host phone's old metadata to keep the tethering connection. In the previous implementation, the Chromebook would wipe the phone's old metadata, making the host "unverified" until the metadata can be decrypted. This could cause a hiccup in service during every group key rotation. Now, the device registry should have empty BetterTogether metadata only while waiting for the *first* metadata decryption. Bug: 951969 Change-Id: If9b93c0157d509e5cea2367eef0b58af69e04a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993745 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#732078}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cb92763d..cd341453 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3ab2f6f7af9a4aa4327a580daa44a071f75b4286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002753Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732077}
-
Emily Stark authored
Signed Exchanges do not have a SSL connection version set. Exclude such cases from the legacy TLS warning treatment to avoid spurious warnings. Bug: 1041773 Change-Id: I323e3c1206da32b629c82b4eb28fc0a67190e7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002830 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#732076}
-
Robbie Gibson authored
Change-Id: I2fe2b5f048edfb7d766ecfe3ad2f5801ef23496d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991620 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732075}
-
kylechar authored
This CL removes unnecessary deps/includes and tightens DEPS rules. Ash and exo should no longer depend on //components/service/viz outside of tests. Bug: 936425 Change-Id: I5536a187fb3ef06145e96aafcaf403923873c996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002749Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#732074}
-
Peter Kotwicz authored
BUG=None Change-Id: Ie562ccd4dd79d18e3d07395899646c74b808ebe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999118 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732073}
-
Justin Donnelly authored
The use of page_classification was removed from DeduplicateMatches (then called SortAndDedupMatches) in https://crrev.com/c/1723807. The use of page_classification was removed from MergeMatchesByProvider over 5 and a half years ago (lol) in https://crrev.com/329783003. Change-Id: I23285325b58c7e61d20ad0c72abe197d3a290513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002973Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#732072}
-
Rodney Ding authored
- add test css property and web tests for ot css features - Design doc https://docs.google.com/document/d/1Lc3U2WV38GZ3ShTAm3-p6fbZeGJGkxL-KZfWIQ-p8GU/edit?usp=sharing Bug: 775189 Change-Id: Ibf13c6f5f182aaaf64598c23e9aac4f466fc0ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990338 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#732071}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/435adfe71a0a..4cf1874981c3 git log 435adfe71a0a..4cf1874981c3 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 jlavrova@google.com Fixing the cache 2020-01-15 jvanverth@google.com Reland "Add new method for storing DrawOpAtlas texture index." Created with: gclient setdep -r src/third_party/skia@4cf1874981c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: I98e0ab4298ebf8a95127c1a847dae1caebe4b6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003128Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732070}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6a138fbe7ca9..aea3d43d0b6a git log 6a138fbe7ca9..aea3d43d0b6a --date=short --first-parent --format='%ad %ae %s' 2020-01-15 khokhlov@google.com [Telemetry] Remove unused --experimental-proto-trace-format flag Created with: gclient setdep -r src/third_party/catapult@aea3d43d0b6a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1028612 Tbr: wenbinzhang@google.com Change-Id: I85f8d836a56ebb2dd2bf30e0424e40449b689704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002971Reviewed-by:
-
Matt Menke authored
NetworkIsolationKeys (NIKs) are used to isolate cached network objects and prevent leaking information between consumers. In this case, each extension will use its own origin for the NIK of its DNS lookups. This allows an extension to leak information to itself when it does DNS lookups in different contexts (within a single profile), which should be fine, but prevents extensions from spying on the activity of other extensions, or web pages it doesn't otherwise have access to. If a website can get timing information about how long it takes an extension to do a DNS lookup, data can be leaked across first party contexts, but doesn't seem like much we can do about that. The extension APIs this CL updates are the DNS API and the legacy TCP/UDP socket APIs. The new TCP/UDP APIs don't do DNS lookups. Bug: 997049 Change-Id: I6310e49d07f7cd6947ceefa068330bab407f91e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995615 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#732068}
-
Evan Stade authored
Bug: 1030785 Change-Id: Ie3c27a576b5908a2d77b3348badb3cc142bd58c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995933 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#732067}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f7650d0b86f4..47bc3d60ef2d git log f7650d0b86f4..47bc3d60ef2d --date=short --first-parent --format='%ad %ae %s' 2020-01-15 lalitm@google.com trace_processor: remove InternString mocking 2020-01-15 lalitm@google.com trace_processor: cleanup StringPool and StringIds 2020-01-15 lalitm@google.com trace_processor: allow start timestamps to be nullopt for thread/process 2020-01-15 lalitm@google.com Merge "trace_processor: remove tableid and refactor argstracker to use ids" Created with: gclient setdep -r src/third_party/perfetto@47bc3d60ef2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1a9bc293896894a93b2ec4d1a4202f509cbc9b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002981Reviewed-by:
-
Aga Wronska authored
The migration to child status reporting should be finished. For child user we only rely on child user status proto. Bug: 827386 Test: ChildStatusCollectorTest + manually Change-Id: I4d9e724039a3bbc887445c23f1ee318a46602f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987829 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#732065}
-
Josh Nohle authored
Bug: 951969 Change-Id: Iec2b366ae5f804e6322af51e6257fa9850a751bb Fixed: 953087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986892 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
minch authored
Bug: 1038147 Change-Id: If6a17e3891493a9c9ac03889f7825f2c86e5bd9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983444Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#732063}
-
Richard Knoll authored
This replaces the multiple maps with a single one and a struct to hold all metadata we need for metrics. Bug: 1038621 Change-Id: I7389fe1c7df72340663e547ce2ae80b37abce01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000745 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#732062}
-
Josh Nohle authored
These metrics have already been added. Bug: 899080, 936273 Change-Id: I4210af9f1b08a18ef052a7c9a969d58aec108db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985170 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Brian White authored
This reverts commit 09b31f71. Reason for revert: Still flaky even on non-MSAN bots. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/1733 https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/1737 Original change's description: > Enable MergeSessionTest.XHRNotThrottled on everything but MSan > > Bug: 990844, 998330 > Change-Id: I244ef0f810ecf2da2796c1ad6b3bce4ad772c772 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906147 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Thomas Tellier <tellier@google.com> > Cr-Commit-Position: refs/heads/master@{#714203} TBR=rsorokin@chromium.org,tellier@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 990844, 998330 Change-Id: Id620600cdd374f5c89cbc6fc02a9f655754a0604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003188Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#732060}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I032081989bada6c6e14023270d033386d9b7746f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002977Reviewed-by:
-
John Budorick authored
Bug: 1039860 Change-Id: I2b4d1465678ddf89a1e6354927e3932f9a0f5c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990258 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#732058}
-
Jesse McKenna authored
On Windows, each Progressive Web App (PWA) must have its own launcher in order for the PWA to be able to register as a handler for file types. On Windows 7, the filename of this launcher is used as the PWA's display name in the "Open With..." menu, because Windows 7 lacks an alternate way to set multiple custom display names for one executable (and PWA launchers are all identical copies of chrome_pwa_launcher.exe). This change omits .exe from the filename of PWA launchers on Windows 7, unless the PWA's name (which will become the launcher filename) is a reserved filename on Windows. Bug: 960245 Change-Id: I9713c3151c276bf460b193ce502ecdf233d3aad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965560 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#732057}
-
Evan Stade authored
Bug: none Change-Id: I5cdf1b9bcd9ae0657ed93c374579c07d99ffc4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001844Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#732056}
-
Marc Treib authored
On a 401 (HTTP unauthorized) error, the correct response it to get a new access token and try again (most likely reason for the error is that the previous access token was expired). PerUserTopicSubscriptionManager did this, but SubscriptionEntry's SubscriptionFinishedCallback was a OnceCallback, and it wasn't re-set for the second subscription attempt. So the result of the second attempt was simply ignored: If it succeeded, we'd now be subscribed, but not know about it (likely resulting in a redundant subscription request at some later time). If it failed, it wouldn't get retried anymore, so invalidations would be broken until at least the next Chrome restart. This CL fixes this by simply making the callback a RepeatingCallback. It also adds a test. Bug: 1020117 Change-Id: Ifaf29a6db21ce9f37888603b534ef50970ffc94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000720 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#732055}
-
Peter Beverloo authored
Bug: 990383 Change-Id: Ib839fefa253079e37d6f2d7625e1f6bf10eec412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002511Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Adds a icon left of the text on the dialog. The icon has a spinner around itself when scanning and a colored circle background when scanning is done. Bug: 999145 Change-Id: Id62cdefd6622969257225bdf77d3dd87a0e83dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993722Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#732053}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5dd59b4e1cf6..a8e0880b3003 Created with: gclient setdep -r src-internal@a8e0880b3003 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:973101 Tbr: jbudorick@google.com Change-Id: I4f661710352d805dec8964a90806416033e5ad59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002976Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732052}
-
Josh Nohle authored
These TODOs were resolved in http://crrev.com/c/1865659. Bug: 990441, 951969 Change-Id: Ie0432295bfe541ef56ad948fd4e52c580946f62a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986621 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Clark DuVall authored
This reverts commit 43735879. Reason for revert: CL that made the test fail already reverted. Original change's description: > Disable failing OfflinePageAutoFetchTest#testAutoFetchTriggersOnDNSErrorWhenOffline > > BUG=1041822 > TBR=harringtond@chromium.org > > Change-Id: Id22776f84bc687fbe164fd197496314b5941c94d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001583 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731732} TBR=twellington@chromium.org,harringtond@chromium.org Change-Id: Iee1da36482cbe50b7f140cd1de9df9f92aaa4833 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1041822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002833Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#732050}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=tfarina@chromium.org Bug: 1041419 Change-Id: I1bb86a7010450186cd178218f65ed1d5291fcb85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998866 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#732049}
-
kylechar authored
This CL adds code to force YUV video quads to use sRGB destination color space with SkiaRenderer when overlays are enabled. The same logic already exists in GLRenderer::DrawYUVVideoQuad() so this just matches existing behaviour. Bug: 1039416 Change-Id: Ie1facca8d6428b283c0b84000484514f5b7ca9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002858Reviewed-by:
Brian Osman <brianosman@google.com> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#732048}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=darin@chromium.org Bug: 1041419 Change-Id: I696a200a33c53a61611d781c2032ee0c25953157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997770 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nate Chapin authored
Currently, we wait to determine what type of Document will be created until it's time to actually construct the Document. This CL moves that determination earlier. The Document type is needed in policy decisions related to ExecutionContext and SecurityContext initialization. If, as planned, the LocalDOMWindow because the ExecutionContext, these policy decisions will happen before Document constructions and will need access to that type. Bug: 1029822 Change-Id: Ic99ae1d74ef955d3e3abf7df46aa67ce7559a227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989065Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#732046}
-
Clark DuVall authored
This is no longer needed now that we have system_webview_apk_or_module_tmpl Change-Id: I3b026070499896e3061e60179d5f92bc11e52f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001742 Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#732045}
-
Miriam Zimmerman authored
This is now handled by an autotest API, added in https://crrev.com/c/1929983 and https://crrev.com/c/1928367. TEST=tast run dut platform.KernelWarning BUG=None Change-Id: I47fa9923cc2949f928784f1b038a10d33427d5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001019Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#732044}
-
arthursonzogni authored
Remove content::ContentSecurityPolicyHeader in favor of a mojo struct in network. This is the last step before being able to replace the content:: structs by the network::mojom ones for IPC. See UnifyCSP: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao Bug: 1021462 Change-Id: Ieba10983f4e5182eee7af656ccc241aff36409b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992322Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#732043}
-
Etienne Bergeron authored
This is the same issue than this CL, but for MAC: https://chromium-review.googlesource.com/c/chromium/src/+/1824104 The MAC API is returning ".Noto Sans Universal" which is not recognized by Skia (i.e. SkTypeface). To work with the API that converts codepoint to glyphs, the same NativeFont must be kept and pass to the SkTypeface_Mac constructor. The goal is to avoid loosing information and keep the exact selected fallback font. Bug: 1022455 Change-Id: If15d7a1306131fe2469406b45fb614d3d3bcdb39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994158Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#732042}
-
Maksim Ivanov authored
Update the icon according to the latest SVG file provided by the UX designers, and adjust the color as requested. Also fix the icon's canvas size, so that the icon is rendered with the expected size - 28 pixels. Bug: 1006439 Test: create a smart card user, unplug the reader, try to login, take a screenshot, verify the error icon size is 28px Change-Id: Idb5d94328463a9e6b3e18f526babde21630a9e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002576Reviewed-by:
-
Henrique Nakashima authored
It acts exactily like ChromeFeatureList, but will be what downstream classes will reference while ChromeFeatureList is moved to the .flags package. This is CL 1/5 for moving ChromeFeatureList to the .flags package. Bug: 1041468 Change-Id: Iff75ebb592c4acb883d668537f4a15d755b105bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001582Reviewed-by:
-
