- 30 Jul, 2019 40 commits
-
-
Raymond Toy authored
If the buffer offset lies outside the boundaries of the AudioBuffer , silently do nothing instead of throwing an error. This is a change in behavior where we used to throw an error if the offset was greater than or equal to the size of the AudioBuffer. Spec issue: https://github.com/WebAudio/web-audio-api/issues/1884 Bug: 987295 Change-Id: I61955108af0fa3072a2c7174889827781c06747e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717185Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#682321}
-
Min Chen authored
Changes in this cl: - Delete kMenuSeparatorColor, kUnifiedMenuSeparatorColor, kUnifiedNotificationSeparatorColor, kUnifiedSystemInfoSeparatorColor and kStackingNotificationCounterBorderColor. All of them are colors of separators. Use kSeparatorOnLightBackgroundColor and kSeparatorOnDarkBackgroundColor for colors of separators instead. - Delete kTrayIconColor, kOobeTrayIconColor, kMenuIconColor, kMenuIconColorDisabled, kMobileNotConnectedXIconColor, kUnifiedMenuIconColor, kUnifiedMenuIconColorDisabled. All of them are colors of icons. Use kIconOnDarkBackgroundColor and kIconOnLightBackgroundColor for colors of icons. kIconOnDarkBackgroundColorDisabled and kIconOnLightBackgroundColorDisabled for corresponding disabled icons. - Rename kUnifiedManagedDeviceIconColor to kIconOnDarkBackgroundSecondaryColor. - Delete kSystemMenuArrowRightIcon, which is not needed now. Bug: 986911 Change-Id: I94643b80692f65b94fcb93f2398aedc71dcce32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721441Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#682320}
-
Owen Min authored
Include user policies depends on the parameters. Include device information. Use default value of no convert value, convert policy type and enable pretty print. Bug: 983174 Change-Id: I3882d0f7f5cc0497e9b897c29d0263e7194d09e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721377Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682319}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/45872947..11c60ffe Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7e27873505ec9658ec9d93a0239942269ff1c804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725135Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682318}
-
Koji Ishii authored
Bug: 985201 Change-Id: If3bd3914a758b8b7c79b688a4abd721d3c683850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726270Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#682317}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7bacbf71f7d3..4da34bf74723 git log 7bacbf71f7d3..4da34bf74723 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 senorblanco@chromium.org First implementation of GrDawnUniformHandler. 2019-07-30 halcanary@google.com experimental/editor: clean up BUILD.gn Created with: gclient setdep -r src/third_party/skia@4da34bf74723 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I4275a9f42d4fa58692e9c5894397cffc87efba8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726294Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682316}
-
Rahul Arakeri authored
This CL fixes a race condition where a mousemove is processed before the renderer has had a chance to set up the scroll state (like the scroll_node etc). This happens due to the fact that when the renderer gets a mousedown, it is first "queued" as a GSB. So that meant, the scroll node was not yet set up. At this point, if a mousemove was sent from the browser proc before a frame is generated, it gets dispatched immediately and this can lead to nullptr derefernces. Bug: 988308 Change-Id: I32d60d33d943a01cb66ce223ea4388de20bc4b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725224Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#682315}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e90f86832eff..42f9ab2813ad Created with: gclient setdep -r src-internal@42f9ab2813ad The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I6b2ecc1519264073413ddb86c4dfaa444f080ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726291Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682314}
-
Paul Moy authored
f in the chat for our brother Will, who has (at least temporarily) joined infra. BUG=none TEST=none Change-Id: I0e431520cc0eb297d80f5ced134a5cd48b6d5cd1 Signed-off-by:
Paul Moy <pmoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721176Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#682313}
-
Alexandre Frechette authored
Try to eliminate race condition identified in https://crbug.com/972871#c32 by waiting for the expected navigations on the UI thread. Bug: 957657, 972871 Change-Id: I54623c37061aabbb81b570572d03f9dede642863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724662Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#682312}
-
Takuto Ikuta authored
Bug: 881609 Change-Id: If1575775206e0fbad06637953f2ffbf09f6368fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722365 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#682311}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6ad84b4c. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 14d3a4a1 "Sort tracks by id in MediaStreamAudioSourceNode" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ic9d74ee1b6b27dd1a6e3ef3d95bfc6e932d8dfa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725134Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682310}
-
Fumitoshi Ukai authored
CI builders migrated: - TSAN Release - TSAN Debug Bug: 950413 Change-Id: Ief5b6cf0113ea507a6f318a7761eedcb5bac7acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724678 Auto-Submit: Fumitoshi Ukai <ukai@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#682309}
-
Piotr Kalinowski authored
RWHIER::ShowContextMenutAtPoint used last_mouse_move_target_ to determine RenderWidgetHostImpl instance to forward the call to. It acknowledged that tracked view may have been destroyed since remembering it, and it first checked if it was in view map. This check used to fail for nullptr without crashing leading to an early return. However, IsViewInMap implementation changed since then and now if there were no mouse enter/leave events earlier, the browser would crash trying to dereference nullptr. This happens when devtools on the desktop connect to a mobile instance of the browser and forward a right click event on the page. TouchEmulator will convert it directly to the call to show context menu, but since remote devtools do not forward mouse move events, as the mobile does not even have a mouse, this variable will be empty. However, TouchEmulator already has a target view associated with emulated touch event that is being converted to context menu request. So pass that along and use it. Bug: 987665 Change-Id: I1bf8012827e9397f911a3c12efc984815ad37901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718571Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#682308}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/70cded6ac635..2613cdba80a3 git log 70cded6ac635..2613cdba80a3 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 syoussefi@chromium.org Vulkan: Fix barriers between render passes Created with: gclient setdep -r src/third_party/angle@2613cdba80a3 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: I80d35189d86a8d5f3b86bac68b1a486cfe78f97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726369Reviewed-by:
-
Synthia Islam authored
Remove unused method RecordAdFrameUkm from AdsPageLoadMetricsObserver class. Bug: 985934 Change-Id: Ib612423fa90f87e9b73297037d7faa3b448f7d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725132 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#682306}
-
dalyk authored
separately." This reverts commit 467d1d9d. This change was reverted because of an issue with an earlier change that this change depended on. There did not appear to be any issues with this change; it just needs to be relanded. > Original change's description: > > Configure the insecure and secure parts of the async resolver > > separately. > > > > We can now set the secure dns mode to AUTOMATIC and turn the > > insecure part of the resolver off, which will result in the async > > resolver issuing DoH requests and falling back to the system resolver > > without attempting to send plaintext DNS requests itself. > > > > In a follow up cl, the secure dns mode part of the configuration > > will be read from prefs. For now, we continue to set the mode to > > AUTOMATIC if there are DoH servers specified and to OFF otherwise. > > > > Bug: 985589 > > Change-Id: Ia40cbae1fdd57e19e925e125dcf1e82289220242 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709928 > > Commit-Queue: Katharine Daly <dalyk@google.com> > > Reviewed-by: Tom Sepez <tsepez@chromium.org> > > Reviewed-by: Eric Orth <ericorth@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#680161} Bug: 985589 Change-Id: I207101bb03b385d08628002c2b463018e189223a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717121Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#682305}
-
Philip Rogers authored
Non-fast scrollable regions are regions on a cc::Layer where the compositor should not handle scroll events. These are generated for: 1) Non-composited scrollable areas. 2) Resize controls. 3) Plugins that request wheel events. These regions were previously computed in ScrollingCoordinator and depended on compositing decisions made in a previous lifecycle stage. This is not compatible with CompositeAfterPaint and needed to be re-implemented to be independent of compositing decisions. In addition, the previous implementation had a flaw where non-fast regions were only stored on scrolling layers. This was incorrect if a non-scrolling layer moved on the compositor, or in the presence of fixed-positioning. This patch re-implements non-fast scrollable regions using the paint system, similar to how touch-action rects are painted. This patch paints non-fast regions for 1, leaving 2 and 3 for followups. The design is outlined in [1] and [2] and has been implemented behind a flag. Painting ScrollHitTestDisplayItems re-uses existing CompositeAfterPaint code for painting scroll hit test display items. PaintNonFastScrollableRegions uses these display items to mark non-fast regions for non-composited scrollers. Though the CompositeAfterPaint scroll hit test display item code is shared, there is a nuance in how pre-CAP and CAP handle composited scrollers: pre-CAP only emits scroll hit test items for composited scrollers (which is known at paint time), whereas CAP emits them for all scrollers (compositing is not known at paint time) and then later ignores the scroll hit test display items that were for composited scrollers (this occurs in PaintArtifactCompositor). [1] design doc: https://docs.google.com/document/d/1IyYJ6bVF7KZq96b_s5NrAzGtVoBXn_LQnya9y4yT3iw/view#heading=h.rrlzkp4v3huj [2] documentation: third_party/blink/renderer/core/paint/README.md Bug: 864567, 817600 Change-Id: Ic24e2887404ff1ddb6481c014f5f4884ae1c924b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719404 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Leonard Grey authored
For very mysterious reasons, this only kind of works; peeking at the systemwide notification which is sent (UAZoomFocusDidChangeNotification), something often tells the system to go focus a seemingly random part of the screen instead. I've been unable to make headway on this, so sending CL on the principle that "something is better than nothing." We can revisit later if we can figure out why this is happening. Comfortingly (?) the same thing happens to Safari web content so I'm going to assume something is wonky with this system on the OS side. Bug: 957395 Change-Id: I8356cff86795f19648ab6746d1f23fd5ea1a7025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713390Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#682303}
-
Scott Haseley authored
QueueType::kWebScheduling was recently added for the scheduling API and these task queues are per-frame. These task queues aren't used outside of unit tests yet, so this DCHECK won't affect chrome builds, but it is failing locally causing flakiness in scheduling API wpt tests. This CL adds a separate IsPerFrameTaskQueue() method with a switch so adding future QueueTypes cause a compile error if the test isn't updated. Bug: 984057 Change-Id: If2ac727f63d26ae3998e8dddccbf39c9b680151e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724896Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#682302}
-
Justin Cohen authored
As of Xcode 11 beta 5, it appears iOS is now setting CERT_STATUS_WEAK_KEY properly. Bug: 977163 Change-Id: I8bc713eb8d20914410c1aa642932a4c615235ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725539Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#682301}
-
Bo Liu authored
Clean up. It's been enabled by default for awhile now. Change-Id: Ice4ffc2d69aa8f17564293d9befe3dc3021244b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725536 Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#682300}
-
Avi Drissman authored
This matches Aura behavior. In addition, native Mac menus take key focus so this matches platform behavior better, too. BUG=986247 TEST=as in bug Change-Id: I92dc11c73d390f348b087aaaa8dd3b15e62b86b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718453Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#682299}
-
Maksim Ivanov authored
Add more browser tests for the CryptohomeKeyDelegate implementation, for these scenarios: * a key that supports two algorithms simultaneously; * another signature algorithm (PKCS #1 v1.5 SHA-1) besides PKCS #1 v1.5 SHA-256; * an unsupported signature algorithm; * the extension removing the key that it reported before; * the extension failing the signature operation. Bug: 826417 Change-Id: Ie298c506a26debfcead64fb8209a2174fedc52b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706440 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Lutz Justen authored
Increases the begin frame delay in ScrollAnimatorSimTest. This works around an issue where ScrollAnimatorSimTest.TestDivUserScrollCallBack was consistently broken on tsan, presumably because it took too long on this heavily instrumented build. TBR=lanwei@chromium.org,bokan@chromium.org BUG=chromium:987981 TEST=Repro steps mentioned in #5 of bug don't work anymore. Change-Id: Iad1205cd0ad8bacc5c6ce618c23a8ae27d706c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724685Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#682297}
-
Oleg Davydov authored
there is no reason to call ExtensionManagementFactory::GetInstance to access it. More, GetForBrowserContext calls GetInstance itself. ExtensionManagementFactory: :GetForBrowserContext is a static method, so Change-Id: Ib761361258047b144edc8c2ee725c2b1811f6697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724511Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Sam Burnett authored
Bug: 895821 Change-Id: If34c7c76d59d713a57fac8d9901f3549f990a7a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704680 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#682295}
-
Steven Bennetts authored
Bug: 853953 Change-Id: If221bdeaa048f3d94cc375f87f81af2f10e2b5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697430 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#682294}
-
Nektarios Paisios authored
When the anchor or the focus objects for a selection are on a platform leaf object, then the anchor and focus offsets should necessarily refer to a text position and not a tree position, since leaf objects never have children and therefore any anchor or focus offsets cannot refer to child indices. Objects that are designated as leaves on certain platforms might not be leaves on every platform. For example, in the internal accessibility tree, native text fields are not leaf objects. They include a whole subtree inside them, which exposes all of the text. However, AXSelection in Blink should never return positions that are inaccessible to platform APIs so it is a safe assumption that any position on a platform leaf object should refer to a text object. The user visible change is that editing now works on the Mac without random navigation errors. R=aleventhal@chromium.org Bug: 988139 Change-Id: I1180274222b8899ec81bb031c35def98d89594bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725129 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#682293}
-
chrome://omniboxmanuk authored
Replaced handleNewAutocompleteResponse with HandleNewAutocompleteResponse in the mojom and cpp files. Retained lower case in the JS file. Bug: 891303 Change-Id: I0399aed03bc857c28452162d2a783d4b989843d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724861 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#682292}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9dc0b9e2f86a..7bacbf71f7d3 git log 9dc0b9e2f86a..7bacbf71f7d3 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 michaelludwig@google.com Update SkPicture version for simplified image filter enums 2019-07-30 halcanary@google.com experimental/editor: Editor::markDirty() private helper 2019-07-30 robertphillips@google.com Add GrContext::defaultBackendFormat 2019-07-30 fmalita@chromium.org [skottie] Fix property observer scoping for effects 2019-07-30 fmalita@chromium.org Clean up SkBaseDevice::CreateInfo 2019-07-30 robertphillips@google.com Add GrCaps::isFormatCompressed 2019-07-30 reed@google.com remove drawlooper bots, as that code is now gone Created with: gclient setdep -r src/third_party/skia@7bacbf71f7d3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:987392 Change-Id: I3d6a5e9f805891f8df90dcc462018527a6741db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726289Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Bug: 956205 Change-Id: I0960ddb12101f35c60c26a70c5592230964ac5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725521 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#682290}
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: Ia640a3c60f69d607bdf932b090235a5493a1a368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725425 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#682289}
-
Abhijeet Kandalkar authored
This is a reland of b223de22 with compile fix for internal builds (see PS1->PS2) Original change's description: > Convert services/media_session services to new Mojo types (6/n) > > The primary goal of this CL is to convert usage of |functions| of > interface AudioFocusManager and port dependent files to adopt new > implementation. > > Bug: 955171 > Change-Id: I2c8f269b2b36034b9ebc5beb1aef56ee3db691b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715367 > Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682154} TBR=abhijeet@igalia.com, kinuko@chromium.org, rockot@google.com, oshima@chromium.org Bug: 955171 Change-Id: If48f271b14f2f74477273f909fa11a8b0771ffd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725639Reviewed-by:
Abhijeet Kandalkar <abhijeet@igalia.com> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#682288}
-
Ricardo Quesada authored
This CL adds "className" attribute, in case it is defined, in the AutomationNode.toString() function. This is helpful when inspecting the automation hierarchy in Chrome OS, where the className is used frequently. TEST=Run this JS code:``` var myRoot; chrome.automation.getDesktop(r => myRoot = r); myRoot.toString();``` And it includes the className in the nodes that have it defined. BUG=chromium:982453 Change-Id: Icaeba586bda6ddcae536063718f8527be69f5f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693701Reviewed-by:Doug Turner <dougt@chromium.org> Commit-Queue: Ricardo Quesada <ricardoq@chromium.org> Auto-Submit: Ricardo Quesada <ricardoq@chromium.org> Cr-Commit-Position: refs/heads/master@{#682287}
-
Yi Su authored
The new layout of NTP articles based on EUCD compliance is ready for testing. Bug: 979143 Change-Id: Iad8e6569ac81674e0bcd474bbda03ad73bddb12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720238 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#682286}
-
Tanmoy Mollik authored
Build components/signin/core/browser targets without implicit conversion from CoreAccountId to std::string All build targets for signin/corebrowser/BUILD.gn now builds without implicit conversion from CoreAccountId to std::string. Bug: 959157 Change-Id: Icd4bc11e21fddb2591b4fe8544b85dc0e0e992cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718411 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682285}
-
David Benjamin authored
The SSLVersionMax policy was introduced in 2017 to allow administrators to disable TLS 1.3, as a temporary workaround for buggy middleboxes. It was always documented in policy_templates.json to be temporary and stop working in M75, with notice in both M74 and M75 release notes. Remove the implementation of the policy. Bug: none Change-Id: Idec7c14101d2199cd5fad23897a5e76cd26025c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716059 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
Rayan Kanso authored
Bug: 985695 Change-Id: Ie6dfa5717219e06a5b7188e50c88b25b32ef69e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726049 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#682283}
-
Omer Katz authored
fix broken tests due to no allocation policy for pre-finalizers Bug: 988445 Change-Id: I5d795c118aecd1e0fbe8d7c0b1a63a07f1901be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726029Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#682282}
-
