- 16 Nov, 2018 40 commits
-
-
Sylvain Defresne authored
Add implementation and test for PrimaryAccountMutatorImpl method SetPrimaryAccount. The method is the new API that will replace SigninManager::OnExternalSigninCompleted(). Bug: 889902, 806778 Change-Id: I0ece2927c24506644a1087a7ed10df4578d592e3 Reviewed-on: https://chromium-review.googlesource.com/c/1335601 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#608735}
-
Ramin Halavati authored
A test is added to ensure that changing content settings in incognito mode does not affect the regular mode. Bug: 841412 Change-Id: I473ba39a1f37e69ef5682c2856e4fe3f62e03681 Reviewed-on: https://chromium-review.googlesource.com/c/1286419Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#608734}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ca28da25. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I06222289d8637512a5fd1b6dd125532ea7d7d210 Reviewed-on: https://chromium-review.googlesource.com/c/1339722 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608733}
-
Yuta Kitamura authored
This moves functions defined in web_task_runner.h to two different headers in platform/scheduler/public: post_cancellable_task.h and post_cross_thread_task.h. The header web_task_runner.h remains in the same place, just having the forwarding #include statements, so the existing code wouldn't break. Minor adjustments are made to the moved code, like: (1) using PLATFORM_EXPORT rather than BLINK_PLATFORM_EXPORT, (2) using base::TimeDelta instead of WTF::TimeDelta, and (3) revising comments. web_task_runner_test.cc is also moved, and is simply renamed to post_cancellable_task_unittest.cc because it only contains tests for PostCancellableTask(). Bug: 826203 Change-Id: I1fa4f35d278975fbca1a7c27fecf37342b0c76c8 Reviewed-on: https://chromium-review.googlesource.com/c/1339503Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#608732}
-
Gauthier Ambard authored
This CL migrates BlockPopupsCollectionViewController so it is a UITableViewController instead of a MDCCollectionViewController. It also fixes few corner cases with the display of the bottom toolbar in the SettingsRootTableViewController. It also add a check for the SectionHeader in the Chrome Table View test case. Bug: 894791 Change-Id: I82d67940846c7a630cadaac5ff07c00cf811113b Reviewed-on: https://chromium-review.googlesource.com/c/1331387 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#608731}
-
Oriol Brufau authored
Spec: https://drafts.csswg.org/css-logical/#directional-keywords Currently logical values compute to the corresponding physical value, and the mapping is with respect to the element itself. This patch makes them compute as specified and changes the mapping to be with respect to the containing block. BUG=901409 TEST=external/wpt/css/css-logical/logical-values-float-clear.html TEST=external/wpt/css/css-logical/logical-values-float-clear-reftest.html TEST=external/wpt/css/css-logical/logical-values-resize.html TEST=webexposed/nonstable-css-properties.html Change-Id: Ie0acaacde813c5343ec3bb8de712c4af03639475 Reviewed-on: https://chromium-review.googlesource.com/c/1315989 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#608730}
-
Ernest Galbrun authored
Before: when clicking the close icon on the upper-right corner or choosing the "no" chip, we would close the init screen but leave autobot hanging. After: Autobot is closed when either of those action is done and the constroller is destroyed. Bug: 806868 Change-Id: Ib82d450df4700914c67354cba2404829c378bb64 Reviewed-on: https://chromium-review.googlesource.com/c/1335551Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Ernest Galbrun <galbrun@google.com> Cr-Commit-Position: refs/heads/master@{#608729}
-
Stepan Khapugin authored
Adds support for the badge on the reading list icon. Change-Id: I9a387796134c89de5aa117d1697a074c56458300 Reviewed-on: https://chromium-review.googlesource.com/c/1299144Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608728}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/95ac6f04a8f7..0c33d62e0821 git log 95ac6f04a8f7..0c33d62e0821 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 perezju@chromium.org [soundwave] Switch pinpoint_service to luci-auth for authentication Created with: gclient setdep -r src/third_party/catapult@0c33d62e0821 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:903026 TBR=sullivan@chromium.org Change-Id: I131beb502b98d49048c9a7ac5ffbf17736513429 Reviewed-on: https://chromium-review.googlesource.com/c/1339482Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608727}
-
David Roger authored
Token revocation requests can now be retried up to three times when the error is one of: - GaiaAuthConsumer::TokenRevocationStatus::kServerError - GaiaAuthConsumer::TokenRevocationStatus::kConnectionFailed - GaiaAuthConsumer::TokenRevocationStatus::kConnectionTimeout - GaiaAuthConsumer::TokenRevocationStatus::kConnectionCanceled Other errors are not retried: - GaiaAuthConsumer::TokenRevocationStatus::kInvalidToken - GaiaAuthConsumer::TokenRevocationStatus::kInvalidRequest - GaiaAuthConsumer::TokenRevocationStatus::kUnknownError kConnectionFailed is currently the most frequent error by far. This CL is also expected to impact the histogram Signin.RefreshTokenRevocationRequestProgress: since requests can now be retried, the process of revoking a token should be longer in average, and the number of token revocations that never complete is expected to raise. Bug: 872457 Change-Id: I8591f13ae9e7bf94e6055028b29490020444a6e2 Reviewed-on: https://chromium-review.googlesource.com/c/1329169 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#608726}
-
Camillo Bruni authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: I8ccf0cd9732103ef22a1c4352037ebd731549b51 Reviewed-on: https://chromium-review.googlesource.com/c/1329629Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#608725}
-
Sergio Villar Senin authored
Replace the usage of SigninManager API by IdentityManager's. Bug: 905281 Change-Id: I64453935c4312eeaf1f42c770aa01d16b6238730 Reviewed-on: https://chromium-review.googlesource.com/c/1337615 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#608724}
-
David Roger authored
OAuth multilogin now tries to keep the current account ordering as much as possible. It also handles the cases where there are more than 10 accounts in Chrome (which happens in real life), and where there are more than 10 accounts in the cookie (should not happen in real life, but should be handled gracefully). Bug: 899472 Change-Id: I04b6ab195beb2691ce23f25e1a645b19b0e2c9d9 Reviewed-on: https://chromium-review.googlesource.com/c/1335598 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#608723}
-
Eric Willigers authored
Recent CSS WG decision https://github.com/w3c/csswg-drafts/issues/3258 Bug: 568705 Change-Id: If24be4b2c0a49ba12c92df873b0a4de12eb1a21e Reviewed-on: https://chromium-review.googlesource.com/c/1337227Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#608722}
-
Eric Willigers authored
We were previously appending a z value of 0px to the specified value of transform-origin. This is not needed, and violates the CSSOM shortest serialization principle. It was also inconsistent with our computed value results, where we don't append a z value of 0px. Bug: 905997 Change-Id: I76612a16e2048f568a6215804aa7e11469cb8e29 Reviewed-on: https://chromium-review.googlesource.com/c/1337669 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#608721}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/39d528d074c9..4b4a9d92fc53 Created with: gclient setdep -r src-internal@4b4a9d92fc53 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I955f98057e416ce26a533951b2859849d138d96d Reviewed-on: https://chromium-review.googlesource.com/c/1339481Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608720}
-
Mythri Alle authored
With IsolatedCodeCache enabled we no longer expect metadata entry to be used in the HttpCache. For unit tests that test for this feature disable this feature explicitly. Bug: chromium:812168 Change-Id: I8acb917bcd3979663c89600267326776b5a54f23 Reviewed-on: https://chromium-review.googlesource.com/c/1337506 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#608719}
-
Alex Loiko authored
The new params introduce options to change the saturation margin, and choose between peak- and RMS-based algorithms. Make sure params are applied both in AudioProcessor and MediaStreamAudioProcessor. Bug: 873650 Change-Id: Ia7584ec17a1e0bc7bec5973da3d143456ec26c41 Reviewed-on: https://chromium-review.googlesource.com/c/1333388 Commit-Queue: Alex Loiko <aleloi@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608718}
-
Jun Choi authored
Currently HoverListView in WebAuthn UI only takes into account height of the hover buttons. As HoverListView also contains item separators, we end up always setting height of the scroll view to few pixels short of actual height of the views in the container. Add separator view height to the height of scroll view. Bug: 877344 Change-Id: I6f38bb8ec69c5c0b52845f0ce71fa1c092fa7ce3 Reviewed-on: https://chromium-review.googlesource.com/c/1336069Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608717}
-
Martin Robinson authored
Original: http://crrev.com/c/1319709 Revert: http://crrev.com/c/1336437 Moves a statically initialized map to a be initialized as a local static using NoDestructor. Original description: ATK requires us to allow it to filter all key events. Add an AtkUtil mechanism to filter key events. Bug: 866334 Change-Id: I918590da241dc10f71ade558454a2fbf118e5860 Reviewed-on: https://chromium-review.googlesource.com/c/1337621 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#608716}
-
Christian Dullweber authored
This adds a few user actions to record how users interact with the new sync ui in ClearBrowsingData. Bug: 901464 Change-Id: Ib8291ff0d8d81f133eb0a5c707ef864afa46309a Reviewed-on: https://chromium-review.googlesource.com/c/1326496 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#608715}
-
Marc Treib authored
including both the iOS and the non-iOS versions. Bug: 884159 Change-Id: Ic8b983a5e10cebd2708084937999b7049fcdcb57 Reviewed-on: https://chromium-review.googlesource.com/c/1337507Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#608714}
-
Sergio Villar Senin authored
Replace the calls to SigninManager API to the IdentityManager one. It's now using a IdentityTestEnvironmentProfileAdaptor to create the profile used by the tests. Bug: 903883 Change-Id: Idd2ff37cd4937307369f76783fdada9a9c770946 Reviewed-on: https://chromium-review.googlesource.com/c/1337332 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#608713}
-
Rune Lillesveen authored
There is no point in marking an element style dirty while we are recalculating style for it. For SVG elements which are referenced through <use> elements we even mark the instances style-dirty which caused a problem in issue 904381 because the <use> instance was outside of the sub-tree rooted at the recalc root, causing the tree to be still style-dirty after UpdateStyle. Bug: 904381 Change-Id: If5e487783668e9d411ff721fd60e80fa7f1a8313 Reviewed-on: https://chromium-review.googlesource.com/c/1335602Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#608712}
-
Jun Choi authored
This reverts commit 73564b6c. Reason for revert: <Fails build Google Chrome Win Build #40337 on "chrome/browser/conflicts/module_blacklist_cache_util_win.cc(242,61)"> Original change's description: > [base] Remove base::span's comparison operators > > At the recent ISO C++ Committee meeting in San Diego it was decided [1] > to make std::span SemiRegular and drop its comparison operators [2]. For > further info see also this blog post [3]. > > This change updates the base::span implemention appropriately and > replaces prior usages of the comparison operators with their STL > algorithm equivalent. > > [1] http://redd.it/9vwvbz > [2] https://wg21.link/p1085 > [3] https://abseil.io/blog/20180531-regular-types#evaluating-span > > Bug: 828324 > Change-Id: I94e94450df5f233b6de81da81f309386e0dcf4a7 > Reviewed-on: https://chromium-review.googlesource.com/c/1337628 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Jun Choi <hongjunchoi@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608702} TBR=rsleevi@chromium.org,dcheng@chromium.org,rockot@google.com,jrummell@chromium.org,mek@chromium.org,haraken@chromium.org,jdoerrie@chromium.org,hongjunchoi@chromium.org Change-Id: Id39b32be29dd80b6d299fc99a2efade8c2246fe6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 828324 Reviewed-on: https://chromium-review.googlesource.com/c/1339999Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608711}
-
Veranika Liaukevich authored
The code hasn't been used by the cleaner or the reporter for a long time. Change-Id: I46e95300ac11d5c6d601bccafe1853b555de54f7 Reviewed-on: https://chromium-review.googlesource.com/c/1316170Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Veranika Liaukevich <veranika@chromium.org> Cr-Commit-Position: refs/heads/master@{#608710}
-
Yutaka Hirano authored
It's no longer crashy. Bug: 902632 Change-Id: I2446b569e116e6a9f62b1bedf2c1eb0338184461 Reviewed-on: https://chromium-review.googlesource.com/c/1338822Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#608709}
-
Amos Lim authored
If a 2d translation is specified, the property must serialize with only one or two values (per usual, if the second value is 0px, the default, it must be omitted when serializing)[1]. [1]: https://drafts.csswg.org/css-transforms-2/#individual-transform-serialization Bug: 904804 Change-Id: I34c4f47b5413348c7526b9050c89ec35212c3093 Reviewed-on: https://chromium-review.googlesource.com/c/1337670Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#608708}
-
Corentin Wallez authored
BUG=chromium:chromium:901830 Change-Id: Idf9d60a7ca58d65ca8632fef1a729691d99207a5 Reviewed-on: https://chromium-review.googlesource.com/c/1337499Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#608707}
-
Ernest Galbrun authored
Bug: 806868 Change-Id: Iacfc5e5100a27f1bec98d7f794bd624eef4c9f82 Reviewed-on: https://chromium-review.googlesource.com/c/1335573 Commit-Queue: Ernest Galbrun <galbrun@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#608706}
-
Jun Choi authored
MacOS use system native UI for Bluetooth pairing process. Thus, instead of showing BLE PIN UI, directly attempt to establish connection with the device user selected during BLE device selection UI. Bug: 877344 Change-Id: I47bcd31e7d679beba65337dcc6d9b3b555bdf739 Reviewed-on: https://chromium-review.googlesource.com/c/1331474Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608705}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0111ee0e733..39d528d074c9 Created with: gclient setdep -r src-internal@39d528d074c9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic9b2fb974e834b590b82eef6ce17add4763b6967 Reviewed-on: https://chromium-review.googlesource.com/c/1339480Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608704}
-
Amos Lim authored
Align WorkerLocation IDL with HTML spec by getting rid of URLUtilsReadOnly and flattening it into WorkerLocation. Spec: https://html.spec.whatwg.org/multipage/workers.html#worker-locations Bug: 699873 Change-Id: I525a47c01e7ef31457958dd76a811134737597b4 Reviewed-on: https://chromium-review.googlesource.com/c/1339680 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#608703}
-
jdoerrie authored
At the recent ISO C++ Committee meeting in San Diego it was decided [1] to make std::span SemiRegular and drop its comparison operators [2]. For further info see also this blog post [3]. This change updates the base::span implemention appropriately and replaces prior usages of the comparison operators with their STL algorithm equivalent. [1] http://redd.it/9vwvbz [2] https://wg21.link/p1085 [3] https://abseil.io/blog/20180531-regular-types#evaluating-span Bug: 828324 Change-Id: I94e94450df5f233b6de81da81f309386e0dcf4a7 Reviewed-on: https://chromium-review.googlesource.com/c/1337628Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#608702}
-
Kent Tamura authored
CustomElementDefinition::disable_internals_ is initialized with the content of 'disabledFeatures'. This code is behind 'ElementInternals' runtime flag, and this CL doesn't have user-visible behavior changes yet. Bug: 905922 Change-Id: I9755835079cb71f34317a74a76cf4ac9486df60d Reviewed-on: https://chromium-review.googlesource.com/c/1339500Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#608701}
-
Kent Tamura authored
'formdata' event handlers can get entries created with form-associated elements. Bug: 825684 Change-Id: I55169bf1491073dc52f310d1165c882ed2a98101 Reviewed-on: https://chromium-review.googlesource.com/c/1338825Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#608700}
-
Hitoshi Yoshida authored
This is a reland of 6a1db25d with fixing the build error. Original change's description: > document: Use ElementCreationOptions in Document.createElement() > > We used (DOMString or Dictionary) type for |option| parameter, > but this CL replaces it with (DOMString or ElementCreationOpitons) > as the spec defined. > > > Bug: 904241 > Change-Id: I9416af83168e7c1f7456ffdbd3141fa97b510706 > Reviewed-on: https://chromium-review.googlesource.com/c/1333094 > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608668} Bug: 904241 Change-Id: I2ea645814ea80f9989dab93574e70e473b72a10a Reviewed-on: https://chromium-review.googlesource.com/c/1339499Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#608699}
-
Oystein Eftevaag authored
Specifically memory.long_running_idle_gmail_background_tbmv2 will OOM on Nexus5 devices with this buffer size. R=eseckler@chromium.org Bug: 902064 Change-Id: If8e5529f3000b9a2f3b86abaecb1f219df356575 Reviewed-on: https://chromium-review.googlesource.com/c/1338889 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#608698}
-
Oystein Eftevaag authored
R=eseckler@chromium.org Bug: 902064 Change-Id: I4b113c69df1192b4d0d05c0a5b9107b84b9cae2e Reviewed-on: https://chromium-review.googlesource.com/c/1338879 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#608697}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 97597a97. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I8d94faa710dfebfa36100ca26344b5ceadc51f86 Reviewed-on: https://chromium-review.googlesource.com/c/1339459 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608696}
-