GitLab

LogoutButtonTray uses and owns LogoutConfirmationDialogView, a dialog that
asks the user to confirm or deny logout. This CL generalizes the dialog
and moves its ownership to a LogoutConfirmationController accessible via
ash::Shell, allowing other classes to show the same dialog.

BUG=278247
TEST=Updated unit tests

Review URL: https://codereview.chromium.org/178183005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255316 0039d316-1c4b-4281-b951-d872f2087c98

switch and field trial.

BUG=346708

Review URL: https://codereview.chromium.org/183923021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255315 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343921

Review URL: https://codereview.chromium.org/178803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255314 0039d316-1c4b-4281-b951-d872f2087c98

> Add VP9 encode support to the remoting host.
> 
> BUG=260879,349862 
> 
> Review URL: https://codereview.chromium.org/28183002

TBR=wez@chromium.org

Review URL: https://codereview.chromium.org/188563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255313 0039d316-1c4b-4281-b951-d872f2087c98

> Move TranslateManager unit tests out of the browser_tests target.
> 
> These are unit tests so they should be in the unit_tests target. A
> TODO says this did not work before, but they appear to pass as unit
> tests now, so this is just a code move.
> 
> R=sky
> BUG=270918
> 
> Review URL: https://codereview.chromium.org/186063007

TBR=danakj@chromium.org

Test is failing on Linux memory bot. If this is passing on main waterfall, it may be due to sharding
and this test may have some global state that previous test didn't cleanup

TranslateManagerRenderViewHostTest.FetchLanguagesFromTranslateServer: 
Xlib:  extension "RANDR" missing on display ":9".
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:319: Failure
Value of: fetcher != NULL
Actual: false
Expected: true
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:319: Failure
Value of: fetcher != NULL
Actual: false
Expected: true
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:662: Failure
Value of: current_supported_languages.size()
Actual: 54
Expected: server_languages.size() - 1
Which is: 7
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:675: Failure
Value of: is_alpha
Actual: true
Expected: TranslateDownloadManager::IsAlphaLanguage(lang)
Which is: false
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:675: Failure
Value of: is_alpha
Actual: true
Expected: TranslateDownloadManager::IsAlphaLanguage(lang)
Which is: false
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>

Review URL: https://codereview.chromium.org/188553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255312 0039d316-1c4b-4281-b951-d872f2087c98

Linux is unaffected. All changed code already is inside sandbox.

BUG=348692

Review URL: https://codereview.chromium.org/185293014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255311 0039d316-1c4b-4281-b951-d872f2087c98

Paint views::Textfield drag images with views::Labels.
Makes the drag image fit the size of the selected text.
(not as wide as the origin Omnibox/textfield itself)
Use an offset for the image similar to the Unity desktop.

This changes the appearance of split-selection BiDi text.
(doesn't show blank area between the visually split text)
See before/after pictures at http://crbug.com/349105

Remove now unused RenderText::DrawSelectedTextForDrag.

BUG=349105
TEST=Linux Aura and ChromeOS text drag images look good.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/177683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255310 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349589

Review URL: https://codereview.chromium.org/188023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255309 0039d316-1c4b-4281-b951-d872f2087c98

R=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/185223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255308 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a virtual keyboard icon when a11y VK is enabled. Click or tap on
the icon will force the VK to show and lock.

BUG=346695

Review URL: https://codereview.chromium.org/177123016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255307 0039d316-1c4b-4281-b951-d872f2087c98

R=agl@chromium.org,felt@chromium.org,rsleevi@chromium.org
BUG=348987
TEST=none

Review URL: https://codereview.chromium.org/187573009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255306 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349153
TEST=bots
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/187413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255305 0039d316-1c4b-4281-b951-d872f2087c98

When the touch-action for the current touch sequence is updated, also update
whether the touch ack time is disabled based on the allowed touch-action. This
provides a straightforward knob for developers to disable the timeout on desktop
sites.

BUG=340060

Review URL: https://codereview.chromium.org/183923034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255304 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349610

Review URL: https://codereview.chromium.org/178943004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255303 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341513

Review URL: https://codereview.chromium.org/185943008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255302 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255301 0039d316-1c4b-4281-b951-d872f2087c98

Changes are needed for GCM for Chrome on desktop.

Full list of changes:

322: Cleanup: Convert from scoped_ptr to std::unique_ptr.
323: remove unused mock methods
324: Add channel_common.proto
325: Revert r322 since Chrome does not yet support unique_ptr
326: update build datestamp
327: February 2014 invalidation client release
328: Adding copies of protos for use in C++ cache invalidation.
329: change protocol buffer compiler options in channel_common.proto
330: add lite runtime option to android_channel.proto

BUG=325020
R=meek@chromium.org

Review URL: https://codereview.chromium.org/185013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255300 0039d316-1c4b-4281-b951-d872f2087c98

This was visible in a couple of rows where the right side of the last input column didn't align with the right side of the (sole) input on the previous/next lines.

BUG=none

Review URL: https://codereview.chromium.org/185653012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255299 0039d316-1c4b-4281-b951-d872f2087c98

User cloud policy token forwarder: Replace PO2TS::GetPrimaryAccountId() with SMB::GetAuthenticatedAccountId.

The functionality is the same, just moving the code to a new place.

BUG=333995,107160

Review URL: https://codereview.chromium.org/137553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255298 0039d316-1c4b-4281-b951-d872f2087c98

Remove an old ID used by QO for development, and add
an ID to the extension on the internal store instead.

BUG=348871

Review URL: https://codereview.chromium.org/186393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255297 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255296 0039d316-1c4b-4281-b951-d872f2087c98

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/183873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255295 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=168527:168581&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/188373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255294 0039d316-1c4b-4281-b951-d872f2087c98

There is no point in trying to return to the same server, if that server
is no longer handling requests.

Review URL: https://codereview.chromium.org/186293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255293 0039d316-1c4b-4281-b951-d872f2087c98

As part of eliminating Signin-related notifications, move SigninTracker to
observing the SigninManager.

BUG=349375
TBR=thakis

Review URL: https://codereview.chromium.org/180743018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255292 0039d316-1c4b-4281-b951-d872f2087c98

This will be used to know when a module has been added so that I can
download needed modules.

BUG=none
TEST=none
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/187653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255291 0039d316-1c4b-4281-b951-d872f2087c98

Converts bookmarks and bookmarkManagerPrivate event related functions
to use the schema generated classes instead of manually constructing
JSON objects.

BUG=

Review URL: https://codereview.chromium.org/185293019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255290 0039d316-1c4b-4281-b951-d872f2087c98

It's POSIX-only and redundant.

R=phajdan.jr@chromium.org
TBR=brettw@chromium.org,jam@chromium.org,gene@chromium.org

Review URL: https://codereview.chromium.org/187993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255289 0039d316-1c4b-4281-b951-d872f2087c98

to allow broken alternate protocol mappings to be expunged.

R=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/187693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255288 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347900
TEST=run_webkit_tests.sh http/tests/filesystem/\*
TEST=run_webkit_tests.sh http/tests/inspector/filesystem/\*

Review URL: https://codereview.chromium.org/187393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255287 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/187893007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255286 0039d316-1c4b-4281-b951-d872f2087c98

This is a followup to https://codereview.chromium.org/148523013.

BUG=none

Review URL: https://codereview.chromium.org/179293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255277 0039d316-1c4b-4281-b951-d872f2087c98

RenderWebColorChooserImpl is owned by blink::ColorChooserUIController so it should not be destroyed in RenderViewObserver::OnDestruct

BUG=342735

Review URL: https://codereview.chromium.org/181233006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255276 0039d316-1c4b-4281-b951-d872f2087c98

This change adds RenderThread::GetShutdownEvent() to the public content API.
This is required for code outside of content/ that wants to safely use
interfaces like SyncChannel.

BUG=

Review URL: https://codereview.chromium.org/186973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255275 0039d316-1c4b-4281-b951-d872f2087c98

This prevents a crash when a token on the via header
is fewer than four characters.

BUG=349020

Review URL: https://codereview.chromium.org/187273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255274 0039d316-1c4b-4281-b951-d872f2087c98

The problem was that if the user was set to use the Gaia profile info, then we ignored any custom profile names that were synced. We shouldn't do that :) 

BUG=343730,348187,349000

Review URL: https://codereview.chromium.org/186803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255273 0039d316-1c4b-4281-b951-d872f2087c98

WaitSyncPoint(0) does not do anything, so return early. Accelerated video code
path frequently calls WaitSyncPoint(0).

BUG=N/A

Review URL: https://codereview.chromium.org/185393008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255271 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245025
TEST=content_unittests --gtest_filter="WebCryptoImpl*"

Review URL: https://codereview.chromium.org/118623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255270 0039d316-1c4b-4281-b951-d872f2087c98

Renamed the char* argument to 'data' and the string argument to 'str'.
Cleaned up the comments on the char* overload (avoid using
string-specific terms and mentioning null byte). Mentioned that this
algorithm is also in Blink.

Added a test case testing that null bytes cause the hash to change.

BUG=347393

Review URL: https://codereview.chromium.org/182253007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255269 0039d316-1c4b-4281-b951-d872f2087c98

Remove un-necessary Dr. Memory exclusions for the now-fixed 349443. Add exclusion for TranslateManagerRenderViewHostTest.*.

BUG=349443,349778
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/183053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255268 0039d316-1c4b-4281-b951-d872f2087c98