- 30 Jul, 2018 40 commits
-
-
Pavel Feldman authored
Change-Id: Ica9b8579796c6684f59eb8bfe3731f26285f880c Reviewed-on: https://chromium-review.googlesource.com/1150823 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#579236}
-
Victor Costan authored
Bug: 850539 Change-Id: I24fe05cb8a909ceb181df643aeaf75c5007a4a3d Reviewed-on: https://chromium-review.googlesource.com/1154999 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#579235}
-
Andrew Moylan authored
This is a reland of 453eba23 Removed the call to mojo::core::Init from the test startup. It caused a memory leak because //chromeos/run_all_unittests.cc already calls it. Original change's description: > Add basic ServiceConnection unit test > > The is just testing that ServiceConnection::BindModelProvider returns > successfully. The Mojo invitation won't go anywhere beyond the no-op > FakeMachineLearningClient D-Bus client. > > To make this test compile, I had to fix an #include from an > overlooked file rename in an earlier CL ... > > Bug: 863794 > > Change-Id: Ifd31fea950145561cd5954ae16e930b801bfe49b > Reviewed-on: https://chromium-review.googlesource.com/1139942 > Commit-Queue: Andrew Moylan <amoylan@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578329} Tested by: manual detect_leaks=1 invocation of the test. TBR=rockot@chromium.org,derat@chromium.org Bug: 863794 Change-Id: I1258de74273551cebdc9dd1a76f86a35ffa50147 Reviewed-on: https://chromium-review.googlesource.com/1154647Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#579234}
-
Kenneth Russell authored
linux_optional_gpu_tests_tel doesn't run the WebGL 1.0 conformance tests on Linux/Intel on the CQ (it should) so this was missed. Bug: 820891, 867675 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I77b898b4ddd83cc1e1ec8fcdcc19918c203433d7 Tbr: kainino@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1155807Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#579233}
-
Eric Karl authored
We had a custom OverlayCandidateValidator for AndroidOutputSurface, but this was missing from GLOutputSurfaceAndroid. Bug: 868504 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I9a7b58575378d8c516b10dba04df8f80a2ccf77d Reviewed-on: https://chromium-review.googlesource.com/1153604 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#579232}
-
Ben Pastene authored
This reverts commit 4dd5af99. Reason for revert: Browser crashes flakily with DCHECKs on See https://chromium-swarm.appspot.com/task?id=3f063cbec4a26e10 https://chromium-swarm.appspot.com/task?id=3f063760c6162910 https://chromium-swarm.appspot.com/task?id=3f063164005d9710 Example crashes https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=e4fef843d0fef24b39d59d06bfddbe1569402f2b&as=chrome.PREVIOUS https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=4d98a300e399d97b4b02cf89f01134050e2f985e&as=chrome_20180730-160158 https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=a4068c05476b786213ab26a80cf35e426fd54f44&as=chrome_20180730-155114 Original change's description: > Enable DCHECKs on amd64-generic simplechrome CQ bot. > > Bug: 867077 > Change-Id: Icad4a62735d3be6579b3c6476bbbb65ad1843ec8 > Reviewed-on: https://chromium-review.googlesource.com/1150939 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579118} TBR=dpranke@chromium.org,dcastagna@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: I42e28d289cd2c6604b829b9971abb0783fa5ee76 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867077 Reviewed-on: https://chromium-review.googlesource.com/1155500Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#579231}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d718d634b7aa..87c1fdcc9a56 git log d718d634b7aa..87c1fdcc9a56 --date=short --no-merges --format='%ad %ae %s' 2018-07-30 tsepez@chromium.org Don't static_cast<>(this) to subclass in CXFA_LayoutItem methods. 2018-07-30 tsepez@chromium.org Return unique_ptr from CXFA_FFNotify::OnCreate{Container,Content}LayoutItem() 2018-07-30 tsepez@chromium.org Convert some asserts to ifs in cxfa_ffnotify.cpp. Created with: gclient setdep -r src/third_party/pdfium@87c1fdcc9a56 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib65f272f30b18482963afe5f468bdaff4fc40fe4 Reviewed-on: https://chromium-review.googlesource.com/1155613Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579230}
-
Victor Vasiliev authored
This reverts commit 8cc4e50c and relands 812abd15 with iOS tests disabled. R=rch@chromium.org Change-Id: I56fb4be93602fcaa9deccdf9a1837ebcd787af11 Reviewed-on: https://chromium-review.googlesource.com/1154361Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#579229}
-
Sarah Hu authored
This reverts commit fa0ab3e4. Add user button is not showing up correctly due to this CL, revert it now and will investigate the cause. TBR=tsepez@chromium.org,msw@chromium.org Change-Id: I2ab8ccd357f2ef27d3f9d1d53733cad45e65b6c8 Reviewed-on: https://chromium-review.googlesource.com/1155757 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#579228}
-
Stephen Martinis authored
This has been flipped on in the recipe side. Bug: 533481 Change-Id: Id0ef0dec5fefbbdcece8a485e65ca672e0982bc0 Reviewed-on: https://chromium-review.googlesource.com/1152035 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Xiangjun Zhang authored
Get permission to start remoting when harmony cast dialog is enabled. Bug: 849020 Change-Id: I98e306c7ffaa6f53dc825a418f2c0b48ea7a9ee2 Reviewed-on: https://chromium-review.googlesource.com/1139173Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579226}
-
Esmael El-Moslimany authored
Add find shortcut handling to sub-pages with search. Bug: 862701 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0db88c2712cac918f1be18068fe02df5d942e53d Reviewed-on: https://chromium-review.googlesource.com/1141157 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#579225}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d795ab891c15..b0e855a33353 git log d795ab891c15..b0e855a33353 --date=short --no-merges --format='%ad %ae %s' 2018-07-30 tandrii@chromium.org cq.cfg: remove cq_name. Created with: gclient setdep -r src/third_party/depot_tools@b0e855a33353 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:866476 TBR=agable@chromium.org Change-Id: Ie813a123c02f374125160a0cda33bd52577e0643 Reviewed-on: https://chromium-review.googlesource.com/1155610Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579224}
-
Stefan Zager authored
Previously, rect-based hit tests were assumed to be list-based as well. However, that's not necessary for IO. It's sufficient to return the first hit test result -- if it's the target element, then the target is not occluded; otherwise, it is occluded. Also add the kIgnoreZeroOpacityObjects flag, since zero opacity objects are not considered occluding by IO. With this change, the "deep layers" benchmark for IOV2 runs 6-7 times slower with visibility checking enabled, which is a big improvement over previous measurements (which were up to 50x slower). BUG=831762,823748 R=chrishtr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7471221357de465e9e5c1673537e7f11ee287e6a Reviewed-on: https://chromium-review.googlesource.com/1153547 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#579223}
-
Darren Shen authored
Currently, when windows change bounds with the virtual keyboard open, we update their insets (visual viewport size), because the overlap between the window and the virtual keyboard has changed. A previous CL added a check so that if the fullscreen handwriting flag is enabled, we don't update the insets. The intention was to reset the inset if we are using fullscreen handwriting mode, but the code actually checked if fullscreen handwriting mode was enabled. This meant that we would stop updating insets if the fullscreen handwriting flag was on, even if we are not using fullscreen handwriting. This patch removes this check. The insets are updated by occluded bounds and fullscreen handwriting has empty occluded bounds (for now), so we don't introduce any problems. TBR=yhanada@chromium.org Change-Id: I4285fb6fc4bcc50fcf502ca6c9c439c8d2aef97f Reviewed-on: https://chromium-review.googlesource.com/1154780Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#579222}
-
Peter Boström authored
Very flaky on Mac 10.10 Tests. Bug: chromium:868376 Change-Id: I415dd89ba7c666630e2d65950c2c5472d2e11968 Reviewed-on: https://chromium-review.googlesource.com/1155819Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#579221}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a78b6dcb82d2..9f7d4cd62a0b git log a78b6dcb82d2..9f7d4cd62a0b --date=short --no-merges --format='%ad %ae %s' 2018-07-30 fmalita@chromium.org [skottie] Parse animations on the fly in SkottieSrc::draw 2018-07-30 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 e452382a61a1..67c388e6c04e (1 commits) 2018-07-30 bsalomon@google.com Remove array of TextureSampler pointers from GrIOResourceProcessor. 2018-07-30 bsalomon@google.com Make GrTextureProxy store a GrTextureType. 2018-07-30 brianosman@google.com For TextureOp + Alpha texture, xform paint color to dest color space Created with: gclient setdep -r src/third_party/skia@9f7d4cd62a0b The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I243b938eed9d6b316911b26a93fc789e502a941c Reviewed-on: https://chromium-review.googlesource.com/1155606Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579220}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ife1784c580c2b4fb9e19f6a24fcd4111dc0e54e3 Reviewed-on: https://chromium-review.googlesource.com/1155791Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579219}
-
Dale Curtis authored
With the async API, MediaCodec will stop sending callbacks once an EOS buffer has been enqueued. Our MediaCodec based decoders give up their timer for the async API, so without these notifications we can end up in a hung state. This modifies CodecWrapper::output_buffer_release_cb to include the draining||drained state and then has MediaCodecVideoDecoder make an informed decision to elide the PumpCodec() if possible. BUG=868670 TEST=https://shaka-player-demo.appspot.com/demo/#asset=https://demo.unified-streaming.com/video/tears-of-steel/tears-of-steel.ism/.mpd;lang=en-US;build=compiled will hang for multiple seconds without patch between adaptations. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I442b3ecdeaa5e87c28002f3cf45a905d31fd6d2e Reviewed-on: https://chromium-review.googlesource.com/1155640Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#579218}
-
mrefaat authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I592ddf446add4654131d9f3c36ca339377ba164b Reviewed-on: https://chromium-review.googlesource.com/1085477 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
-
Sujie Zhu authored
Currently the structure of the payments_client and its save_delegate may cause competition between two save_delegates if we create one more save_delegate for the LocalCardSaveManager. We try to remove the Delegates in the payments_client and save the OnceCallback as part of the PaymentsRequest The informal design doc for this: https://docs.google.com/document/d/16YzsQEiFVJSwaE3AS91hSYJfnIE4b5e_iyGYvX02BBg/edit?usp=sharing Bug: 852904 Change-Id: Id83fdfd515ba5faab42a251a67da4cf3394ef05f Reviewed-on: https://chromium-review.googlesource.com/1148777 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#579216}
-
rajendrant authored
Crashes are observed in X86 Android with jellybean. So disabling those metrics until rootcause is analyzed. Bug: 865373 Change-Id: I4d72bf8fc47fd917091b8b8b4e0e4dee5dca662c Reviewed-on: https://chromium-review.googlesource.com/1155788Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#579215}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0f2c4fec1272..65f883bb7739 git log 0f2c4fec1272..65f883bb7739 --date=short --no-merges --format='%ad %ae %s' 2018-07-30 benjhayden@chromium.org Support bot aliases in Descriptor and ReportQuery. Created with: gclient setdep -r src/third_party/catapult@65f883bb7739 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I03a4bf76706b57118fb8cd422953f52615859e84 Reviewed-on: https://chromium-review.googlesource.com/1155611Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579214}
-
Reid Kleckner authored
This reverts commit 24c0d3d2. Reason for revert: Try the warning again after Clang r337706. Original change's description: > Disable -Wmemset-transposed-args when building with ToT clang > > This warning has a few false positives in ffmpeg. > > TBR=thakis@chromium.org > BUG=866202 > > Change-Id: I08634bdeabe6e30225d37941b078c540c21a74bc > Reviewed-on: https://chromium-review.googlesource.com/1145887 > Reviewed-by: Reid Kleckner <rnk@chromium.org> > Commit-Queue: Reid Kleckner <rnk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577055} TBR=thakis@chromium.org,rnk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 866202 Change-Id: I2d2dceca60f19b20554f96dea0c7d8bb2dc6792d Reviewed-on: https://chromium-review.googlesource.com/1155497Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#579213}
-
Wez authored
LeaveGroup() previously used ip_mreq, which does not allow the interface to which the operation applies to be specified by Id. Since no interface IP address is specified in the call, it fails if the network stack expects the interface to be explicitly specified (i.e. under Fuchsia). Bug: 864450 Change-Id: Idff67518387d80c6c91f96bfd774db4a11a310f8 Reviewed-on: https://chromium-review.googlesource.com/1152903Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#579212}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1bd66642c370..f452e3e5882f git log 1bd66642c370..f452e3e5882f --date=short --no-merges --format='%ad %ae %s' 2018-07-30 buildbot@webrtc.org Roll chromium_revision 2d5685c1..0e06bcbb (578940:579047) 2018-07-30 nisse@webrtc.org Delete unused RtpVideoStreamReceiver methods GetRemoteSsrc and GetCsrcs 2018-07-30 nisse@webrtc.org Convert webrtcvideoengine CVO tests away from cricket::VideoCapturer. Created with: gclient setdep -r src/third_party/webrtc@f452e3e5882f The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I108724d1d5caa3ce28ed4750074313b0ef2edd38 Reviewed-on: https://chromium-review.googlesource.com/1155604Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579211}
-
Tibor Goldschwendt authored
This means that the compiled Java of each DFM and the base module are optimized together in one proguarding step. The advantage is that symbols and symbol usages get obfuscated in the same way and, thus, usages still work even in the optimized state. To allow modularization, we split the optimized Jar into the modules after. Design doc: go/gn-aab-proguarding Bug: 862696 Change-Id: I0f6032b09b31a572838721e0b90b025ff879891d Reviewed-on: https://chromium-review.googlesource.com/1149040 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#579210}
-
rbpotter authored
Test that the preview hides when the user clicks print before the preview has loaded if the printer is local, and that the preview remains open until the preview loads if printing to PDF. Bug: 865544 Change-Id: I1fd89a565f65f4aa0c8115facc8817478896b141 Reviewed-on: https://chromium-review.googlesource.com/1153621 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Lily Houghton authored
This is a reland of 2ae89dce Original change's description: > Change ProxyResolutionService API to use std::unique_ptr<Request> instead of raw pointers. > > Bug: 479898 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I3d1b89fc33ebae27f6ab4007eceffb9eb6134ef6 > Reviewed-on: https://chromium-review.googlesource.com/887598 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578436} Bug: 479898 Change-Id: Id5684b743d27a0edf4d436beb113e37e32a70b89 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1152567 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Amy Qiu authored
Update recordings in tough_pinch_zoom_cases to current websites. Add login for sites that need it and replace non-existant websites with comparable ones. Bug: 852530 Change-Id: I2e02c1c0374ae8d9ba8f8cd32095172c827eeb7f Reviewed-on: https://chromium-review.googlesource.com/1153027Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Amy Qiu <amyqiu@google.com> Cr-Commit-Position: refs/heads/master@{#579207}
-
Antoine Labour authored
It's easy to post a task instead, which avoids the cross-thread lock whose usage is not fully consistent, and could also block. Bug: 866486 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I380a03351388a26a210f40c315f60b88d99591aa Reviewed-on: https://chromium-review.googlesource.com/1154140 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
-
Jun Choi authored
Currently, FIDO devices that sends any other protocols other than 'FIDO_2_0' or 'U2F_V2'in response to GetInfo command is rejected. This constraint needs to be fixed so that while devices that send duplicate or empty protocol list should be rejected, any protocols that the client does not know should be ignored. Change-Id: I0a574ada22d621e891c99d313eb19c3648144638 Reviewed-on: https://chromium-review.googlesource.com/1153620 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#579205}
-
Patrick Noland authored
Also adds token invalidation when we get a 401 and a test for header values being set correctly. Bug: 869132 Change-Id: I61f963bf17a89f58d10583c51eb5234daa263639 Reviewed-on: https://chromium-review.googlesource.com/1155717Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#579204}
-
Lu Chen authored
In this CL, metrics from the renderer process are processed in the browser. We extract document level metrics (e.g., number of links), as well as derived features (e.g., area rank). The calculated navigation scores (and other info) from onLoad are stored and can be looked up when an anchor element is clicked. Bug: 850624 Change-Id: I3a7516d3a991dc278441fb925822efa780a84b8d Reviewed-on: https://chromium-review.googlesource.com/1132680Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Lu Chen <chelu@chromium.org> Cr-Commit-Position: refs/heads/master@{#579203}
-
Emircan Uysaler authored
This CL adds functionality to convert webrtc::ColorSpace info into chromium's media::VideoColorSpace and sets it in remote video receiver. Bug: 867029 Change-Id: I175fcb6eb0f7918c510b7ff4f355aa300a89473c Reviewed-on: https://chromium-review.googlesource.com/1154030 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#579202}
-
Esmael El-Moslimany authored
Bug: 867193 Change-Id: I140d9b979ba7f58a3ab8e62142797caddd148f44 Reviewed-on: https://chromium-review.googlesource.com/1154195Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#579201}
-
Andrii Shyshkalov authored
It has been deprecated and is no longer required. R=jbudorick, mknyszek Bug: 866476 Change-Id: I78b348e6d9a9dcf078608f27853abdd9b6531df1 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/1155798Reviewed-by:
-
Rouslan Solomakhin authored
Bug: 869038 Change-Id: Ib22c53fb131acdf7ba887ca21171776663a0079d Reviewed-on: https://chromium-review.googlesource.com/1155100Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#579199}
-
Peter Wen authored
Add `--compile-sdk-version` flag to `generate_gradle.py` in order to allow Android Studio to find the right SDK source files. This is useful when our targetSdkVersion is on a new android version while the publicly available source code for that version is not yet available. Passing this flag with an older version number allows Android Studio to use that older version's SDK source code during editing. Bug: 620034 Change-Id: I85d3c2bb9db6d7a1f39182cc6a66d65009072c00 Reviewed-on: https://chromium-review.googlesource.com/1155482 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#579198}
-
Peter Kvitek authored
Change-Id: I56bb2d9930203b0a1668b6f00b9fdcd89fcf1e3e Reviewed-on: https://chromium-review.googlesource.com/1155745Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#579197}
-
