- 23 Aug, 2018 40 commits
-
-
Zhongyi Shi authored
No flag update. In QUIC, move TTL logic from QuicServerStream to QuicStream. Not protected. No functional change expected because the TTL interface is not used yet. Merge internal change: 209152580 https://chromium-review.googlesource.com/c/chromium/src/+/1185984 Reduce the size of some quic enum types to 1 byte, and change some int8_t enums to uint8_t. Not protected. Merge internal change: 209149404 https://chromium-review.googlesource.com/c/chromium/src/+/1185983 Store QuicStreamFrame inline within QuicFrame. Not flag protected. (Data structure layout change, hard to protect.) Merge internal change: 209007693 https://chromium-review.googlesource.com/c/chromium/src/+/1185978 Factor out the code for creating KeyExchange objects from QuicCryptoServerConfig::ParseConfigProtobuf into a KeyExchangeSource object which is passed into the QuicCryptoServerConfig's constructor. Merge internal change: 209002409 https://chromium-review.googlesource.com/c/chromium/src/+/1185917 Rollback of internal change 208339929. Merge internal change: 208974769 https://chromium-review.googlesource.com/c/chromium/src/+/1185870 Update stream flow controller on QuicStream::Read(). We are observing that our send window is not getting updated on reads. From the QuicStream::Read() comment and current usage in qbone, it looks like perhaps the Read method should call back to QuicStream::AddBytesConsumed(). Merge internal change: 208892429 https://chromium-review.googlesource.com/c/chromium/src/+/1185867 Enable version 99 testing in QUIC End to End tests Merge internal change: 208877810 https://chromium-review.googlesource.com/c/chromium/src/+/1185864 In QUIC, increase random bytes length to 20 bytes in IETF stateless reset packet. Protected by --quic_more_random_bytes_in_stateless_reset. Merge internal change: 208805996 https://chromium-review.googlesource.com/c/chromium/src/+/1185853 Use the async version of KeyExchange::CalculateSharedKeys in QuicCryptoServerConfig::ProcessClientHelloAfterGetProof(). Protected by --quic_use_async_key_exchange. Merge internal change: 208764362 https://chromium-review.googlesource.com/c/chromium/src/+/1185849 Split QuicCryptoServerConfig::ProcessClientHelloAfterGetProof() into ProcessClientHelloAfterGetProof and ProcessClientHelloAfterCalculateSharedKeys. Follow up CLs will use the async version of CalculateSharedKeys and will pass in ProcessClientHelloAfterCalculateSharedKeys as the callback. Merge internal change: 208762327 https://chromium-review.googlesource.com/c/chromium/src/+/1185846 Add a new async version of KeyExchange::CalculateSharedKey to allow the key exchange operation to be offloaded. Follow up CLs will enable this new codepath in QuicCryptoServerConfig::ProcessClientHelloAfterGetProof(). Merge internal change: 208760423 https://chromium-review.googlesource.com/c/chromium/src/+/1185842 Disable QUIC v35. Protected by --quic_disable_version_35. Merge internal change: 208714937 https://chromium-review.googlesource.com/c/chromium/src/+/1185782 Deprecate --gfe2_reloadable_flag_quic_disable_version_42. Also removes QUIC_VERSION_42 code. Merge internal change: 208698903 https://chromium-review.googlesource.com/c/chromium/src/+/1185739 Deprecate --gfe2_reloadable_flag_quic_disable_version_41_2. Also removes QUIC_VERSION_41 code. Merge internal change: 208668770 https://chromium-review.googlesource.com/c/chromium/src/+/1185528 Remove an unreachable QUIC_BUG_IF in QuicUnackedPacketMap. Not protected. Merge internal change: 208654236 https://chromium-review.googlesource.com/c/chromium/src/+/1185493 Deprecate --quic_use_static_stream_collection_in_write_blocked_list. Merge internal change: 208645294 https://chromium-review.googlesource.com/c/chromium/src/+/1185492 Deprecate --quic_add_to_blocked_list_if_writer_blocked. Merge internal change: 208644812 https://chromium-review.googlesource.com/c/chromium/src/+/1185488 In QuicConnection, notify debug_visitor after a connectivity probing packet is sent. Protected by --quic_notify_debug_visitor_on_connectivity_probing_sent. Merge internal change: 208530778 https://chromium-review.googlesource.com/c/chromium/src/+/1185407 Change-Id: I3bee166d54607a6297cb0c43f079ecdf96f5d0d1 Reviewed-on: https://chromium-review.googlesource.com/1185999 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#585529}
-
Tessa Nijssen authored
The following changes were made: - Store reference to monitor bounds - Rename variable to determine child menu position - Renamed anchor bounds - Renamed menu bounds - Removed Calls to gfx::Rect's origin Store Reference to Monitor Bounds state_.monitor_bounds -> monitor_bounds Renamed Variable to Determine Child Menu Position create_on_the_right -> create_on_right Also cleaned up initialization. Renamed Anchor Bounds owner_bounds -> anchor_bounds The variable is described as being the anchor bounds in a comment above its instantiation. Renamed Menu Bounds pref -> menu_bounds More descriptive name. Removed Calls to gfx::Rect's Origin origin().x() -> x() origin().y() -> y() Calls to x() and y() return the origin's x and y positions. Adding a call to the origin is unnecessary. Change-Id: I29d9b669d567b3d978da721c1b34b9399a1e8178 Reviewed-on: https://chromium-review.googlesource.com/1145544Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#585528}
-
Stephan Herhut authored
There is a mechanism that registers the size of the backing store of a typed array with v8 if such backing store is used by a typed array in a v8 isolate. This is done so that v8 can properly assess the memory pressure of an isolate in the presence of external allocations. With shared array buffers, we can no longer attribute a buffer to a specific isolate, as it might be used by multiple isolates at the same time. The current implementation tries to work around this by only registering with one isolate but ultimately fails at doing so, leading to false data. As a stop-gap fix, this change disables registering of shared buffers completely to at least keep the data consistent while we design a working solution. Change-Id: Ib007cbad6af80e6c82d6ab809bf14ce95c54fc93 Bug: chromium:877055 Reviewed-on: https://chromium-review.googlesource.com/1186461 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#585527}
-
John Abd-El-Malek authored
This way it can be used by tests inside content. Bug: 817187 Change-Id: If1a7c1470b738296f8d121a796f5b5b2492497d6 Reviewed-on: https://chromium-review.googlesource.com/1186028 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Perez authored
Add a function to convert the response from a test results request into a data frame for convenient access of the data. Also add corresponding unit tests. Bug: 875251 Change-Id: I396a5c209e37a470ab305edbee82ccc407472766 Reviewed-on: https://chromium-review.googlesource.com/1185184Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#585525}
-
Sammie Quon authored
Introduce swipe down gesture to homecher. This cl implements the design at: https://docs.google.com/document/d/1Bt5956kVDcgUz-_BTJc6M1wm5d03onBgJWE3vHQQGl0/edit# The design doc states to use a new ScopedClass but after a bit more thought I think that would be more difficult especially once animations are added. This should be behind a enabled by default flag, but I do not want to merge too much during code review, so I will add the flag shortly after this lands. Test: added tests Bug: 872319 Change-Id: Ibc2dd7344fb3cdb81967b0eefb41d58d377688a3 Reviewed-on: https://chromium-review.googlesource.com/1184326 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585524}
-
Dan Harrington authored
- Improve the style of the content: style more closely approximates the suggestions on the NTP. This is still a placeholder UI until we receive the UI spec. - Pressing on content will open it up. - Add 'show all' option. Pressing on it opens the download manager. Bug: 852872 Change-Id: I1d5b93420b88e5a947baac418ca372475b1155cc Reviewed-on: https://chromium-review.googlesource.com/1164177 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Edward Jung <edwardjung@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#585523}
-
Elly Fong-Jones authored
On Mac, VKEY_APPS is actually the right command key, which is not supposed to behave this way in menus. Bug: 875559 Change-Id: I78329273f4ddd5c5cd9aed89669d46f722de118b Reviewed-on: https://chromium-review.googlesource.com/1186705Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#585522}
-
Kevin McNee authored
In the guest view js implementation, setupAttributes and getApiMethods both form circular dependencies. Bug: 793935 Change-Id: I1118e03daea247e3ea670b6bee3788ba9558d779 Reviewed-on: https://chromium-review.googlesource.com/1177841Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#585521}
-
Ben Pastene authored
This reverts commit 80a5f1d8. Reason for revert: outage over Original change's description: > Demote android-kitkat-arm-rel to 100% CQ experiment. > > It's not doing well. > https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel?limit=200 > > Fortunately, the M bot is ok: > https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel?limit=200 > > NOTRY=true > > Bug: 876539 > Change-Id: Icb9770bf0df60fe28ad92dfabeb0c5c8f14f30af > Reviewed-on: https://chromium-review.googlesource.com/1185229 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585029} TBR=dpranke@chromium.org,bpastene@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 876539 Change-Id: I3f137fb209f0decfc13be5dab518e9e644e98b8c Reviewed-on: https://chromium-review.googlesource.com/1187084Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#585520}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9259fd0d4f4c..c40974417610 git log 9259fd0d4f4c..c40974417610 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 syoussefi@google.com Fix x64 visual studio build errors Created with: gclient setdep -r src/third_party/angle@c40974417610 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I88df068b59390a601bf40fa81532ca33c3bc1ab6 Reviewed-on: https://chromium-review.googlesource.com/1186551Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585519}
-
braveyao authored
IOSurfaceCapturer has been enabled 100% everywhere. So remove the related field trial testing config. Bug: 840597 Change-Id: I3d79b5f734c86ec5197527e7c7736c0233dcff71 Reviewed-on: https://chromium-review.googlesource.com/1185526Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#585518}
-
Eugene But authored
Added the following tests: - testAccessibilityOnNotStartedDownloadToolbar - testAccessibilityOnCompletedDownloadToolbar Bug: 854232 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2c49197f02881548cdae817a9753798507ddfc3b Reviewed-on: https://chromium-review.googlesource.com/1184323Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#585517}
-
Bailey Berro authored
This change enforces the NetBiosShareDiscoveryEnabled policy. If enforced, no NetBios discovery will be set up or performed when by the SmbService. Bug: 757625 Change-Id: I8bcd8d049dc597db208f9c38fae5a17b8069dd28 Reviewed-on: https://chromium-review.googlesource.com/1185405 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#585516}
-
Rayan Kanso authored
This was causing callbacks (like GetVisualsForItem) to be lost since the ContentID namespace did not match the registered OfflineContentProvider namespace. Change-Id: I009cbd2c38ac8d91c8c1efcd302be725c6588463 Reviewed-on: https://chromium-review.googlesource.com/1186734Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#585515}
-
Ted Choc authored
All committers should have the ability to modify strings. BUG=876369 Change-Id: Ie2d456de05bb6da79b802a408c19ad3d657db187 Reviewed-on: https://chromium-review.googlesource.com/1187007Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#585514}
-
Boris Sazonov authored
This CL performs several minor cleanups in SyncAndServicesPreferences without any changes to the behavior: 1. Reorder constants, fields and calls to have a consistent order for preferences. 2. Consistently use PREF_ prefix for preference keys. 3. Use mSync prefix for preferences that control sync data types. 4. Rename mSyncOmnibox to mSyncHistory to match the title string. 5. Replace onPreferenceClick and if chain with separate listener objects. Bug: 814728 Change-Id: I60fda93757fa160e7c70b98925486332880c92d5 Reviewed-on: https://chromium-review.googlesource.com/1185200Reviewed-by:
-
David Benjamin authored
We have not worked on this code for years. Others have more context around it these days. Bug: none Change-Id: I95c258b08b6e25c359b3b7faa6bfa91cede95350 Reviewed-on: https://chromium-review.googlesource.com/1186981 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#585512}
-
khmel@google.com authored
This resolves races in this test. TEST=Passes ~10000 iteration, no failure reported (before ~5%) BUG=874538 Change-Id: I4d098ebc9a3bb76af3d640a0336716a9b570a2a3 Reviewed-on: https://chromium-review.googlesource.com/1186548 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
-
Guido Urdaneta authored
This reverts commit 68e23978. Reason for revert: As expected, this revert had nothing to do with the WebRTC bot failures. Original change's description: > Revert "[NTP] Clear attribution on the existing tab when apply a theme" > > This reverts commit a9ed1fd3. > > Reason for revert: Speculative revert since two WebRTC bots started failing reliably after this CL. > If the revert does not fix the bots (which I think is likely), we will reland it. > > Original change's description: > > [NTP] Clear attribution on the existing tab when apply a theme > > > > Now we will clear the attribution also on the existing tab when a theme > > is applied. > > > > Bug: 875519 > > Change-Id: I65e8a0dc1ed3492c512cabcf1a2d3f0e6f2e64f7 > > Reviewed-on: https://chromium-review.googlesource.com/1181684 > > Commit-Queue: Weilun Shi <sweilun@chromium.org> > > Reviewed-by: Kristi Park <kristipark@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#584964} > > TBR=kristipark@chromium.org,ramyan@chromium.org,kmilka@chromium.org,sweilun@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 875519 > Change-Id: I20ff372903d2abee0620d42e9cff18777515ac65 > Reviewed-on: https://chromium-review.googlesource.com/1186762 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585499} TBR=guidou@chromium.org,kristipark@chromium.org,ramyan@chromium.org,kmilka@chromium.org,sweilun@chromium.org Change-Id: Ie612910fe42f3ce69fb87186ab3a4b5bc1331afc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875519 Reviewed-on: https://chromium-review.googlesource.com/1186802Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#585510}
-
Aleks Totic authored
Bug: 591099 Change-Id: I714827fa06e19ae0b3067ba864ff26f182e07e3c Reviewed-on: https://chromium-review.googlesource.com/1185970Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#585509}
-
gogerald authored
This CL also removes a redundant interface and moved the interface around. Bug: 839130 Change-Id: I5a684dd0319302ed9a0cda95f02ee6f9401be835 Reviewed-on: https://chromium-review.googlesource.com/1185876Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#585508}
-
David Benjamin authored
I was added as backup OWNER before net/OWNERS as here. Now that net/OWNERS is here, remove explicit reference to myself, so this is spread between all net/OWNERS. Bug: none Change-Id: Id27d6b73e24708fa0eb9c903621f9d40c7d20956 Reviewed-on: https://chromium-review.googlesource.com/1186983Reviewed-by:
-
Sam Maier authored
This is a reland of be62a5ba Original change's description: > Android: removing default execute() on AsyncTask > > execute() is a confusing function, with a hidden implicit meaning that > changed in API 11. It would be better if everyone had to use the more > explicit executeOnExecutor() so their preference (serial or thread pool) > is called out. > > Bug: 869907 > Change-Id: I79be6d2b3114cb0520df1104ec5849f7c070c99e > Reviewed-on: https://chromium-review.googlesource.com/1172446 > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584189} TBR=smaier@ reland now that fix is in https://chromium-review.googlesource.com/c/chromium/src/+/1172446 Bug: 869907 Change-Id: I90613192c8655ee08dba939785c79e4aa254c08c Reviewed-on: https://chromium-review.googlesource.com/1181803 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#585506}
-
Maxim Kolosovskiy authored
If the password generation element is in <iframe>, the popup is shown at wrong position (see the bug). Autofill popups (a list of saved credentials) worked fine. The bounds of the element is changed in two steps: a) apply TransformToRootCoordinates from chrome_password_manager_client.cc b) add web_contents()->GetContainerBounds().OffsetFromOrigin() which is an equivalent of GetBoundsInScreenSpace from chrome_password_manager_client.cc. For generation popups, only TransformToRootCoordinates was applied. This CL adds the second step. Bug: 877049 Change-Id: Ic96b1c454dc245055c641b7fc4ad4b69d5c285dd Reviewed-on: https://chromium-review.googlesource.com/1186736 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#585505}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/31629a8a3271..9db44ed0ef7f git log 31629a8a3271..9db44ed0ef7f --date=short --no-merges --format='%ad %ae %s' 2018-08-23 halcanary@google.com bin/droid script: fix wierd mkdir error on my device 2018-08-23 bsalomon@google.com Revert "Fix leak in SkSLParser" 2018-08-23 bsalomon@google.com Fix leak in SkSLParser 2018-08-23 egdaniel@google.com Revert "Add GPU-side caching of mask-filtered path masks" 2018-08-23 fmalita@chromium.org [skottie] Plumb external SkFontMgr 2018-08-23 borenet@google.com [infra] Speculative fix for cq.cfg 2018-08-23 robertphillips@google.com Add GPU-side caching of mask-filtered path masks Created with: gclient setdep -r src/third_party/skia@9db44ed0ef7f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I2cbb2524eafe25d1acf017b7ae0c1ad25963e0c7 Reviewed-on: https://chromium-review.googlesource.com/1186665Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585504}
-
Calder Kitagawa authored
Phase 3 of the work to replace url_template with action and params as per the updated WebShareTarget spec: https://wicg.github.io/web-share-target/. This work updates WebAPKs to use the new action and parameter model rather than |url_template|. See the bug for a detailed plan for performing these changes. Bug: 871788 Change-Id: I17ea1f7cb0fa5b6bef0e1ad1cf90434f0bacb60f Reviewed-on: https://chromium-review.googlesource.com/1171587 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#585503}
-
Paul Meyer authored
Bug: 872771 Change-Id: Ia3732f5112be42bdb517bee5b47855fcf2e24d8a TBR: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1169591 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#585502}
-
Pavel Yatsuk authored
Specifics: +618,790 bytes normalized apk size +3 zip entries file count +41,588 bytes main lib size +391,432 bytes main dex size InstallSize: +230,268 bytes APK size +1,811,653.28 bytes Estimated installed size InstallBreakdown (+1,809,693.28 bytes): +2,910 bytes unwind_cfi (dev and canary only) size +1,568 bytes Non-compiled Android resources size +41,588 bytes Native code size +164 bytes Package metadata size +1,748,939.28 bytes Java code size +14,524 bytes Compiled Android resources size Dex: +1,948 entries fields +2,665 entries methods +633 entries types +1,320 entries strings R=fgorski@chromium.org Change-Id: I024c2f4c193059fc9b93d75d4f756ed1de076dd2 Reviewed-on: https://chromium-review.googlesource.com/1185844 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#585501}
-
Theresa authored
BUG=871802 Change-Id: Ia96c4bd872ba9d0e2e7529b5b27b91d8b8ffbc7e Reviewed-on: https://chromium-review.googlesource.com/1185891Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#585500}
-
Guido Urdaneta authored
This reverts commit a9ed1fd3. Reason for revert: Speculative revert since two WebRTC bots started failing reliably after this CL. If the revert does not fix the bots (which I think is likely), we will reland it. Original change's description: > [NTP] Clear attribution on the existing tab when apply a theme > > Now we will clear the attribution also on the existing tab when a theme > is applied. > > Bug: 875519 > Change-Id: I65e8a0dc1ed3492c512cabcf1a2d3f0e6f2e64f7 > Reviewed-on: https://chromium-review.googlesource.com/1181684 > Commit-Queue: Weilun Shi <sweilun@chromium.org> > Reviewed-by: Kristi Park <kristipark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584964} TBR=kristipark@chromium.org,ramyan@chromium.org,kmilka@chromium.org,sweilun@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 875519 Change-Id: I20ff372903d2abee0620d42e9cff18777515ac65 Reviewed-on: https://chromium-review.googlesource.com/1186762Reviewed-by:
-
Lukasz Anforowicz authored
This CL exposes content::GlobalFrameRoutingId and GlobalRoutingID via //content/public/browser API and uses it where appropriate instead of std::pair<int, int>. This CL also opportunistically fixes some other minor issues: - IWYU problems reported by |git cl lint| - Presubmit issues (e.g. using base::Callback instead of OnceCallback) This CL is intended to be pure refactoring - no intended behavior change. Bug: 834185 Change-Id: I39daff220c8a7da19114d28a1ea9ca8e24cc93fe Reviewed-on: https://chromium-review.googlesource.com/1184150Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#585498}
-
Troy Hildebrandt authored
In preparation for a single shared database for browser features, additional parameters have been added to LoadWithFilter to allow only specific entries to be loaded instead of the entire database. Some minor modifications to FakeDB are made to ensure tests still build and run. Bug: 870813 Change-Id: I802331d477ec0ed2d6821c6d937cb2d497560345 Reviewed-on: https://chromium-review.googlesource.com/1169874 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#585497}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2229a8947448..a7fb87b3a3d1 git log 2229a8947448..a7fb87b3a3d1 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 nednguyen@google.com Wrap all exception of websocket with telemetry's exception.Error for recoverability Created with: gclient setdep -r src/third_party/catapult@a7fb87b3a3d1 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:876681,chromium:877074 TBR=sullivan@chromium.org Change-Id: I71fcf38964d1c2bde5afaea5d789314b35724b0e Reviewed-on: https://chromium-review.googlesource.com/1186664Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585496}
-
Rayan Kanso authored
Starting a request / storing a response don't propagate errors to the job controller. This is why we should check whether we got all of the request/response pairs before deciding what sort of event to dispatch. Change-Id: Ie3c89ab92a7b843220b8f3b1201f527f895faf77 Reviewed-on: https://chromium-review.googlesource.com/1181576 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
-
Victor Costan authored
Change-Id: I03d1e0ba27eae87f73862027b52d3d46aff09179 Reviewed-on: https://chromium-review.googlesource.com/1185785 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#585494}
-
chaopeng authored
This test switches a <frameset> to a <body>. For framesets, LayoutView::CalculateScrollbarModes forces the user scrollable bit to be false. So, we need to make sure to call LayoutView::SetNeedsPaintPropertyUpdate when the LayoutView's child changes to/from a frameset. Bug: 875287 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5ae0a7673ae8e325242465633749ffcd76ca705f Reviewed-on: https://chromium-review.googlesource.com/1186181Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#585493}
-
Tim Schumann authored
Change the sync Wallet integration tests to simulate a more realistic server behavior. In particular, provide a realistic version number, GC directives, no client defined unique tags, and non-incremental updates. Wallet data cannot be served by the loopback server (which only supports incremental updates) and shouldn't as that server is used for local sync. Instead, this functionality is added to the FakeServer. Worth noting: Adding time-based values to the progress marker (gc directive's version_watermark) required changes in the way how integration tests verify two clients are in an equal sync-state. Before this was done by comparing the complete progress markers. Verified that when enabling USS for autofill wallet data, the incorrect behavior of dropping cards without a client tag is exercised. Bug: 876308 Change-Id: I9fc8929a508ce5fb62df79a1acf62c65ff98d0fe Reviewed-on: https://chromium-review.googlesource.com/1184821 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#585492}
-
Mason Freed authored
This continues the work done in https://chromium-review.googlesource.com/c/chromium/src/+/1171144, this time expanding the set of folders considered for replacement, and the scope of the replacements. With this CL, I believe I have replaced most references to Style() with StyleRef() within these folders: - paint - layout - svg - frame Note that I only replaced immediate uses of Style(), i.e. Style()->Xyz. These are guaranteed not to cause any breakage (assuming I did the replacement well) because they already dereferenced the pointer. There are many references to Style() where the result is first checked, or where the actual pointer is passed around, and I have not touched those (yet). Perhaps for a later CL. I have also consciously not modified code in other folders (including animation, css, dom, editing, exported, html, input, layout/ng, page, and style). The reason I skipped these is that, at least for now, I am not sure that Style can always safely be assumed to be available (non-null). There are definitely cases where that can be inferred, but I didn't want to change some references in a folder and not others. Perhaps for a later CL. Bug: 872508 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie2293901477ef3ed8912582d206bdaac8fd000e1 Reviewed-on: https://chromium-review.googlesource.com/1182185 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#585491}
-
Doug Arnett authored
This is in conjunction with launching NoScript Preview to Stable channel via Finch. Bug: 876778 Change-Id: Ibc5f559b4c4b36555fc04966c8c44a4cccdb381d Reviewed-on: https://chromium-review.googlesource.com/1185369 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#585490}
-
