GitLab

This CL moves the search provider check into the function which
determines how to display hotwording. Prior to this, it was only being
updated when the search provider was changed and other javascript could
come along and re-show the hotword section (even though it was now
supposed to be hidden). Now every time the hotwording should be
displayed, the search provider is checked beforehand. This is the
logically correct way to do it.

BUG=442938

Review URL: https://codereview.chromium.org/815683003

Cr-Commit-Position: refs/heads/master@{#309522}

BUG=426119, 437750

Review URL: https://codereview.chromium.org/787023002

Cr-Commit-Position: refs/heads/master@{#309521}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/818033004

Cr-Commit-Position: refs/heads/master@{#309520}

Revert of Clean up Smart Lock cryptohome keys logic: (patchset #5 id:80001 of https://codereview.chromium.org/808563004/)

Reason for revert:
Once this change landed chromeos file manager tests started failing across the MSAN bots.

This is the most likely culprit, so reverting speculatively. If this does not help will reland this change.

See http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Browser%20%282%29/builds/139

Original issue's description:
> Clean up Smart Lock cryptohome keys logic:
>
> 1. Queue all cryptohome keys operations.
> 2. Roll ClearRemoteDevices as a specific case of SetRemoteDevices
> 3. Introduce new RefreshKeys operation using the existing add and remove keys
>    operations to replace the current cryptohome keys with new keys.
> 4. After reauthenticating for setup, remove the old cryptohome keys.
>
> BUG=432996
>
> Committed: https://crrev.com/275152c34d8edc5346757288cfffe63444650faa
> Cr-Commit-Position: refs/heads/master@{#309094}

TBR=tbarzic@chromium.org,xiyuan@chromium.org,tengs@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=432996

Review URL: https://codereview.chromium.org/789793005

Cr-Commit-Position: refs/heads/master@{#309519}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/824683003

Cr-Commit-Position: refs/heads/master@{#309518}

Removed the permission message generating code that was duplicated
across SocketPermission and SocketManifestPermission and combined it
into a single static function in SocketManifestPermission.

Based on crrev.com/795543002.

BUG=398257

Review URL: https://codereview.chromium.org/794063002

Cr-Commit-Position: refs/heads/master@{#309517}

If the user updates the pref (e.g., via chrome://settings) then they
presumably already know about always on hotwording so there's no reason to
annoy them with a notification. This CL adds a pref registrar observer
to the always on pref and when it's changed, marks the notification as seen
and then removes the observer.

This will only work for new users since once they have the always on pref,
this observer will get hit on switching between profiles, but presumably
once they have the always on pref, it means they enabled it or disabled it
at some point.

BUG=443805

Review URL: https://codereview.chromium.org/815223003

Cr-Commit-Position: refs/heads/master@{#309516}

Made possible by the new Tuple implementation.
No intended behavior change.

BUG=440675

Review URL: https://codereview.chromium.org/818123002

Cr-Commit-Position: refs/heads/master@{#309515}

Also copy a few helper functions from extension_function_test_utils.h to
api_test_utils.h so we don't need to depend on chrome/. These helper
functions are needed by tests other than the display test and will help with
the migration.

BUG=392842

Review URL: https://codereview.chromium.org/779083002

Cr-Commit-Position: refs/heads/master@{#309514}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463
TBR=rogerta@chromoium.org

Review URL: https://codereview.chromium.org/802413003

Cr-Commit-Position: refs/heads/master@{#309513}

This adds PostMessage support for MimeHandlerView allow sites that embed extension mime handlers to communicate with them.

BUG=415858

Review URL: https://codereview.chromium.org/729333002

Cr-Commit-Position: refs/heads/master@{#309512}

Another of these tests is now failing.

TBR=ckehoe@chromium.org
NOTRY=true
BUG=444516

Review URL: https://codereview.chromium.org/826433002

Cr-Commit-Position: refs/heads/master@{#309511}

ui_java target was ported in
https://chromium.googlesource.com/chromium/src/+/26046b5fe46738a9c214a64862831e9417f27850
by cjhopman.

This patch was tested with the following command lines:

$ out/Debug/gn gen out_gn/Debug/ --args='os="android" cpu_arch="arm"'

$ ninja -C out_gn/Debug/ ui/base

BUG=None
TEST=see above
TBR=sky@chromium.org,brettw@chromium.org

Review URL: https://codereview.chromium.org/819233002

Cr-Commit-Position: refs/heads/master@{#309510}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d582cab..16c8f14

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/819963002

Cr-Commit-Position: refs/heads/master@{#309509}

When '<' and '>' Android keyboard generates KEYCODE_SHIFT_LEFT followed by
KEYCODE_COMMA or KEYCODE_PERIOD. Android client sends shift event as a key
event and then the actual character is sent as a text event. As result
when the input injector tries to inject text event shift key is pressed
and as result injected keys are not interpreted correctly. Fixed input
injector to release all keys before trying to inject text events.

BUG=407463

Review URL: https://codereview.chromium.org/806223008

Cr-Commit-Position: refs/heads/master@{#309508}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/55af1ae..be75b55

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/809323004

Cr-Commit-Position: refs/heads/master@{#309507}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/817413002

Cr-Commit-Position: refs/heads/master@{#309506}

nullptr is one of the C++11 allowed features. See https://chromium-cpp.appspot.com/ and https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/4mijeJHzxLg.

This patch was generated with the following command lines:

$ ninja -C out/Debug -t compdb cxx > out/Debug/compile_commands.json
$ cd out/Debug
$ find ../../tools/gn -name '*.cc'  | xargs -n 16 -P 32 \
~/src/repos/llvm/build/bin/clang-modernize -use-nullptr -p . -include \
tools/gn -format -style=Chromium
$ ninja gn gn_unittests

BUG=None
TEST=compiles + gn_unittests
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/798333005

Cr-Commit-Position: refs/heads/master@{#309505}

One tile memory takes 160 bytes currently.
This patch can reduce the tile memory by removing unnecessary
variables and packing the booleans to 144 bytes.

BUG=341919

Review URL: https://codereview.chromium.org/810713002

Cr-Commit-Position: refs/heads/master@{#309504}

New metrics to record when cast_shell makes an initial paint for a
webpage.

R=gunsch@chromium.org
BUG=

Review URL: https://codereview.chromium.org/819213002

Cr-Commit-Position: refs/heads/master@{#309503}

Covers jingle/, media/, ppapi/, remoting/, rlz/, skia/, and sync/.

BUG=422426
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/819203002

Cr-Commit-Position: refs/heads/master@{#309502}

The GN version 'gn_unittests' target has template_unittest.cc in its
source list, but the GYP version not. This patch fixes that making them
match.

BUG=None
TEST=gn_unittests --gtest_filter=Template*
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/825543002

Cr-Commit-Position: refs/heads/master@{#309501}

It must be some leftovers from another CL.

Cleaning this up makes code reviews in gpu/command_buffer much easier.

BUG=
TEST=gpu_unittests
R=kbr@chromium.org
TBR=jamesr@chromium.org,bajones@chromium.org

Review URL: https://codereview.chromium.org/799143003

Cr-Commit-Position: refs/heads/master@{#309500}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/823663003

Cr-Commit-Position: refs/heads/master@{#309499}

Fix data reduction proxy browser tests to check that
dataReductionUpdateDailyLengths is reset after date lengths are updated.

BUG=384394

Review URL: https://codereview.chromium.org/823703002

Cr-Commit-Position: refs/heads/master@{#309498}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/823713002

Cr-Commit-Position: refs/heads/master@{#309497}

Covers content/.

BUG=422426
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/803813003

Cr-Commit-Position: refs/heads/master@{#309496}

This patch prepares sync codebase for supporting datatypes with
implicit permanent forlders by introducing an empty/unset
syncable ID.
There was a notion of Null ID before but it was equivalent
to the root ID which caused some confusion in the code - a Null
ID would sometimes be used where a "root" would be appropriate
and vice versa.
See the following code fragment for an example:
// TODO(sync): We could use null here, but to ease conversion we use "r".
// fix this, this is madness :)
inline bool IsNull() const {
  return IsRoot();
}

This change will be followed by one or two separate changes
that will actually remove dependencies on PARENT_ID and
SERVER_PARENT_ID and use a different way to organize nodes
in the directory based on node's datatype rather than parent ID.

This change impacts the following:
1) The default ID value in EntryKernel ID fields and elsewhere is
Null ID and not Root ID as it used to be.
2) This means that some tests that depended on Root ID being
set implicitly
in PARENT_ID and SERVER_PARENT_ID now need to set these IDs explicitly.
3) Node's GetPredecessorId, GetSuccessorId, and GetFirstChildId
methods now return a null ID rather than a root ID when there
is no predecessor, successor, or children.
4) Small changed throughout the code to make sure that
null IDs and root IDs are used accordingly (now that they
are no longer equivalent).
5) Changed some validation methods to accept Null IDs
to avoid large changes in the test code.

BUG=438313

Review URL: https://codereview.chromium.org/805633004

Cr-Commit-Position: refs/heads/master@{#309495}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/825523002

Cr-Commit-Position: refs/heads/master@{#309494}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/818113002

Cr-Commit-Position: refs/heads/master@{#309493}

The CMA code is not linked in for Android builds.

R=erickung@chromium.org
TBR=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/821793002

Cr-Commit-Position: refs/heads/master@{#309492}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6e7a766..55af1ae

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/824803002

Cr-Commit-Position: refs/heads/master@{#309491}

Covers courgette/, dbus/, device/, extensions/, gin/, google_apis/, and gpu/.

BUG=422426
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/819193002

Cr-Commit-Position: refs/heads/master@{#309490}

This is based on Nat's patch: https://codereview.chromium.org/441873007/

Move timeline and importers to use telemetry.timeline.TraceData

This (admittedly massive) patch actually gives us an ubertrace object: the
TraceData. The key way to understand this CL is to read timeline/trace_data.py file,
then read importer.py. The rest is cosmetic fallout from the signature changes.

A TraceData contains the data from many tracers, and is always serializable. A
TimelineModel is constructed from a single TraceData. Internally, a
TraceData is an in memory version of json of the following form:
  { traceEvents: ...
    inspectorTimelineEvnets: ...
    tabIds: ...
  }

Since a TraceData has all the tracer data, the model and importer system was
updated so that instead of there being 1 importer per value, the importers
instead indicate which part of the TraceData they can handle, if any.

BUG=356763

Review URL: https://codereview.chromium.org/805463002

Cr-Commit-Position: refs/heads/master@{#309489}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463#

Review URL: https://codereview.chromium.org/825503002

Cr-Commit-Position: refs/heads/master@{#309488}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/795043004

Cr-Commit-Position: refs/heads/master@{#309487}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/823733002

Cr-Commit-Position: refs/heads/master@{#309486}

Covers chrome/browser/* from f on.

BUG=422426
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/816403003

Cr-Commit-Position: refs/heads/master@{#309485}

This CL makes Widget::RunShellDrag() and DesktopDragDropClientWin not crash if
the browser window is deleted during a drag-drop operation. An extension can
delete the browser window during the drag-drop operation.

BUG=440534
TEST=BookmarkBarViewTest22.*
R=pkasting
TBR=sky (The files in ui/views/widget are identical to the original CL)

Review URL: https://codereview.chromium.org/819793002

Cr-Commit-Position: refs/heads/master@{#309484}

Review URL: https://codereview.chromium.org/818033005

Cr-Commit-Position: refs/heads/master@{#309483}