- 04 Mar, 2020 40 commits
-
-
Chih-Hsuan Kuo authored
Bug=1054761 Test=build and pass CQ Merge-With: eureka-internal/367058 Change-Id: I64e33d87398eab09704ea63b6eaf8e3922e3f98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066397 Commit-Queue: Chih-Hsuan Kuo <chkuo@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#746695}
-
Omer Katz authored
All known data races in HashTable based collections have been resolved. Bug: 986235 Change-Id: Ia7a22d707aaaea1ab3ebc70c47da0876fc426aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078617Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746694}
-
Andy Paicu authored
Change-Id: I23074a6dbc88cc10aa5b6067377fd73d67e6b739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087051 Auto-Submit: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#746693}
-
Matthew Mourgos authored
This change adds an accessibility page that can be shown by clicking a link on the marketing opt in screen. The link to show the accessibility screen is only shown if the user was shown the gesture navigation screen before getting to the marketing opt in screen. The accessibility page contains a toggle for changing the kAccessibilityTabletModeShelfNavigationButtonsEnabled pref. Bug: 976949 Change-Id: Ibbb1568389b86cd336d8c4b65fe275ca2b256ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078740 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#746692}
-
Alan Cutter authored
This CL updates the web app manifest update checker to check the contents of icons specified in the latest manifest for differences against the locally installed icons. If there are any differences it will trigger the web app to update with the latest manifest data. Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=435726&signed_aid=__Gv5ahpYIVLkTCEKEXscA==&inline=1 Bug: 926083 Change-Id: If5d0229b41931cad305a164e420ba4b917df02d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072344 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#746691}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/779e58d10e2f..2fdaf67e5529 Created with: gclient setdep -r src-internal@2fdaf67e5529 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I3943626768e6b54a6eade1741c074795787c980a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086190Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746690}
-
Josh Simmons authored
Multiple places in the code check for Quick View being open after performing a series of actions that should open it. These have been refactored in a single helper function. Bug: 1058289 Change-Id: I8a55d141895395637d6679fe7ad22df3c50baf7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086469 Commit-Queue: Josh Simmons <simmonsjosh@google.com> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#746689}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/57b83355c515..a40862f237fc git log 57b83355c515..a40862f237fc --date=short --first-parent --format='%ad %ae %s' 2020-03-03 nigi@chromium.org Remove the prefix in BaseFont when trying to find a substitute font. 2020-02-29 nigi@chromium.org Enable RenderManyRectanglesWithExternalMemory for SkiaPaths/Skia. 2020-02-28 thestig@chromium.org Add dsymutil to DEPS for Mac builds. Created with: gclient setdep -r src/third_party/pdfium@a40862f237fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I2cace5a1262f00b82c47cc2429e6170930bb43fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086953Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746688}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/64a3f8fcb749..c6d0fdfb4098 git log 64a3f8fcb749..c6d0fdfb4098 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-03-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 13184a2d..2f96e324 (443 commits) 2020-03-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b84969ad69c3..9e9493f29dbf (7 commits) 2020-03-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 176f3a3dbbc9..126720bd2e57 (2 commits) Created with: gclient setdep -r src/third_party/skia@c6d0fdfb4098 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: Ie3f871db69e66b34785230212e10480a1afd3c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086951Reviewed-by:
-
Alan Cutter authored
This CL fixes the theme service to be able to toggle native increased contrast support. We were not considering IncreasedContrastThemeSupplier as a default theme and were not removing it when native increased contrast was disabled. Bug: 1056335 Change-Id: I42b59e58912de8224b3d7d4e84fb355cd7851dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078376 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#746686}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f6edc90900fe..bbd4f3e6052c git log f6edc90900fe..bbd4f3e6052c --date=short --first-parent --format='%ad %ae %s' 2020-03-04 dberris@chromium.org Pinpoint: Add logging to results2 generation Created with: gclient setdep -r src/third_party/catapult@bbd4f3e6052c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050740 Tbr: skyostil@google.com Change-Id: I29ede5d35c19b58cfff0fe76dfe0c753353590d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086952Reviewed-by:
-
Eric Willigers authored
All tests using SystemWebAppIntegrationTest are now parameterized, and run with both bookmark and web app backend implementations. Bug: 1058274 Change-Id: Iffd8f1bf1242bab126de70d36fb4683981915ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086461Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#746684}
-
Eric Willigers authored
The test suite SystemWebAppManagerBrowserTest is now parameterized, and runs with both bookmark and web app backend implementations. Not yet updated: SystemWebAppManagerAdditionalSearchTermsTest.AdditionalSearchTerms and SystemWebAppManagerNotShownInLauncherTest.NotShownInLauncher currently fails with web apps. Tracked in crbug.com/1054195 In system_web_app_manager_browsertest.cc, helper methods EvalJs and ExecJs are retired as they have no clients. TBR=pkasting@chromium.org Bug: 1054195 Change-Id: Ib76ed1e2b14f42bf81138c61f5c263652dbe1ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086355 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
The directory structure before: <ProfileDir> WebApps Sync Data LevelDB Temp <temp_name> <app_id> Web Applications _crx_<app_id> After: <ProfileDir> Web Applications _crx_<app_id> Sync Data LevelDB Temp <temp_name> Manifest Resources <app_id> This is breaking change, all local BMO profile icons will be clean. We should land it now to avoid file migrations in the future. Note: "Sync Data/LevelDB" directory is created only if kDesktopPWAsSharedStoreService feature is off. We use shared <ProfileDir>/Sync Data/LevelDB/ otherwise. This code is disabled behind kDesktopPWAsWithoutExtensions feature. It introduces no behavior changes. Bug: 877898 Change-Id: I96af88386f3ce6031881d713b330eff2e32f33e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084215 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#746682}
-
Luciano Pacheco authored
Bug: 992822 Change-Id: I0a5cbd7f2233a9079065fe9d85dffe4b39462007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086352 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/18eac1a4..56ff573a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iec678ba39cecd98fee1cf96603d78d1afcdffd31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086880Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746680}
-
Tal Pressman authored
Bug: 1049056 Change-Id: I45bfba484c6d8c99190568a5965a33e996c37bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078520Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#746679}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/40dd59329abe..f92fd4849f47 git log 40dd59329abe..f92fd4849f47 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 szuend@chromium.org [utilities] Use Map instead of Array in TestFileSystem.Entry Created with: gclient setdep -r src/third_party/devtools-frontend/src@f92fd4849f47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1de31644754ce6983612c47cdc1f736b3f7fe3f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086189Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Example failed run: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/16572 TBR=altimin@chromium.org Bug: 1054194 Change-Id: I955aa5674f3b5896b5360d1b9be6d450820f4b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086383Reviewed-by:
-
Regan Hsu authored
When the user switches the radio button from "PIN" to "PASSWORD" back to "PIN" quickly, the "PASSWORD" button is re-selected on it's own. In the brief moment that that "PIN" is selected, the button on the RHS, which should be labeled as "Set up Pin" is "Change Pin". In order to prevent the radio button from toggling from "PIN" back to "Password" on its own (without user action), the selectedUnlockType is checked again after active lockscreen preferences are changed asynchronously. Replacing "hidden" with a dom-if template shortens the delay of "Set up PIN" and "Change PIN" in a noticeable way, but it doesn't resolve the fact that "incorrect strings may be shown for a brief period, and updating them causes UI flicker" [1]. This still happens from time to time, and is not consistent. [1] https://tinyurl.com/vdxo262 In order to reduce UI flicker, which is unavoidable in instances of failure (fail to change from PIN to password), the "Set up PIN" and "Change PIN" button is modified to change immediately on user action to the intended value: if the user changes from password to PIN, "Set up PIN" becomes the default immediately (as it should). If the lock type fails to change from PIN to password, then UI flicker occurs in that "Set up PIN" changes back to "Change PIN" (as opposed to seeing the "Change PIN" change to "Set up PIN" with higher frequency). There is not a good way around this, the alternative being that a pinwheel of some sort should be visible as async tasks are being performed, and additional UI to show that CrOS was unable to change from PIN to password and vice versa. Bug: 1054327 Change-Id: Iade95bb3c3a44c90a69b069faa160f17b093107b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079834 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#746676}
-
Giovanni Ortuño Urquidi authored
This reverts commit 57466f0e. Reason for revert: Tests are consistently timing out on debug builds: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg?limit=50 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17377 Original change's description: > Restore End-To-End test on ChromeOS > > Bug: 1054935 > Change-Id: I2da8e4c8240647614728c21e351a6b2e940aaae0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074882 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744800} TBR=xiyuan@chromium.org,antrim@chromium.org,rsorokin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1054935, 1058022 Change-Id: Ie52bbd3036bebee69aaf836556aceb5e3322f970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086385 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL fixes a crash when TrustedWebActivityClient#createLaunchIntentForTwa() is given a non-HTTPS URL BUG=1057524 TEST=TrustedWebActivityClientTest#createLaunchIntentForTwaNonHttpScheme() Change-Id: Ib16ebd309c2e450ac40183f1ef4f7c7c6bb4876f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082485Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746674}
-
Zain Afzal authored
This is an upstream of web_app_file_handling.externs.js to cl/294762966. Additional context: chooseFileSystemEntries is still in the draft stage and as such is not known to closure. This cl adds the function to the native file handling externs file and gives it a type definition matching the wicg spec. https://wicg.github.io/native-file-system/#api-choosefilesystementries Bug: 1040328,996088 Change-Id: I6f3d2efacc092d36149866f05fccac9cb6e98ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084039 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#746673}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/54bd00057324..9e9493f29dbf git log 54bd00057324..9e9493f29dbf --date=short --first-parent --format='%ad %ae %s' 2020-03-04 ynovikov@chromium.org Skip crashing dEQP-GLES3.functional.samplers.*_tex_3d.* on SwANGLE Created with: gclient setdep -r src/third_party/angle@9e9493f29dbf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: Ibeeee8d1d36ff623e176883cca0caeef80f6177a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086185Reviewed-by:
-
Giovanni Ortuño Urquidi authored
See bugs for details TBR=rtoy@chromium.org Bug: 941219, 1047163 Change-Id: Ic6e8111c9432a530a3b0947b7581d66c37209db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086460Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/20ed48e8e963..64a3f8fcb749 git log 20ed48e8e963..64a3f8fcb749 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 bsalomon@google.com Revert "Use spin lock in SkIDChangeListener" Created with: gclient setdep -r src/third_party/skia@64a3f8fcb749 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I14c7d9df1208d4b74bd81abf6a596de03073805b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086187Reviewed-by:
-
Alan Cutter authored
Bug: 1007786 Change-Id: I674710a2fd92a669c636ab190337483825bac6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076222 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#746669}
-
Eric Willigers authored
GetAppIdForTab now supports web apps, in addition to bookmark apps and Chrome platform apps. AppServiceAppWindowWebAppBrowserTest is now parameterized by web_app::ProviderType. Bug: 1048055 Change-Id: I2fc9f656f88634d6b0c2f03a2531ea7914452797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078377Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#746668}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eedab7912f7c..779e58d10e2f Created with: gclient setdep -r src-internal@779e58d10e2f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie0890ec326eb07a1a407d0dc07fe976fecf6fed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086186Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Flakes started again around: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81647 TBR=avi@chromium.org Bug: 985255 Change-Id: I1827cb12df13a490c8de00ae753c223d17c62f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086458Reviewed-by:
-
Alex Danilo authored
With the flag enabled, and upcoming change the DOM structure of the breadcrumb, this test can't work in files-ng. Bug: 1035691 Change-Id: I3a78f7d82bc5f117fd3dfeab6b925c7284e41b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086379Reviewed-by:
-
Koji Ishii authored
This patch fixes an use-of-uninitialized-value accidentally introduced in r746511 <crrev.com/c/2079775>. |is_hanging_| is initialized and should be used only for |NGPhysicalLineBoxFragment|. The CL passes |is_hanging_| as an argument for this purpose, but the function mistakenly uses it in the super class, instead of using the one passed by the argument. Bug: 982194 Change-Id: I3b33595fa0305f92408914b9ac77d15fbccb9d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086456Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#746664}
-
Tal Pressman authored
Bug: 1049056 Change-Id: I52a862b6d5999203cff4ad92b9d1d63eff811ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078518Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/970291c5e024..40dd59329abe git log 970291c5e024..40dd59329abe --date=short --first-parent --format='%ad %ae %s' 2020-03-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@40dd59329abe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0a2ed4fc9363ad1d073d0280b95d7f5515367b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086183Reviewed-by:
-
Yuki Shiino authored
'Dictionary' type is obsolete and deprecated. The new bindings generator won't support it. The existing use cases (in *.idl) have been removed by peria@, except only for MediaTrackConstraintSet dictionary that contains Dictionary type. Removes web tests that depend on 'Dictionary' type. This is the last use case that is directly visible from IDL interface bindings. (MediaTrackConstraintSet dictionary yet contains Dictionary type, but it's not directly visible from IDL interface bindings.) Bug: 839389 Change-Id: Iec4f1112a0c17a7931aaf49ef4c2780ca564474e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084773Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#746661}
-
Mathew King authored
On the Drallion stylus when the errse button is pressed the digitizer will send an BTN_TOOL_RUBBER event before a BTN_TOUCH event and then a BTN_TOOL_PEN. This sequence should be considered an POINTER_TYPE_ERASER and not a POINTER_TYPE_PEN. Bug: b:139781900 Change-Id: I268ef0d72e25fa374832ed529a4b54559bc0f805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076530Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Commit-Queue: Mathew King <mathewk@chromium.org> Cr-Commit-Position: refs/heads/master@{#746660}
-
Kent Tamura authored
This CL relands crrev.com/c/2074840. A part of it was landed as crrev.com/746315, and this CL is the remaining. > HTMLOptionElement's InsertedInto() and RemovedFrom() called > MenuListSelectType::UpdateTextStyleAndContent(), which updates a Text > node in a UA shadow tree. It triggered a DCHECK failure about > IsSlotAssignmentRecalcForbidden(). We should not update the DOM tree > in these functions. > > This CL moves the logic of the InsertedInto() and the RemovedFrom() to > HTMLSelectElement::ChildrenChanged() and |HTMLOptGroupElement:: > ChildrenChanged()|. > > As for kAllChildrenRemoved such as |select.innerHTML=''|, > ChildrenChanged() had no ways to know removed nodes. This CL adds > ChildrenChangedAllChildrenRemovedNeedsList flag, and ContainerNode > provides a list of removed nodes if the flag is true. > > This CL also updates comments on Node::InsertedInto(), > Node::RemovedFrom(), and ContainerNode::ChildrenChanged(). Bug: 1056094 Change-Id: Icef4c9f180333a5b39d38b1950f9c5c2660c66c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086451Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#746659}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ia9d9b134b9f1fb09a466e1a3c6ccce8a2968910f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086555Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746658}
-
Giovanni Ortuño Urquidi authored
List of failed builders: Builder: Mac10.12 Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests First failing build: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/b8886807550037870064 TBR=bokan@chromium.org Bug: 1058244 Change-Id: I2a44c2e90c866785d49320114fed6fd1eec485da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086356Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/40d8cb5fc0ae..806369810527 git log 40d8cb5fc0ae..806369810527 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0380a339..b7f5172d (746487:746590) Created with: gclient setdep -r src/third_party/webrtc@806369810527 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I65a0445db64d011497cf1798f7aa6c79c900bf1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086181Reviewed-by:
-
