- 24 Sep, 2019 40 commits
-
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 211 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-03-22. Change-Id: Ie04b919e56dfb2877234ccadbe46567f8e743985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822237 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#699440}
-
Ankit Kumar 🌪️ authored
Document links or bookmarks may have horizontal scroll offsets defined in the PDF. Currently the horizontal scroll offsets are not taken into account during navigation of document links or bookmarks. This CL adds the horizontal scroll offset for document links and bookmarks. Tests have been modified to validate the scroll value. Bug: 982176 Change-Id: I80d227b1455db49d35294835dd6ed07f6154ca9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803941Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699439} -
Adrienne Walker authored
Change-Id: I71684e81c6cca77bcf7a84fbb5a65db33497cbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822417 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#699438}
-
Khushal authored
R=ericrk@chromium.org Bug: 992626 Change-Id: I6d106e24e3ee5a328449d59e9c20979bb4d64efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817326Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#699437}
-
Lukasz Anforowicz authored
This CL disallows an unlocked renderer process from accessing origins/urls that require isolation (i.e. require a process lock). The new enforcement works only on the UI thread - calls to CanAccessDataForOrigin on the IO thread will unfortunately continue to allow access for all unlocked renderer processes. See also https://docs.google.com/document/d/17t85azUYz-Wzo9vPrrghd47ilxjqCryDNJPGROKc8Es The new enforcement is enabled only on Android. On desktop, the citadel-style enforcement is blocked by NTP support for OOPIFs - see https://crbug.com/566091 and also https://docs.google.com/document/d/1jtanAByotYMaJzdxd2aIknwoVz1kjxL_HAR_mKBsJls Bug: 764958 Change-Id: I7864ca737c14c26c3c8cefe3cc2887028f891679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545157Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#699436}
-
Carlos Caballero authored
MessageLoopFor is going away soon. Bug: 891670 Change-Id: I9e2521c6f3479ffb2dc7f9806620bd185320577a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821921Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#699435}
-
Christy Chen authored
In the Network condition tools, user facing strings in the dropdown menu of user agent options are not localized. https://imgur.com/ZDp4j8D In this change: - adds ls() calls to those strings in NetworkConfigView.js. - GRDP changes are generated automatically, with manually written descriptions - Placeholders (<ph name="LOCKED_1">) are added in the grdp to prevent translations of the branding related strings. Bug: 941561 Change-Id: Ib274dd425733d0ef4f4199ff6334810f113ade27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816184Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Mandy Chen <mandy.chen@microsoft.com> Commit-Queue: Christy Chen <chrche@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699434}
-
Raul Tambre authored
Conversion performed automatically using '2to3 -w -f has_key .'. This is backwards compatible with Python 2. Bug: 941669 Change-Id: Ia884751c572c6bbe94cea10831f010e85f9e59fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817600Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#699433}
-
Tommy Li authored
Adds a metric to track how unstable our matches are due to asynchronous updates. Whenever a dropdown position gets asynchronously set to a new match that's different from the old match, this histogram logs the index. Bug: 398135 Change-Id: I9e7ba88c2ad8be616d933649805697aeb23cd938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803830 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#699432}
-
Abigail Klein authored
Bug: 949340, 785493 Change-Id: I2c467420ae4a250253071f9ce7d1c77a4b42aa32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817107 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#699431}
-
Fredrik Söderquist authored
Since we (now) know which instance times originated as offset-values in the attribute, we can clear those out before (re)parsing the attribute, rather than keeping a set of existing times and filter against those. The only potential downside is that this filtering step is O(n^2). When doing this we can also remove the HashTraits and associated bits for hashing SMILTimes. Also start exposing the origin from SMILTimeWithOrigin directly and change the (few) users. Adding of the implicit '0s' begin-time is now also done in ParseBeginOrEnd if needed since it is also treated as having 'attribute' origin. Bug: 1005185 Change-Id: I3bdf6a099d5853683cbbb516d8778e587353c3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818481 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#699430}
-
Tim van der Lippe authored
This includes the update to escodegen to 1.12.0 Change-Id: Ib186ca573c9435caaba9556fc6e85b122af219c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821609Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#699429}
-
Bin Du authored
Bug: internal bug id b/130928904 Change-Id: I051aa85d6e43e92b66b37ec420fbcc70060ac79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814674 Commit-Queue: Bin Du <dubin@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#699428}
-
Robert Ogden authored
Also bumps the expirations. Change-Id: I4f88f6e2dfef4a605f1bb2b9c4b68b87f2df385a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822325 Commit-Queue: Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#699427}
-
Nathan Zabriskie authored
https://chromium-review.googlesource.com/c/chromium/src/+/1764515 introduced a DCHECK that was being hit in views_examples_exe. Adding values to the SwapTimings submitted by DirectOutputSurface fixes the problem. Change-Id: Ic82b6dc8570811576c6f4b48f1fcbac1cd9c9e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820046 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#699426}
-
Mandy Chen authored
ServiceWorkerVersionRunningStatus is sent through CDP and displayed directly to the user in DT. This CL localizes the running status strings in the frontend. Location of the running status strings: https://imgur.com/pIZZCqo ServiceWorkerVersionRunningStatus: https://chromedevtools.github.io/devtools-protocol/tot/ServiceWorker#type-ServiceWorkerVersionStatus Bug: 941561 Change-Id: I14142f6fa0e95d6392e26676e450041b8207929c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814501Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699425}
-
danakj authored
We have the min/max page zoom factors limits and methods to convert between "page zoom factor" and "page zoom level" in - content/common/page_zoom.h - blink/renderer/core/exported/web_view_impl.cc - blink/public/web/web_view.h Instead of duplicating the limits and the logic, consolidate it all into a single blink public header. content/browser/ and components are able to include blink public headers, they just can't link against blink. The new site is in blink/public/common/page/page_zoom.h This updates all callers to point to this common site, and removes the redundant ones in content/common/ and WebView{Impl}. R=dcheng@chromium.org TBR=darin Bug: 419087 Change-Id: Ib89f022d96c9ac7ebfd4b84c08f666a25458725a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814857 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#699424}
-
Chris Davis authored
This change fixes an issue with the delayloads_unittest.cc not respecting the is_multi_dll_chrome set to false. This is needed in anticipation of the change to merge chrome.dll and chrome_child.dll. Bug: http://crbug.com/726150 Change-Id: Iccc35c2bcb2b952c871da2fa43eff211fb1df3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809671 Commit-Queue: Chris Davis <chrdavis@microsoft.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699423}
-
Matt Simmons authored
* If in incognito, hide the MV tile layout. * Start MVC'ing the MV tile list component. * Add tests for MVC'ed bits. Bug: 985386 Change-Id: I479756d2c28bb1dd743821e84803f6b53b68c669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814575Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#699422}
-
Marc Treib authored
Bug: none Change-Id: I77ac2637794507da16e2d172600c4839f2aa2dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821603 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#699421}
-
K Moon authored
This change adds a mutable PDFEngine* field to TestClient. This can be useful whenever the TestClient needs to call back into the PDFEngine. Note that creating an engine requires a PDFEngine::Client, so the reference from the client to the engine must be set after construction. For PDFiumEngine specifically, PDFiumTestBase::InitializeEngine() provides a convenient way to create an engine and initialize it from a PDF file. The TestClient may need to call into the PDFEngine before the PDF is fully loaded, however, so InitializeEngine() now takes care of setting the backreference on the client. Bug: 885110 Change-Id: I4f1cea5b40c995f91fcac32ff49d7de931505c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812134 Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#699420}
-
Reid Kleckner authored
This 2016 code is passing a flag in place of a boolean value. The flag happens to be non-zero (0 << 1), so this does not cause a behavior change. All other tests pass true or false boolean literals, so this does the same. TBR=rockot@google.com Bug: 1007367 Change-Id: Icd9a6fdb5b47a87d9dd19abdd8985323661f27b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822437Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#699419}
-
Matt Wolenetz authored
The MSE spec (https://www.w3.org/TR/media-source/) does not include any "Seekable()" method on the MediaSource object. Instead, it describes adjusted logic for HTMLMediaElement::seekable() when the media element is attached to (extended by) the MSE API. This change removes an obsolete, unused HTMLMediaSource::Seekable() declaration, MediaSource::Seekable() override declaration and definition. The actual logic for the MSE-adjusted seekable logic is in HTMLMediaSource::SeekableInternal() and MediaSource::SeekableInternal() already. The referenced bug will be modifying the MSE-adjusted SeekableInternal() logic, and I found this related cleanup during work on that bug. BUG=963717 Change-Id: I25e8d134e056690634a0cd026d5d63934ebbec9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820025Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#699418}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: Id4e0d4032099ab191bf373148aab657250cf2948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790446 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#699417}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1a76e688..cbf276fd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0ff0bcfb3406e483b20276e0711578a82e777910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822098Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699416}
-
John Z Wu authored
Change-Id: I6b45699c6813d62987f96dbeafbca112410bcc15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817317 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#699415}
-
Eric Willigers authored
Update comment to refer to WebAppMenuButton. Bug: 788051 Change-Id: I397cc63296996f0a4dc8438a45986531b4ad5718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819095 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#699414}
-
Jonathan Backer authored
Bug: 967716 Change-Id: I8c6f6d7ebd6a9e27744368811340eb1737cf4eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822017Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699413}
-
Friedrich Horschig authored
The translation pipeline needs destinations and scaffold files. This CL adds that. TBR:agrieve@chromium.org TBR Reason: The translation pipeline is blocked on this and it's a small change that doesn't touch any code. benmason@ can confirm :) Bug: 1006869 Change-Id: I65af5a8eba6b4e8ea47bb12aec67c0cc7a5ed1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821528 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#699412}
-
Dirk Pranke authored
I'm not really doing much stuff w/ Blink these days, and so there are better owners in //third_party/blink and //third_party/test_fonts. I also don't really know much about //third_party/libcxx-pretty-printers, and so probably shouldn't be an owner there. Change-Id: I0bca5f54285be2f9d9913fa6bd55a8d2bfc132b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819892Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#699411}
-
David Roger authored
This CL removes the unconsented_primary_account_ in identity manager. Instead, PrimaryAccountManager is now storing this information, in the form of a boolean rather than a string. This will prevent bugs where the two strings go out of sync. PrimaryAccountManager also persists that boolean in prefs, and as a result the unconsented primary account becomes available at Chrome startup. This will allow simplifying the code, as it won't be necessary for users to wait for it to be loaded. TBR=jzw Change-Id: I832ae5775c9665709d6780a9ec5ef2a2389357ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803145Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#699410}
-
Mohammad Refaat authored
This code is no longer needed after switching to the new cookie store. Bug: 989554 Change-Id: I83b89a77b141a313343f20615b9ab0eeb3d2f2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819998Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#699409}
-
Tom Anderson authored
BUG=1006102 R=pkasting Change-Id: I67b040c84886655f37b4731a09e990399affcfb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819332 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#699408}
-
Rob Paveza authored
In the Elements Event Listeners pane, one of the things that is possible due to the "Ancestors" inclusion is that a parent element with an event listener can be navigated-to via a mouse click on the element name. This functionality is now extended to keyboard- only users by handling the enter keypress for that same tree node. Change-Id: I7603c43991079af24cbf749b10ff270928945d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815820Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699407}
-
Gayane Petrosyan authored
Removing 'non-white-bg' class as search suggestions was the only user of it and they are not using it anymore. Bug: None Change-Id: Icb118c92f4117b6f6a7da5d6c97acdcf994c380d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811929 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#699406}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8de7737d65f3..59ab7b718b08 git log 8de7737d65f3..59ab7b718b08 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 seanabraham@chromium.org Revert "image_lib: more debug output forLoopbackPartitions.Mount" Created with: gclient setdep -r src/third_party/chromite@59ab7b718b08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Idf76444d1689e3a3a7ddab2324f2f3b878360a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821960Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699405}
-
Adrienne Walker authored
Previously, the third argument was web-exposed when it should not have been. Bug: 1006131 Change-Id: Ie35a6e8b0e08f35e8fdf7bf297435ab6edac3cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816579 Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#699404}
-
David Van Cleve authored
This is one of a series of three CLs adding more uniformity to referrer controls' implementation. The switch's functionality remains accessible via disabling the enable_referrers pref. The changes in this CL comprise: 1. Removing the switch 2. Removing the previous calls directly checking the switch, rather than the enable_referrers pref. Happily, these checks of the switch were both redundant with the later check of enable_referrers performed in NetworkDelegate::NotifyBeforeURLRequest. 3. A nominal amount of refactoring of some dead/nearly-dead referrer-related code: - network::ComputeReferrer removed from loader_util.cc (after removing the --no-referrers switch, this method now duplicates GURL::GetAsReferrer). - content::Referrer::SetReferrerForRequest removed (it had no callers). R=gab, falken Bug: 1004486 Change-Id: I00bc503d0954700565047a188bbb9842c4d4bc9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808144 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#699403}
-
Allen Bauer authored
Bug: 1005568 Change-Id: I3aa86d1f9cf20eacabdc1084cecd24894e5252b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822019 Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#699402}
-
Mythri A authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Change-Id: I8ababa87c428f3b7431a10b0f9e758071837c505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815128 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#699401}
-