GitLab

This patch ensures that persistence binding is not established if working copy
of network UISourceCode does not match with the working copy of filesystem
UISourceCode.

This validation is done proactively: whenever automapping reports a binding,
we fetch contents of both network and filesystem UISourceCodes and compare them.

For this to work fast, we do *not* validate the following types of bindings:
- bindings of source map sources. These could be slow to fetch, and they don't break us in any
  way.
- bindings of binary files (e.g. images). These are never going to be edited, and
  thus can't deal any harm.

To sum up, we request contents only of those text resources which were already
succesfully loaded by the website itself, which means they are of manageble size.
However, to be on the safe side, this change is guarded by on-by-default experiment.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2542073002
Cr-Commit-Position: refs/heads/master@{#437761}

Fixes WindowServerTest.OnWindowHierarchyChangedIncludesTransientParent().

BUG=none
TBR=sky@ to fix tree.

Review-Url: https://codereview.chromium.org/2558043008
Cr-Commit-Position: refs/heads/master@{#437760}

This build flag is always set for non-iOS platforms. The flag is not
overridable in the build and we never test other settings of it. The policy
code is stable and doesn't change.

This patch removes the flag and replaces it with !ios conditionals.

BUG=671706

Review-Url: https://codereview.chromium.org/2558043004
Cr-Commit-Position: refs/heads/master@{#437759}

This is a simple src-side dependency required by
https://codereview.webrtc.org/2563203002

BUG=668446

Review-Url: https://codereview.chromium.org/2565063002
Cr-Commit-Position: refs/heads/master@{#437758}

https://skia.googlesource.com/skia.git/+log/1951f3ddbddc..2790c52e36dd

$ git log 1951f3ddb..2790c52e3 --date=short --no-merges --format='%ad %ae %s'
2016-12-09 bsalomon Make *OpList::recordOp functions take sk_sp<GrOp> not GrOp*

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2563243002
Cr-Commit-Position: refs/heads/master@{#437757}

JumpListIcons(Old) folders are getting unexpectively huge for some users.
This may be caused by file operation failures.

After analyzing those folders' problematic move operation metric
by landing crrev.com/2522163003/, we find that it is necessary
to dig into every major step in base::move() operation for better
understanding the root cause.

Added code to record more detailed JumpListIcons folder's move operation
status to UMA.

Will revert this CL after gathering user data for further analysis.

BUG=179576
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2563483004
Cr-Commit-Position: refs/heads/master@{#437756}

Use ThreadTaskRunnerHandle instead of BrowserThread::GetTaskRunnerForThread.
This avoids a data race in shutdown due to the fact that RendererScheduler
(used on a BrowserThread in this test) tramples the MessageLoop's TaskRunner
in a manner BrowserThreadImpl's TaskRunner facade does not anticipate.

Also opportunistically corrects some non-const ref arguments in
RenderThreadImpl.

BUG=672812

Review-Url: https://codereview.chromium.org/2568543002
Cr-Commit-Position: refs/heads/master@{#437755}

The gpu message-pump is no longer ncessary. It is not used in
chrome-gpu either.

BUG=671397

Review-Url: https://codereview.chromium.org/2560303002
Cr-Commit-Position: refs/heads/master@{#437754}

Revert of Change exo::SurfaceFactoryOwner to exo::ExoCompositorFrameSink (patchset #54 id:1050001 of https://codereview.chromium.org/2493223002/ )

Reason for revert:
Breaks test (DesktopMediaListAshTest.ScreenOnly) in chromeos-ozone builds.

Original issue's description:
> Moved exo::SurfaceFactoryOwner to its own file and renamed it to exo::CompositorFrameSink.
>
> CompositorFrameSink implements cc::mojom::MojoCompositorFrameSink.
>
> CompositorFrameSink is no longer a friend class of exo::Surface.
>
> Added exo::CompositorFrameSinkHolder class that implements cc::mojom::MojoCompositorFrameSinkClient.
>
> BUG=659601
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2493223002

TBR=reveman@chromium.org,fsamuel@chromium.org,jbauman@chromium.org,sky@chromium.org,staraz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659601

Review-Url: https://codereview.chromium.org/2566813002
Cr-Commit-Position: refs/heads/master@{#437753}

Revert of Build services as standalone executables (patchset #14 id:260001 of https://codereview.chromium.org/2557213002/ )

Reason for revert:
Lots of test failures - ICU data not being found in service processes.

Original issue's description:
> Build services as standalone executables
>
> Cleans up a bunch of service manager details which exist to support
> the currently untenable goal of dynamically loading service binaries
> in a common host executable.
>
> Changes services to instead build as standalone executables, and
> teaches the service manager how to launch them.
>
> BUG=642879
>
> Review-Url: https://codereview.chromium.org/2557213002

TBR=ben@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642879

Review-Url: https://codereview.chromium.org/2566663004
Cr-Commit-Position: refs/heads/master@{#437752}

Most of this changelist is just fixing up SpdyFramer constructor call sites and tests.

This CL lands server change 141335728 by birenroy.

BUG=488484

Review-Url: https://codereview.chromium.org/2566513004
Cr-Commit-Position: refs/heads/master@{#437751}

This CL allows us to notify keyboard type changes to a client
through zcr_keyboard_device_configuration_v1 interface.

BUG=670247

Review-Url: https://codereview.chromium.org/2506263002
Cr-Commit-Position: refs/heads/master@{#437750}

BUG=612493
R=dgozman

Review-Url: https://codereview.chromium.org/2569563002
Cr-Commit-Position: refs/heads/master@{#437749}

Cr-Commit-Position: refs/heads/master@{#437748}

Previously the frame scheduler was setting target bitrate whenever
bandwidth estimate changes. VP8 encoder doesn't handle this very well:
every time bitrate is update quality drops significanlty for the
following frames. It happens because every time biutrate is updated the
codec needs to be reconfigured, resulting in encoder state reset.

Fixed it by adding a filter that calculates average BW estimate over
last second and updates target bitrate only when the average BW
estimate differs from the current target bitrate by more than 33%.

Also fixed WebrtcConnectionToHost::Connect() to avoid crash when
running perftests.

Review-Url: https://codereview.chromium.org/2562893003
Cr-Commit-Position: refs/heads/master@{#437747}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/707aaac64b3c..19565fdb148a

$ git log 707aaac64..19565fdb1 --date=short --no-merges --format='%ad %ae %s'
2016-12-09 nednguyen Revert of re-enabled netlog viewer dev server tests (patchset #2 id:20001 of https://codereview.chromium.org/2553213002/ )
2016-12-09 charliea Roll battor_agent_bin to include new init retry logic

BUG=672631

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2567543003
Cr-Commit-Position: refs/heads/master@{#437746}

This CL implements Timezone Selection screen for material design ChromeOS OOBE.

BUG=604119
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2564563004
Cr-Commit-Position: refs/heads/master@{#437745}

If the extension isn't available, we cannot read from fbo attaching
float texture attachment. This CL adds error message when the extension
is not available.

BUG=369849, 624436

Review-Url: https://codereview.chromium.org/2565703002
Cr-Commit-Position: refs/heads/master@{#437744}

BUG=672593

Review-Url: https://codereview.chromium.org/2560823005
Cr-Commit-Position: refs/heads/master@{#437743}

Reduces the number of layouts performed.
Moves update to be run in a requestAnimationFrame callback.
Cleans up the code a bit to move pieces of the massive update functions
into their own methods for a clearer breakdown of where time is spent.

BUG=657141
R=lushnikov,paulirish

Review-Url: https://codereview.chromium.org/2551403002
Cr-Commit-Position: refs/heads/master@{#437742}

https://skia.googlesource.com/skia.git/+log/0e8fc8b9e6a1..1951f3ddbddc

$ git log 0e8fc8b9e..1951f3ddb --date=short --no-merges --format='%ad %ae %s'
2016-12-09 bsalomon Rename testingOnly_drawBatch to testingOnly_addDrawOp and sk_sp
2016-12-09 mtklein bicubic, attempt gazillion
2016-12-09 bsalomon Make GrRenderTargetOpList::addDrawOp use sk_sp
2016-12-09 bsalomon Fix comment formatting for GrRenderTargetContext::drawArc
2016-12-09 halcanary tools and docs: clean up gyp-specific things

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2565433005
Cr-Commit-Position: refs/heads/master@{#437741}

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2561953003
Cr-Commit-Position: refs/heads/master@{#437740}

BUG=666858

Review-Url: https://codereview.chromium.org/2549023003
Cr-Commit-Position: refs/heads/master@{#437739}

This patch migrates the "left thick blue" icon, which points to the
inspected node, onto UI.Icon. As a result, the icon is now sharp
on retina!

This patch also introduces icon support for treeoutline: every
TreeElement now has TreeElement.setTrailingIcons(icons) method.
Users might call it to add icons after the treeelement's title.

In future, a symmetrical method TreeElement.setLeadingIcons(icons)
method, which will be used to migrate navigator icons over to
the UI.Icon.

BUG=669323

Review-Url: https://codereview.chromium.org/2564433004
Cr-Commit-Position: refs/heads/master@{#437738}

This corrects how the ServiceManager clears out identity mappings
to singleton services, preventing it from indefinitely holding a
raw Instance* to any singleton it starts.

BUG=None

Review-Url: https://codereview.chromium.org/2566663003
Cr-Commit-Position: refs/heads/master@{#437737}

Review-Url: https://codereview.chromium.org/2560353002
Cr-Commit-Position: refs/heads/master@{#437736}

All new tests repro prior to their fix, and no longer repro on trunk.

Added 257c076e3e8866554529d495440b606e321d9e39 to internal repo.

R=dalecurtis@chromium.org
BUG=668346,640912,640889,639961,637428,635422

Review-Url: https://codereview.chromium.org/2569543002
Cr-Commit-Position: refs/heads/master@{#437735}

Merge internal change: 141451848

Review-Url: https://codereview.chromium.org/2561913003
Cr-Commit-Position: refs/heads/master@{#437734}

BUG=661612

Review-Url: https://codereview.chromium.org/2550063003
Cr-Commit-Position: refs/heads/master@{#437733}

The Breadcrumbs project dumps system state to a persistent file so that it can
be analyzed after a crash.  We want to include in that the complete set of field
trials.  That means saving them to the file when the browser starts and being
able to retrieve them from the file on a future run; they will be loaded into a
protobuf and uploaded.

BUG=663414

Review-Url: https://codereview.chromium.org/2560723004
Cr-Commit-Position: refs/heads/master@{#437732}

The behavior we want to launch is animate-nonsecure-only, so update the
waterfall to that animation behavior.

BUG=

Review-Url: https://codereview.chromium.org/2569433003
Cr-Commit-Position: refs/heads/master@{#437731}

When trying to understand why particular symbols are pulled in to a
binary it can be helpful to examine the verbose linker output.
However it quickly becomes unwieldy. This parses it and allows
querying of it to explain why a particular object file is pulled
in. This was used in the investigation of the linked bug, and others.

BUG=630755

Review-Url: https://codereview.chromium.org/2564543003
Cr-Commit-Position: refs/heads/master@{#437730}

BUG=671194
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
TEST=manual, install Trusteer Rapport, verify dialog appears.

Review-Url: https://codereview.chromium.org/2566733003
Cr-Commit-Position: refs/heads/master@{#437729}

BUG=

Review-Url: https://codereview.chromium.org/2515313003
Cr-Commit-Position: refs/heads/master@{#437728}

Force slow path for now, which is the same as what we are doing in
PaintInvalidationState.

BUG=672989
TEST=virtual/spinvalidation/fast/multicol/span/abspos-containing-block-outside-spanner.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2569483003
Cr-Commit-Position: refs/heads/master@{#437727}

Safe Browsing Extended Reporting reports show a number of certificate
errors from Windows users where the certificate error is
ERR_CERT_DATE_INVALID but the certificate chain appears to have
perfectly valid dates.

To get some diagnostic data from Canary, this CL calls
DumpWithoutCrashing() when we observe such a chain. This CL is intended
to be reverted after obtaining a few days of data from Canary.

BUG=672906

Review-Url: https://codereview.chromium.org/2567643003
Cr-Commit-Position: refs/heads/master@{#437726}

Cleans up a bunch of service manager details which exist to support
the currently untenable goal of dynamically loading service binaries
in a common host executable.

Changes services to instead build as standalone executables, and
teaches the service manager how to launch them.

BUG=642879

Review-Url: https://codereview.chromium.org/2557213002
Cr-Commit-Position: refs/heads/master@{#437725}

Since the anchor's text might have been changed via the textContent
assignment, the icon might not be attached.

This patch makes sure icon is attached to the dom before attempting to
remove it.

BUG=672746
R=dgozman

Review-Url: https://codereview.chromium.org/2552883014
Cr-Commit-Position: refs/heads/master@{#437724}

Previously, the various editors would return |null| to the caller
(PaymentRequestImpl) in the case of a cancel. We are now returning the
original item that was passed in for edit.

BUG=672996
TEST=PaymentRequest*Test*

Review-Url: https://codereview.chromium.org/2561373002
Cr-Commit-Position: refs/heads/master@{#437723}

Two types of sync metadata, once stored in the sync directory, are now being
migrated to the web database. These two types are the per-entry EntityMetadata
and the ModelTypeState, which is globalstate for the autofill model type. This
change adds a migration to add the tables and functions on AutofillTable to
read/write/delete it, with associated tests.

BUG=671832

R=shess@chromium.org,mathp@chromium.org,pavely@chromium.org

Review-Url: https://codereview.chromium.org/2550293002
Cr-Commit-Position: refs/heads/master@{#437722}