- 21 Nov, 2018 1 commit
-
-
Sara Kato authored
This change exposes text location data for a node, by calling refreshWithExtraData on Android side. This is exposed to s2s on chrome side to allow spoken words to be highlighted respectively. go/s2s-arc for design document detailing change, and summarizing design iterations Android side change: https://googleplex-android-review.git.corp.google.com/c/platform/vendor/google_arc/+/5361958 Bug: b/72793987 Test: Manual Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3cd01b80d12b21bd77c0133b0d78a2a44516b670 Reviewed-on: https://chromium-review.googlesource.com/c/1212442Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#609858}
-
- 20 Nov, 2018 39 commits
-
-
Charlie Andrews authored
BLINK_PLATFORM_EXPORT can't be safely removed without causing a linker error on Windows and this fact isn't going away. Bug: 691714 Change-Id: Ie2399c50877e16fa80f9cb3ebe455c56493e6cce Reviewed-on: https://chromium-review.googlesource.com/c/1343291 Commit-Queue: Charlie Andrews <charliea@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#609857}
-
Bo Liu authored
This matches old behavior. Note that fragment navigation is strict subset of in-page navigations. in-page navigations also include history.replaceState and history.pushState Bug: 902722, 896022 Change-Id: I002fab4982620e7e13b84a7d96547e105c7338bb Reviewed-on: https://chromium-review.googlesource.com/c/1345229Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#609856}
-
Aiden Benner authored
Adds an interface JniStaticTestMocker and an anonymous implementation in each generated class created by the JniProcessor. The TEST_HOOKS field contains a method that will set the mock that is used when testing is enabled. When testing is disabled, TEST_HOOKS will never be called and should be optimized away by proguard/R8. This should allow for generic JUnit rules that work with all static mockable 'proxy' natives. Bug: 898261 Change-Id: I026858957e7f98cbbe16da0772dc3e68d38717bb Reviewed-on: https://chromium-review.googlesource.com/c/1342805 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#609855}
-
Luciano Pacheco authored
Change directory tree icon override to also override for volume-type-icon which makes tests that uses selectVolume helper to be able to continue to select Downloads folder. This will be properly fixed and removed when MyFilesVolume is fully rolled out. Bug: 873539 Change-Id: I38a36aaacf4a52b68237466846cbd468ee60b0b9 Reviewed-on: https://chromium-review.googlesource.com/c/1343594Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#609854}
-
Michael Spang authored
Rather than allowing arbitrary scales, only allow integer scales and 1.5 (for 1080p). This means we won't apply strange scales that may not work well when using a non-standard resolution. There's no change for standard TV resolutions. Bug: b/117782357 Test: cast_graphics_unittests Change-Id: Ied44492232fbe7bf61d0d48e99ab5a6038f28031 Reviewed-on: https://chromium-review.googlesource.com/c/1344904 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#609853}
-
Jeremy Apthorp authored
This allows usage on windows of non-goma build wrappers (e.g. sccache[1]) for us lowly non-googlers. We've been using this in Electron for several months[2]. [1]: https://github.com/mozilla/sccache [2]: https://github.com/electron/electron/blob/d56617e5d009fc03f4faa684ca1e6fbe0e1d2e51/patches/common/chromium/windows_cc_wrapper.patch Change-Id: I2de68eac93bfbf3343e04b3253330dfa28e6048b Reviewed-on: https://chromium-review.googlesource.com/c/1343518 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#609852}
-
Xiaohan Wang authored
If the current video stream is encrypted, set PROTECTED_VIDEO in the decoded video frame. Notes: - clear leads in an encrypted video stream also have PROTECTED_VIDEO set - For clear stream, even though we are using the CDM to decode it, PROTECTED_VIDEO will NOT be set Bug: 849464 Change-Id: Iae3257aaa122af8073f815278d8b65b55946f3f3 Reviewed-on: https://chromium-review.googlesource.com/c/1337486 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609851}
-
Tatiana Buldina authored
Bug: chromedriver:2658 Change-Id: Id1acd6fbab55a47f42858d5c82aec9210dacf845 Reviewed-on: https://chromium-review.googlesource.com/c/1343371Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#609850}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5db7ecf7859e..0d23e71a1714 Created with: gclient setdep -r src-internal@0d23e71a1714 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2d0023c01ba387fb7ea645d70c03f804a0f3ffc4 Reviewed-on: https://chromium-review.googlesource.com/c/1344899Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609849}
-
Etienne Pierre-Doray authored
In an effort to avoid creating threads from the main thread, this CL avoids the creation of a new idle thread after waking up the current idle thread from the main thread. This is done by moving a call to MaintainAtLeastOneIdleWorkerLockRequired() from WakeUpOneWorkerLockRequired() to GetWork(). Note that a call to MaintainAtLeastOneIdleWorkerLockRequired() is still done before waking up a worker in WakeUpOneWorkerLockRequired(), in case no idle thread was created yet. Bug: 847501 Change-Id: Ib3903c117a781a72f9d6a6aaeceee6554e5b9803 Reviewed-on: https://chromium-review.googlesource.com/c/1338382 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#609848}
-
Philip Rogers authored
According to the spec, filtering should apply before clipping (https://drafts.fxtf.org/css-masking-1/#placement): "...effects are applied to the element in order: filter effects, clipping, masking and opacity." This patch fixes clip-path order with BlinkGenPropertyTrees (BGPT) which exposed the issue of filter and clip order. Testcases have been added showing the fixed behavior with BGPT, and the non-BGPT results have been marked as failing. NOTRY=true Bug: 906154, 907175 Change-Id: I5e9c7dbb7c694afc623fbc3bb2c7f2f8cc458195 Reviewed-on: https://chromium-review.googlesource.com/c/1344217 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#609847}
-
Clark DuVall authored
This adds a test for clearing the bad proxy cache when DRP is turned off, and implements that functionality with network service. Bug: 721403 Change-Id: I12f441191de6dfb890c7a042b72a5a87f72e41aa Reviewed-on: https://chromium-review.googlesource.com/c/1343352Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#609846}
-
Marc-Antoine Ruel authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/7f463e66e1c4..b6e9e23e4e79 $ git log 7f463e66e..b6e9e23e4 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 maruel [client]: fix undefined class reference 2018-11-19 vadimsh [proto] Fix google/rpc/*_pb2.py, it has wrong proto paths in it. 2018-11-19 maruel protobuf: upgrade to 3.6.1 from 3.5.1 2018-11-19 jchinlee [client] Print time with tasks update message. Also increase frequency. Created with: roll-dep src/tools/swarming_client R=jchinlee@chromium.org Bug: 905012 Change-Id: I5e397d787e27223d94dd85b35d3c2826dc93febe Reviewed-on: https://chromium-review.googlesource.com/c/1343666Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#609845}
-
Wenzhao Zang authored
When ephemeral user selects a new wallpaper, it's not saved to disk. But we should still be able to keep this wallpaper before user logout. The wallpaper is already cached in memory, but we ignored the cache for ephemeral users: so when lock screen or wallpaper app calls ShowUserWallpaper, it always thinks that ephemeral users never set a wallpaper and then display the default wallpaper. Bug: 825237, 902327 Change-Id: Id9a811c91243b04c7459f3ee20569ec4fdff14b0 Reviewed-on: https://chromium-review.googlesource.com/c/1343105 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#609844}
-
Sergey Ulanov authored
Change-Id: Ia1f21d38b2e3eb04377cba774d19172718f82e91 Reviewed-on: https://chromium-review.googlesource.com/c/1344878Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#609843}
-
Min Chen authored
Changes in this cl: - Make sure ShelfLayoutManager doesn't handle the following gesture events after ET_GESTURE_SCROLL_BEGIN for auto_hide shelf. Then they can still be propagated to ShelfButton to process the drag and drop. - Start the gesture drag and ink drop timer of the shelf item only if the shelf is visible. Then gesture drag on the item in AUTO_HIDE_HIDDEN shelf will not activate the ink drop of the shelf item. - Update the shelf visibility in ShelfView::OnMenuClosed only if there is no shelf item in drag. Since shelf should be kept as visible during drag even the menu is closed. Bug: 905847 Change-Id: I384b4c4b3bc2d240820cea338c4ddc59d8cc517a Reviewed-on: https://chromium-review.googlesource.com/c/1340952 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#609842}
-
Ben Pastene authored
Should have enough bots. R=jbudorick, dpranke Bug: 902468 Change-Id: If699354b2747c77a11741972fe8b531d9d500234 Reviewed-on: https://chromium-review.googlesource.com/c/1344689Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#609841}
-
Thomas Guilbert authored
The RemotePlaybackAppLauncher CL was reverted due to a regression (see cb04d0bc). Since the revert, needs have changed, and we no longer need a fully dynamically chosen app ID. This CL adds the ability to define a custom RemotePlayback app ID from the AndroidManifest, which can be overriden downstream. The info is stored in a static field, since it does not change at runtime. Bug: 790766 Change-Id: I2b2d466304234f4c07a4b617dc336f936aabc585 Reviewed-on: https://chromium-review.googlesource.com/c/1334660 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#609840}
-
Qiyu Hu authored
Deadcode Bug: 111367421 Test: CQ Change-Id: I51d4f187aacd6f9594f74c612ca49d1e99d62a09 Reviewed-on: https://chromium-review.googlesource.com/c/1338089Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#609839}
-
Tom Anderson authored
These were only needed for GTK2, which we've since dropped support for. BUG=None R=sky Change-Id: Ibbceaad8230361b7f114c96f489433cc77ef13f7 Reviewed-on: https://chromium-review.googlesource.com/c/1344877Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#609838}
-
Carlos Knippschild authored
Allows the offline content list on the dino page to be collapsed by the user, mirroring the UX used on the NTP for collapsing the list of suggested articles. These two collapsible lists also share the same PrefsService setting so that the expanded/collapsed state of one is reflected on the other. This also fixes a small issue with the background color appearing between a suggestion image and its border. Bug: 852872 Change-Id: I47ed7abaa777fe233ec79153a033482812ae478a Reviewed-on: https://chromium-review.googlesource.com/c/1318630Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Reviewed-by:
Edward Jung <edwardjung@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#609837}
-
Thomas Tangl authored
If the unified consent feature is disabled, always show the "Enhanced spell check" toggle. Bug: 905470 Change-Id: I0fde90d956945a4089db4cfad95475635b94dc58 Reviewed-on: https://chromium-review.googlesource.com/c/1344050Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#609836}
-
Thomas Tangl authored
- The unified consent master toggle is removed from the "Sync and Google services" settings page. - The UnifiedConsentGiven pref is removed from settings. - The sync-everything toggle is added under the sync section. Bug: 906031 Change-Id: I01c82cba206d2c98c053864226907cb9663f1796 Reviewed-on: https://chromium-review.googlesource.com/c/1342557 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609835}
-
Katie D authored
Set the --enable-experimental-accessibility-features flag to never expire. This flag is used by multiple a11y features and will continue to be used for the forseable future. Change-Id: I18cf355e1116a69c87c45928e250295eeb2787b3 Reviewed-on: https://chromium-review.googlesource.com/c/1340783 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#609834}
-
Xiaoqian Dai authored
The CL is to improve the smoothness of tab dragging in tablet mode. See before video with two heavy web pages: https://drive.google.com/open?id=1aN02WfhPo-qd33EzQgbTQUSYpoAupXm_ and after video with two heavy web pages: https://drive.google.com/open?id=1GjJteBEu29Q_8i8zubRyYbXYgA9Mkm_g Bug: 896015 Change-Id: I90612120c370e391d003beb463da087fa378bfac Reviewed-on: https://chromium-review.googlesource.com/c/1330834Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#609833}
-
Sam McNally authored
Currently, the hover color for dialog ok buttons is not set, so it falls through to the default button color, which varies depending on whether check-select is applied to the body. This causes hovering to make the text color dark instead of remaining unchanged. Set the color for both with and without hover to avoid this. Bug: 842130 Change-Id: I67a02346a7aa173de91ac41366cbdd5057e9e6c3 Reviewed-on: https://chromium-review.googlesource.com/c/1345169 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#609832}
-
Evan Stade authored
BrowserNonClientFrameViewAshTest.HeaderVisibilityInOverviewAndSplitview This test was disabled due to flake (classic Ash), which I can't repro now. But while it was disabled, it quit passing because some updates to the test broke it, and because the home launcher now means that tablet mode affects the visibility of caption buttons. This fixes the test for all configurations including multi process Mash. Bug: 818170 Change-Id: Ia0a029f52872b84f6ce6d37c1e433719c243eb56 Reviewed-on: https://chromium-review.googlesource.com/c/1327529Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#609831}
-
Christian Biesinger authored
Change-Id: Iec7f382006b6215b6ac1b847722511f66ff82db2 Reviewed-on: https://chromium-review.googlesource.com/c/1344200Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#609830}
-
Mustaq Ahmed authored
Change-Id: I29dbfa090291d933582fdeaece594808dea5e046 Reviewed-on: https://chromium-review.googlesource.com/c/1344580Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#609829}
-
Eric Foo authored
Bug: 868202 Change-Id: Iee7e12d9aa5a1575d542739b99f351589f1ebb76 Reviewed-on: https://chromium-review.googlesource.com/c/1341241Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#609828}
-
Robert Liao authored
This test works fine on Linux. BUG=161902 TBR=sky@chromium.org Change-Id: Idaefa2f3f0f1544af4f28ba6e43b211b7a368e0f Reviewed-on: https://chromium-review.googlesource.com/c/1344216Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#609827}
-
Xi Cheng authored
Bug: 701944 Change-Id: Idf06f127aba7d4a50fa23d631ff78604b3a57258 Reviewed-on: https://chromium-review.googlesource.com/c/1342672Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#609826}
-
John Chen authored
Fixing a JavaScript code syntax error in the code intended to cause a two frame wait before dispatching touch events. Bug: chromedriver:2665 Change-Id: I7a69a58500fdae5fdb45ab836eb96c054f8e54b9 Reviewed-on: https://chromium-review.googlesource.com/c/1340582Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609825}
-
Tommy C. Li authored
We have launched this to Stable some time ago. Bug: 900255 Change-Id: I52ea22c451cee3b0bf7df67710978ef272f781ae Reviewed-on: https://chromium-review.googlesource.com/c/1343366 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#609824}
-
Mohamed Heikal authored
The Protobuf Java Lite runtime is now separate from the main java runtime. This cl adds the java lite runtime to the repo. In a follow up Bug: 782237 Change-Id: I9f4af1736006ab224dc4230d3a071290974135b8 Reviewed-on: https://chromium-review.googlesource.com/c/1338574Reviewed-by:
Grace Kloba <klobag@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#609823}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f1238bc..2ecd5f54 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0cec98aac943d42f6fdcf4d3c6f42812beab8a37 Reviewed-on: https://chromium-review.googlesource.com/c/1344253 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609822}
-
Kevin McNee authored
A GinPort's onDisconnect may invalidate the context (e.g. MessagingApiTest.MessagingBackgroundOnly). Attempting to invalidate the events throws an exception which interferes with the extensions JS testing framework. Now the framework can call more of the safe builtins without triggering the exception, so we do so here. Bug: 803668 Change-Id: I07aa962ba689174a4f35885c72a9c3318256ff50 Reviewed-on: https://chromium-review.googlesource.com/c/1342068Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#609821}
-
Adam Langley authored
There has been confusion about the third-party review process. Try to clarify that chromium-third-party is about licensing review, that the reviewers may simply leave a comment, and that they are not expected to be able to approve a change. Change-Id: I8461f9b416f8d76542230beb770a2cf8f5c44d6f Reviewed-on: https://chromium-review.googlesource.com/c/1338477Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#609820}
-
Jacob Dufault authored
- Remove the webui lock screen tests. - Re-enable flaky test since it should no longer flake because there is no longer webui involved. Bug: 899777 Change-Id: I759ad6d20a08ad48e6a992fcfca9a25572ad16a5 Reviewed-on: https://chromium-review.googlesource.com/c/1327163 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#609819}
-