GitLab

* Also open the extension "uninstall URL" only when uninstall is user initiated.

BUG=84556

Review URL: https://codereview.chromium.org/406063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285079 0039d316-1c4b-4281-b951-d872f2087c98

Previous patch failed because of GC issue (GC for the first test
only happens after the second test started, and it turns out
that we rely on __del__ in that test -- not good!). This is fixed in:

https://codereview.chromium.org/409113006/

BUG=392901

Review URL: https://codereview.chromium.org/408913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285078 0039d316-1c4b-4281-b951-d872f2087c98

The descriptor module defines a generic infrastructure for declaring USB
descriptor formats. Features such as fixed and computed descriptor
fields are intended to make it as easy as possible to construct a
well-formed descriptor.

BUG=396682
R=rockot@chromium.org,rpaquay@chromium.org

Review URL: https://codereview.chromium.org/409883008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285076 0039d316-1c4b-4281-b951-d872f2087c98

This change adds a toggle to turn webspeech off when tab goes background.
And further request to turn media capture devices on will be denied.
So Both WebRTC and webSpeech won't be able to initiate new requests when tab is in background.

BUG=396054
R=dalecurtis@chromium.org, jam@chromium.org

Review URL: https://codereview.chromium.org/415433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285072 0039d316-1c4b-4281-b951-d872f2087c98

The DeviceLocalAccountTest.Extensions* assumed that extensions get copied
to an account's cache after successful installation. In reality,
extensions are downloaded to the cache at first and then removed again if
installation fails. The removal happens asynchronously on a background
thread. This led to a race where tests would try to verify that an
extension does not exist in a cache without waiting for the removal
process to finish first.

This CL switches the tests from verifying that an extension has been
removed from disk to checking whether the cache entry has been removed,
which happens synchronously on the UI thread.

BUG=393208
TEST=DeviceLocalAccountTest.Extensions*

Review URL: https://codereview.chromium.org/389313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285070 0039d316-1c4b-4281-b951-d872f2087c98

Extensions unit tests originally ran as part of Chrome's unit_tests suite.
We have introduced a extensions_unittests target which is now running on
trybots, CQ and main waterfall. It started with duplicates of tests in
chrome_tests_unit.gypi (so we wouldn't lose coverage).

Now that extensions_unittests is running everywhere we can remove the
duplicate test entries.

BUG=348066
TEST=unit_tests extensions_unittests

Review URL: https://codereview.chromium.org/417603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285069 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/412433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285068 0039d316-1c4b-4281-b951-d872f2087c98

Rename gpu_unittest_utils test_utils for project consistency.

Add angle unit tests.

Update comments in GPU GYP file referencing GN targets.

Review URL: https://codereview.chromium.org/409423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285067 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/417503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285066 0039d316-1c4b-4281-b951-d872f2087c98

chrome.logPrivate.dumpLogs(function(fileEntry) {...});
  
- dumps all system logs as |fileEntry| (a .tgz file)


chrome.logPrivate.startEventRecorder(type, function(){});
chrome.logPrivate.stopEventRecorder(type, function(){});

- start/stop additional log collection for dumps generated with chrome.logPrivate.dumpLogs(). 

TEST=LogPrivateApiTest.*
BUG=385289

Review URL: https://codereview.chromium.org/329853010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396752
R=estade@chromium.org

Review URL: https://codereview.chromium.org/414753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285064 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395430
NOTRY=True

Review URL: https://codereview.chromium.org/406933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285056 0039d316-1c4b-4281-b951-d872f2087c98

Comment the breakpad gyp file.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/413863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285055 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285054 0039d316-1c4b-4281-b951-d872f2087c98

This gets the "no chromium code" flag for the GN build.

R=dalecurtis@chromium.org
TBR=dalecurtis

Review URL: https://codereview.chromium.org/417783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285053 0039d316-1c4b-4281-b951-d872f2087c98

As explained in the long comment in ninja_copy_target_writer.cc, writing implicit deps for the copy command is both unnecessary and causes problems given the way Chrome specifies the command.

This also updates the expectations for the binary output given the new variables added in a previous patch (this test isn't being run on the bot yet).

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/418573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285052 0039d316-1c4b-4281-b951-d872f2087c98

Many win32 APIs take non-const string pointers. I checked that MSDN documents
them as _In_ and says that they are inputs, and then added const_cast<>s at
the calling sites. (In one test, I introduced a helper struct so that there
can be fewer casts.)

This wasn't just busywork, I found one function that we were handing string
literals where the documentation explicitly said that that's not valid
(filed http://crbug.com/396705).

I didn't change the DECLARE_REGISTRY_APPID_RESOURCEID() call in cloud_print;
it sounds like that'll fix itself when we update to the 2014 sdk:
http://connect.microsoft.com/VisualStudio/feedback/details/806376/atl-hindrances-to-adopting-new-strictstrings-conformance-option-in-vs2013

BUG=396705,82385
R=rnk@chromium.org, rsleevi@chromium.org, sergeyu@chromium.org, vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/413763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285051 0039d316-1c4b-4281-b951-d872f2087c98

See [1].

[1] http://developer.android.com/reference/android/hardware/Camera.html#setParameters(android.hardware.Camera.Parameters)

BUG=b/16370110

Review URL: https://codereview.chromium.org/400933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285050 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391473
TEST=Follow a link from Gmail or hold shift when clicking a link. A new activity following the link is created.

Review URL: https://codereview.chromium.org/398603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285049 0039d316-1c4b-4281-b951-d872f2087c98

Paste popup should be hidden from the corresponding
input box whenever there is a change in focus.This
change takes care of hiding the paste popup when
focus is changing from edit field to URL bar.

BUG=396620

Review URL: https://codereview.chromium.org/416493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285047 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372607

Review URL: https://codereview.chromium.org/408493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285045 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396184
NOTRY=true

Review URL: https://codereview.chromium.org/410703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285043 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scottmg

Review URL: https://codereview.chromium.org/415743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285042 0039d316-1c4b-4281-b951-d872f2087c98

The Linux hidraw interface expects the buffer written to the device to
always have the report ID as the first byte. Remove the conditional that
only added this data when the report ID was non-zero.

BUG=
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/411463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285041 0039d316-1c4b-4281-b951-d872f2087c98

Destroying an Aura window generates a synthetic mouse move event if the mouse
is inside the window.  This causes the InputRouter to get stuck in a state
where it is waiting for the renderer to ack the mouse move.

BUG=395737
R=sky@chromium.org

Review URL: https://codereview.chromium.org/405253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285040 0039d316-1c4b-4281-b951-d872f2087c98

These cards either do not support D3D11 fully, or interact with an
unknown ANGLE bug to cause black screens and an unusable browser.
Force off D3D11 until we can diagnose if a fix is possible.

BUG=395861

Review URL: https://codereview.chromium.org/409223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285039 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds const versions of operator* for layer iterators, so
that we can use them for sorting/heapifying the iterators.

R=reveman

Review URL: https://codereview.chromium.org/413603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285038 0039d316-1c4b-4281-b951-d872f2087c98

This method is never called from Blink ("web components" are always enabled).

Review URL: https://codereview.chromium.org/408053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285037 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=keybuk@chromium.org
TBR=keybuk@chromium.org

Review URL: https://codereview.chromium.org/401953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285036 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285031 0039d316-1c4b-4281-b951-d872f2087c98

R=nick@chromium.org
TBR=brettw@chromium.org,nick@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/371313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285030 0039d316-1c4b-4281-b951-d872f2087c98

In addition to a developer-readable string for inline install failures, include
a stable error code. This isn't perfect, since a) the function prototype of
function(error, errorCode) isn't great, and b) we kind of lose track of what
went wrong after a certain point in the install process. Unfortunately, to fix
a) requires either a breaking change or a revamp to our whole error reporting,
and fixing b) requires stable error values at every point in our install
process (which we don't have, and won't anytime soon).

BUG=331887
TBR=benwells@chromium.org (app_list)
TBR=yoshiki@chromium.org (file_manager)

TBRs for trivial, no-functionality changes.

Review URL: https://codereview.chromium.org/384823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285029 0039d316-1c4b-4281-b951-d872f2087c98

This change puts nexe information in the parameters for starting a NaCl
plugin instead of sending that information over SRPC. This may remove the
need for that IPC round trip entirely; perhaps we could report load failure
as part of the RPCs for starting sel_ldr or performing StartModule().

nacl_defines.gypi as added as a dependency in components/components_tests.gyp
because nacl_process_host.h now includes
"native_client/src/public/nacl_file_info.h", which requires nacl_defines.

BUG=333950
R=bbudge@chromium.org, brettw@chromium.org, hidehiko@chromium.org, jschuh@chromium.org, mseaborn@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/332463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285028 0039d316-1c4b-4281-b951-d872f2087c98

Fix libxml clang warnings.

Add ppapi_unittest_shared target.

Rename ipc:test_support_ipc to ipc:test_support and use this target when needed (the places that wanted this incorrectly specified only "ipc".

R=hclam@chromium.org

Review URL: https://codereview.chromium.org/418453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396385
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/406143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285025 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/409793007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=328119

Review URL: https://codereview.chromium.org/401723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285023 0039d316-1c4b-4281-b951-d872f2087c98

Check in perf-to-tracing conversion script. This lets the --perf command
line switch actually produce trace files that can be loaded by Trace
Viewer.

The conversion script was originally written by Victor Miura
<vmiura@chromium.org> in https://codereview.chromium.org/296623002/.

TEST=PerfControllerTest
BUG=375754

Review URL: https://codereview.chromium.org/404543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285022 0039d316-1c4b-4281-b951-d872f2087c98

In a previous change, an improved test subclass of
GetAuthTokenFunction was created for multi-login tests. All
chrome.identity.getAuthToken browser tests now use this class, and the
original test class has been removed.

The new class does not have any mock methods since the originals were
not testing anything interesting anyway, and does not need to be a
friend of its base class.

This change also adds some coverage for error cases in getAuthToken,
for requests specifying a non-primary account ID.

BUG=364203

Review URL: https://codereview.chromium.org/410553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285020 0039d316-1c4b-4281-b951-d872f2087c98

Getting the value is fine and fast, but returning a reference has the
advantage of allowing you to pass &handle.value() to anything taking a
|const MojoHandle*| (without needing to save to a temporary variable).

R=sky@chromium.org

Review URL: https://codereview.chromium.org/417583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285019 0039d316-1c4b-4281-b951-d872f2087c98