- 09 Jul, 2020 6 commits
-
-
Xinghui Lu authored
Add a flag named "SafeBrowsingSecuritySectionUIAndroid". When this flag is enabled: * Remove the Safe Browsing, data breach and Scout settings from SyncAndServicesSettings. They will be moved under the new "Security" section. before: http://screen/sqZdYYgeTui after: http://screen/WomGjbCwT14 * Add a "Security" section under the "Privacy" section. before: http://screen/Knonxg95erZ after: http://screen/EsXPyntvkpV * Rename the "Privacy" section to "Privacy and security" section. before: http://screen/U75bT4sDFmJ after: http://screen/DuqDjmmR1x0 More context can be found in go/esb-clank-dd. Bug: 1097310 Change-Id: I7644167ff36741a8a39feaa269704904ae6c73ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275343Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786561}
-
Rakib M. Hasan authored
Bug: 1102480 Change-Id: I885168c2b792d2c50353246e7b387c66427b06f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278440 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#786560}
-
Andrew authored
BUG:1103025 TEST:Validate the Recovery App can send feedback using feedbackPrivate. Change-Id: I856737cdaacc0d65f7a42f9766ad7b4d3debf28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287951 Commit-Queue: Andrew Lassalle <andrewlassalle@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#786559}
-
Bailey Berro authored
This change introduces static factory functions to construct DisplayAlignmentIndicator's in order to make clear the distinction between constructing an indicator with a pill and without an pill. Bug: 1070122 Change-Id: I79978091f045df13412cf7eae3308431e9a6120d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284052 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I00b2a602d5e93024ece2a6a558e8968520e6d995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288833Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786557}
-
Marijn Kruisselbrink authored
Rather than sorting all extensions, keep the website provided extensions first and append the mime-type derived extensions to that list. This should give the website more control over what extension gets appended to a file name if the user doesn't include an extension themselves. Additionally pass 1 as file_type_index, to select the first type by default. Most file dialog implementations did this anyway when passing 0, but it seems better to be explicit about what type to select by default. Bug: 1103133 Change-Id: I531f13e72bdaa4de8d7b3270da21a577ebe56e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288429 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#786556}
-
- 08 Jul, 2020 34 commits
-
-
Dale Curtis authored
NaCl always starts from the sandboxed zygote, so we don't need these added. Additionally they trigger a warning message since the NaCl zygote shouldn't be unsandboxed. Fixed: 1085552 Change-Id: Ic41e89dda9d06d533cf88d45228a66bd646ed1d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288821 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Derek Schuff <dschuff@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#786555}
-
Songtao Xia authored
The frontend fix CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2288419 Bug: crbug.com/1103380 Change-Id: I5d5d037a32f81fe49aa0d6f1f0b3de8260530210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288108Reviewed-by:
John Emau <John.Emau@microsoft.com> Commit-Queue: Songtao Xia <soxia@microsoft.com> Cr-Commit-Position: refs/heads/master@{#786554}
-
Renjie Tang authored
CloseStream() and SendRstStream() both only partially cover stream closure code paths. So they are not recording all the streams' states upon their closure. QuicSession::OnStreamClosed() is called however when the stream is closed. It makes more sense to do the logging here. Bug: 1101516 Change-Id: I8bfb7b927eef862497587907998f772e290d76fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288316Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#786553}
-
Saurabh Nijhara authored
MinimumChromeVersionEnforced is a device policy and only applicable to ChromeOS. Bug: 1048607 Change-Id: I3dcf88c018b2b16aceb82086996b121f60a1b28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279882 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#786552}
-
Erik Staab authored
Bug: 1103364 Change-Id: Ic27edc10f6b27c4739d9d2cf027794d919811318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288311Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a3f6dc2fadb4..900c7e87ce70 2020-07-08 nguyenmh@google.com Serialize d/s buffers + use color buffers' impl format for readPixels 2020-07-08 jonahr@google.com Skip MultithreadingTest.MultiCreateContext on Ozone If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1103009 Tbr: syoussefi@google.com Change-Id: I09e8985100edb6814e1c1f25d4c7cda02fbfa88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288659Reviewed-by:
-
Lukasz Anforowicz authored
String literals cannot be used to initialize *non-const* fields - such usage would trigger the following warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]. Because of the above, this CL ensures makes a change to include in the rewrite the fields below: char* char_ptr; wchar_t* wide_char_ptr; while continuing to exclude the fields below: const char* const_char_ptr; const wchar_t* const_wide_char_ptr; Bug: 1069567 Change-Id: Id660806c9e947220644b1ad10b083eeebaae36e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283771 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#786549}
-
Stephen Roe authored
Build times for the arm64 CQ 50% bot experiment over the last week are similar to the existing x64 CQ trybot: builder fuchsia_arm64 fuchsia_x64 builds 549 1114 build_minutes_p50 27.18 29.33 build_minutes_p70 47.80 47.18 build_minutes_p90 58.42 57.23 Stability is good at 50% https://ci.chromium.org/p/chromium/builders/try/fuchsia_arm64 Capacity is also good at 50%. The average number of arm64 bots running at one time at 50% CQ varies from 24 to 36 by day out of 240 bots. Typical spikes are 50 to 60 bots active when a CL build is in progress or 150 to 240 bots active when multiple CL builds overlap. Bot usage percentages on a weekday are p50 27 bots p90 76 bots p99 131 bots out of 240 bots There is more pending time info at https://docs.google.com/spreadsheets/d/1yzHLqp7oNFXlKkRg3whoZ2QhAwC4DYN9pJz8PaXwRYA There is more build time info at https://docs.google.com/spreadsheets/d/1A1B6zgLw2VnBXD5IQXrPZGr5NavJrhjhj8JKeunSvno There is more capacity and bot usage info at https://docs.google.com/spreadsheets/d/15oFJzlDLbfLLnndaTSH2Vsi14QgfiWpIm1dbgn742mU Bug: 1042511 Change-Id: I4fbb69b3c33f3b6ae172f64fb471f88748f591d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288709Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#786548}
-
Mason Freed authored
This is one CL of many, moving tests out of the virtual/controls-refresh directory, into fast/forms. This CL moves: virtual/controls-refresh/focus-rect -> fast/forms/focus-rect This is a pure move of the above folder(s). A few tests share names in the old/new location, but in all cases, the version being moved is updated/new and should overwrite the old version. See also crbug.com/1102647 - there is additional cleanup that will be needed after this move is complete. But to keep the review process simple, this is just a pure move. Bug: 1034611 Change-Id: I99e246142240ba872d8b3a0bec0815769634aaf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284020 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#786547}
-
dpapad authored
Delegate more logic from pdf-viewer into viewer-zoom-toolbar. Bug: None Change-Id: I4a80f895ce26825dc491cd7eb4291afdc4b5292f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285360Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#786546}
-
Devlin Cronin authored
The current implementation of tabs.update() will perform updates as it goes, potentially firing an error for invalid update properties after making other changes. Update this so that tabs.update() will only update a window once all parameters are validated. This allows the extension to know that if it threw an error, none of the updates were performed. This also hopefully de-flakes the ExtensionTabsTest.InvalidUpdateWindowState API test. Bug: 1081549 Change-Id: Ice1af2c6af599c6529278f249a6a9b54ad7f078b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261160Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786545}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c5e8e8bf91ef..c3a81f99020d 2020-07-08 mmortensen@google.com scripts/cros_sdk.py: Use cros_build_lib.Die rather than rethrow exception. 2020-07-07 ahassani@chromium.org dev_server_wrapper.py: Strictly specify the static directory 2020-07-07 saklein@chromium.org autotest_util: Check for files before creating archive. 2020-07-07 chrome-bot@chromium.org Update config settings by config-updater. 2020-07-07 bpastene@chromium.org deploy_chrome: Add an arg to deploy test binaries. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I0c31ee015fc0772acd551884683dd101ba2ea654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287779Reviewed-by:
-
Alex Gough authored
31 bit refcounts are pushing up against larger renderer memory limits so should be guarded for overflow. Bug: 1101547 Change-Id: Iaf613e642be43f2dbddf25bed573e50a0eedf7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288490Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#786543}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/973c321add1b..d60500e69944 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jam@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1090060 Tbr: jam@google.com Change-Id: I4432c33347fafb81cd1e0df5bdeae6f1d37f66c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288576Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786542}
-
manuk authored
Adds a OmniboxDynamicMaxAutocomplete feature with 2 params, OmniboxDynamicMaxAutocompleteUrlCutoff & OmniboxDynamicMaxAutocompleteIncreasedLimit. - When disabled, the omnibox allows UIMaxAutocompleteMatches suggestions. - When dynamic max autocompletion is enabled, the omnibox allows suggestions up to the increased limit if doing so has URL cutoff or less URL suggestions. It could also allow a partial increase if doing so avoids showing more than the cutoff. E.g. a UIMaxAutocompleteMatches of 8, URL cutoff of 2, and increased limit of 10 translates to "show 10 or 9 suggestions if doing so includes at most 2 URLs; otherwise show 8 suggestions. Change-Id: I2f5e589f9e5307a62158223e6f6965476e55c257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274466 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#786541}
-
Lukasz Anforowicz authored
GetOriginForURLLoaderFactoryUnchecked can calculate the origin of the parent frame from the |navigation_request| parameter - there is no need to separately pass the |target_frame| parameter. Additionally, before this CL, the caller would calculate |target_frame| by calling GetRenderFrameHost() which only works at WILL_PROCESS_RESPONSE or later time. Depending on |frame_tree_node()->parent()| means that GetOriginForURLLoaderFactoryUnchecked may be called earlier - this will hopefully help in the future call GetOriginForURLLoaderFactory when creating a speculative/provisional frame (in this scenario the |target_frame| does not exist yet). Bug: 1098938 Change-Id: I51f1d00dd2b85cb9f50aec5e07e88428655bfff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288810 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#786540}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e64cd3aeff71..6402141d1f56 2020-07-08 sokcevic@google.com Rename blocklist/allowlist to skip_list/check_list 2020-07-08 vadimsh@chromium.org [lucicfg] Update to v1.18.2. 2020-07-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1051724,chromium:1098560 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: If49cd1165fda48852ddbcbc51a03f6d2e5c79d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288487Reviewed-by:
-
Kenneth Russell authored
Previously the last one in the list would win; now the first one wins, which is the order in which the code is read. Improves performance for some WebGL content using the validating command decoder on Intel GPUs on macOS. Bug: 1045643 Change-Id: I99c1c874b4d323362f70a11aa6c7971cbdfdd1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288503Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#786538}
-
Dale Curtis authored
Adds support for parsing color information from vpcc box as well as the colr box if available. Previously we only supported colr, mdcv, and clli for av1. These are standardized boxes, so they may be available on any codec. The VP9 in MP4 spec (https://www.webmproject.org/vp9/mp4/) uses slightly different fourcc codes for the mdvc and clli boxes: SmDm and CoLL respectively - these are now supported as well. R=cassew Fixed: 1102200 Test: Updated unittests Change-Id: I44db608f0439778a9ac4085efc2c1c138432a78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284084 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#786537}
-
shrekshao authored
Fixing several BPTC and RGTC texture validation logic according to recent WebGL spec and test updates: https://github.com/KhronosGroup/WebGL/pull/3105 https://github.com/KhronosGroup/WebGL/pull/3111 https://github.com/KhronosGroup/WebGL/pull/3112 Bug: 1100834, 1102924 Change-Id: I82938a642821308a08e6f73175553f312c1c0e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285179 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#786536}
-
Devlin Cronin authored
The TODO called for testing for action.onClicked, which exists in the form of MultiActionAPITest.OnClickedDispatching. Bug: 893373 Change-Id: Id33a00340aebcbc11be1d8f15b98663a662bcb89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288496Reviewed-by:
-
Lei Zhang authored
- Remove the public_deps entry for //gin. It can just be a regular deps. - Remove a duplicate entry for pdf_features.h. It is already in the public section. - Give //pdf:pdf_test_utils the minimal required visibility. - Remove a comment about a dependency that is no longer necessary. GN checks and knows the dependency must be there. - Add a dummy group for //pdf:features, since it is public facing just like //pdf:pdf. Change-Id: Ibfe5b6970ad55d65e073f96b42e57228a89a14dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288431Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#786534}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/babba97ae63a..eb7703565a86 2020-07-08 johnstiles@google.com Update SkXfermodeImageFilter to consolidate color processors. 2020-07-08 herb@google.com Combine MakeOp and insertSubRunOpsIntoTarget 2020-07-08 jlavrova@google.com TextStyle::matchOneAttribute compares backgrounds even if they don’t exist If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: I2b25c290916fd1f517b1a33f201f68cac6daefa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288662Reviewed-by:
-
Christopher Cameron authored
This is causing the test GPUTestConfigTest.LoadCurrentConfig to fail. Bug: 1101436 Change-Id: I3b3c80de68e222f19d7aa7fc7b9eaf1aac8a4437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285339 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
-
Ted Choc authored
Criteria.checkThat/CriteriaNotSatisfiedException is the only allowed path in CriteriaHelper going forward. BUG=1071247 Change-Id: Idde0bd13ce78689b57422e0fc8bdadde57cc2276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288091Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#786531}
-
rbpotter authored
Change-Id: Ie930f1064826913243648ccf125d204b946af82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285181Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#786530}
-
Emily Stark authored
This CL adds in fading to/from transparent alongside the existing elision animation to/from simplified domain. It's similar to the previous PathFadeAnimation that faded out the path except that it (a) happens concurrently with changing the URL's display bounds, and (b) it can apply to subdomains as well as the path. Bug: 1090393 Change-Id: I8f9348dc47dce3260969577feb5517b14483d558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285074 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#786529}
-
Rakib M. Hasan authored
Bug: 1050754 Change-Id: Ica13baa307a947362957060551d0984f591b7e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283636Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594209491-ef5df3b74524e456f9efc0fd239921f6b10d9a40.profdata to chrome-win64-master-1594231179-e92968c7f7a7f3e72dcd314b17d160c794b4cf4c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I19c294c3336e75350a4f4b38923b015c4f7c599e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288573Reviewed-by:
-
Matthew Porter authored
Previous PR was reviewed and merged (https://chromium-review.googlesource.com/c/chromium/src/+/2141215) then reverted here (https://chromium-review.googlesource.com/c/chromium/src/+/2166465) due to this failure (https://bugs.chromium.org/p/chromium/issues/detail?id=1074508). Added the tryjob to validate the fix in assistant_timers_browsertest Modified Notification View to take out hardcoded colors. Moved them to NativeTheme::ColorId and used the GetSystemColor call at the different references to it. Replaced NotificationButtonMD with MDTextButton. Changed accent_color to base::Optional<SkColor>, updated associated calls to account for that Bug: 1056948, 1074508 Change-Id: I17d786b2e2311bfb7c52472aed2bb02c8593ae0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220474 Commit-Queue: Matthew Porter <matt.porter@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#786526}
-
Samuel Attard authored
symbols require a underscore prefix Bug: 1098899 Change-Id: I21f9cafcc7eb071b8cdb2dca383608598ac45df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288475Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#786525}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594220267-9b42ec61f1a87a14500dff1ab9da4a37b8c79053.profdata to chrome-win32-master-1594223967-fb5c79f9944c5a268366596411e8494ec34413b0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC liaoyuke@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: liaoyuke@google.com,jeffyoon@google.com Change-Id: I69e6ae0248def8c4e647795a677a0c7e6e27a7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288482Reviewed-by:
-
George Steel authored
This causes no behavioural change. Change-Id: Ieef9d0138cd0f1bc2d647f2b3b5a782d88ac4287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268582 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#786523}
-
Xianzhu Wang authored
These tests inherited the [ Skip ] expectation of the base tests. crrev.com/c/2231550 missed to add [ Pass ] for them. Bug: 1103349 Change-Id: I44b9a23c08b87e1c0b569012db7094b559943139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288639Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786522}
-
