- 30 Nov, 2020 40 commits
-
-
Abigail Klein authored
Do not enable extra mac nodes on the AXTree because it caused a crash. Bug: 1136813 Change-Id: I46ce64b3af5ec5d4bf3abb82e30bbb96b71637e5 AX-Relnotes: Fix a browser crash on Mac. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555559 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#831999}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606737208-c1622dbc8154d000833156e031e2fb92fdbe0368.profdata to chrome-linux-master-1606759191-6cd311392c4a2d76b8ec4391ac1874206c9889b0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibbe128fb84ccc1e97f186f665afc7e84729bf6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565114Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831998}
-
Lucas Radaelli authored
This change implements support in the AccessibilityBridge to deal with multiple semantic trees, each one representing an iframe. The trees are combined before they are sent to Fuchsia into a single semantic tree. Test: AccessibilityBridgeTest.* Bug: fuchsia:63612,fuchsia:63610,fuchsia64329 Change-Id: I174ec9db254647edb33ada5b31eb24595debe031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556462Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Cr-Commit-Position: refs/heads/master@{#831997}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606737208-e8262bf3e6eb680125b6c552d8461f977d1e98a6.profdata to chrome-mac-master-1606759191-e36e6bb9e34aaec2b6f2fa507df72b0ae1dbb4d4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8d0ca2c0cf6c2ea4e36b254cb2b6759d97742d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565111Reviewed-by:
-
Thomas Guilbert authored
This CL uses video.requestVideoFrameCallback to guarantee a video frame was displayed before ending the test. Bug: 1083605, 1083609e Change-Id: I6a6b3a4a3349ba35c301fe1c7998857c9f94d9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561746 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#831995}
-
Peter Kotwicz authored
This CL configures //third_party:dagger_java //third_party:dagger_processor so that they can point to the internal implementation of Dagger2 for internal Chrome builds BUG=1141111 Change-Id: Ibe7bc24341afcaad4835bf7a60093f563d65de5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565192Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#831994}
-
Benjamin Beaudry authored
Users of Narrator experience a consistent crash caused by an endpoint in AXPlatformNodeTextRangeProvider being on a position that isn't null but had no associated anchor. This position is likely a product of the implementation of TextRangeEndpoints::OnNodeWillBeDeleted, where we move the position to its parent that might have been deleted previously. The crash was caused by an observer not being removed. It was not removed because of the use of !IsNullPosition(), in which we return true if GetAnchor() returns a nullptr. Eventually, when bug:1152939 is fixed at the source, it will be safe to go back with IsNullPosition(). Bug: 1152939 Change-Id: I633d403d8182adca807fde61563a343ce7ee78e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561648 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#831993}
-
Alexander Surkov authored
Move tree formatters Create methods from tree formatters into a separate factory class, which lives in content public and thus can implement create methods for any formatter located both in content and ui. Bug: 1133330 Change-Id: I7ddde664f3307a228e1fd472e20c65f273f4a4bc AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490383Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#831992}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4324.9-1606129869-benchmark-89.0.4337.0-r1 to 89-4324.9-1606737320-benchmark-89.0.4337.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I473cebf6330406365b8550005c95106d48a55128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565108Reviewed-by:
-
evliu authored
Bug: 1122784 Change-Id: I0a683a3965219bdced0b78516c74eb55eabd0d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561123Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#831990}
-
Greg Thompson authored
FilePathWatcher::Watch(bool) is going away. No functional changes. BUG=1147071 R=ericorth@chromium.org Change-Id: I1a59c2d34b24725c46c9bc4e0ba7497151fa3ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562670 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#831989}
-
mlcui authored
.gitattributes should force all committed CSVs to have LF line endings (https://crrev.com/c/2102647) but the power measurement CSVs were committed before that CL. The CRLF line endings caused these CSVs to always appear in a `git stash -p`. These files were converted using dos2unix. Bug: None Change-Id: I23812fe00e25b6a82d8d4e0b8533338b13137158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563190 Auto-Submit: Michael Cui <mlcui@google.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#831988}
-
Fabian Henneke authored
During an Autofill session, distinct sets of views (also called partitions) can trigger individual fill requests. However, there is a configurable limit on the maximum number of partitions, which in the case of stock Android is set to 10. Since Chrome never finishes an Autofill session and every page load with a form adds a partition, this means that Autofill fills stop triggering after a short time. This can be mitigated by cancelling the session when user actions indicate that there is no longer any Autofill-related state to preserve in the current tab: * When the user switches away from a tab. By cancelling the session before the tab contents become hidden, we additionally prevent Autofill from initiating a save flow as all virtual views become invisible. * When top-level navigation occurs that has not been initiated by the renderer. Renderer-initiated navigation, such as tapping a submit button in a form, may trigger Autofill's save functionality and must therefore not cancel the session. * When the domain part of the current URL changes. This behavior is part of the Android Autofill service's compatibility mode, but was partially broken on Android Q+ due to http://crbug.com/1103555 and completely broken by the workaround for that bug. The current change restored this behavior. These changes apply to Android P+ only as this is the first Android version with compatibility Autofill support for Chrome. The remaining scenarios in which the maximal partition count can be reached and Autofill stops triggering include: * A single document with more than ten separate forms. This should be rare and would equally be a problem in a native app. * Single-page apps or those consisting of multiple linked pages with a high total number of fillable forms. If the user does not switch tabs, Autofill may stop working after some time. Further improvements might be possible here, but have to avoid cancelling Autofill in a possible save scenario. Bug: 1150732 Change-Id: I1005cbd349f3ba3ea25a9edafe80d82a21876bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546900Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Adds the necessary files and changes to start generating Android O x86 emulator system images. Bug: 1145728 Change-Id: I31e4b56b70991b7850ac410655a085d84f0eb52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553025 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
-
Patrick Noland authored
ExpandablePaymentHandlerBrowserTest.ClickSecurityIcon Bug: 1094159 Change-Id: I71e397d88cdf43e735bf98d80d6f0cc9a2a5ff3b TBR: sahel@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565697Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#831985}
-
Jeremy Roman authored
This generates much less code and should be faster at runtime. Part of an ongoing quest to remove unnecessary runtime collection of static data structures. Change-Id: I3951f2093623f4e8a56f610c5174d2ea1458709f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562822 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Willie Koomson <wvk@google.com> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#831984}
-
evliu authored
This CL adds a check when binding the speech recognition recognizer to destroy the speech recognition service if the Speech On-Device API (SODA) binary or model files don't exist on the device. This scenario can occur if a user manually deletes the SODA files from their device and triggers the Live caption feature before the files are redownloaded. The speech recognition service will not be launched in the first place if the SODA components have never been installed before because the local prefs containing the paths to the files will be empty. Bug: 1152915 Change-Id: I92d5abccf0ecd6c9fa5f1f80deda650f2344e879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561641Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#831983}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ibac313e4c134044a13bb1219aa49895797bd50e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563761 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Patrick Monette authored
This makes it so that all content/ embedders will be able to use the concept of execution context priority. This CL also moves OverrideVoteAggregator, MaxVoteAggregator and BoostingVoteAggregator out of public visibility, as it is no longer needed. Bug: 971272 Change-Id: I39096d966cc844f75b739d909b4ac2df605eef88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564038Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#831981}
-
Simon Zünd authored
This CL introduces a new experimental CDP event in the network domain. As mentioned in the event documentation, the event can fire before the corresponding network request is sent, or after the response is received, depending on success/failure and the type of the Trust Token operation. R=caseq@chromium.org, sigurds@chromium.org Bug: chromium:1126824 Change-Id: I57fad66b08200ce8c98c44b8406b805627fd3b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554542 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#831980}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ie7e703e9270086bd5ef1e9c3a2911f8f76d28713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563762 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: If9abd86031c1eaa915a2faa5cdbada40f3e6ee3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560954 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
-
Yulun Wu authored
Bug: 1145414 Change-Id: I6f218dd45ed9403326e205cb9f125edd6ff25de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545052Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#831977}
-
Mark Yacoub authored
Problem with old non blocking commit: In some cases with high resolution and high frame rate (such as playing graphics or media content on a 4K 60Hz monitor), switching modes (extended->mirrored) will cause DRM to get 2 nearly back to back nonblocking commits from Chrome: One for disabling planes on old controller, and another actual content flip. Due to the close time proximity of the 2 nonblocking commits, while prepping the 2nd one, DRM will throw -EBUSY error because at this time, the flip_done for the 1st commit was not yet complete as userspace is not allowed to get ahead of the previous commit with nonblocking ones (a kernel check). Behavior after the EBUSY depends on the application. On Chrome, the GPU crashes, and resets, trying to recover to a good state, but content would be reset as well. Fix with blocking commit: Making DisablingOverlayPlanes a blocking commit will guarantee that the flip_done for this commit is complete before OS sends any subsequent non-blocking page flips. On blocking commits, DRM does not hand control back to OS until well after the flip_done is complete. Rationale of the new design: DisablingOverlayPlanes happens on the same thread and during the same time as the full modeset, which is a blocking commit. So makes sense that all modeset-related commits to be blocking until everything has been set/reset properly. BUG: b/171409360,b/172306392 TEST: with 4K display attached to a kohaku, switch from extended to mirror mode. Change-Id: Icff491be107267eb49cf3a2846b6d219a0f82c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559170 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#831976}
-
Becca Hughes authored
Add a metric that records whether a user opened a recommendation from Kaleidoscope during the Kaleidoscope session. BUG=1110373 Change-Id: I49cc5ac2b8a3dbccb711301068b23c315e725eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551286Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#831975}
-
Ryan Sturm authored
This refactors client hints to allow main frame prefetch navigations to add client hints without needing a frame. Related headers CL: https://chromium-review.googlesource.com/c/chromium/src/+/2552723 Bug: 1142074 Change-Id: I662d4a8529f7546df80d81128d7df8545717fbb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551671Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#831974}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606715277-9385c299327136363de38f40b28eb44b3b85ec7c.profdata to chrome-win64-master-1606748271-2b69dce80f38ecf2d66f6209245527ea06788f5d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic24b6f6fdebc366d53a5a74cd282094091920402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563874Reviewed-by:
-
Junyi Xiao authored
This is a reland for https://chromium-review.googlesource.com/c/chromium/src/+/2131009 with attempt to fix the failing test on Mac. Bug: 1046481 Change-Id: Ibd4adb5a3315df5be583dabd45de05c97127a2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511979 Commit-Queue: Junyi Xiao <juxiao@microsoft.com> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#831972}
-
Ryan Sturm authored
Bug: 1152562 Change-Id: Ie719be00784ca796a3275eb9b44bb89de2ca964f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559215Reviewed-by:
-
Patrick Noland authored
on marshmallow emulators Bug: 1153888 Change-Id: Ieaa0be35276100a19a6ea6b4de6521621db96e0b TBR: hypan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564757Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5968da649c17..619ae0038825 2020-11-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 8756b1cb930a to ce0450b9e8e5 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I1e3a469b77e882ee5e1aa14ce9328668edd2b75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565104Reviewed-by:
-
Wenyu Fu authored
The previous dimension assuming the button height is 42dp, while minimum touch target size is now 48dp. Bug: 1127528 Change-Id: Ia9946360d1dc7ae261494f460cf8cb860766e526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560605 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#831968}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4324.9-1606128713-benchmark-89.0.4337.0-r1 to 89-4324.9-1606733211-benchmark-89.0.4337.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic0d27fa5c2075d42cc03d1d0cb9a816c8053191a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565498Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I8ad7887c8903f907699d1fd5f98bf4cb8f6bb42f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556957Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#831966}
-
Maksim Ivanov authored
Delete the Enterprise.ExistingInstallAttributesLock UMA histogram. It's expired a while ago and doesn't seem to be needed anymore. Bug: 1084091 Change-Id: Ie62a2f3edae5d1084f0747ef0dc2e19f9c337d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548625 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
David Tseng authored
R=dmazzoni@chromium.org Fixed: 1131321 Change-Id: If11517ade428937676330728733a6dccba0c0064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560616 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
Mike Reed authored
The long-term change is Skia dropping SkFilterQuality entirely. This has some important repercussions: - clients specify their sampling when they create their imageshader - skia never changes its behavior (due to CTM or other conditions) e.g. if the client asks for cubic-resampling, skia always does that This CL is a small step in this direction: updating callsites for scalePixels() to pass in SkSamplingOptions, rather than the enum. Bug: skia:7650 Change-Id: I8edccf6c32e5c966c65f25ea19c3c613dc710b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556474Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mike Klein <mtklein@google.com> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#831963}
-
Thomas Guilbert authored
This CL uses video.requestVideoFrameCallback to guarantee a video frame is displayed on screen before ending the test. Bug: 1083314 Change-Id: I1e011d9bc18260f2bad3867892ed623bd4de4b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561779 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
-
Solomon Kinard authored
Restrict web_accessible_resources based on site |matches| that extension developers have supplied in manifest.json. Manifest V3 includes changes to the web_accessible_resources key of manifest.json. Use parsed |matches| field to determine which sites have access to specific resources. In the following example, a.com can access a.gif, but other sites can't: "web_accessible_resources": [{ "resources": ["a.gif"], "matches": ["https://a.com/*"] }] Bug: 1133624 Change-Id: Idd0f4a828e2d1a543aaf5e51ab7af6ec6f2f7220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485887Reviewed-by:John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#831961}
-
Gavin Mak authored
Bug: 1007635 Change-Id: I9efd01370fde3b5263ad5a2af7878ae46b0f86c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558730Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#831960}
-
