- 15 Jul, 2020 40 commits
-
-
Thomas Guilbert authored
This CL changes preservesPitch tests to wait until the audioElement's currentTime is at least 0.5 seconds before trying to detect the pitch. Without this check, the test can try to detect the pitch before the audio has played enough, which can return a dominant frequency of 0Hz and fail the test. The CL also makes a few stylistic changes, and fixes an off-by-one error in the number of increments used to calculate frequencies. Bug: 1096238 Change-Id: I6e98e172862a47bea1c4026737138293914f7906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298281 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#788535}
-
Swapnil authored
There are a few errors which occur when parsing of update manifest for force installed extensions. According to the statistics, one of the most common failure reason is MISSING_UPDATE_CHECK_TAG. In that case update server usually provides non-OK app status. Update check tag should be parsed only if app status is OK. To get more details about the types of app status error, UMA statistics are added. Following histogram is added: Extensions.ForceInstalledFailureManifestInvalidAppStatusError Extensions.ForceInstalledFailureManifestInvalidErrorDetail histogram is deprecated. Extensions.ForceInstalledFailureManifestInvalidErrorDetail2 histogram is added due to addition of new failure. Bug: 1100931 Change-Id: Ie45d01b358429fcc4505ee4dcd251b8f2df16f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276417Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#788534}
-
Yutaka Hirano authored
Put a link for slides describing the relationship between the fetch spec and Chromium loading implementation from some README.md files. Bug: None Change-Id: I21cdc8cd005f74152e7908dfb58a1b34b7041d32 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298886 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#788533}
-
Amr Aboelkher authored
Bug: 1100210 Change-Id: Ia86facd2e4a7716ca8b81348f829e5b4fb8b3044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270563 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#788532}
-
Amr Aboelkher authored
Bug: 1100210 Change-Id: I4f87d3649f46238dcc02157050cf1690b41dde4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272300 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4290f3d1534f..a0f7f4611c4c 2020-07-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I929d35c9062ae154f3b7eab82e0a21f774e3508f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299070Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788530}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=jdoerrie@chromium.org Change-Id: I5b949189dc4a977897dc31bbb36df8fedd1e2e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298780 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#788529}
-
Amr Aboelkher authored
Bug: 1100210 Change-Id: I6d4bac995aef5515eeb009d5d2fb9b924f9e4d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272319 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
-
Amr Aboelkher authored
Bug: 1100210 Change-Id: I7498f93113ab7eb1e6be32c0f211a5f3da855903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270447 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
-
Thiemo Nagel authored
Video, audio, and location are considered to be among the most sensitive permissions. Pushing them up the list to show up more prominently to users. Bug: none Change-Id: I319fb1bcaf3b946580b78b4b01871ba81c4e9c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297620Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#788526}
-
Wei Lee authored
We should have our own PRESUBMIT.py after moving the code path to chromeos/components/camera_app_ui. Bug: none Test: git cl presubmit Change-Id: I1166875df171f145b43dbd830d1236b28821c534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289571 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#788525}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a721ddba..98ad3617 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic39a3a2091e652a3df7e38d1118638b0b9a2d90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298117Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788524}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594771186-d832f8303da18f87f12d9f2a0dd0e6f277bb9e8f.profdata to chrome-mac-master-1594792759-0a538db695d514f42650e461e1847cd9df8b7634.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9d064e8301e80b7094233c04d560261567dc7101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298547Reviewed-by:
-
Albert J. Wong authored
Some of the DOM Attribute APIs require lower casing of the ASCII characters. Historically, Blink code called Element::LowercaseIfNecessary() anytime such a comparison was needed. This caused 2-3 string traversals in most lookup APIs, one for verifying the string was lowercase, another for lowercasing the string if necessary, and a third for doing a string lookup in the AtomicStringTable. Furthermore, in the cases of very short strings on platforms with V8 Pointer Compression (eg x64), there can often be 2 more string traversals: The first happens when V8::String object is copied into a Blink StringImpl, and the second happens when that StringImpl is added to the AtomicStringTable. This lookup is NOT cached via the externalization process when V8 Pointer compression is on. This CL: * Removes unnecessary creation of a ASCII lower-cased AtomicString if it is only used for checking existence in a collection. * Removes multiple calls to lowercasing functions within one DOM API function call chain. This is done by: * Normalizing the DOM APIs to take a StringView instead of an AtomicString as a parameter. * Using the newly added WeakFind() API in AtomicStringTable and "Hinted" APIs in AttributeCollection. The change also avoids unnecessary AddRef/Release pairs in many API call chains and will remove much of the performance hit when StringImpl is made threadsafe. Performance on microbenchmarks is preserved or slightly improved on desktop and mobile platforms. Note that performance analysis on this code is difficult. arm32 does not have v8 pointer compression so the most critical speed-up is ensuring externalization can happen. However, this means adding more conditionals to all APIs that take a StringView to check if that view is backed by an AtomicString and then fast pathing. Accidentally inhibiting externalization will reduce benchmark performance by greater than 50%. Also many of these codepaths are sensitive to -Oz versus -O2 changes. In contrast, on x64, externalization does not affect most of these microbenchmarks thus the priority is removing branches and copies. Unilaterally removing any Blink String creation yields a 20% speed-up in the benchmarks, but will hurt code that has larger strings which would get externalized (this is not represented in the blink_perf benchmarks). Adding the conditionals in to support this case will remove some of this 20% speed-up. Doing performance optimization on this code requires balancing all these different use cases. The current implementation reflects a best attempt to address each case satisfactorily. Note: This CL regresses Android get-attribute perf by 15%. https://pinpoint-dot-chromeperf.appspot.com/job/1141cbd7120000 But the final CL with all other changes comes down to only 5% regression https://pinpoint-dot-chromeperf.appspot.com/job/111168fe120000 Committing as is rather than debugging perf on each step. This is partially broken out of https://chromium-review.googlesource.com/c/chromium/src/+/2204539 which in turn is broken out of https://chromium-review.googlesource.com/c/chromium/src/+/1557854 See this design doc for more details on the larger motivation for this change: https://docs.google.com/document/d/1hp7h6zfD5S6mnMI4cHe1PpacRnb2rNpRRkn1gBBJHuQ/edit#heading=h.erv1bv18t616 Bug: 1083392 Change-Id: I502040666fdaec3008bb2d59ca845b14a637f951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263652 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#788522}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/24010e318dc4..f5d0ae98c34c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hajimehoshi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: hajimehoshi@google.com Change-Id: I5951fc0af8dce85d1b3a469ee49fd9fbbffc4fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299061Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788521}
-
Colin Blundell authored
Missing README files for directories of which I'm an OWNER. Change-Id: I48a3bd92f0c156901edfca48c341d0634bc415fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297521Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#788520}
-
Peter E Conn authored
For modularization, we don't want ExternalAuthUtils to rely on AppHooks. Since AppHooks is required for the creation of an ExternalAuthUtils, we have AppHooks hold the singleton instance instead of having ExternalAuthUtils do it itself. Change-Id: I5845333ddf92a6f2fdeb61f7d12b2b632e849f16 Bug: 1104817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296088Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#788519}
-
Yutaka Hirano authored
This is aligned with the spec. Bug: 1097227 Change-Id: Id5b5170cd90cfe6f0818e0b3a80dc2b0db66f27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298887Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#788518}
-
Noel Gordon authored
File-ng requires an 8px vertical gap between any action-icon and their drop down menu. Action icon have a 48px x 48px tap target and the drop down menu should not overlap that tap target, hence the 8px gap. Bug: 1066727 Change-Id: Ic91d2fda156abb359e5110c32488b9b1cec41406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298847Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#788517}
-
Yoshifumi Inoue authored
This patch changes |NGLineBreaker::Rewind()| to skip empty text item to adjust |item_index_| for making next line break to work correctly. Before this patch, we hit |DCHECK_EQ()| in |NGLineBreaker::RewindOverflow()| after |Rewind()| when line breaking occured at a space item followed by empty text, e.g. "abc..."(long text) ""(empty text) " "(a space for line break). Example: <div><i>0123456789<b> </b>ab</i></div> [0] kOpeNTag 0-0 <i> [1] kText 0-10 "012345679" [2] kOpenTag 10-10 <b> [3] kText 10-10 "" [4] kText 10-11 " " <== line break [5] kCloseTag 11-11 <b> [6] kText 11-13 "ab" [7] kCloseTag 13-13 <i> Bug: 1104582 Change-Id: Ibcc145a97d9f1b94159035a9eb6b65a50f2b8bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298960 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#788516}
-
Lan Wei authored
This reverts commit 01da6796. Reason for revert: Test fails on Mac10.14: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/6447 Original change's description: > Reland "Avoid testRunner.eventSender in > overflow-scroll-in-overflow-scroll-scrolled.html" > > Avoid testRunner.eventSender in > paint/invalidation/scroll/overflow-scroll-in-overflow-scroll-scrolled.html > > TBR=wangxianzhu@chromium.org > > Bug: 1047176 > Change-Id: If4522d945a8e5d2d269bd7e8eedf8b070a81cc6c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298277 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788491} TBR=wangxianzhu@chromium.org,lanwei@chromium.org Change-Id: I2f2bafa448c7eb653c2e4b11c22d8157f5dd88f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299140Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#788515}
-
Keishi Hattori authored
Change global variables referencing LayoutObjects to Persistents in anticipation of oilpanization of LayoutObjects. Because global variables need to be added to the GC root set. Bug: 1030176 Change-Id: Ie0ab6e52052f0819172aa0ff6ff9926f167566a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297038Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9421094d01b1..6e7083de3589 2020-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from cd0af6456eb1 to 1de497cc50ab (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I5ed0586fea7024ef28a9ddc2b67ea1883f51ad42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299058Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I63d349b6d0accaf80f4cf600e46d749bc3bdec63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299019Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788512}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7b1e2d2f6d2726cee57a4b0f55f0417942a0250b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299059Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds util::ranges implementations of the algorithms found in [alg.replace], [alg.fill] and [alg.generate]. Bug: 1071094 Change-Id: I00780a4550febd4bc1b709ac650f260aa04204b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284501Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#788510}
-
Alan Cutter authored
This CL moves the logic where we make a web app's theme_color opaque to UpdateWebAppInfoFromManifest() instead of at installation (BMO) or at read (bookmark apps). This is important for manifest update checks that needs to compare the transformed installed web app manifest data with the current page's manifest data under the same transformations. Bug: 1103590 Change-Id: Ib243227999ea13c1f00e146b20bb55c39482978d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288719Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#788509}
-
Dominic Farolino authored
This CL fixes a renderer crash caused by blink::RemoteFrame::Navigate not calling LazyLoadFrameObserver::CancelPendingLazyLoad(), thus disconnecting the underlying intersection observer. The problem was that when the intersection observer does not get disconnected and detached from the iframe element, then LazyLoadFrameObserver::LoadImmediately gets called N times for a given element, however after the first time it gets called, its |lazy_load_request_info_| gets moved, and therefore is in an invalid state, so future invocations of LoadImmediately try and reuse this invalid state. The problem could have been caught if the DCHECKs in this method were CHECKs, so this CL turns them into CHECKs until we confirm that there are no more issues. If there are, the CHECKs will make them much easier to track down. R=kinuko@chromium.org, sclittle@chromium.org Bug: 1104664 Change-Id: I0adc8e26375406f0016031dd2d2d89ad043dd6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298331Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#788508}
-
Vikas Soni authored
Set GrContextOptions::fPreferExternalImagesOverES3 to true which causes Skia to use ES2 instead of ES3 if GL_OES_EGL_image_external_essl3 is not available and GL_OES_EGL_image_external is available. Bug: 1031383,1104891 Change-Id: I87c2e35e4f1ae95a4882a275d3aceb416c47bd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296875Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#788507}
-
Dale Curtis authored
This is blocking our ability to handle HDR images since the function always forced HDR color spaces to P3. This change removes this method and updates a few call sites to expect that. Most callers are unchanged since they properly handle the HDR color space. R=ccameron Bug: 960620, 1076568 Change-Id: If507cae148a1e510b3569907773f6d84c5ed2d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298580 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#788506}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/35dec5f127c3..9d9199a509bf 2020-07-15 chanli@chromium.org [led] Roll to latest If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099018 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: Ic1747423c2e82c118349278d065ac5e1beeeb4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298812Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fb20ab83..a721ddba Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4ae80d5f8ae8a07aae99894f1c77d2953ba18057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298740Reviewed-by:
-
Matt Falkenhagen authored
Bug: 1092329 Change-Id: I7e5697631a0eedd12202533f59c48b15aba674be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298843Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#788503}
-
Brett Kilty authored
Update the IS_ANDROID_THINGS check to use the superset IS_ANDROID_APPLIANCE, covering cases using other Android platform builds. Bug: b/156263192(internal) Test: local build (device) Change-Id: Ia750c8d31a98881e7efaa6e69b10f2f7a6ba0ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298342Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Brett Kilty <brettk@google.com> Cr-Commit-Position: refs/heads/master@{#788502}
-
David Vallet authored
BUG=1068382 Change-Id: I1e717499d26e0d8984d731bdd74b59700285b861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291134 Commit-Queue: David Vallet <dvallet@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#788501}
-
Jit Yao Yap authored
Sync server-side changes from cl/320034367. Change-Id: I16909359e462681ec2a3b1b7a7be8ef2730c60b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294659Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#788500}
-
Hajime Hoshi authored
TBR=agl@chromium.org Bug: 997732 Bug: 1105733 Change-Id: Iab83322d35a5e24f3ea1ee5bbdb25daae33ecc60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298961Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788499}
-
Zhongyi Shi authored
connectivity related errors. Early data indicating that most connections has been closed by the time a network change happens, which is the main motivation for me to track the count for closed connections caused by connectivity related errors. Some connection may get closed early due to connectivity related issues: 1. public reset by the peer post handshake is typically caused by NAT rebinding. 2. QUIC_PACKET_WRITE_ERROR by self is typically early signal indicating network no longer being usable. 3. QUIC_TOO_MANY_RTOS by self is typically caused by silent blackholing. This change also moves metrics logging to QuicConnectivityMonitor. Bug: 1090532 Change-Id: Ic0d05fc788aeb35b49ae853b0b8b652673c16ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293261Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788498}
-
Mei Liang authored
TabSuggestionMessageCardTest#groupTabSuggestionReviewedAndDismissed is flaky when running on an emulator. This CL is to disable this test on the emulator testers. TBR=wychen@chromium.org Bug: 1102423 Change-Id: I8196a21a028d40cce846d47ee7cd4d8bf6fda0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296292Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#788497}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7cdf3fb532c2..24010e318dc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hajimehoshi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419 Tbr: hajimehoshi@google.com Change-Id: Ie0d76a0beca7f5f1a77f4b9ab1aa90d330c660d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298804Reviewed-by:
-
